From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C36C432BE for ; Wed, 28 Jul 2021 11:02:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8378A60F46 for ; Wed, 28 Jul 2021 11:02:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235873AbhG1LCA (ORCPT ); Wed, 28 Jul 2021 07:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231994AbhG1LBy (ORCPT ); Wed, 28 Jul 2021 07:01:54 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CB06C061757 for ; Wed, 28 Jul 2021 04:01:52 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id l11-20020a7bc34b0000b029021f84fcaf75so3993141wmj.1 for ; Wed, 28 Jul 2021 04:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bocNcom+XM+jt/yaZntODE+ELWnSFxGY5QcrB5KsPUU=; b=EjbJeqOzTBHIOqmnkwnMCJkPUrOgbI1IDfEFz0L1gPOlX423R3Bt2ocdidAT+VWmPT Pi2Lel7fGN3o97T/7SLFfgO62PvpQElzqmVC4VVxfc90ZviBK8Y3b/znKbdkyoGwVkbY Acy9oYj8foz98GCWHzd0y4h+ToiiarJv0Z2h39nBAHAoPvbL68UNSEonqmvb573waTm4 iX+1WpMTiOYXtCbdZ84DWQMpKEpnhXwhnStBidT7VjDBA4a4b73r8yFAavmn8jUAprpg Akkru7Qq9ywvQ3Hw4jcr5wJU+cCGnPBQ1PfAHxSvywxq5HkeHTxwvX30gf+Gc1umRfTa ELxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bocNcom+XM+jt/yaZntODE+ELWnSFxGY5QcrB5KsPUU=; b=IfwPv7jD9M6ZpEkix0+tl/OYOlHc8GegYWarm+6YTm8vvXWkOFsT6PDl0L+9W2Ser6 RJwhKeZJMiHe5MNzZIWK2l8AYJK3GWx5H3gOBmRsVxnvxUCguowGfJsuKjCukwMSQE1q pLSNfBjDOEPsPw6l38PkigFiYcj0B7eYW8SbecEAh95IHBGHWsZLYrZ8Vmi1rWBy4dc7 9drv8l8qi69qkxv1zYf/9AyWqSfM3bk5pQtHsaRFvIKqxOjXAAiz9LcpX/KxLPN6WPOV 7g2f0oIcDDIcG9WNHQp1xnDrsYuGmIqOvjCHBfZQfu3OmKZ4Wo5o3XXKx1QOGsHxNHAq 7W+w== X-Gm-Message-State: AOAM530mQaW3PEKnvg6Uxk8/LgFZxn0st+6gyJyJW5GfOLbuOU9/T4dy FyAWNWUig5GJznqhYA8n4QOL3wWTdfX/8wDExsL+jQ== X-Google-Smtp-Source: ABdhPJyna0vcoiKE/wYRcEVB8vIZ5PlgxSOy1HdpZLPd4BVX7GO8vBxp7RFPT0UZjP63w4uRBWo3MPTdKXzHObWSVC0= X-Received: by 2002:a05:600c:154a:: with SMTP id f10mr26212334wmg.183.1627470110734; Wed, 28 Jul 2021 04:01:50 -0700 (PDT) MIME-Version: 1.0 References: <20210707093632.1468127-1-maxime@cerno.tech> <20210707093632.1468127-2-maxime@cerno.tech> In-Reply-To: <20210707093632.1468127-2-maxime@cerno.tech> From: Dave Stevenson Date: Wed, 28 Jul 2021 12:01:34 +0100 Message-ID: Subject: Re: [PATCH 2/2] drm/vc4: hdmi: Remove unused struct To: Maxime Ripard Cc: DRI Development , Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , bcm-kernel-feedback-list@broadcom.com, Daniel Vetter , Phil Elwell , Tim Gover , Dom Cobley , Emma Anholt , Nicolas Saenz Julienne , LKML , linux-rpi-kernel@lists.infradead.org, Maxime Ripard , kernel test robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Jul 2021 at 10:36, Maxime Ripard wrote: > > Commit 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec") removed the > references to the vc4_hdmi_audio_component_drv structure, but not the > structure itself resulting in a warning. Remove it. > > Fixes: 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec") > Reported-by: kernel test robot > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index 3165f39a4557..1bb06c872175 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -1403,18 +1403,6 @@ static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = { > { "TX", NULL, "Playback" }, > }; > > -static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = { > - .name = "vc4-hdmi-codec-dai-component", > - .dapm_widgets = vc4_hdmi_audio_widgets, > - .num_dapm_widgets = ARRAY_SIZE(vc4_hdmi_audio_widgets), > - .dapm_routes = vc4_hdmi_audio_routes, > - .num_dapm_routes = ARRAY_SIZE(vc4_hdmi_audio_routes), > - .idle_bias_on = 1, > - .use_pmdown_time = 1, > - .endianness = 1, > - .non_legacy_dai_naming = 1, > -}; > - > static const struct snd_soc_component_driver vc4_hdmi_audio_cpu_dai_comp = { > .name = "vc4-hdmi-cpu-dai-component", > }; > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A84FC4338F for ; Wed, 28 Jul 2021 11:01:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1C0360F00 for ; Wed, 28 Jul 2021 11:01:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D1C0360F00 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C0FB6E920; Wed, 28 Jul 2021 11:01:53 +0000 (UTC) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 495226E8D2 for ; Wed, 28 Jul 2021 11:01:52 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id u15-20020a05600c19cfb02902501bdb23cdso4017145wmq.0 for ; Wed, 28 Jul 2021 04:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bocNcom+XM+jt/yaZntODE+ELWnSFxGY5QcrB5KsPUU=; b=EjbJeqOzTBHIOqmnkwnMCJkPUrOgbI1IDfEFz0L1gPOlX423R3Bt2ocdidAT+VWmPT Pi2Lel7fGN3o97T/7SLFfgO62PvpQElzqmVC4VVxfc90ZviBK8Y3b/znKbdkyoGwVkbY Acy9oYj8foz98GCWHzd0y4h+ToiiarJv0Z2h39nBAHAoPvbL68UNSEonqmvb573waTm4 iX+1WpMTiOYXtCbdZ84DWQMpKEpnhXwhnStBidT7VjDBA4a4b73r8yFAavmn8jUAprpg Akkru7Qq9ywvQ3Hw4jcr5wJU+cCGnPBQ1PfAHxSvywxq5HkeHTxwvX30gf+Gc1umRfTa ELxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bocNcom+XM+jt/yaZntODE+ELWnSFxGY5QcrB5KsPUU=; b=I9OYcai51vxISgZpMx0tnXGrEFDe+rYE2rOY7lEyOUZA3HXYSOFcHbvoncDrZs91+5 L2qKYkVEAlj/cItF1gSVd2CR3PillhU/E4BUzqVfmTDhno3HwAtUdehcBMY6oCDy/Hxx v9+kF8E86Yae8lrJrD6mMDHJWN44cLXE00Jl3P3f6Piq++71eD+qqVJoR6DO1jMZxMzz 010cmTsS3jpczVnfmD9J0oT5aS7LvGItMvMq126vaRU7Jevz71JGnqvawMIWYM1FjohN 7imZSnVkhigf6/pOd0SUTofQ3Dp5ajZkPOyipVD868trVNEWzuHmtX9ya/xbmBVlqa2p lmIg== X-Gm-Message-State: AOAM533CDiEtZ8/Xm/CEBfPtHWufG0ICsCPsHb1oL7xHCxScA1fVO7+j pN3f7aDaWQcoMFWp2NhviEPRlb2JY6AsMEeAJ3eSIg== X-Google-Smtp-Source: ABdhPJyna0vcoiKE/wYRcEVB8vIZ5PlgxSOy1HdpZLPd4BVX7GO8vBxp7RFPT0UZjP63w4uRBWo3MPTdKXzHObWSVC0= X-Received: by 2002:a05:600c:154a:: with SMTP id f10mr26212334wmg.183.1627470110734; Wed, 28 Jul 2021 04:01:50 -0700 (PDT) MIME-Version: 1.0 References: <20210707093632.1468127-1-maxime@cerno.tech> <20210707093632.1468127-2-maxime@cerno.tech> In-Reply-To: <20210707093632.1468127-2-maxime@cerno.tech> From: Dave Stevenson Date: Wed, 28 Jul 2021 12:01:34 +0100 Message-ID: Subject: Re: [PATCH 2/2] drm/vc4: hdmi: Remove unused struct To: Maxime Ripard Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Saenz Julienne , Tim Gover , Emma Anholt , David Airlie , LKML , DRI Development , kernel test robot , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann , Daniel Vetter , Phil Elwell , Dom Cobley Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 7 Jul 2021 at 10:36, Maxime Ripard wrote: > > Commit 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec") removed the > references to the vc4_hdmi_audio_component_drv structure, but not the > structure itself resulting in a warning. Remove it. > > Fixes: 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec") > Reported-by: kernel test robot > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index 3165f39a4557..1bb06c872175 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -1403,18 +1403,6 @@ static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = { > { "TX", NULL, "Playback" }, > }; > > -static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = { > - .name = "vc4-hdmi-codec-dai-component", > - .dapm_widgets = vc4_hdmi_audio_widgets, > - .num_dapm_widgets = ARRAY_SIZE(vc4_hdmi_audio_widgets), > - .dapm_routes = vc4_hdmi_audio_routes, > - .num_dapm_routes = ARRAY_SIZE(vc4_hdmi_audio_routes), > - .idle_bias_on = 1, > - .use_pmdown_time = 1, > - .endianness = 1, > - .non_legacy_dai_naming = 1, > -}; > - > static const struct snd_soc_component_driver vc4_hdmi_audio_cpu_dai_comp = { > .name = "vc4-hdmi-cpu-dai-component", > }; > -- > 2.31.1 >