From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBADEC433F5 for ; Tue, 2 Nov 2021 16:33:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90A7460EB8 for ; Tue, 2 Nov 2021 16:33:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 90A7460EB8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 77AB2731AC; Tue, 2 Nov 2021 16:33:34 +0000 (UTC) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C1AF731AD for ; Tue, 2 Nov 2021 16:33:32 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id d24so3646130wra.0 for ; Tue, 02 Nov 2021 09:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LAvIC90H2Q09upFWDw++dDK4c8sFoQjuntZhnvDGSjc=; b=c0mbANBt9R9oj2N98L18a2I8SDKA/gipnKrWs4hd1qLDydb9Sm8p0Tcn6pVUrcNZYS 0YO3WLlDbYN9LkPXt9oDJl6yHVNsRc/ZsbJO9SKBnFILFlOP3mGcsfylFiqzMlw2UqnT YK29EU54tvJhS6nmvqPUWmde/+VU0IeseY5lGZcxiujlOLNV4AjDG5pzVCa0ln+/aCSm dC2PM5dknbACWIF0UteQJKH32XlB45eSytkJNuBTEBSSscH8Ui1Aoi/AbUA/acW/jYmG dItZ9cExxmcMcfe+F9ZlzG16Fvcdwy5icX9D78B+l+EgvI0PHndwL0Ww0EwxWl26H6Oi Ziag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LAvIC90H2Q09upFWDw++dDK4c8sFoQjuntZhnvDGSjc=; b=nDMsvDplhYWc2Lfatyzq+mZlLRqNfm8uCWEiBbTnH4Y+DCYmUfyvEVH2CxbCKWWnTM 48vivCQD2MCBCBR6ymGQqkpldTmjB0XQIxq8dzLv0q1m4x/n/rhpMyTx1Hp6Fd1O+tAT msFcKGsAqEnp/gTiw884Fvbh7v+KpRUyQShScGngL0WlNktG6tQ+zW/glTVW0oLVzxs0 E5sG+YJOlIAHvk2zVJd5ou8UJ9xTZJUaXrXK4ghAYZVbydzlyv8pgpCqDbjkT7Ivi44q dAqA9LictyhIgpAKaQ5jrXfhisemWWOhlMJQbdXigcL0f4wKJsPOuaXcBCaRKicnhIwa wZdg== X-Gm-Message-State: AOAM530v62q4rBwnma336zvwoBJiV5+NyL15OBenMW7HTwlWReWi/ueJ g7AzUjD8LwHz7S7wEpr1M1PmPrNAnSWFAaBoEdHM7A== X-Google-Smtp-Source: ABdhPJzWC/vow5AFfmXW2psyst7Pv3WXP5/d12dixg/4qM4EsHpPOXqX8KOpobyDj89zmTTPgtf8ds+xSsuvmiW+gcM= X-Received: by 2002:adf:a143:: with SMTP id r3mr48509272wrr.8.1635870810754; Tue, 02 Nov 2021 09:33:30 -0700 (PDT) MIME-Version: 1.0 References: <20211025152903.1088803-1-maxime@cerno.tech> <20211025152903.1088803-7-maxime@cerno.tech> In-Reply-To: <20211025152903.1088803-7-maxime@cerno.tech> From: Dave Stevenson Date: Tue, 2 Nov 2021 16:33:14 +0000 Message-ID: Subject: Re: [PATCH v8 06/10] drm/vc4: crtc: Add some logging To: Maxime Ripard Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Saenz Julienne , Tim Gover , Emma Anholt , David Airlie , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann , Daniel Vetter , Phil Elwell , Dom Cobley Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 25 Oct 2021 at 16:29, Maxime Ripard wrote: > > The encoder retrieval code has been a source of bugs and glitches in the > past and the crtc <-> encoder association been wrong in a number of > different ways. > > Add some logging to quickly spot issues if they occur. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index fbc1d4638650..6decaa12a078 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -541,6 +541,9 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc, > struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state); > struct drm_device *dev = crtc->dev; > > + drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)", > + crtc->name, crtc->base.id, encoder->name, encoder->base.id); > + > require_hvs_enabled(dev); > > /* Disable vblank irq handling before crtc is disabled. */ > @@ -572,6 +575,9 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crtc, > struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, new_state); > struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder); > > + drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)", > + crtc->name, crtc->base.id, encoder->name, encoder->base.id); > + > require_hvs_enabled(dev); > > /* Enable vblank irq handling before crtc is started otherwise > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C24C433EF for ; Tue, 2 Nov 2021 16:44:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2683610FC for ; Tue, 2 Nov 2021 16:44:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234787AbhKBQq4 (ORCPT ); Tue, 2 Nov 2021 12:46:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234662AbhKBQqs (ORCPT ); Tue, 2 Nov 2021 12:46:48 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27FF7C0432ED for ; Tue, 2 Nov 2021 09:33:32 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id d3so34197069wrh.8 for ; Tue, 02 Nov 2021 09:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LAvIC90H2Q09upFWDw++dDK4c8sFoQjuntZhnvDGSjc=; b=c0mbANBt9R9oj2N98L18a2I8SDKA/gipnKrWs4hd1qLDydb9Sm8p0Tcn6pVUrcNZYS 0YO3WLlDbYN9LkPXt9oDJl6yHVNsRc/ZsbJO9SKBnFILFlOP3mGcsfylFiqzMlw2UqnT YK29EU54tvJhS6nmvqPUWmde/+VU0IeseY5lGZcxiujlOLNV4AjDG5pzVCa0ln+/aCSm dC2PM5dknbACWIF0UteQJKH32XlB45eSytkJNuBTEBSSscH8Ui1Aoi/AbUA/acW/jYmG dItZ9cExxmcMcfe+F9ZlzG16Fvcdwy5icX9D78B+l+EgvI0PHndwL0Ww0EwxWl26H6Oi Ziag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LAvIC90H2Q09upFWDw++dDK4c8sFoQjuntZhnvDGSjc=; b=BNex0n5/CHIif7KHLGHH+tspd9XaHuhWr+pSPPrFgzq9V9cvanuz8sPOlaW850XgJj n9jWY4V31PuRi+JPQx0EGPhsnODIjIQmIuHH6Zsh3aX9NdyuroeZRiRUsH5+0p0vhnLc bZIeDZj4f3jPxUyPBzQvsQxWImDD//xWJBQhdQqN5WKlfYFDPMxGCr17dt1XEGWPqQ9H d+SXnPP6B9dUsZXk4IHkFZ46BjFMt2kWhab4uNGF9j/6msWGMLMaxN8VPC4k2xHmSGrR 1hXcTZf+GSu2tT2pKUTI6nv5wmj7rHVWfp9cv1FOoYXBE25WQEk1233JTAO//BNEIW0U f7nA== X-Gm-Message-State: AOAM530/oDCWwV+3yIudoQLvp7zhrduTKiVwww+TZZDuAlMLckurOTA1 mZj4On53BHRD71TjanzhRv3Ir2D8C/jUJau/TSI+KQ== X-Google-Smtp-Source: ABdhPJzWC/vow5AFfmXW2psyst7Pv3WXP5/d12dixg/4qM4EsHpPOXqX8KOpobyDj89zmTTPgtf8ds+xSsuvmiW+gcM= X-Received: by 2002:adf:a143:: with SMTP id r3mr48509272wrr.8.1635870810754; Tue, 02 Nov 2021 09:33:30 -0700 (PDT) MIME-Version: 1.0 References: <20211025152903.1088803-1-maxime@cerno.tech> <20211025152903.1088803-7-maxime@cerno.tech> In-Reply-To: <20211025152903.1088803-7-maxime@cerno.tech> From: Dave Stevenson Date: Tue, 2 Nov 2021 16:33:14 +0000 Message-ID: Subject: Re: [PATCH v8 06/10] drm/vc4: crtc: Add some logging To: Maxime Ripard Cc: DRI Development , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , linux-rpi-kernel@lists.infradead.org, LKML , Maxime Ripard , Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, Emma Anholt , Phil Elwell , Tim Gover , Dom Cobley Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Oct 2021 at 16:29, Maxime Ripard wrote: > > The encoder retrieval code has been a source of bugs and glitches in the > past and the crtc <-> encoder association been wrong in a number of > different ways. > > Add some logging to quickly spot issues if they occur. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index fbc1d4638650..6decaa12a078 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -541,6 +541,9 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc, > struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state); > struct drm_device *dev = crtc->dev; > > + drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)", > + crtc->name, crtc->base.id, encoder->name, encoder->base.id); > + > require_hvs_enabled(dev); > > /* Disable vblank irq handling before crtc is disabled. */ > @@ -572,6 +575,9 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crtc, > struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, new_state); > struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder); > > + drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)", > + crtc->name, crtc->base.id, encoder->name, encoder->base.id); > + > require_hvs_enabled(dev); > > /* Enable vblank irq handling before crtc is started otherwise > -- > 2.31.1 >