From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 402A4C433DB for ; Tue, 9 Feb 2021 09:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB20D64E8B for ; Tue, 9 Feb 2021 09:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbhBIJwQ (ORCPT ); Tue, 9 Feb 2021 04:52:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230490AbhBIJuE (ORCPT ); Tue, 9 Feb 2021 04:50:04 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D04A6C061788 for ; Tue, 9 Feb 2021 01:49:23 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id t142so2468186wmt.1 for ; Tue, 09 Feb 2021 01:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iODsYL577vtiTZcS5AXU5f62AD5nWHRXTaswzxJRGpE=; b=JBX1u8nYfJ2D17HCZU3bF64mR3tXNePMMbkujQwPzUB4EHhq0FLPs5OOM92rDCpHBF 4O9xTvVsnstE1b4IgRWf/cN/5JU2cy+inHw8TS2/FNMZeJNBStL7jnJ8ZcPrtCFvxPG4 V/4KyzneELW/HpkZBFhB9trOu3KvpkoWlsMbt5tVgBOMJdCNMuB/45CFP7unHH4zy3N2 NFahaB6yHkIYKLQFa/wTYu0dpNn78LVyWqe8lOs5wsRRZj5Dw2+AdWS4zVBv+s35utmv HQfK/sg06HSj9kgzRvVI2EWfBGQTkY4bQKv9rmjLvOp2dFbUsZ/6hGhjOZ1SksYp8P8F /Blg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iODsYL577vtiTZcS5AXU5f62AD5nWHRXTaswzxJRGpE=; b=SqQ8qNgi6z/b0jHhmoje9IvbBIwUiudL56/oEcIst+BqOzW8XPcw2NUtBQcwZKYXbp EU69vzLhqYduL/WLXKZfIplxtfeyzJIgHSC9WIh2o8wYBbXVPdPtE+iuGMPVoWgyDny6 OSoHn3NL7PSNXQZUyKgZk26lEJ7m7gJaFDtcJgMd2YnPWX/z997Tr6maGurM6tQakcSb nPbtUALJMs+AMH+9gxHP1WlUfm0BRI1R3jW06vmmcgeqm+AJo18EHTml9jYx3PVDGM82 xrY+6kQ4NRCzFncV1T2jwj91aAbRAbsZIG16PPliz3eU2Eu9UZwhvv54lEsj1CfN6lsP Zcfw== X-Gm-Message-State: AOAM533BUqP7m1gg2U3xb4qoQ9y3mP8iOrsGnIW/A9/LCVY7HVjvC0hS njc5gBBgDYt4hMLF7EmEQe/cb80Y6NXeRNRM/vrwCA== X-Google-Smtp-Source: ABdhPJwkXMO4uhvCsmyjxeJIJN/dMVthik8rV2agcLFH9W28tEatgkKRxyaLXGqmb/ZxKjwVzyOeJ3lIrOe3jbSNI4Y= X-Received: by 2002:a7b:ca57:: with SMTP id m23mr2607883wml.116.1612864162564; Tue, 09 Feb 2021 01:49:22 -0800 (PST) MIME-Version: 1.0 References: <20210111142309.193441-1-maxime@cerno.tech> <20210111142309.193441-15-maxime@cerno.tech> In-Reply-To: <20210111142309.193441-15-maxime@cerno.tech> From: Dave Stevenson Date: Tue, 9 Feb 2021 09:49:05 +0000 Message-ID: Subject: Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller To: Maxime Ripard Cc: Eric Anholt , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Hans Verkuil , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, Mauro Carvalho Chehab , Linux Media Mailing List , Florian Fainelli , Nicolas Saenz Julienne Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote: > > The BSC controllers used for the HDMI DDC have an interrupt controller > shared between both instances. Let's add it to avoid polling. This seems to have unintended side effects. GIC interrupt 117 is shared between the standard I2C controllers (i2c-bcm2835) and the l2-intc block handling the HDMI I2C interrupts. Whilst i2c-bcm2835 requests the interrupt with IRQF_SHARED, that doesn't appear to be an option for l2-intc registering as an interrupt controller. i2c-bcm2835 therefore loses out and fails to register for the interrupt. Is there an equivalent flag that an interrupt controller can add to say that the parent interrupt is shared? Is that even supported? Thanks Dave > Reviewed-by: Florian Fainelli > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/bcm2711.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi > index 4847dd305317..8bb46ae76a92 100644 > --- a/arch/arm/boot/dts/bcm2711.dtsi > +++ b/arch/arm/boot/dts/bcm2711.dtsi > @@ -308,6 +308,14 @@ dvp: clock@7ef00000 { > #reset-cells = <1>; > }; > > + bsc_intr: interrupt-controller@7ef00040 { > + compatible = "brcm,bcm2711-l2-intc", "brcm,l2-intc"; > + reg = <0x7ef00040 0x30>; > + interrupts = ; > + interrupt-controller; > + #interrupt-cells = <1>; > + }; > + > hdmi0: hdmi@7ef00700 { > compatible = "brcm,bcm2711-hdmi0"; > reg = <0x7ef00700 0x300>, > @@ -341,6 +349,8 @@ ddc0: i2c@7ef04500 { > reg = <0x7ef04500 0x100>, <0x7ef00b00 0x300>; > reg-names = "bsc", "auto-i2c"; > clock-frequency = <97500>; > + interrupt-parent = <&bsc_intr>; > + interrupts = <0>; > status = "disabled"; > }; > > @@ -377,6 +387,8 @@ ddc1: i2c@7ef09500 { > reg = <0x7ef09500 0x100>, <0x7ef05b00 0x300>; > reg-names = "bsc", "auto-i2c"; > clock-frequency = <97500>; > + interrupt-parent = <&bsc_intr>; > + interrupts = <1>; > status = "disabled"; > }; > }; > -- > 2.29.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8957C433DB for ; Tue, 9 Feb 2021 09:50:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 464C564E8B for ; Tue, 9 Feb 2021 09:50:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 464C564E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9m4NKYlXdjlpjE9bVunrvlxi67Sm1novzzuHolhWso8=; b=AFa1yFZcQ0A9JF2jkS/pyWOl5 tiBsAVukInlNw+X2ugniWjV5M5HIAuUeRT117lV0MgWZSzvG1rP7f9eZp9FuJKIN+6vT/eL7iVAFs CZvQYTjL5us8qyxDdy1EZv2j55Zao8Y49hM65ww6i219saUG3abwywlhwp+UUN7va5HvHSTEq3HbG aiH6lK2AI6O5gonML6lRdh/jZYmAvBph4CDdtt+/joP1qhF6hWqe8YUOxz7q0nrI4Voi1wOlOFzWY Acias/BLumPuwAfg/BdFbfG18WkdwX50HxdxPVp2teh9ipYj/82VugnSLJyyIflU5ZX24oBZSsZkV Dyb9i+5vg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9PeC-0007MW-Fg; Tue, 09 Feb 2021 09:49:28 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9Pe9-0007Lc-Tl for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 09:49:26 +0000 Received: by mail-wm1-x334.google.com with SMTP id t142so2468194wmt.1 for ; Tue, 09 Feb 2021 01:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iODsYL577vtiTZcS5AXU5f62AD5nWHRXTaswzxJRGpE=; b=JBX1u8nYfJ2D17HCZU3bF64mR3tXNePMMbkujQwPzUB4EHhq0FLPs5OOM92rDCpHBF 4O9xTvVsnstE1b4IgRWf/cN/5JU2cy+inHw8TS2/FNMZeJNBStL7jnJ8ZcPrtCFvxPG4 V/4KyzneELW/HpkZBFhB9trOu3KvpkoWlsMbt5tVgBOMJdCNMuB/45CFP7unHH4zy3N2 NFahaB6yHkIYKLQFa/wTYu0dpNn78LVyWqe8lOs5wsRRZj5Dw2+AdWS4zVBv+s35utmv HQfK/sg06HSj9kgzRvVI2EWfBGQTkY4bQKv9rmjLvOp2dFbUsZ/6hGhjOZ1SksYp8P8F /Blg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iODsYL577vtiTZcS5AXU5f62AD5nWHRXTaswzxJRGpE=; b=O2fMD6B/slQSND5fhoLgt7Hd7+JitvEpoKAx+2q5+LiPsikVUxs5CXnxPfZ6gxhZb5 itafSDpv6+i71S8OX7Hy2A5glT3zi121hdufc2w72fOhAea29xjYEXODL505dgH8IBoo v6qcipe5OQsQO9rEUeqIfss29bpJdOUhw9bFdE01HFXaQDln/e2RgiwCddspBjg7UwD3 /coZF7z4qgBA9MBGLA5XTc/hFYTbR0KbAGVGy1E8ihq0BDpv6ezr8eYIbTydcD12VFvX LKr1U8VNJyzUz4hbg6nRDtaI+uOLp3UUyfzolECmSmZaBeduvLwSEeHqyXDLe91q0Ovk O9sg== X-Gm-Message-State: AOAM5338u2xJ8XJFy3F2GF6o4Y98bbmgbf7SGssHvzZ5LB+jdJpbFtv1 ly3wgrG00w++We0J+7wQpRtRrKpC2GqDQcAaq40upg== X-Google-Smtp-Source: ABdhPJwkXMO4uhvCsmyjxeJIJN/dMVthik8rV2agcLFH9W28tEatgkKRxyaLXGqmb/ZxKjwVzyOeJ3lIrOe3jbSNI4Y= X-Received: by 2002:a7b:ca57:: with SMTP id m23mr2607883wml.116.1612864162564; Tue, 09 Feb 2021 01:49:22 -0800 (PST) MIME-Version: 1.0 References: <20210111142309.193441-1-maxime@cerno.tech> <20210111142309.193441-15-maxime@cerno.tech> In-Reply-To: <20210111142309.193441-15-maxime@cerno.tech> From: Dave Stevenson Date: Tue, 9 Feb 2021 09:49:05 +0000 Message-ID: Subject: Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_044926_148169_1FD1D992 X-CRM114-Status: GOOD ( 19.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , David Airlie , Nicolas Saenz Julienne , Maarten Lankhorst , LKML , DRI Development , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann , Hans Verkuil , Daniel Vetter , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote: > > The BSC controllers used for the HDMI DDC have an interrupt controller > shared between both instances. Let's add it to avoid polling. This seems to have unintended side effects. GIC interrupt 117 is shared between the standard I2C controllers (i2c-bcm2835) and the l2-intc block handling the HDMI I2C interrupts. Whilst i2c-bcm2835 requests the interrupt with IRQF_SHARED, that doesn't appear to be an option for l2-intc registering as an interrupt controller. i2c-bcm2835 therefore loses out and fails to register for the interrupt. Is there an equivalent flag that an interrupt controller can add to say that the parent interrupt is shared? Is that even supported? Thanks Dave > Reviewed-by: Florian Fainelli > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/bcm2711.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi > index 4847dd305317..8bb46ae76a92 100644 > --- a/arch/arm/boot/dts/bcm2711.dtsi > +++ b/arch/arm/boot/dts/bcm2711.dtsi > @@ -308,6 +308,14 @@ dvp: clock@7ef00000 { > #reset-cells = <1>; > }; > > + bsc_intr: interrupt-controller@7ef00040 { > + compatible = "brcm,bcm2711-l2-intc", "brcm,l2-intc"; > + reg = <0x7ef00040 0x30>; > + interrupts = ; > + interrupt-controller; > + #interrupt-cells = <1>; > + }; > + > hdmi0: hdmi@7ef00700 { > compatible = "brcm,bcm2711-hdmi0"; > reg = <0x7ef00700 0x300>, > @@ -341,6 +349,8 @@ ddc0: i2c@7ef04500 { > reg = <0x7ef04500 0x100>, <0x7ef00b00 0x300>; > reg-names = "bsc", "auto-i2c"; > clock-frequency = <97500>; > + interrupt-parent = <&bsc_intr>; > + interrupts = <0>; > status = "disabled"; > }; > > @@ -377,6 +387,8 @@ ddc1: i2c@7ef09500 { > reg = <0x7ef09500 0x100>, <0x7ef05b00 0x300>; > reg-names = "bsc", "auto-i2c"; > clock-frequency = <97500>; > + interrupt-parent = <&bsc_intr>; > + interrupts = <1>; > status = "disabled"; > }; > }; > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB0C1C433DB for ; Tue, 9 Feb 2021 09:49:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9352E64E7C for ; Tue, 9 Feb 2021 09:49:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9352E64E7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D2A286E02D; Tue, 9 Feb 2021 09:49:25 +0000 (UTC) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAD446E02D for ; Tue, 9 Feb 2021 09:49:23 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id i5so2468352wmq.2 for ; Tue, 09 Feb 2021 01:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iODsYL577vtiTZcS5AXU5f62AD5nWHRXTaswzxJRGpE=; b=JBX1u8nYfJ2D17HCZU3bF64mR3tXNePMMbkujQwPzUB4EHhq0FLPs5OOM92rDCpHBF 4O9xTvVsnstE1b4IgRWf/cN/5JU2cy+inHw8TS2/FNMZeJNBStL7jnJ8ZcPrtCFvxPG4 V/4KyzneELW/HpkZBFhB9trOu3KvpkoWlsMbt5tVgBOMJdCNMuB/45CFP7unHH4zy3N2 NFahaB6yHkIYKLQFa/wTYu0dpNn78LVyWqe8lOs5wsRRZj5Dw2+AdWS4zVBv+s35utmv HQfK/sg06HSj9kgzRvVI2EWfBGQTkY4bQKv9rmjLvOp2dFbUsZ/6hGhjOZ1SksYp8P8F /Blg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iODsYL577vtiTZcS5AXU5f62AD5nWHRXTaswzxJRGpE=; b=f38BuldARVxZgavLrClTkhhnYgqkTydEC479VigI+3O+vgNDEDhNyTs/w9ehFcVo1h T4YEMX9EDh3kp8w60m+osjzjcx8XSgOh6TiwiyQK2ZgWTbQvDnofb8WBHghdloBZtWyN INVcQfEhIYthQVDBBD1w8V7xgyH+VeWF5I/Pu0hpBXdtkOFEFR8cGk/9nWLfkpbA4pyo vNLos5HF2zPF5YtxhQrFVEE5NeOgroxp8Bss9rCr7paJnpaMuingaOUx1cF2/T1mnAgV gQb7dhv3nGaZ1C4xGWOEjdfG9rtGWkVREY14IOYdak6qZ+DzIhct4hWckBIsJxbakht/ EnSw== X-Gm-Message-State: AOAM532psqNfESDS5CmuFIyzzUKTJMtZAUNKENTNeqaLCV5quBKuzkyV 2ePVIjo9XCb/LqO9PWMmZAm73gpAYf7Q+NgZDQxq7tEYAyRR1w== X-Google-Smtp-Source: ABdhPJwkXMO4uhvCsmyjxeJIJN/dMVthik8rV2agcLFH9W28tEatgkKRxyaLXGqmb/ZxKjwVzyOeJ3lIrOe3jbSNI4Y= X-Received: by 2002:a7b:ca57:: with SMTP id m23mr2607883wml.116.1612864162564; Tue, 09 Feb 2021 01:49:22 -0800 (PST) MIME-Version: 1.0 References: <20210111142309.193441-1-maxime@cerno.tech> <20210111142309.193441-15-maxime@cerno.tech> In-Reply-To: <20210111142309.193441-15-maxime@cerno.tech> From: Dave Stevenson Date: Tue, 9 Feb 2021 09:49:05 +0000 Message-ID: Subject: Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller To: Maxime Ripard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , David Airlie , Nicolas Saenz Julienne , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Thomas Zimmermann , Hans Verkuil , Daniel Vetter , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote: > > The BSC controllers used for the HDMI DDC have an interrupt controller > shared between both instances. Let's add it to avoid polling. This seems to have unintended side effects. GIC interrupt 117 is shared between the standard I2C controllers (i2c-bcm2835) and the l2-intc block handling the HDMI I2C interrupts. Whilst i2c-bcm2835 requests the interrupt with IRQF_SHARED, that doesn't appear to be an option for l2-intc registering as an interrupt controller. i2c-bcm2835 therefore loses out and fails to register for the interrupt. Is there an equivalent flag that an interrupt controller can add to say that the parent interrupt is shared? Is that even supported? Thanks Dave > Reviewed-by: Florian Fainelli > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/bcm2711.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi > index 4847dd305317..8bb46ae76a92 100644 > --- a/arch/arm/boot/dts/bcm2711.dtsi > +++ b/arch/arm/boot/dts/bcm2711.dtsi > @@ -308,6 +308,14 @@ dvp: clock@7ef00000 { > #reset-cells = <1>; > }; > > + bsc_intr: interrupt-controller@7ef00040 { > + compatible = "brcm,bcm2711-l2-intc", "brcm,l2-intc"; > + reg = <0x7ef00040 0x30>; > + interrupts = ; > + interrupt-controller; > + #interrupt-cells = <1>; > + }; > + > hdmi0: hdmi@7ef00700 { > compatible = "brcm,bcm2711-hdmi0"; > reg = <0x7ef00700 0x300>, > @@ -341,6 +349,8 @@ ddc0: i2c@7ef04500 { > reg = <0x7ef04500 0x100>, <0x7ef00b00 0x300>; > reg-names = "bsc", "auto-i2c"; > clock-frequency = <97500>; > + interrupt-parent = <&bsc_intr>; > + interrupts = <0>; > status = "disabled"; > }; > > @@ -377,6 +387,8 @@ ddc1: i2c@7ef09500 { > reg = <0x7ef09500 0x100>, <0x7ef05b00 0x300>; > reg-names = "bsc", "auto-i2c"; > clock-frequency = <97500>; > + interrupt-parent = <&bsc_intr>; > + interrupts = <1>; > status = "disabled"; > }; > }; > -- > 2.29.2 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel