From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178AEC433E0 for ; Tue, 28 Jul 2020 11:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2932206D4 for ; Tue, 28 Jul 2020 11:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="df7cZt6I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729143AbgG1LmT (ORCPT ); Tue, 28 Jul 2020 07:42:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729060AbgG1LmS (ORCPT ); Tue, 28 Jul 2020 07:42:18 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCCFEC061794 for ; Tue, 28 Jul 2020 04:42:16 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id f18so17875914wml.3 for ; Tue, 28 Jul 2020 04:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TT24vZnC4xOCdUpOmIAerDESvJeTmO8+8fod85enhmw=; b=df7cZt6I8hQuIl1XU7ttHu4TN5PR1P69UXn6jcfq0mJeliTervs8ge8M8D2wbyi4+u f3u21AIP4rNKufXo9ROZqH8Lj8kVdEnlNLO8ve9kHB6JBq1uwujo0fUL4um3GqE/sYUQ 8NvDtgJwDEbbFZcceKLKEQA2bGi3QvT2WZYzU0t+Tzj4hFnYG5NFCt+w4hi8zqMccP5D CQln4XVfU+gkL44eP7GRwnvZmGGhz/E2HJTucxx4+1Y7sE0U9C8HJ/9KJV7DeRNQz10m XBb0/rgDKA+nA7fNo4M7DnBaWbBEooj+JLGxEuLc6cEyTFwvp89apJctgBuPRR85vBdP VcZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TT24vZnC4xOCdUpOmIAerDESvJeTmO8+8fod85enhmw=; b=Kf7V3rNN+dxFZs6vLmtAvKYZQFA59hUofYiWDerHAlgGVxvbtJRtZM7FJhv5AOBlCl YDwGIoz0puWvo4xJo53lN9J3VFDXBKjMJ9XpKFk60MdicoZTloyq5nJXSS9UQeQXE5oM tGkUIhXuhrCG4w5cxBlAxNv6tPTb8WfPxE5MiuVhGuQFgY4SFRZPwjXBMkiaLGPqVxyr D9Qkb/vuK/95WMpxJH++qmhnlXezo/a4inORbt3QLNd1vi5a/BYRuESzkkomfP/yYqk/ 1U5fHJGTOEKl3dHTTCBI5vKLJI3VDnkp921a/cP7B+fh25Nebi4Z0QLYKnCvkUD/oNAj IO5A== X-Gm-Message-State: AOAM533icX136z7gQl+/xhYF5O3Jk7Y5w1mRnWILQXQp/OVpvGoa2wMi tUE/oyOfzZtLQO09LhDz6ad0qAdoJqZnvbN7aySc3g== X-Google-Smtp-Source: ABdhPJz8AUHazoZwcaZZ9jNUzaMz3ho5hqMfyeOSaPMimnzYiaStb9+h5tEC/aggQScQWwU+fwuhtNmhcjK0dfIEvn0= X-Received: by 2002:a1c:1d52:: with SMTP id d79mr1167435wmd.82.1595936535673; Tue, 28 Jul 2020 04:42:15 -0700 (PDT) MIME-Version: 1.0 References: <596dac201108233446694a1014726c51843172c5.1594230107.git-series.maxime@cerno.tech> In-Reply-To: <596dac201108233446694a1014726c51843172c5.1594230107.git-series.maxime@cerno.tech> From: Dave Stevenson Date: Tue, 28 Jul 2020 12:41:56 +0100 Message-ID: Subject: Re: [PATCH v4 31/78] drm/vc4: crtc: Clear the PixelValve FIFO during configuration To: Maxime Ripard Cc: Nicolas Saenz Julienne , Eric Anholt , DRI Development , linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, LKML , Tim Gover , Phil Elwell Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime On Wed, 8 Jul 2020 at 18:43, Maxime Ripard wrote: > > Even though it's not really clear why we need to flush the PV FIFO during > the configuration even though we started by flushing it, experience shows > that without it we get a stale pixel stuck in the FIFO between the HVS and > the PV. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index 13fe0e370fb3..25a77cd46b28 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -358,7 +358,7 @@ static void vc4_crtc_config_pv(struct drm_crtc *crtc) > if (is_dsi) > CRTC_WRITE(PV_HACT_ACT, mode->hdisplay * pixel_rep); > > - CRTC_WRITE(PV_CONTROL, > + CRTC_WRITE(PV_CONTROL, PV_CONTROL_FIFO_CLR | > vc4_crtc_get_fifo_full_level_bits(vc4_crtc, format) | > VC4_SET_FIELD(format, PV_CONTROL_FORMAT) | > VC4_SET_FIELD(pixel_rep - 1, PV_CONTROL_PIXEL_REP) | > -- > git-series 0.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6EA1C433F4 for ; Tue, 28 Jul 2020 11:43:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8C73206D4 for ; Tue, 28 Jul 2020 11:43:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2MvgXdIz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="df7cZt6I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8C73206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5DdQRTdMgYYJIcy1DPb9Dg5tn4rB6Zv2vgwB1n17FDs=; b=2MvgXdIz8uFJjA8dxt40mdDGH HJ5f5hgsZSaTX5qJfTvRBzKHACJ/yWe4qVOEOhG8PPgWft3OLiNLWYJJ0B6NjRsaCHND3J5JX6LvF yN6/MaeoWjTB3qVk3lojVzpmLazjT5onGiiAXZm5KWUacQVHfFp43WSNRHRxwb+wS02kTuALYllMK nZ2RzvzvBF4LSGolstplZXVCh5K60u/f6zIiA0QFriM63Dps/82Xnc8QWTe9RZrOd2/r4501iEFuX dysjcQakCjGpqT8Qi5IJchVzdMud3wrdw4cSS6G299tKlNXX5Juh4cOMmvoEaMPr6ZvVddUkcX5dM /uInNmwEQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0Nzv-0004yK-Ig; Tue, 28 Jul 2020 11:42:19 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0Nzs-0004xO-PO for linux-arm-kernel@lists.infradead.org; Tue, 28 Jul 2020 11:42:17 +0000 Received: by mail-wm1-x344.google.com with SMTP id k8so7540116wma.2 for ; Tue, 28 Jul 2020 04:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TT24vZnC4xOCdUpOmIAerDESvJeTmO8+8fod85enhmw=; b=df7cZt6I8hQuIl1XU7ttHu4TN5PR1P69UXn6jcfq0mJeliTervs8ge8M8D2wbyi4+u f3u21AIP4rNKufXo9ROZqH8Lj8kVdEnlNLO8ve9kHB6JBq1uwujo0fUL4um3GqE/sYUQ 8NvDtgJwDEbbFZcceKLKEQA2bGi3QvT2WZYzU0t+Tzj4hFnYG5NFCt+w4hi8zqMccP5D CQln4XVfU+gkL44eP7GRwnvZmGGhz/E2HJTucxx4+1Y7sE0U9C8HJ/9KJV7DeRNQz10m XBb0/rgDKA+nA7fNo4M7DnBaWbBEooj+JLGxEuLc6cEyTFwvp89apJctgBuPRR85vBdP VcZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TT24vZnC4xOCdUpOmIAerDESvJeTmO8+8fod85enhmw=; b=o7DBhJPQtS4f4LzFGQPUf7hZ8QV3DSN/IlX7JZd9TfRRMfxkz7BtOg9GTWcnNJcTIK aaFk0K1a40KGPRVPkpD+1TfnX3Oa9P9WE8e6f6HQ9FDMZLkzj4mGNG3YnUZDpyUsjA51 PVt+X4HE7bLDcT8MmJckhVOTDkWYp0xd2NenX8RaX+oE4hOcYToX00gWwlm7NuywuY0B un6fkSRsdfGnool6YtZ2RV3cBBa8iMWm09zr0xc3MKGjP8MoK3NLDMqNLPWnDEZC4LEl nxeJY/VXPhAGQdXpdVIxid9jxyLOwHOJzDyJBA6Waa8meQvpAOvR68Sl7QgbuvnBV+Bm oEyQ== X-Gm-Message-State: AOAM533cWdC9gi47JcnUxAGCNH9XqQyRi0kt68/UblkO1RvNL3vZ8ysK w4SYeHibRwJ8SCZ0df/weN3ECkHpopfAVfHWGA5uhg== X-Google-Smtp-Source: ABdhPJz8AUHazoZwcaZZ9jNUzaMz3ho5hqMfyeOSaPMimnzYiaStb9+h5tEC/aggQScQWwU+fwuhtNmhcjK0dfIEvn0= X-Received: by 2002:a1c:1d52:: with SMTP id d79mr1167435wmd.82.1595936535673; Tue, 28 Jul 2020 04:42:15 -0700 (PDT) MIME-Version: 1.0 References: <596dac201108233446694a1014726c51843172c5.1594230107.git-series.maxime@cerno.tech> In-Reply-To: <596dac201108233446694a1014726c51843172c5.1594230107.git-series.maxime@cerno.tech> From: Dave Stevenson Date: Tue, 28 Jul 2020 12:41:56 +0100 Message-ID: Subject: Re: [PATCH v4 31/78] drm/vc4: crtc: Clear the PixelValve FIFO during configuration To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_074216_908295_47398D31 X-CRM114-Status: GOOD ( 15.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , LKML , DRI Development , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime On Wed, 8 Jul 2020 at 18:43, Maxime Ripard wrote: > > Even though it's not really clear why we need to flush the PV FIFO during > the configuration even though we started by flushing it, experience shows > that without it we get a stale pixel stuck in the FIFO between the HVS and > the PV. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index 13fe0e370fb3..25a77cd46b28 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -358,7 +358,7 @@ static void vc4_crtc_config_pv(struct drm_crtc *crtc) > if (is_dsi) > CRTC_WRITE(PV_HACT_ACT, mode->hdisplay * pixel_rep); > > - CRTC_WRITE(PV_CONTROL, > + CRTC_WRITE(PV_CONTROL, PV_CONTROL_FIFO_CLR | > vc4_crtc_get_fifo_full_level_bits(vc4_crtc, format) | > VC4_SET_FIELD(format, PV_CONTROL_FORMAT) | > VC4_SET_FIELD(pixel_rep - 1, PV_CONTROL_PIXEL_REP) | > -- > git-series 0.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2525DC433E3 for ; Tue, 28 Jul 2020 11:42:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA94D206D4 for ; Tue, 28 Jul 2020 11:42:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="df7cZt6I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA94D206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D1DF6E287; Tue, 28 Jul 2020 11:42:17 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA0226E287 for ; Tue, 28 Jul 2020 11:42:16 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id k20so10201732wmi.5 for ; Tue, 28 Jul 2020 04:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TT24vZnC4xOCdUpOmIAerDESvJeTmO8+8fod85enhmw=; b=df7cZt6I8hQuIl1XU7ttHu4TN5PR1P69UXn6jcfq0mJeliTervs8ge8M8D2wbyi4+u f3u21AIP4rNKufXo9ROZqH8Lj8kVdEnlNLO8ve9kHB6JBq1uwujo0fUL4um3GqE/sYUQ 8NvDtgJwDEbbFZcceKLKEQA2bGi3QvT2WZYzU0t+Tzj4hFnYG5NFCt+w4hi8zqMccP5D CQln4XVfU+gkL44eP7GRwnvZmGGhz/E2HJTucxx4+1Y7sE0U9C8HJ/9KJV7DeRNQz10m XBb0/rgDKA+nA7fNo4M7DnBaWbBEooj+JLGxEuLc6cEyTFwvp89apJctgBuPRR85vBdP VcZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TT24vZnC4xOCdUpOmIAerDESvJeTmO8+8fod85enhmw=; b=OHNJ3If6soF+nmPM60mS//AXIlgVBmuyjj6pwcKT5SjFC2KGatN7lZYm94dcprkh6E 80bzAqDUgXr4dYnD+K8SNaFMm+gZl5WCdCBR3dp1DS0NVeweoxWxOL2ttmGmCfwuH5kt L33Ikcc+iJX8SnZ/1IjETp3Chh+SbdDDeJYh94i5Vhi3XJd25XdESiLHrX1lxxrfz1z4 v8fG/jARqX+bIsYEphIRSrv+ig+jqDSfTmoXF+i2XhJL07uY3ihSa7SLs6duRw2fOZmd cq+0RjxFwmIG8or5JvpK1ytjRn42Q1rgPrI/r19pS6E4ZyzzmRBKcK3kal80BUt1Qr/U B2Zg== X-Gm-Message-State: AOAM532bWDpspRJ5i6pszXSZeM9nLy7jPerBLD3e2MXthgvav51ez7f+ O6bbU1zISYo1ADG48Ext+9d+QeihAx6oZbJqXT/PSQ== X-Google-Smtp-Source: ABdhPJz8AUHazoZwcaZZ9jNUzaMz3ho5hqMfyeOSaPMimnzYiaStb9+h5tEC/aggQScQWwU+fwuhtNmhcjK0dfIEvn0= X-Received: by 2002:a1c:1d52:: with SMTP id d79mr1167435wmd.82.1595936535673; Tue, 28 Jul 2020 04:42:15 -0700 (PDT) MIME-Version: 1.0 References: <596dac201108233446694a1014726c51843172c5.1594230107.git-series.maxime@cerno.tech> In-Reply-To: <596dac201108233446694a1014726c51843172c5.1594230107.git-series.maxime@cerno.tech> From: Dave Stevenson Date: Tue, 28 Jul 2020 12:41:56 +0100 Message-ID: Subject: Re: [PATCH v4 31/78] drm/vc4: crtc: Clear the PixelValve FIFO during configuration To: Maxime Ripard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime On Wed, 8 Jul 2020 at 18:43, Maxime Ripard wrote: > > Even though it's not really clear why we need to flush the PV FIFO during > the configuration even though we started by flushing it, experience shows > that without it we get a stale pixel stuck in the FIFO between the HVS and > the PV. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index 13fe0e370fb3..25a77cd46b28 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -358,7 +358,7 @@ static void vc4_crtc_config_pv(struct drm_crtc *crtc) > if (is_dsi) > CRTC_WRITE(PV_HACT_ACT, mode->hdisplay * pixel_rep); > > - CRTC_WRITE(PV_CONTROL, > + CRTC_WRITE(PV_CONTROL, PV_CONTROL_FIFO_CLR | > vc4_crtc_get_fifo_full_level_bits(vc4_crtc, format) | > VC4_SET_FIELD(format, PV_CONTROL_FORMAT) | > VC4_SET_FIELD(pixel_rep - 1, PV_CONTROL_PIXEL_REP) | > -- > git-series 0.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel