All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuri Khan <yurivkhan@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/1] Input: xpad - Handle all variations of Mad Catz Beat Pad
Date: Mon, 9 Jul 2012 22:52:32 +0700	[thread overview]
Message-ID: <CAP_d_8UDAO8u+y8F8JgPn6FZaZHccjH_aPof4n9zTYT+tDhtMw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1207091608060.19366@pobox.suse.cz>

On Mon, Jul 9, 2012 at 9:08 PM, Jiri Kosina <jkosina@suse.cz> wrote:

>> --- a/drivers/hid/usbhid/hid-quirks.c
>> +++ b/drivers/hid/usbhid/hid-quirks.c
>> +     { USB_VENDOR_ID_MADCATZ, USB_DEVICE_ID_MADCATZ_BEATPAD, HID_QUIRK_IGNORE },
>
> Please put it in drivers/hid/hid-core.c, hid_ignore_list[] array instead.
> HID_QUIRK_IGNORE is there solely for allowing specification as a module
> parameter.

I knew something was not right as there were no prior HID_QUIRK_IGNORE
entries. Thanks for the guidance, will send a revised patch tomorrow.

  reply	other threads:[~2012-07-09 15:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06 16:32 [PATCH 0/1] Input: xpad - Add a variation of Mad Catz Beat Pad Yuri Khan
2012-07-06 16:32 ` [PATCH 1/1] " Yuri Khan
2012-07-06 16:57 ` [PATCH 0/1] " Yuri Khan
2012-07-06 17:03   ` Dmitry Torokhov
2012-07-08  5:49 ` [PATCH v2 1/1] Input: xpad - Handle all variations " Yuri Khan
2012-07-09 14:08   ` Jiri Kosina
2012-07-09 15:52     ` Yuri Khan [this message]
2012-07-10 17:33 ` [PATCH v3 " Yuri Khan
2012-07-10 20:05   ` Jiri Kosina
2012-07-10 20:42   ` Dmitry Torokhov
2012-07-11  7:02 ` [PATCH v4 " Yuri Khan
2012-07-11  7:02   ` Yuri Khan
2012-07-11  7:57   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP_d_8UDAO8u+y8F8JgPn6FZaZHccjH_aPof4n9zTYT+tDhtMw@mail.gmail.com \
    --to=yurivkhan@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.