From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 704B6C4346E for ; Tue, 29 Sep 2020 05:17:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37EBC216C4 for ; Tue, 29 Sep 2020 05:17:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rawzs6k4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727391AbgI2FRk (ORCPT ); Tue, 29 Sep 2020 01:17:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbgI2FRj (ORCPT ); Tue, 29 Sep 2020 01:17:39 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F09FC061755; Mon, 28 Sep 2020 22:17:35 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id 77so4020075lfj.0; Mon, 28 Sep 2020 22:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xif5oC/NRIYYhpW7XETZfA0h68yDq+U57n1x8FOdeWU=; b=rawzs6k4NMlg6bsVsbWsPDBl2UaCGARw1RPjil0OKWhWmLKHo+FOAGheM4W/l1jgCh ntfnJQD1rlXTUrk+If0qpZD2YxEp3os+qzms7fAR7NI0dZkd+LmOdlaKA7/39J2TQThs n7OIgwshgCO5DCcBoNk+gpLg8GsgWOyArueI5twuJ25+eeLBroZfYUD85jJqmBBC1HsZ AOsL6pO/eQ3kcK4P8XtgmWLVbRC888sDzCDtBJ//C6VivSP8Rc6IvHdx5+cDx/pL3iCi U447icvBcUcFBM0BdPKdDNq8m83UnVT2/ZMBdhmV+wtQSxmPW4Pjf6HHHzhjk24ybuW2 mbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xif5oC/NRIYYhpW7XETZfA0h68yDq+U57n1x8FOdeWU=; b=TLiionnPO0fs/L8jXVBWjVXYmBe2t5T/n2VVqORsjgDl9e504eCiJ0CJhRVASWz7U/ vRLQ5y2WZWM4rIWSxZaT2B9UpxW36/6eqXxLUhARRabr/fdPcAqL3hvB6AfC2dxEResp 69g2KsGzNYYLOzxvtLd4ncn6iVO/FCHaL/x3Jef1F65e2+XXnhcOlYMF+Dq3Ykf6Ka9Z 0GxpQad4CwxVYug+KBFWoNM1ZF5g9jV5hB/BiVirhyWJt88GuUmAjnHExTmADhfQujKu oYu2RahCtUETEf+znITqC/gp2TinaPFJ8ZOxcNOMJFefos+zsrXSqiqJcUHL8Fsc3iuz Khkw== X-Gm-Message-State: AOAM531tURi6cbj6RyVICuC/CDBKSnXAodX9DUNlNYg3jQT8JgQq7RpE bDbS4I1yGdQ55fxkHnE3GRKwvhQ9vpNznJMVHVw= X-Google-Smtp-Source: ABdhPJycgZBSkevRQeXI1VbUJ3Yyp8eqTYufhpIaDs+0WpIrV5IhsXpb1BlXRucnYS+kLO+uTMnYwDrzZsNB+58IdvU= X-Received: by 2002:a05:6512:31d2:: with SMTP id j18mr621070lfe.316.1601356651774; Mon, 28 Sep 2020 22:17:31 -0700 (PDT) MIME-Version: 1.0 References: <20200929050302.28105-1-bigclouds@163.com> In-Reply-To: <20200929050302.28105-1-bigclouds@163.com> From: yue longguang Date: Tue, 29 Sep 2020 13:17:20 +0800 Message-ID: Subject: Re: [PATCH] ipvs: Add traffic statistic up even it is VS/DR or VS/TUN mode To: "longguang.yue" Cc: Wensong Zhang , Simon Horman , Julian Anastasov , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , "open list:IPVS" , "open list:IPVS" , "open list:NETFILTER" , "open list:NETFILTER" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org especially in public cloud case, statistic is related to monitorring and billing , both ingress and egress packets will go throught ipvs, even dr/tun mode. in dr/tun mode, ipvs need to do nothing except statistic, so skb->ipvs_property = 1 regards On Tue, Sep 29, 2020 at 1:04 PM longguang.yue wrote: > > It's ipvs's duty to do traffic statistic if packets get hit, > no matter what mode it is. > > Signed-off-by: longguang.yue > --- > net/netfilter/ipvs/ip_vs_core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c > index e3668a6e54e4..ed523057f07f 100644 > --- a/net/netfilter/ipvs/ip_vs_core.c > +++ b/net/netfilter/ipvs/ip_vs_core.c > @@ -1413,8 +1413,11 @@ ip_vs_out(struct netns_ipvs *ipvs, unsigned int hooknum, struct sk_buff *skb, in > ipvs, af, skb, &iph); > > if (likely(cp)) { > - if (IP_VS_FWD_METHOD(cp) != IP_VS_CONN_F_MASQ) > + if (IP_VS_FWD_METHOD(cp) != IP_VS_CONN_F_MASQ){ > + ip_vs_out_stats(cp, skb); > + skb->ipvs_property = 1; > goto ignore_cp; > + } > return handle_response(af, skb, pd, cp, &iph, hooknum); > } > > -- > 2.20.1 (Apple Git-117) >