From: Chia-I Wu <olvaffe@gmail.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: oleksandr_andrushchenko@epam.com,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Dave Airlie" <airlied@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] Revert "drm/virtio: drop prime import/export callbacks"
Date: Fri, 19 Apr 2019 09:45:31 -0700 [thread overview]
Message-ID: <CAPaKu7T=kcX4ZiCL+CNFfzJgunh1hj+54mwse0ukHmRgkYjvOA@mail.gmail.com> (raw)
In-Reply-To: <CACvgo534FFRhLOnQGnU4Y3AjkRN9wvHhHWWRAPLyw3m-op=10A@mail.gmail.com>
On Fri, Apr 19, 2019 at 9:21 AM Emil Velikov <emil.l.velikov@gmail.com> wrote:
>
> On Fri, 19 Apr 2019 at 16:57, Marc-André Lureau
> <marcandre.lureau@redhat.com> wrote:
> >
> > This patch does more harm than good, as it breaks both Xwayland and
> > gnome-shell with X11.
> >
> > Xwayland requires DRI3 & DRI3 requires PRIME.
> >
> > X11 crash for obscure double-free reason which are hard to debug
> > (starting X11 by hand doesn't trigger the crash).
> >
> > I don't see an apparent problem implementing those stub prime
> > functions, they may return an error at run-time, and it seems to be
> > handled fine by GNOME at least.
> >
> > Please consider a revert.
> >
> > This reverts commit b318e3ff7ca065d6b107e424c85a63d7a6798a69.
> >
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Dave Airlie <airlied@redhat.com>
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The DRI3 code extensively uses prime_handle_to_fd and
> prime_fd_to_handle for self-import.
>
> Fwiw the patch is:
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
We also use Xwayland and will be helped by the revert.
I believe the cap was removed because the driver only supports
self-import. But the driver only runs inside VMs where there is no(?)
other dma-buf clients, and it handles runtime errors fine even if
there are, I would also like to see this revert be considered.
>
> -Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-19 16:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 15:57 [PATCH] Revert "drm/virtio: drop prime import/export callbacks" Marc-André Lureau
2019-04-19 16:21 ` Emil Velikov
2019-04-19 16:45 ` Chia-I Wu [this message]
2019-04-23 8:05 ` Gerd Hoffmann
2019-04-23 11:55 ` Emil Velikov
2019-04-23 14:06 ` Gerd Hoffmann
2019-04-23 16:17 ` Emil Velikov
2019-04-24 0:54 ` Dave Airlie
2019-04-23 8:01 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPaKu7T=kcX4ZiCL+CNFfzJgunh1hj+54mwse0ukHmRgkYjvOA@mail.gmail.com' \
--to=olvaffe@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=oleksandr_andrushchenko@epam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.