All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eugen Konkov <kes-kes@yandex.ru>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: BUG: git rebase shows different commit message
Date: Wed, 14 Oct 2020 10:55:45 -0700	[thread overview]
Message-ID: <CAPc5daVAJxfZVz0HwTFwhq-EfERrESU2Ta6-0fAyXrzf3YJREg@mail.gmail.com> (raw)
In-Reply-To: <703071109.20201014201106@yandex.ru>

> $git log --graph --decorate --pretty=oneline --abbrev-commit
> * 093010ea (local/dev) Change column 'Label' => 'OPFG' and added column 'comment'
> * 86221a47  Updated OpenAPI schema according to SCHEMA 193
> * 6202eb08 Added opfg.html
>
> $git rebase -i --autostash --rebase-merges 86221a47^
> label onto
>
> reset onto
> pick 86221a47 Updated OpenAPI schema according to SCHEMA 193
> pick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'
>
> Here commit message is shown without leading space.
> I  think  that this is wrong. Because if space was shown then I reword
> commit message
>
> r 86221a47 Updated OpenAPI schema according to SCHEMA 193
> pick 093010ea Change column 'Label' => 'OPFG' and added column 'comment'
>
> but now I just do not see that I shold reword it =(

These one-line titles are shown to help you identify the commit to futz with,
not to help you review them. After all, you see only titles here
without the body
of the log message [*1*].

Besides, if the "breakage" in the title were not just an extra
whitespace but some
control characters that take the terminal into an insane state, we
should sanitize
the title we'd show here for identification purposes, so "show the
title as-is" is not
a good idea to begin with.

So, NAK.

[Footnote]
*1* ... and if majority of your commits have a single-liner titles, I cannot
imagine how these logs can be useful to its consumers (i.e. those who
use "git show" after identifying an old commit that broke things using
"git bisect" or "git blame").

A leading whitespace in such a "git log" output would be the least of your
problems in such a history, I would have to say.

  reply	other threads:[~2020-10-14 17:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 17:11 BUG: git rebase shows different commit message Eugen Konkov
2020-10-14 17:55 ` Junio C Hamano [this message]
2020-10-15  7:36   ` Eugen Konkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPc5daVAJxfZVz0HwTFwhq-EfERrESU2Ta6-0fAyXrzf3YJREg@mail.gmail.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kes-kes@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.