All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miao Yan <yanmiaobest@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/12] cmd: qfw: remove qemu_fwcfg_free_files()
Date: Mon, 16 May 2016 17:47:43 +0800	[thread overview]
Message-ID: <CAPc5xaOeKyLQ6jSa1iq0C6Qp75MhUsY=2gNk1cEeJUO0xoTM1Q@mail.gmail.com> (raw)
In-Reply-To: <20160513204625.GY13571@bill-the-cat>

2016-05-14 4:46 GMT+08:00 Tom Rini <trini@konsulko.com>:
> On Fri, May 13, 2016 at 10:00:05PM +0800, Bin Meng wrote:
>> Hi Miao,
>>
>> On Fri, May 13, 2016 at 2:29 PM, Miao Yan <yanmiaobest@gmail.com> wrote:
>> > This patch is part of the qfw refactor work.
>> >
>> > The qemu_fwcfg_free_files() function is only used in error handling in
>> > ACPI table generation, let's not make this a core function and move it
>> > to the right place.
>> >
>>
>> But I suspect this API may still be needed in some other scenarioes?
>> eg: for future ARM64 ACPI?
>
> Yes, as it stands currently the code looks likely useful for non-x86
> QEMU+ACPI.

ARM64 and x86 should be able to share common ACPI code. As for now,
this function is not used anywhere but error handling in only one
place. I'd prefer not to make this public.

Thanks,
Miao


>
> --
> Tom

  reply	other threads:[~2016-05-16  9:47 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13  6:29 [U-Boot] [PATCH 00/12] cleanup QEMU fw_cfg code Miao Yan
2016-05-13  6:29 ` [U-Boot] [PATCH 01/12] x86: qemu: fix ACPI Kconfig options Miao Yan
2016-05-13 13:59   ` Bin Meng
2016-05-16  9:37     ` Miao Yan
2016-05-13  6:29 ` [U-Boot] [PATCH 02/12] cmd: qfw: add API to iterate firmware list Miao Yan
2016-05-13 14:00   ` Bin Meng
2016-05-13  6:29 ` [U-Boot] [PATCH 03/12] cmd: qfw: remove qemu_fwcfg_free_files() Miao Yan
2016-05-13 14:00   ` Bin Meng
2016-05-13 20:46     ` Tom Rini
2016-05-16  9:47       ` Miao Yan [this message]
2016-05-17  0:42         ` Tom Rini
2016-05-13  6:29 ` [U-Boot] [PATCH 04/12] cmd: qfw: make fwcfg_present and fwcfg_dma_present public Miao Yan
2016-05-13 14:00   ` Bin Meng
2016-05-13  6:29 ` [U-Boot] [PATCH 05/12] x86: qemu: split qfw command interface and qfw core Miao Yan
2016-05-13 14:00   ` Bin Meng
2016-05-16  9:39     ` Miao Yan
2016-05-16  8:47   ` Bin Meng
2016-05-16  9:50     ` Miao Yan
2016-05-16 13:32       ` Bin Meng
2016-05-13  6:29 ` [U-Boot] [PATCH 06/12] x86: qemu: move x86 specific operations out of " Miao Yan
2016-05-13 14:00   ` Bin Meng
2016-05-13  6:29 ` [U-Boot] [PATCH 07/12] x86: qemu: add comment about qfw register endianness Miao Yan
2016-05-13 14:00   ` Bin Meng
2016-05-13  6:29 ` [U-Boot] [PATCH 08/12] cmd: qfw: rename qemu_fw_cfg.[c|h] to qfw.[c|h] Miao Yan
2016-05-13 14:00   ` Bin Meng
2016-05-13  6:29 ` [U-Boot] [PATCH 09/12] cmd: qfw: workaround qfw build issue Miao Yan
2016-05-13 14:00   ` Bin Meng
2016-05-13 20:46     ` Tom Rini
2016-05-16  9:44       ` Miao Yan
2016-05-13  6:29 ` [U-Boot] [PATCH 10/12] cmd: qfw: do not depend on x86 Miao Yan
2016-05-13 14:00   ` Bin Meng
2016-05-16  9:44     ` Miao Yan
2016-05-16 13:33       ` Bin Meng
2016-05-13  6:29 ` [U-Boot] [PATCH 11/12] cmd: qfw: bring ACPI generation code into qfw core Miao Yan
2016-05-13 14:01   ` Bin Meng
2016-05-13  6:29 ` [U-Boot] [PATCH 12/12] x86: qemu: rename qemu/acpi_table.c Miao Yan
2016-05-13 14:01   ` Bin Meng
2016-05-16  9:40     ` Miao Yan
2016-05-17  0:42       ` Tom Rini
2016-05-17  1:23         ` Miao Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPc5xaOeKyLQ6jSa1iq0C6Qp75MhUsY=2gNk1cEeJUO0xoTM1Q@mail.gmail.com' \
    --to=yanmiaobest@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.