From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756938AbcBIXA7 (ORCPT ); Tue, 9 Feb 2016 18:00:59 -0500 Received: from mail-yw0-f181.google.com ([209.85.161.181]:32820 "EHLO mail-yw0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756618AbcBIXAz (ORCPT ); Tue, 9 Feb 2016 18:00:55 -0500 MIME-Version: 1.0 In-Reply-To: <569983CC.7000207@google.com> References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> <1452869739-3304-27-git-send-email-gustavo@padovan.org> <569930FF.1090601@Intel.com> <20160115180207.GD2664@joana> <569983CC.7000207@google.com> Date: Tue, 9 Feb 2016 14:55:29 -0800 Message-ID: Subject: Re: [RFC 26/29] dma-buf/fence: remove pointless fence_timeline_signal at destroy phase From: Tom Cherry To: Greg Hackmann Cc: Gustavo Padovan , John Harrison , Gustavo Padovan , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Riley Andrews , Daniel Vetter , Rob Clark , Maarten Lankhorst , Dmitry Torokhov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2016 at 3:42 PM, Greg Hackmann wrote: > On 01/15/2016 10:02 AM, Gustavo Padovan wrote: >> >> Patches 27 and 28 are attempt to fix that. I assumed that if some code is >> calling fence_timeline_destroy() it wants to stop everything so I >> worked on a solution that stops any waiter and allows the timeline to be >> destroyed. >> >> No one is using fence_timeline_destroy() in mainline now, so it is >> definately a behaviour we can discuss. >> >> Gustavo >> > > +Tom Cherry and Dmitry Torokhov recently discovered that this was broken by > the refactoring of Android sync on top of dma-buf fences. > > Tom and Dmitry, did you send the proposed fix upstream? There was a similar issue that I had originally thought to be related to fence_timeline_destroy() but was actually related to sync_fence_free(). Dmitry sent the patch upstream at https://lkml.org/lkml/2015/12/14/953, but it does not look like it has received any feedback. We saw real panics without this patch. I didn't see this patch or any similar changes in the destaging commits, and I would recommend it be looked at while destaging this driver. Tom From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Cherry Subject: Re: [RFC 26/29] dma-buf/fence: remove pointless fence_timeline_signal at destroy phase Date: Tue, 9 Feb 2016 14:55:29 -0800 Message-ID: References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> <1452869739-3304-27-git-send-email-gustavo@padovan.org> <569930FF.1090601@Intel.com> <20160115180207.GD2664@joana> <569983CC.7000207@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f182.google.com (mail-yw0-f182.google.com [209.85.161.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id D9B096E3CA for ; Tue, 9 Feb 2016 14:55:30 -0800 (PST) Received: by mail-yw0-f182.google.com with SMTP id g127so1309214ywf.2 for ; Tue, 09 Feb 2016 14:55:30 -0800 (PST) In-Reply-To: <569983CC.7000207@google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Hackmann Cc: devel@driverdev.osuosl.org, daniels@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Maarten Lankhorst , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Dmitry Torokhov , Greg Kroah-Hartman , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKYW4gMTUsIDIwMTYgYXQgMzo0MiBQTSwgR3JlZyBIYWNrbWFubiA8Z2hhY2ttYW5u QGdvb2dsZS5jb20+IHdyb3RlOgo+IE9uIDAxLzE1LzIwMTYgMTA6MDIgQU0sIEd1c3Rhdm8gUGFk b3ZhbiB3cm90ZToKPj4KPj4gUGF0Y2hlcyAyNyBhbmQgMjggYXJlIGF0dGVtcHQgdG8gZml4IHRo YXQuIEkgYXNzdW1lZCB0aGF0IGlmIHNvbWUgY29kZSBpcwo+PiBjYWxsaW5nIGZlbmNlX3RpbWVs aW5lX2Rlc3Ryb3koKSBpdCB3YW50cyB0byBzdG9wIGV2ZXJ5dGhpbmcgc28gSQo+PiB3b3JrZWQg b24gYSBzb2x1dGlvbiB0aGF0IHN0b3BzIGFueSB3YWl0ZXIgYW5kIGFsbG93cyB0aGUgdGltZWxp bmUgdG8gYmUKPj4gZGVzdHJveWVkLgo+Pgo+PiBObyBvbmUgaXMgdXNpbmcgZmVuY2VfdGltZWxp bmVfZGVzdHJveSgpIGluIG1haW5saW5lIG5vdywgc28gaXQgaXMKPj4gZGVmaW5hdGVseSBhIGJl aGF2aW91ciB3ZSBjYW4gZGlzY3Vzcy4KPj4KPj4gICAgICAgICBHdXN0YXZvCj4+Cj4KPiArVG9t IENoZXJyeSBhbmQgRG1pdHJ5IFRvcm9raG92IHJlY2VudGx5IGRpc2NvdmVyZWQgdGhhdCB0aGlz IHdhcyBicm9rZW4gYnkKPiB0aGUgcmVmYWN0b3Jpbmcgb2YgQW5kcm9pZCBzeW5jIG9uIHRvcCBv ZiBkbWEtYnVmIGZlbmNlcy4KPgo+IFRvbSBhbmQgRG1pdHJ5LCBkaWQgeW91IHNlbmQgdGhlIHBy b3Bvc2VkIGZpeCB1cHN0cmVhbT8KClRoZXJlIHdhcyBhIHNpbWlsYXIgaXNzdWUgdGhhdCBJIGhh ZCBvcmlnaW5hbGx5IHRob3VnaHQgdG8gYmUgcmVsYXRlZAp0byBmZW5jZV90aW1lbGluZV9kZXN0 cm95KCkgYnV0IHdhcyBhY3R1YWxseSByZWxhdGVkIHRvCnN5bmNfZmVuY2VfZnJlZSgpLiAgRG1p dHJ5IHNlbnQgdGhlIHBhdGNoIHVwc3RyZWFtIGF0Cmh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE1 LzEyLzE0Lzk1MywgYnV0IGl0IGRvZXMgbm90IGxvb2sgbGlrZSBpdCBoYXMKcmVjZWl2ZWQgYW55 IGZlZWRiYWNrLgoKV2Ugc2F3IHJlYWwgcGFuaWNzIHdpdGhvdXQgdGhpcyBwYXRjaC4gIEkgZGlk bid0IHNlZSB0aGlzIHBhdGNoIG9yIGFueQpzaW1pbGFyIGNoYW5nZXMgaW4gdGhlIGRlc3RhZ2lu ZyBjb21taXRzLCBhbmQgSSB3b3VsZCByZWNvbW1lbmQgaXQgYmUKbG9va2VkIGF0IHdoaWxlIGRl c3RhZ2luZyB0aGlzIGRyaXZlci4KClRvbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK