All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Gardiner <bengardiner@nanometrics.ca>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] mtd_debug: report ecc layout
Date: Wed, 10 Aug 2011 13:52:55 -0400	[thread overview]
Message-ID: <CAPcSpE+rnwoD=7MG6F1vLLnu9tRfpUq-K8DPdx6bY1BQN1THDg@mail.gmail.com> (raw)
In-Reply-To: <CAN8TOE-H9f9=DtamWPHTLbCJQBnGpeOJDtcXo18nkdC-d8WB7A@mail.gmail.com>

Hi Brian,

On Wed, Aug 10, 2011 at 1:07 PM, Brian Norris
<computersforpeace@gmail.com> wrote:
> On Tue, Aug 9, 2011 at 1:57 PM, Ben Gardiner <bengardiner@nanometrics.ca> wrote:
>> Add the ECC size and OOB available to that list. The other entries in the
>> ecclayout struct are arrays and are not as meaningful as eccsize and oobavail.
>> ---
>> I noticed that the struct nand_ecclayout_user and its corresponding ioctl
>> has been marked deprecated; however, since this is a 'debug' utility and at
>> least one person found it useful I thought it would be a good idea to propose
>> these changes anyways.
>
> While I agree with your rationale for ignoring the deprecation (it's
> OK for a debug utility),

Thanks for the review  -- and for agreeing with me :)

> users of this feature should be warned that
> struct nand_ecclayout_user will not report all information if there
> are more ECC entries than "MTD_MAX_ECCPOS_ENTRIES" (i.e., 64). It will
> simply truncate ECC at 64. This may be a problem for large page flash
> with large ECC regions. It's a similar story for "oobavail" as well.
>
> And before the question is asked, I'm not sure how to implement my
> suggestion that "users of this feature should be warned". Perhaps just
> a comment in the code?

Sounds reasonable to me -- I will insert a warning comment in v2.

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca

  reply	other threads:[~2011-08-10 17:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 20:38 [PATCH 0/3] mtd-utils: bit errors in nandtest Ben Gardiner
2011-08-09 20:57 ` [PATCH 1/3] mtd_debug: report ecc layout Ben Gardiner
2011-08-10 17:07   ` Brian Norris
2011-08-10 17:52     ` Ben Gardiner [this message]
2011-08-17  8:32     ` Artem Bityutskiy
2011-08-17  8:03   ` Artem Bityutskiy
2011-08-18 14:01     ` Ben Gardiner
2011-08-22 11:00       ` Artem Bityutskiy
2011-08-22 13:11         ` Ben Gardiner
2011-08-09 20:57 ` [PATCH 2/3] nandtest: print number of bits corrected during test Ben Gardiner
2011-08-25 11:00   ` Artem Bityutskiy
2011-08-09 20:57 ` [PATCH 3/3] nandtest: report estimated BER Ben Gardiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPcSpE+rnwoD=7MG6F1vLLnu9tRfpUq-K8DPdx6bY1BQN1THDg@mail.gmail.com' \
    --to=bengardiner@nanometrics.ca \
    --cc=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.