From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7293FCF for ; Mon, 27 Sep 2021 18:19:35 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id w11so12324295plz.13 for ; Mon, 27 Sep 2021 11:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/zKrL812IZj983CDNoTAXGWrzyYsFXUo70xd8d5OVRw=; b=Jsb0eKvqCXj6YljT8mnNPPjr3BIta8VJgkFwUhes6b/1qGEctJiqdGoU7reuK1AZM/ dRzwyM05Kp1f84uAdAfp6lpa6Kk6KrCctynYJjcNFlJqW67E/6X+ki37v3QUWU0m1/u9 TcXQwmHrrC+9oANWkZnWvfG0vHePNl6ImGj+TPhUqDGEZvuThtKyx/QVWv+BDBO5CxEH nrnvSk8H17UdAOfIRs/v4MaCJiFlW6Utx65qH2WPjcTKzOWfyynuYxqSqy7z5IXJyz+K HWDDhB4TmrlY5XL9sfDfM16NI7TUx5PNG6Ocitq0UJCYq9SmfPkhVoCkM5WUHXeUawcz 7uLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/zKrL812IZj983CDNoTAXGWrzyYsFXUo70xd8d5OVRw=; b=qlpTyr/nzFrI0e8IRj6zWdiY56ZosHUtofEJd0piG2tAZI4h6o37nn3nlopHys8NaH V4q/YJxyuICasPFZNtIzc5DekHrDGpcp3D3GDrDRmYqgGrqkddqct559Ea2wdS9eevOF wfBo2sN4HHCKNwx5n/1ngOtrKeM/9i8I4HIeUzO9kbhAJl6HfOP6X4pkx55s3kV3Mfr/ T4J5Z0UwhJTOy1Sev/FRpOv28sl7bQvo4ZZC5/6Gd6N7y/tnSh0eYUzgg33agQ/qxvdo n6ijU0zJmx0i/MGgKQnrhMmLQFv3B+060x07TscokR5rsf9URqtMHYocAmPMTQU5ypwg k+7A== X-Gm-Message-State: AOAM53166V+2EUjeJLSiwLScrSAhxOi8rWOwUKILaq0+qcHsJczLEmuH mhMADiyXmzhUN8C/2AT1orKjl8JmNBhb1pRlNkDh3g== X-Google-Smtp-Source: ABdhPJzYACAhNeBki+5sxnyzl/I1D8hsXspGBbTtTNOTP9ryqsZwhQMC1+Cl+YsUD0Vcn6/Cm7DGttsgpUvEDzyH18I= X-Received: by 2002:a17:90a:d686:: with SMTP id x6mr573260pju.8.1632766774563; Mon, 27 Sep 2021 11:19:34 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210922183331.2455043-1-hch@lst.de> In-Reply-To: <20210922183331.2455043-1-hch@lst.de> From: Dan Williams Date: Mon, 27 Sep 2021 11:19:26 -0700 Message-ID: Subject: Re: fix a dax/block device attribute registration regression To: Christoph Hellwig Cc: Jens Axboe , Vishal Verma , Dave Jiang , Ira Weiny , linux-block@vger.kernel.org, Linux NVDIMM Content-Type: text/plain; charset="UTF-8" On Wed, Sep 22, 2021 at 11:34 AM Christoph Hellwig wrote: > > Hi Dan and Jens, > > this series fixed a regression in how the dax/write_cache attribute of the > pmem devices was registere. It does so by both fixing the API abuse in the > driver and (temporarily) the behavior change in the block layer that made > this API abuse not work anymore. I took patch1 into for-5.15/libnvdimm, patch2 into for-5.16/libnvdimm, and I'll leave patch3 for Jens. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00FE7C433F5 for ; Mon, 27 Sep 2021 18:19:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D57C460F4B for ; Mon, 27 Sep 2021 18:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235942AbhI0SVN (ORCPT ); Mon, 27 Sep 2021 14:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235845AbhI0SVN (ORCPT ); Mon, 27 Sep 2021 14:21:13 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13F5FC061575 for ; Mon, 27 Sep 2021 11:19:35 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id on12-20020a17090b1d0c00b001997c60aa29so436884pjb.1 for ; Mon, 27 Sep 2021 11:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/zKrL812IZj983CDNoTAXGWrzyYsFXUo70xd8d5OVRw=; b=Jsb0eKvqCXj6YljT8mnNPPjr3BIta8VJgkFwUhes6b/1qGEctJiqdGoU7reuK1AZM/ dRzwyM05Kp1f84uAdAfp6lpa6Kk6KrCctynYJjcNFlJqW67E/6X+ki37v3QUWU0m1/u9 TcXQwmHrrC+9oANWkZnWvfG0vHePNl6ImGj+TPhUqDGEZvuThtKyx/QVWv+BDBO5CxEH nrnvSk8H17UdAOfIRs/v4MaCJiFlW6Utx65qH2WPjcTKzOWfyynuYxqSqy7z5IXJyz+K HWDDhB4TmrlY5XL9sfDfM16NI7TUx5PNG6Ocitq0UJCYq9SmfPkhVoCkM5WUHXeUawcz 7uLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/zKrL812IZj983CDNoTAXGWrzyYsFXUo70xd8d5OVRw=; b=DnKsPiKYgZZ6RM0G3BqbPn9F7wS80I0WGsV59iOEIAQFej08p+h6Eiw4OA7JDSgtGW eeO6MRS+/JUe8OMvpox6GfkN1qUWHbvxlPmxEI0Qj2W3FZM9OLThq37MOtSOFbkl2fCb 5aI66oCWLNtTLHrF+oR+tZD3xmiFml1xCRHl0rjXx5GQGWXk4eYTo+Wlc+hxdaos/HLo gipjpe4bzhT5h0naCwuwsgxkPL+kmX0XA4Q7gWAge9kkzGHzNs83dk8fFcD304+rYQuj sw+L5eLyt+6jGTKTuXwhMsaa0UP74oVcx/mjDDPkc4e6z0TjPNoPRd/bDxQbzyIMpJGv Wqfw== X-Gm-Message-State: AOAM5302J8XJdUOJnqthpSSHIQk3ROVMrsunrNOGVlI3C9yOx2ELWEs6 l8G5t/r/d2hQLS3wBx1pIfO88JI9KPTXsYUWAmVFzQ== X-Google-Smtp-Source: ABdhPJzYACAhNeBki+5sxnyzl/I1D8hsXspGBbTtTNOTP9ryqsZwhQMC1+Cl+YsUD0Vcn6/Cm7DGttsgpUvEDzyH18I= X-Received: by 2002:a17:90a:d686:: with SMTP id x6mr573260pju.8.1632766774563; Mon, 27 Sep 2021 11:19:34 -0700 (PDT) MIME-Version: 1.0 References: <20210922183331.2455043-1-hch@lst.de> In-Reply-To: <20210922183331.2455043-1-hch@lst.de> From: Dan Williams Date: Mon, 27 Sep 2021 11:19:26 -0700 Message-ID: Subject: Re: fix a dax/block device attribute registration regression To: Christoph Hellwig Cc: Jens Axboe , Vishal Verma , Dave Jiang , Ira Weiny , linux-block@vger.kernel.org, Linux NVDIMM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Sep 22, 2021 at 11:34 AM Christoph Hellwig wrote: > > Hi Dan and Jens, > > this series fixed a regression in how the dax/write_cache attribute of the > pmem devices was registere. It does so by both fixing the API abuse in the > driver and (temporarily) the behavior change in the block layer that made > this API abuse not work anymore. I took patch1 into for-5.15/libnvdimm, patch2 into for-5.16/libnvdimm, and I'll leave patch3 for Jens.