From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32CE072 for ; Thu, 28 Oct 2021 00:20:52 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id nn3-20020a17090b38c300b001a03bb6c4ebso3342243pjb.1 for ; Wed, 27 Oct 2021 17:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=thFpqdlxLVjcGfDZPprDTzPo9iTzt5bk9dqhDCzY+u0=; b=Bp5byUxxNEOGWx1LiYKcSiES+UNWDp5D/cMWZdjtl33fGWM9mdrZIzgn/KeGW66w48 HLlosh7rVoB0KWLzJNIesUqmq7HyWnrZDWPZXtEInbmdYlimOId2CvHzX4NDal8E2jsZ NIOS1NWX2Og4zHktLs8Z73ffbx1VrB4tMgXBr+cAXsS3m4YEPwio+BMFFkGVGFDC70ho bg5uNNY9RzCmq9k8vu68K0vdjkKG8QMiqL+5O7IERSfZ90owTTf78IF/SLmMshLsv0gn algtrVwvBQo2E9HZ/GOG94ZMah+I89z5KkLKLbHkHit8m9WqG6x8NqMi8PHespkOBUpP 20MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=thFpqdlxLVjcGfDZPprDTzPo9iTzt5bk9dqhDCzY+u0=; b=OWyQrnXmox+7OgiRTzYwkAaYATkncKzKxjsGSbGtuTM7HXfqbG4bBR/ycB8gsK2fw2 wMYNMWJgtLfsSo80PPdnYulUimg3++Sk/9Fk8mY/ddTHUWbyCfLK8qrFaJs5Y1djJvYE JrxrI28y+kSrh1Pe21OsVKGqXdwe2rHNYSMHXAWyq27DW9sMSQbFUxAihXIra0Pu/4AP 1enmDFXS5e2EXdsej/paRE3xHdU/D0tpqRo1YN/hctVmGkiGvouO6AJlhJQDtm2SzTdA AeSwRtlOHs4QbJwIxmN0Z/xMfGzl4Of3Qu3pooeACFkvRU+oBAVSNt4XusUeNb6MCwU8 ZCEQ== X-Gm-Message-State: AOAM533FJwtuPFf2xgppAVpR3Si+DT9AAttCMrF9VVb8F5bmJEgDi+nL heiraoHtc6MB8hnEJvsVZ/yGH7uOrLNMPLkXx42qgg== X-Google-Smtp-Source: ABdhPJzDJ7G0OO0ihyu2DGXMx9nVI+vhdbJMigLbokXMw0jK9Xiqd7lMu/pWH/LSzIK1m8uglUBBOlGG+XCxTCXb4vQ= X-Received: by 2002:a17:90b:350f:: with SMTP id ls15mr942901pjb.220.1635380451659; Wed, 27 Oct 2021 17:20:51 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-8-hch@lst.de> <20211019154447.GL24282@magnolia> In-Reply-To: <20211019154447.GL24282@magnolia> From: Dan Williams Date: Wed, 27 Oct 2021 17:20:40 -0700 Message-ID: Subject: Re: [dm-devel] [PATCH 07/11] dax: remove dax_capable To: "Darrick J. Wong" Cc: Christoph Hellwig , Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny Content-Type: text/plain; charset="UTF-8" On Tue, Oct 19, 2021 at 8:45 AM Darrick J. Wong wrote: > > On Mon, Oct 18, 2021 at 06:40:50AM +0200, Christoph Hellwig wrote: > > Just open code the block size and dax_dev == NULL checks in the callers. > > > > Signed-off-by: Christoph Hellwig > > --- > > drivers/dax/super.c | 36 ------------------------------------ > > drivers/md/dm-table.c | 22 +++++++++++----------- > > drivers/md/dm.c | 21 --------------------- > > drivers/md/dm.h | 4 ---- > > drivers/nvdimm/pmem.c | 1 - > > drivers/s390/block/dcssblk.c | 1 - > > fs/erofs/super.c | 11 +++++++---- > > fs/ext2/super.c | 6 ++++-- > > fs/ext4/super.c | 9 ++++++--- > > fs/xfs/xfs_super.c | 21 ++++++++------------- > > include/linux/dax.h | 14 -------------- > > 11 files changed, 36 insertions(+), 110 deletions(-) > > [..] if (ext4_has_feature_inline_data(sb)) { > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > > index d07020a8eb9e3..163ceafbd8fd2 100644 > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c [..] > > + if (mp->m_super->s_blocksize != PAGE_SIZE) { > > + xfs_alert(mp, > > + "DAX not supported for blocksize. Turning off DAX.\n"); > > Newlines aren't needed at the end of extX_msg/xfs_alert format strings. Thanks Darrick, I fixed those up. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE5AC4332F for ; Thu, 28 Oct 2021 00:20:56 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FA2360F9B for ; Thu, 28 Oct 2021 00:20:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7FA2360F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 449E640112; Thu, 28 Oct 2021 00:20:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kK0zrb9NZyze; Thu, 28 Oct 2021 00:20:55 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id ABCBE4010E; Thu, 28 Oct 2021 00:20:54 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6E5C1C0019; Thu, 28 Oct 2021 00:20:54 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 161BFC000E for ; Thu, 28 Oct 2021 00:20:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E3EBD40112 for ; Thu, 28 Oct 2021 00:20:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ykhPJ5Gh2v5p for ; Thu, 28 Oct 2021 00:20:52 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2ED9A4010E for ; Thu, 28 Oct 2021 00:20:52 +0000 (UTC) Received: by mail-pl1-x62a.google.com with SMTP id f8so3165178plo.12 for ; Wed, 27 Oct 2021 17:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=thFpqdlxLVjcGfDZPprDTzPo9iTzt5bk9dqhDCzY+u0=; b=Bp5byUxxNEOGWx1LiYKcSiES+UNWDp5D/cMWZdjtl33fGWM9mdrZIzgn/KeGW66w48 HLlosh7rVoB0KWLzJNIesUqmq7HyWnrZDWPZXtEInbmdYlimOId2CvHzX4NDal8E2jsZ NIOS1NWX2Og4zHktLs8Z73ffbx1VrB4tMgXBr+cAXsS3m4YEPwio+BMFFkGVGFDC70ho bg5uNNY9RzCmq9k8vu68K0vdjkKG8QMiqL+5O7IERSfZ90owTTf78IF/SLmMshLsv0gn algtrVwvBQo2E9HZ/GOG94ZMah+I89z5KkLKLbHkHit8m9WqG6x8NqMi8PHespkOBUpP 20MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=thFpqdlxLVjcGfDZPprDTzPo9iTzt5bk9dqhDCzY+u0=; b=JgrBGKVBljUzkR9A+tTFzpCw60ojnFX6s9ClUxw2Ul8z2e37ITnnnYX9xDQzbok6mB gJ6UHhQUnEdPgRoXVU1l0nB381wEPPDuCYyq0lQP6r7ErxIpVnjoVwto9PYg21ItU2mB cr9fWTwHKevOkCWhz+p5E9OZIt7pIWEGv/QzJlEzVX9yOYjqh1gSqZ+jkRymCf+NqSug jxDGOMUmkP9Ps/BFD4biDIpHe97fKsLubE+WA/od7noFK6NOXXaOiakyADFATb+NiJ8/ bpT4OfmXcp+74r/AeDKdAihoYZkq+wfoiJoRKymTx0dlKJCN0WLV7FRmZIECJQS2gB9J YFEA== X-Gm-Message-State: AOAM533RS5GhPRJLcEycx6e3MRUMeANWG29z9BwakU2UrEoLHFqa4B6/ U4G8O8SxgsynNEM8rhrRH7egVLVHMukYcB7AbMdJtg== X-Google-Smtp-Source: ABdhPJzDJ7G0OO0ihyu2DGXMx9nVI+vhdbJMigLbokXMw0jK9Xiqd7lMu/pWH/LSzIK1m8uglUBBOlGG+XCxTCXb4vQ= X-Received: by 2002:a17:90b:350f:: with SMTP id ls15mr942901pjb.220.1635380451659; Wed, 27 Oct 2021 17:20:51 -0700 (PDT) MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-8-hch@lst.de> <20211019154447.GL24282@magnolia> In-Reply-To: <20211019154447.GL24282@magnolia> From: Dan Williams Date: Wed, 27 Oct 2021 17:20:40 -0700 Message-ID: Subject: Re: [dm-devel] [PATCH 07/11] dax: remove dax_capable To: "Darrick J. Wong" Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , Ira Weiny , virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , linux-erofs@lists.ozlabs.org, Christoph Hellwig X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Oct 19, 2021 at 8:45 AM Darrick J. Wong wrote: > > On Mon, Oct 18, 2021 at 06:40:50AM +0200, Christoph Hellwig wrote: > > Just open code the block size and dax_dev == NULL checks in the callers. > > > > Signed-off-by: Christoph Hellwig > > --- > > drivers/dax/super.c | 36 ------------------------------------ > > drivers/md/dm-table.c | 22 +++++++++++----------- > > drivers/md/dm.c | 21 --------------------- > > drivers/md/dm.h | 4 ---- > > drivers/nvdimm/pmem.c | 1 - > > drivers/s390/block/dcssblk.c | 1 - > > fs/erofs/super.c | 11 +++++++---- > > fs/ext2/super.c | 6 ++++-- > > fs/ext4/super.c | 9 ++++++--- > > fs/xfs/xfs_super.c | 21 ++++++++------------- > > include/linux/dax.h | 14 -------------- > > 11 files changed, 36 insertions(+), 110 deletions(-) > > [..] if (ext4_has_feature_inline_data(sb)) { > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > > index d07020a8eb9e3..163ceafbd8fd2 100644 > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c [..] > > + if (mp->m_super->s_blocksize != PAGE_SIZE) { > > + xfs_alert(mp, > > + "DAX not supported for blocksize. Turning off DAX.\n"); > > Newlines aren't needed at the end of extX_msg/xfs_alert format strings. Thanks Darrick, I fixed those up. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B296C433EF for ; Thu, 28 Oct 2021 00:21:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9ED4610C7 for ; Thu, 28 Oct 2021 00:21:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E9ED4610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HfmSF4N4Zz2yKN for ; Thu, 28 Oct 2021 11:21:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel-com.20210112.gappssmtp.com header.i=@intel-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=Bp5byUxx; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=2607:f8b0:4864:20::633; helo=mail-pl1-x633.google.com; envelope-from=dan.j.williams@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel-com.20210112.gappssmtp.com header.i=@intel-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=Bp5byUxx; dkim-atps=neutral Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HfmS84XyCz2xlC for ; Thu, 28 Oct 2021 11:20:56 +1100 (AEDT) Received: by mail-pl1-x633.google.com with SMTP id t21so3182920plr.6 for ; Wed, 27 Oct 2021 17:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=thFpqdlxLVjcGfDZPprDTzPo9iTzt5bk9dqhDCzY+u0=; b=Bp5byUxxNEOGWx1LiYKcSiES+UNWDp5D/cMWZdjtl33fGWM9mdrZIzgn/KeGW66w48 HLlosh7rVoB0KWLzJNIesUqmq7HyWnrZDWPZXtEInbmdYlimOId2CvHzX4NDal8E2jsZ NIOS1NWX2Og4zHktLs8Z73ffbx1VrB4tMgXBr+cAXsS3m4YEPwio+BMFFkGVGFDC70ho bg5uNNY9RzCmq9k8vu68K0vdjkKG8QMiqL+5O7IERSfZ90owTTf78IF/SLmMshLsv0gn algtrVwvBQo2E9HZ/GOG94ZMah+I89z5KkLKLbHkHit8m9WqG6x8NqMi8PHespkOBUpP 20MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=thFpqdlxLVjcGfDZPprDTzPo9iTzt5bk9dqhDCzY+u0=; b=IbOIpRv6lcJ0Smhi/ZmD3cKXiXQ2CpfSGnfP1w6CLnHpmsZilv+MtLy4FLdHaDj9GE DaZDsaCu0GLeT0VPsWv7tkhq0LzyE4PPnDr7Jc4IYrCfMxaLv0k4Lp/VcUIzf0xjuSi0 iB+d4mAwqq0Qb7RbEXdZwnIG1BkmQBMnvqL4wKufmwJd1Owp8EtVMTUnq7EpzgB+7KG7 vS2ZDvaQ/7/I9uyYzfrYQxr/dhC8isYtS1pn8E6XnbIjpTmFNuB/Xt0xQ+FDt3u6wrFi vSDeUu0Xo7vYia0bcZeTT0SnlFsb7hptu/Yb6YHKT8ArGXgjSzpCZKoRtxAM3tIhl7qT 1mwQ== X-Gm-Message-State: AOAM5337gx1zi39wJksxDMuryqR+Kg5zWaavQ/WrFwr665SosWuDiDst oUwHkE4iT8TCz01C3IsHY/EO7ZELqpYwkIkh27hujg== X-Google-Smtp-Source: ABdhPJzDJ7G0OO0ihyu2DGXMx9nVI+vhdbJMigLbokXMw0jK9Xiqd7lMu/pWH/LSzIK1m8uglUBBOlGG+XCxTCXb4vQ= X-Received: by 2002:a17:90b:350f:: with SMTP id ls15mr942901pjb.220.1635380451659; Wed, 27 Oct 2021 17:20:51 -0700 (PDT) MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-8-hch@lst.de> <20211019154447.GL24282@magnolia> In-Reply-To: <20211019154447.GL24282@magnolia> From: Dan Williams Date: Wed, 27 Oct 2021 17:20:40 -0700 Message-ID: Subject: Re: [dm-devel] [PATCH 07/11] dax: remove dax_capable To: "Darrick J. Wong" Content-Type: text/plain; charset="UTF-8" X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , Ira Weiny , virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , linux-erofs@lists.ozlabs.org, Christoph Hellwig Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Tue, Oct 19, 2021 at 8:45 AM Darrick J. Wong wrote: > > On Mon, Oct 18, 2021 at 06:40:50AM +0200, Christoph Hellwig wrote: > > Just open code the block size and dax_dev == NULL checks in the callers. > > > > Signed-off-by: Christoph Hellwig > > --- > > drivers/dax/super.c | 36 ------------------------------------ > > drivers/md/dm-table.c | 22 +++++++++++----------- > > drivers/md/dm.c | 21 --------------------- > > drivers/md/dm.h | 4 ---- > > drivers/nvdimm/pmem.c | 1 - > > drivers/s390/block/dcssblk.c | 1 - > > fs/erofs/super.c | 11 +++++++---- > > fs/ext2/super.c | 6 ++++-- > > fs/ext4/super.c | 9 ++++++--- > > fs/xfs/xfs_super.c | 21 ++++++++------------- > > include/linux/dax.h | 14 -------------- > > 11 files changed, 36 insertions(+), 110 deletions(-) > > [..] if (ext4_has_feature_inline_data(sb)) { > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > > index d07020a8eb9e3..163ceafbd8fd2 100644 > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c [..] > > + if (mp->m_super->s_blocksize != PAGE_SIZE) { > > + xfs_alert(mp, > > + "DAX not supported for blocksize. Turning off DAX.\n"); > > Newlines aren't needed at the end of extX_msg/xfs_alert format strings. Thanks Darrick, I fixed those up. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41F86C433EF for ; Thu, 28 Oct 2021 00:21:06 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1A1B610C7 for ; Thu, 28 Oct 2021 00:21:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C1A1B610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-WeF-_RK4NRWm8fGIt5es6g-1; Wed, 27 Oct 2021 20:21:03 -0400 X-MC-Unique: WeF-_RK4NRWm8fGIt5es6g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B76011808304; Thu, 28 Oct 2021 00:20:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9DACB100EA05; Thu, 28 Oct 2021 00:20:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B00A81806D03; Thu, 28 Oct 2021 00:20:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19S0Ks0E021600 for ; Wed, 27 Oct 2021 20:20:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6F21740CFD10; Thu, 28 Oct 2021 00:20:54 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A19440CFD0C for ; Thu, 28 Oct 2021 00:20:54 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5032A8007B1 for ; Thu, 28 Oct 2021 00:20:54 +0000 (UTC) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-Cl0D3mqeM0eU7FenALtTNw-1; Wed, 27 Oct 2021 20:20:52 -0400 X-MC-Unique: Cl0D3mqeM0eU7FenALtTNw-1 Received: by mail-pl1-f170.google.com with SMTP id i5so3194350pla.5 for ; Wed, 27 Oct 2021 17:20:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=thFpqdlxLVjcGfDZPprDTzPo9iTzt5bk9dqhDCzY+u0=; b=olgZ3rgBqadZCmnZytrvrCDu+qG1uFEEIjhPuGZ1gFysDcpi5xNKXfOC0uG0MDSbAA vYAUsVH3uQ+Yn6eVeqYspQCOQ6E7CkTa8AdSOFHBMf6GrLDIbUiHOwcH8odKdMWzOJ6q WHXUpfAzP3waS4W1xYL+qCDsDhg0gmpVO8LItX8rnq8tFHATHGsQUoxTeAhRp36FA6Ha Bm1mPoGAKqFGCDaas/ef2i5L8jF6IcQUOXfbt5/IP+W0O5o1nzxsjRtwTN1jn0EQhp6E mtqFbt2VcSIq7VGgZafnSWSkvWS6Nr6EpF5MhdEc7nBw7iLSq7kG8JGEUpKsxoFDVLVl Vq8Q== X-Gm-Message-State: AOAM533h7kqKf7X9EfKGSRNEQtFrHuzs0qlruZ/PLTg00+5aZ/fDSfu9 BYQ1yU5Q5GDUifxeVf8xF36HsGaLb3WkMzrQuvKLiw== X-Google-Smtp-Source: ABdhPJzDJ7G0OO0ihyu2DGXMx9nVI+vhdbJMigLbokXMw0jK9Xiqd7lMu/pWH/LSzIK1m8uglUBBOlGG+XCxTCXb4vQ= X-Received: by 2002:a17:90b:350f:: with SMTP id ls15mr942901pjb.220.1635380451659; Wed, 27 Oct 2021 17:20:51 -0700 (PDT) MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-8-hch@lst.de> <20211019154447.GL24282@magnolia> In-Reply-To: <20211019154447.GL24282@magnolia> From: Dan Williams Date: Wed, 27 Oct 2021 17:20:40 -0700 Message-ID: To: "Darrick J. Wong" X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: dm-devel@redhat.com Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , Ira Weiny , virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , linux-erofs@lists.ozlabs.org, Christoph Hellwig Subject: Re: [dm-devel] [PATCH 07/11] dax: remove dax_capable X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Oct 19, 2021 at 8:45 AM Darrick J. Wong wrote: > > On Mon, Oct 18, 2021 at 06:40:50AM +0200, Christoph Hellwig wrote: > > Just open code the block size and dax_dev == NULL checks in the callers. > > > > Signed-off-by: Christoph Hellwig > > --- > > drivers/dax/super.c | 36 ------------------------------------ > > drivers/md/dm-table.c | 22 +++++++++++----------- > > drivers/md/dm.c | 21 --------------------- > > drivers/md/dm.h | 4 ---- > > drivers/nvdimm/pmem.c | 1 - > > drivers/s390/block/dcssblk.c | 1 - > > fs/erofs/super.c | 11 +++++++---- > > fs/ext2/super.c | 6 ++++-- > > fs/ext4/super.c | 9 ++++++--- > > fs/xfs/xfs_super.c | 21 ++++++++------------- > > include/linux/dax.h | 14 -------------- > > 11 files changed, 36 insertions(+), 110 deletions(-) > > [..] if (ext4_has_feature_inline_data(sb)) { > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > > index d07020a8eb9e3..163ceafbd8fd2 100644 > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c [..] > > + if (mp->m_super->s_blocksize != PAGE_SIZE) { > > + xfs_alert(mp, > > + "DAX not supported for blocksize. Turning off DAX.\n"); > > Newlines aren't needed at the end of extX_msg/xfs_alert format strings. Thanks Darrick, I fixed those up. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel