From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03FBA2C80 for ; Thu, 14 Oct 2021 16:35:47 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id kk10so5183961pjb.1 for ; Thu, 14 Oct 2021 09:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GQiBdpe7qbcqSGrUqozD2QtPj9Zro4pYZ3W/Jb6TO/g=; b=ZNJGoGdx+8OHFFkt/GPeDtg2CWAGRYXW+GZJgm0XiRmkOHHRHTYjwKEok5+3suoYN2 +8cP986JoPMdYMsaS3TtKwfjxSghX9ZKiJqXCO7tPDpyS87zJaqsn0RbiGlcsLvZk5vM M09BfFe0EhVJ3a8WSM4N8P0Z2lnY6Ox6zQ5+ubceZSTOgqpxJGJKaSIrdlzkxwuX9JvE eW5h9QGaLenlUw7qOmMdkoIuSnfRf5QAAy938cEWKuLpCGyM+cmwm4kOd+UzULTyuE1b ZUJ0pwOMobAprNjZ01oOS4RD1y2Fli1AR5SmebNiLLVV1navHuMIah+/KO+BXjAU8x5D yUGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GQiBdpe7qbcqSGrUqozD2QtPj9Zro4pYZ3W/Jb6TO/g=; b=4swGTGOeOsj3gIMltt17envKhf5UwgUIUI0mbopOrpScv8PiZAapHAGvSE2lCZ/XjE tPxUJ7VJNQCqePNyEITpEaYhoyvTffnBwNXSDnnLNsl3H1FUBgwvAPcZFrxdBxHmfCzw 1weRSyK6PV8fe/LEq2ybJMCNwbH7zTh7Dh3YHVP9XR+UNPU46S382WX9nQ7Oeeex7v4a QYhIoDHc2LehNFh+r9mV+CjWchgpuPnHYLrvkSXTxQNFA6vUdPf53Fp11rf3AAnDYvIv Z7+xrJZhrscqyw/ycw4SllWiprWrK7Eu4kaDt66oPSfq40cHrzCMO00bq3B+vjmP/wJt HFlw== X-Gm-Message-State: AOAM531dofWTZJ6nVVxkhKj/rhW+duRiwuuEdhq70v3ok8iy/CooY0aL m0KFQ8joX9vFgtU2Q0PE8Px3bj+hc7gK0LJyHXB3Sg== X-Google-Smtp-Source: ABdhPJycN/CudUZAYRPO2n8r4sg/sohuVKEXkwqGQ9RYUO7njtY7K8PmBYgAUFm2O12cyEt9ABb0vuw38v44r4g4YUk= X-Received: by 2002:a17:90a:a085:: with SMTP id r5mr21432231pjp.8.1634229347397; Thu, 14 Oct 2021 09:35:47 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211007082139.3088615-1-vishal.l.verma@intel.com> <20211007082139.3088615-9-vishal.l.verma@intel.com> In-Reply-To: <20211007082139.3088615-9-vishal.l.verma@intel.com> From: Dan Williams Date: Thu, 14 Oct 2021 09:35:37 -0700 Message-ID: Subject: Re: [ndctl PATCH v4 08/17] libcxl: add support for the 'GET_LSA' command To: Vishal Verma Cc: linux-cxl@vger.kernel.org, Ben Widawsky , Linux NVDIMM Content-Type: text/plain; charset="UTF-8" On Thu, Oct 7, 2021 at 1:22 AM Vishal Verma wrote: > > Add a command allocator and accessor APIs for the 'GET_LSA' mailbox > command. > > Cc: Ben Widawsky > Cc: Dan Williams > Signed-off-by: Vishal Verma > --- > cxl/lib/private.h | 5 +++++ > cxl/lib/libcxl.c | 36 ++++++++++++++++++++++++++++++++++++ > cxl/libcxl.h | 7 +++---- > cxl/lib/libcxl.sym | 4 ++-- > 4 files changed, 46 insertions(+), 6 deletions(-) > > diff --git a/cxl/lib/private.h b/cxl/lib/private.h > index f76b518..9c6317b 100644 > --- a/cxl/lib/private.h > +++ b/cxl/lib/private.h > @@ -73,6 +73,11 @@ struct cxl_cmd_identify { > u8 qos_telemetry_caps; > } __attribute__((packed)); > > +struct cxl_cmd_get_lsa_in { > + le32 offset; > + le32 length; > +} __attribute__((packed)); > + > struct cxl_cmd_get_health_info { > u8 health_status; > u8 media_status; > diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c > index 413be9c..33cc462 100644 > --- a/cxl/lib/libcxl.c > +++ b/cxl/lib/libcxl.c > @@ -1028,6 +1028,42 @@ CXL_EXPORT struct cxl_cmd *cxl_cmd_new_raw(struct cxl_memdev *memdev, > return cmd; > } > > +CXL_EXPORT struct cxl_cmd *cxl_cmd_new_read_label(struct cxl_memdev *memdev, > + unsigned int offset, unsigned int length) > +{ > + struct cxl_cmd_get_lsa_in *get_lsa; > + struct cxl_cmd *cmd; > + > + cmd = cxl_cmd_new_generic(memdev, CXL_MEM_COMMAND_ID_GET_LSA); > + if (!cmd) > + return NULL; > + > + get_lsa = (void *)cmd->send_cmd->in.payload; Any reason that @payload is not already a 'void *' to avoid this casting? Other than that this looks good to me. You can add: Reviewed-by: Dan Williams