From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B29C4727E for ; Sat, 26 Sep 2020 03:31:42 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FF1A21741 for ; Sat, 26 Sep 2020 03:31:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="nFM9EXLs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FF1A21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C7D0914E59565; Fri, 25 Sep 2020 20:31:40 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::643; helo=mail-ej1-x643.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 747B214DF662F for ; Fri, 25 Sep 2020 20:31:38 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id nw23so1263964ejb.4 for ; Fri, 25 Sep 2020 20:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UI5cEN8K/GeU1uj0Hlr3P0QJH4xnq6J/e8uw5E+CELg=; b=nFM9EXLswqbb5477o4UUgt06gbHZd30tqKoruqN9TU7ki2iygmPrxb7yud48jxEgZq AMdDChWJGTw00YcdVmLrbNsz96hgAYy9rLT8Q0eewH1VILl3IBRfLrHEAuRIrjY4TwNO a/fZ4xfdXd7wgLUEhzggKOZEVmSqrVywkt7nRGs7sNL6j0nuJQhoK00IBAhEs2IYCNU7 RAPowAucxxNYdJYteLM9uVq9Y5T/f7buOcPqzEhhqz7OSigsqGF95NI1/MOQ6bjw21RE eIrb7wntjMtTIXAMQoss9yw159RS/dEAB3wDiNdJgcqObuKazZObmWqT2gO5VJIlKVmY wEtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UI5cEN8K/GeU1uj0Hlr3P0QJH4xnq6J/e8uw5E+CELg=; b=udB/AO+t6ORA72L0EGy1bFpboWlAiKrVyIjovWL0yLVkWjad8iSvNkG115LVZ2BHDN 87lKPczshAardeCsx+5sM25UianIUyf3oMB/D4JXK6o0dI1mK+ndRu+MzW+wLeKOQcCV K5NzOdkYLYizzWOtBcJ3S69RmbWC8mGSt+R07NNwgeR01TaUQaMkQumPdka2DgUeOJ8+ FE+pStNhHvAjMVdB4ej4Nifyfe0gjXEqD+shA3ku8JM9PFs1Ud5A7DrpFMujLMFJcla1 yabbAYGHDBY0uzAWLrtZXxYr/spPQOK8bMoVorzspZFLfMA8Nzp4oXsO6ZjSoPvmGzVo m47g== X-Gm-Message-State: AOAM533eThBXpVp8PY6lAoEDJgTKsakG4vt0Im4r5m7Cmr+j/quMmiMU 3j5ETAN3i3ozSgLydZZ7R8xUSEay3u3jyxL6cwy7Mg== X-Google-Smtp-Source: ABdhPJzT9T905L59sMxHvdd3yvvw2e/dtiHXcaPuK+9fYnGGItRqKC2gQWw5Zi1v0zAPXBfy/TsQ6vOApAyCmQ7bvxA= X-Received: by 2002:a17:906:d7ab:: with SMTP id pk11mr5686686ejb.472.1601091096174; Fri, 25 Sep 2020 20:31:36 -0700 (PDT) MIME-Version: 1.0 References: <160106109960.30709.7379926726669669398.stgit@dwillia2-desk3.amr.corp.intel.com> <160106118486.30709.13012322227204800596.stgit@dwillia2-desk3.amr.corp.intel.com> <20200925192234.33ae92b75012c1f2bdd974b8@linux-foundation.org> In-Reply-To: <20200925192234.33ae92b75012c1f2bdd974b8@linux-foundation.org> From: Dan Williams Date: Fri, 25 Sep 2020 20:31:24 -0700 Message-ID: Subject: Re: [PATCH v5 15/17] device-dax: add an 'align' attribute To: Andrew Morton Message-ID-Hash: BAU4SVOQNJTL4BQDZRVPYY2WXIWIDNHH X-Message-ID-Hash: BAU4SVOQNJTL4BQDZRVPYY2WXIWIDNHH X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Joao Martins , Dave Hansen , Linux MM , linux-nvdimm , Linux Kernel Mailing List X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Sep 25, 2020 at 7:22 PM Andrew Morton wrote: > > On Fri, 25 Sep 2020 12:13:04 -0700 Dan Williams wrote: > > > Introduce a device align attribute. While doing so, rename the region > > align attribute to be more explicitly named as so, but keep it named as > > @align to retain the API for tools like daxctl. > > > > Changes on align may not always be valid, when say certain mappings were > > created with 2M and then we switch to 1G. So, we validate all ranges > > against the new value being attempted, post resizing. > > > > Link: https://lkml.kernel.org/r/159643105944.4062302.3131761052969132784.stgit@dwillia2-desk3.amr.corp.intel.com > > Link: https://lore.kernel.org/r/20200716172913.19658-3-joao.m.martins@oracle.com > > Signed-off-by: Joao Martins > > Signed-off-by: Dan Williams > > > > The signoff chain implies that this was From:Joao. Please clarify? Yes, sorry, my script to squash the fix rewrote the author and I failed to catch it. This indeed should be: From: Joao Martins I double-checked, and it looks like this was the only one in the series with that problem. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B68C4727C for ; Sat, 26 Sep 2020 03:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD0EC218AC for ; Sat, 26 Sep 2020 03:33:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="nFM9EXLs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729992AbgIZDbi (ORCPT ); Fri, 25 Sep 2020 23:31:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729225AbgIZDbh (ORCPT ); Fri, 25 Sep 2020 23:31:37 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F502C0613CE for ; Fri, 25 Sep 2020 20:31:37 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id u21so1283248eja.2 for ; Fri, 25 Sep 2020 20:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UI5cEN8K/GeU1uj0Hlr3P0QJH4xnq6J/e8uw5E+CELg=; b=nFM9EXLswqbb5477o4UUgt06gbHZd30tqKoruqN9TU7ki2iygmPrxb7yud48jxEgZq AMdDChWJGTw00YcdVmLrbNsz96hgAYy9rLT8Q0eewH1VILl3IBRfLrHEAuRIrjY4TwNO a/fZ4xfdXd7wgLUEhzggKOZEVmSqrVywkt7nRGs7sNL6j0nuJQhoK00IBAhEs2IYCNU7 RAPowAucxxNYdJYteLM9uVq9Y5T/f7buOcPqzEhhqz7OSigsqGF95NI1/MOQ6bjw21RE eIrb7wntjMtTIXAMQoss9yw159RS/dEAB3wDiNdJgcqObuKazZObmWqT2gO5VJIlKVmY wEtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UI5cEN8K/GeU1uj0Hlr3P0QJH4xnq6J/e8uw5E+CELg=; b=Tte/c01XQg+8pV2BnCacBzAjFzaY54xnZVqUB9ZilRaAkbCkh+YjuKcbKhHCJFuSEi YFCMnuK0SXLsS2IfssJDIPom5KAT8YNzyuLSHqq+Lxw5hAJYIX/ZxWIuFM2CUKTx7EUs HatJC7mtcNrtW2lb+NJUbkxjRW3V3BVGLciqa9B6Aimw7liHBcWHOZPgxYT/AmnUXjrO zjaOxV4oqNmxFVhqdy5QANTYapHwtc5wLFWZGx6iA0azy7IqLXQwBUTk0tX+0hpJm6mw ORCiyCmqlLquWbeMDiuaigPbRrH6+qeDoX6Non1uijC6zNTHCa9HmpEZnufKZq4Gbtr/ 8ctA== X-Gm-Message-State: AOAM531MTgjW5GYAy0G6fAPXEciPw2nmJKkVdNztb5E9kZ9dlJPLhAPJ kQAgbMERdxmEO1hOrvM2D5YBP7PtMK5sns1/qUY2a7UF5s7VNA== X-Google-Smtp-Source: ABdhPJzT9T905L59sMxHvdd3yvvw2e/dtiHXcaPuK+9fYnGGItRqKC2gQWw5Zi1v0zAPXBfy/TsQ6vOApAyCmQ7bvxA= X-Received: by 2002:a17:906:d7ab:: with SMTP id pk11mr5686686ejb.472.1601091096174; Fri, 25 Sep 2020 20:31:36 -0700 (PDT) MIME-Version: 1.0 References: <160106109960.30709.7379926726669669398.stgit@dwillia2-desk3.amr.corp.intel.com> <160106118486.30709.13012322227204800596.stgit@dwillia2-desk3.amr.corp.intel.com> <20200925192234.33ae92b75012c1f2bdd974b8@linux-foundation.org> In-Reply-To: <20200925192234.33ae92b75012c1f2bdd974b8@linux-foundation.org> From: Dan Williams Date: Fri, 25 Sep 2020 20:31:24 -0700 Message-ID: Subject: Re: [PATCH v5 15/17] device-dax: add an 'align' attribute To: Andrew Morton Cc: Joao Martins , Vishal L Verma , Dave Hansen , Linux MM , linux-nvdimm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 7:22 PM Andrew Morton wrote: > > On Fri, 25 Sep 2020 12:13:04 -0700 Dan Williams wrote: > > > Introduce a device align attribute. While doing so, rename the region > > align attribute to be more explicitly named as so, but keep it named as > > @align to retain the API for tools like daxctl. > > > > Changes on align may not always be valid, when say certain mappings were > > created with 2M and then we switch to 1G. So, we validate all ranges > > against the new value being attempted, post resizing. > > > > Link: https://lkml.kernel.org/r/159643105944.4062302.3131761052969132784.stgit@dwillia2-desk3.amr.corp.intel.com > > Link: https://lore.kernel.org/r/20200716172913.19658-3-joao.m.martins@oracle.com > > Signed-off-by: Joao Martins > > Signed-off-by: Dan Williams > > > > The signoff chain implies that this was From:Joao. Please clarify? Yes, sorry, my script to squash the fix rewrote the author and I failed to catch it. This indeed should be: From: Joao Martins I double-checked, and it looks like this was the only one in the series with that problem. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD42C4727C for ; Sat, 26 Sep 2020 03:31:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC40420838 for ; Sat, 26 Sep 2020 03:31:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="nFM9EXLs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC40420838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CBB456B005C; Fri, 25 Sep 2020 23:31:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6CE76B0062; Fri, 25 Sep 2020 23:31:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5AE86B0068; Fri, 25 Sep 2020 23:31:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 9B6D36B005C for ; Fri, 25 Sep 2020 23:31:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4DAC68249980 for ; Sat, 26 Sep 2020 03:31:39 +0000 (UTC) X-FDA: 77303787918.03.straw42_3f15bd12716d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 276BF28A4E8 for ; Sat, 26 Sep 2020 03:31:39 +0000 (UTC) X-HE-Tag: straw42_3f15bd12716d X-Filterd-Recvd-Size: 4261 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Sat, 26 Sep 2020 03:31:37 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id i26so1195085ejb.12 for ; Fri, 25 Sep 2020 20:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UI5cEN8K/GeU1uj0Hlr3P0QJH4xnq6J/e8uw5E+CELg=; b=nFM9EXLswqbb5477o4UUgt06gbHZd30tqKoruqN9TU7ki2iygmPrxb7yud48jxEgZq AMdDChWJGTw00YcdVmLrbNsz96hgAYy9rLT8Q0eewH1VILl3IBRfLrHEAuRIrjY4TwNO a/fZ4xfdXd7wgLUEhzggKOZEVmSqrVywkt7nRGs7sNL6j0nuJQhoK00IBAhEs2IYCNU7 RAPowAucxxNYdJYteLM9uVq9Y5T/f7buOcPqzEhhqz7OSigsqGF95NI1/MOQ6bjw21RE eIrb7wntjMtTIXAMQoss9yw159RS/dEAB3wDiNdJgcqObuKazZObmWqT2gO5VJIlKVmY wEtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UI5cEN8K/GeU1uj0Hlr3P0QJH4xnq6J/e8uw5E+CELg=; b=UW7x9wKc4ujKvFeq+YNfOu5fbBPrj/tLS6piy1Kh7YEDy83911BG9VDHpFwuM8o4fA GEnPZtfpeZiR8mIfcm5YRL5eNVTyN0zBiQu1vWQqqRZSeeF7Tz/R3rhjtaVlld6oqP10 jTmoE3xb5rGkhkTQ+QAYeCZaoDqvYq/MqD3Y30DWhGwg1w/PZTprnUvLNUSwbwFIdwpb /b3Bt7itZXfKC4DbOOGvEndFdKYj4hezXRf8sMYaFvzCbpz8ULfczrmtHlUQHatRJoyJ isl1NllVeNq9/n3mnamSvMqI5WPyOiPtj1J7JkSzP1UhuXKP0Us42Bs0mOqs+Ru1mrzM BgXg== X-Gm-Message-State: AOAM533ZRS5U/XNMILjmZcl9ZnyrvBqZEvCaDyCwZmARBsWRXgHVOD1E I3e87LffUF2qSyAh/4ci3qs+w2Qxxtb+UlyVUUamtw== X-Google-Smtp-Source: ABdhPJzT9T905L59sMxHvdd3yvvw2e/dtiHXcaPuK+9fYnGGItRqKC2gQWw5Zi1v0zAPXBfy/TsQ6vOApAyCmQ7bvxA= X-Received: by 2002:a17:906:d7ab:: with SMTP id pk11mr5686686ejb.472.1601091096174; Fri, 25 Sep 2020 20:31:36 -0700 (PDT) MIME-Version: 1.0 References: <160106109960.30709.7379926726669669398.stgit@dwillia2-desk3.amr.corp.intel.com> <160106118486.30709.13012322227204800596.stgit@dwillia2-desk3.amr.corp.intel.com> <20200925192234.33ae92b75012c1f2bdd974b8@linux-foundation.org> In-Reply-To: <20200925192234.33ae92b75012c1f2bdd974b8@linux-foundation.org> From: Dan Williams Date: Fri, 25 Sep 2020 20:31:24 -0700 Message-ID: Subject: Re: [PATCH v5 15/17] device-dax: add an 'align' attribute To: Andrew Morton Cc: Joao Martins , Vishal L Verma , Dave Hansen , Linux MM , linux-nvdimm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 25, 2020 at 7:22 PM Andrew Morton wrote: > > On Fri, 25 Sep 2020 12:13:04 -0700 Dan Williams wrote: > > > Introduce a device align attribute. While doing so, rename the region > > align attribute to be more explicitly named as so, but keep it named as > > @align to retain the API for tools like daxctl. > > > > Changes on align may not always be valid, when say certain mappings were > > created with 2M and then we switch to 1G. So, we validate all ranges > > against the new value being attempted, post resizing. > > > > Link: https://lkml.kernel.org/r/159643105944.4062302.3131761052969132784.stgit@dwillia2-desk3.amr.corp.intel.com > > Link: https://lore.kernel.org/r/20200716172913.19658-3-joao.m.martins@oracle.com > > Signed-off-by: Joao Martins > > Signed-off-by: Dan Williams > > > > The signoff chain implies that this was From:Joao. Please clarify? Yes, sorry, my script to squash the fix rewrote the author and I failed to catch it. This indeed should be: From: Joao Martins I double-checked, and it looks like this was the only one in the series with that problem.