From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EEDB211D9155 for ; Wed, 3 Apr 2019 11:31:13 -0700 (PDT) Received: by mail-oi1-x244.google.com with SMTP id v7so14416602oie.8 for ; Wed, 03 Apr 2019 11:31:13 -0700 (PDT) MIME-Version: 1.0 References: <20190402142816.GA13084@linux.ibm.com> <20190402142933.14547-1-paulmck@linux.ibm.com> In-Reply-To: <20190402142933.14547-1-paulmck@linux.ibm.com> From: Dan Williams Date: Wed, 3 Apr 2019 11:31:01 -0700 Message-ID: Subject: Re: [PATCH RFC tip/core/rcu 1/4] dax/super: Dynamically allocate dax_srcu List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Paul E. McKenney" Cc: David Howells , Thomas Gleixner , linux-nvdimm , Peter Zijlstra , fweisbec@gmail.com, jiangshanlai@gmail.com, Linux Kernel Mailing List , Steven Rostedt , Josh Triplett , rcu@vger.kernel.org, Eric Dumazet , Mathieu Desnoyers , Oleg Nesterov , dipankar@in.ibm.com, joel@joelfernandes.org, Andrew Morton , Ingo Molnar , Tejun Heo List-ID: On Tue, Apr 2, 2019 at 7:29 AM Paul E. McKenney wrote: > > Having DEFINE_SRCU() or DEFINE_STATIC_SRCU() in a loadable module > requires that the size of the reserved region be increased, which is > not something we really want to be doing. This commit therefore removes > the DEFINE_STATIC_SRCU() from drivers/dax/super.c in favor of defining > dax_srcu as a simple srcu_struct, initializing it in dax_core_init(), > and cleaning it up in dax_core_exit(). > > Reported-by: kbuild test robot > Signed-off-by: Paul E. McKenney Looks good to me. Reviewed-by: Dan Williams _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57CFAC4360F for ; Wed, 3 Apr 2019 18:31:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 162472133D for ; Wed, 3 Apr 2019 18:31:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="K82tE2mG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726770AbfDCSbN (ORCPT ); Wed, 3 Apr 2019 14:31:13 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:42911 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbfDCSbN (ORCPT ); Wed, 3 Apr 2019 14:31:13 -0400 Received: by mail-oi1-f193.google.com with SMTP id w139so14410492oie.9 for ; Wed, 03 Apr 2019 11:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qGyOEoxy0h99gsusBdQVGr14JAL4WdfFO3oAZW2FLVs=; b=K82tE2mGbkfbDv/ZMwdn2vS34AGRa8573cH/nOfXtricK6qHk2WruUr1jEHi/JPnXV vWxTeXlW66+TJ1NbEvo1lrtb3vYU+bqXNe0Qrx5Uoq3sc4YDHNNtCOvOOf4+FqSjdFsa pOoZQ5neek+VAx7fOLXhKPMlurb9qAEtyn2RqpAVr24wGx0Fs6eFUjEk0mCydcuxhOBY EqtaZWO6vXg4UVn3DbNsTTqexizZMU2QIiAKrGzBH6wD1q8cKP6AAbpjs5TKrWrfyOa1 r4KWwti4xfuXWzoHYsHPBLF7WwXni4OkLXXBxHfwBXnkuIQ3a1+CB/Nc+Q0xbiuDymGR CLJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qGyOEoxy0h99gsusBdQVGr14JAL4WdfFO3oAZW2FLVs=; b=KYX+V6BJu844fsVBLu85aFJdKOsNshu3UTr7p0B+kU5rOB14Ta9hcqKWAjIvpRrjct eTDjIjVi1qOdZb0jDc1vVVaxMircdcAAKrYcK0/yG3JASlzXJv1tiyhBl6jRfGqm9+R+ u3e66615Z5Fr7l2EKqhoaF7zWdBDiqox7+25wAh7pNBU/8CngIC3UPhG45wJsxwue5Oi zqRsuBTRTNn24UFClIph6YVXV2Oc6UeZhUZbt7Z43rC71VDqJuCKNfSgEnz0C6WmLeSw r4GVoHS6PnhBEkJMqD3Ynun6Vrwy6+4k6e8wErEZf5L1i3JRRmgb3o08Jh0bTQ6cEytw tonQ== X-Gm-Message-State: APjAAAVwTl1ZsE3RkO42J7BTme97HzUmTQV3XkpQbsjHOh8ZVA4WbV4c UlFk3/cKYzyxC3xgevJ2sLPT2+ZOsZLrqrgZBfRvAw== X-Google-Smtp-Source: APXvYqy5zjcoJ2avp8UeuvRXQCAhzPmvu0BeDnN5WLnF6of2XTu8J+cpcrq0tNVk3mzxziWnqwlUeLwz8FrjyibkgAs= X-Received: by 2002:aca:f581:: with SMTP id t123mr660054oih.0.1554316272610; Wed, 03 Apr 2019 11:31:12 -0700 (PDT) MIME-Version: 1.0 References: <20190402142816.GA13084@linux.ibm.com> <20190402142933.14547-1-paulmck@linux.ibm.com> In-Reply-To: <20190402142933.14547-1-paulmck@linux.ibm.com> From: Dan Williams Date: Wed, 3 Apr 2019 11:31:01 -0700 Message-ID: Subject: Re: [PATCH RFC tip/core/rcu 1/4] dax/super: Dynamically allocate dax_srcu To: "Paul E. McKenney" Cc: rcu@vger.kernel.org, Linux Kernel Mailing List , Ingo Molnar , jiangshanlai@gmail.com, dipankar@in.ibm.com, Andrew Morton , Mathieu Desnoyers , Josh Triplett , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , David Howells , Eric Dumazet , fweisbec@gmail.com, Oleg Nesterov , joel@joelfernandes.org, Vishal Verma , Keith Busch , Dave Jiang , Tejun Heo , linux-nvdimm Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 2, 2019 at 7:29 AM Paul E. McKenney wrote: > > Having DEFINE_SRCU() or DEFINE_STATIC_SRCU() in a loadable module > requires that the size of the reserved region be increased, which is > not something we really want to be doing. This commit therefore removes > the DEFINE_STATIC_SRCU() from drivers/dax/super.c in favor of defining > dax_srcu as a simple srcu_struct, initializing it in dax_core_init(), > and cleaning it up in dax_core_exit(). > > Reported-by: kbuild test robot > Signed-off-by: Paul E. McKenney Looks good to me. Reviewed-by: Dan Williams