All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: tools@linux.kernel.org
Subject: b4 am partial-re-roll vs reviewed-by
Date: Tue, 21 Sep 2021 14:04:35 -0700	[thread overview]
Message-ID: <CAPcyv4gS6St_EuWWQwVAF-1XbMQmxLFHU8sVKPO3xiBiTS-GMQ@mail.gmail.com> (raw)

Hi,

I notice that:

b4 am 163225205828.3038145.6831131648369404859.stgit@dwillia2-desk3.amr.corp.intel.com

...warns about a case where I manually replied with a reviewed-by tag
of someone else which is a great feature.

The bit of magic I was also hoping for it to notice is that [PATCH v4
17/21] picked up a reviewed-by with a note that said effectively "if
you fix this, then apply my reviewed-by":

https://lore.kernel.org/r/20210910105313.00006408@Huawei.com

I then neglected to manually add that tag when sending v5:

https://lore.kernel.org/r/163164680798.2831381.838684634806668012.stgit@dwillia2-desk3.amr.corp.intel.com

It would increase b4's already high levels of usefulness if similar to
the -S warning there was a warning of "vX picked up a reviewed-by,
carry that forward by re-running with <option foo>". Sometimes it's an
oversight to miss a previous review tag, and sometimes it is
deliberate that the submitter believes that previous review is
invalidated by the new submission.

No worries if this does not cleanly fit into the b4 series assembly engine.

                 reply	other threads:[~2021-09-21 21:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4gS6St_EuWWQwVAF-1XbMQmxLFHU8sVKPO3xiBiTS-GMQ@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.