From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5033FC43331 for ; Wed, 13 Nov 2019 01:26:23 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 093E6222CE for ; Wed, 13 Nov 2019 01:26:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="doPKvu1g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 093E6222CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from new-ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 34940100DC41F; Tue, 12 Nov 2019 17:28:05 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::243; helo=mail-oi1-x243.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2DFDA100DC41C for ; Tue, 12 Nov 2019 17:28:01 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id 22so271121oip.7 for ; Tue, 12 Nov 2019 17:26:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d0MB/SSMpogQj4Fcl4IC+pxpUwq0gyFs7A/amSO1m4Y=; b=doPKvu1gZNpcuqwOmCORE1idu0dAD0+ZV4ybOrLIR70xlU/Ld+eQ7FHZDb7gjt5NSd uISrpZzkm2+LjEtMuDDLkKlB7O2X18chqvg8BtH28z3+X12qZdHaQHtuQushixLAzJg7 t983ph1Tvk4oDHv2V/w4UkB4XE4huboN+gnSOdLM32WdvXQhALzflaDwdfqPOs4q1FDx KHTaYVXq5pc5+JMyRNtd4GCn8D2IdH6SpPmHk2S+B8emEa5gIX6d6TAhG7Nj1WNaSqx/ ZxFw0h3C4SOkt6WE3U5FxbkudR4vKN1cP2Z3YTQ4vcdCMRuvF/2j35Cwczb+P1sv6s+B KzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d0MB/SSMpogQj4Fcl4IC+pxpUwq0gyFs7A/amSO1m4Y=; b=ZrXpYy4Pj9bg3DhAy7N81o88xHMcbq5QcW1Vm9TVF+kfRi0/9t6NudIeUafVzlK5up WHuYQ1eDyxaUPhIzF+VrzJf5mYzEw//rarCVACWS3s/1OmghBIB1e4SYa5+M/rOv4ad2 uvszs7ifhSmmmYfVD+JRLYqYs8rnc4XpUcNhG9pG8oKgKXhcqtdE3yPktO/Tx3ju5k/n W2CSW3i9WUnyEn+jzN5eROupsQXbFqVE1nV51TAG3JdNvTPavcvj5WgOU//bsPt5IwIZ Yn/nSWtQX/pqFP+ZDj5I6QhFJOyjGBhz7x2BTXOw/V6tLBQcN+tsLUr/nGuRWyJC3wkP b/MA== X-Gm-Message-State: APjAAAWaFe+yAKI2ponR72m8HCucdT2hN0XbN06Jt998SkAXkCuXjQBs ql++NUxbODmftXLxZQB7emAkWfb9JVszTN0c2tKK9g== X-Google-Smtp-Source: APXvYqxe6zvqvkMBezUGqzKAEYSTwQ/sNKuj6ffZfvcWwiO9AOk1SDdrnEGOgdcqBDW/SJNVakQKutXfNYK60w6drc8= X-Received: by 2002:aca:ead7:: with SMTP id i206mr499780oih.0.1573608378184; Tue, 12 Nov 2019 17:26:18 -0800 (PST) MIME-Version: 1.0 References: <157309899529.1582359.15358067933360719580.stgit@dwillia2-desk3.amr.corp.intel.com> <157309901655.1582359.18126990555058555754.stgit@dwillia2-desk3.amr.corp.intel.com> <87h839tpo9.fsf@linux.ibm.com> In-Reply-To: <87h839tpo9.fsf@linux.ibm.com> From: Dan Williams Date: Tue, 12 Nov 2019 17:26:07 -0800 Message-ID: Subject: Re: [PATCH 04/16] libnvdimm: Move nd_numa_attribute_group to device_type To: "Aneesh Kumar K.V" Message-ID-Hash: NGWY3HX5LRQZT3LIT5RGUM226YKTU32L X-Message-ID-Hash: NGWY3HX5LRQZT3LIT5RGUM226YKTU32L X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-nvdimm , Michael Ellerman , Peter Zijlstra , Dave Hansen , Linux Kernel Mailing List , Linux MM X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Nov 12, 2019 at 1:23 AM Aneesh Kumar K.V wrote: > > Dan Williams writes: > > > A 'struct device_type' instance can carry default attributes for the > > device. Use this facility to remove the export of > > nd_numa_attribute_group and put the responsibility on the core rather > > than leaf implementations to define this attribute. > > > > Cc: Ira Weiny > > Cc: Michael Ellerman > > Cc: "Oliver O'Halloran" > > Cc: Vishal Verma > > Cc: Aneesh Kumar K.V > > Signed-off-by: Dan Williams > > > can we also expose target_node in a similar way? This allows application > to better understand the node locality of the SCM device. It is already exported for device-dax instances. See DEVICE_ATTR_RO(target_node) in drivers/dax/bus.c. I did not see a use case for it to be exported for other nvdimm device types. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DD7C17440 for ; Wed, 13 Nov 2019 01:26:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 733E5222CD for ; Wed, 13 Nov 2019 01:26:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="doPKvu1g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbfKMB0T (ORCPT ); Tue, 12 Nov 2019 20:26:19 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:44262 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbfKMB0T (ORCPT ); Tue, 12 Nov 2019 20:26:19 -0500 Received: by mail-oi1-f196.google.com with SMTP id s71so250302oih.11 for ; Tue, 12 Nov 2019 17:26:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d0MB/SSMpogQj4Fcl4IC+pxpUwq0gyFs7A/amSO1m4Y=; b=doPKvu1gZNpcuqwOmCORE1idu0dAD0+ZV4ybOrLIR70xlU/Ld+eQ7FHZDb7gjt5NSd uISrpZzkm2+LjEtMuDDLkKlB7O2X18chqvg8BtH28z3+X12qZdHaQHtuQushixLAzJg7 t983ph1Tvk4oDHv2V/w4UkB4XE4huboN+gnSOdLM32WdvXQhALzflaDwdfqPOs4q1FDx KHTaYVXq5pc5+JMyRNtd4GCn8D2IdH6SpPmHk2S+B8emEa5gIX6d6TAhG7Nj1WNaSqx/ ZxFw0h3C4SOkt6WE3U5FxbkudR4vKN1cP2Z3YTQ4vcdCMRuvF/2j35Cwczb+P1sv6s+B KzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d0MB/SSMpogQj4Fcl4IC+pxpUwq0gyFs7A/amSO1m4Y=; b=rSxv3HQ1kBKvkK/wFPJZmvhb0apImdUWWWzfupgigWxYq2DlfL4tFjO43zXucuqmxB Z4vqy485de/6RYIuv/FXsOlvIYlFCgQCXZFH2n0ddScbAisMePVf//n6XoJo+K9dN3od w+D2JNDuyvwdr8tMqSx73G0o79FenXntnYNRnRmcwsnggPGczaNM6KsSu48kRae+E5wh Mn5ZAfqSNJRWZXKmNjnuWKDGrsuENDqgkfdhvE4Pt+32oLMuAT8girkaJ0hYmsNNLHUJ /nCxQLuX7tZ//sgv5h1jbrBO8FMUs9NbeiVhm8AI7hUxbXmdGwSqTWgRWisSZ5NHmTDi MS0g== X-Gm-Message-State: APjAAAUbXdFj944qkAPYVoMMgiFR2lcoIO6mF3yKqh398tcwPZy6FDGv ZTUIBfVtGs8BO57ylQ+C9VcSsvrCKPW6kRRiMx1uAw== X-Google-Smtp-Source: APXvYqxe6zvqvkMBezUGqzKAEYSTwQ/sNKuj6ffZfvcWwiO9AOk1SDdrnEGOgdcqBDW/SJNVakQKutXfNYK60w6drc8= X-Received: by 2002:aca:ead7:: with SMTP id i206mr499780oih.0.1573608378184; Tue, 12 Nov 2019 17:26:18 -0800 (PST) MIME-Version: 1.0 References: <157309899529.1582359.15358067933360719580.stgit@dwillia2-desk3.amr.corp.intel.com> <157309901655.1582359.18126990555058555754.stgit@dwillia2-desk3.amr.corp.intel.com> <87h839tpo9.fsf@linux.ibm.com> In-Reply-To: <87h839tpo9.fsf@linux.ibm.com> From: Dan Williams Date: Tue, 12 Nov 2019 17:26:07 -0800 Message-ID: Subject: Re: [PATCH 04/16] libnvdimm: Move nd_numa_attribute_group to device_type To: "Aneesh Kumar K.V" Cc: linux-nvdimm , Ira Weiny , Michael Ellerman , "Oliver O'Halloran" , Vishal Verma , Peter Zijlstra , Dave Hansen , Linux Kernel Mailing List , Linux MM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 12, 2019 at 1:23 AM Aneesh Kumar K.V wrote: > > Dan Williams writes: > > > A 'struct device_type' instance can carry default attributes for the > > device. Use this facility to remove the export of > > nd_numa_attribute_group and put the responsibility on the core rather > > than leaf implementations to define this attribute. > > > > Cc: Ira Weiny > > Cc: Michael Ellerman > > Cc: "Oliver O'Halloran" > > Cc: Vishal Verma > > Cc: Aneesh Kumar K.V > > Signed-off-by: Dan Williams > > > can we also expose target_node in a similar way? This allows application > to better understand the node locality of the SCM device. It is already exported for device-dax instances. See DEVICE_ATTR_RO(target_node) in drivers/dax/bus.c. I did not see a use case for it to be exported for other nvdimm device types. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92ADBC43331 for ; Wed, 13 Nov 2019 01:26:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 46A81222CD for ; Wed, 13 Nov 2019 01:26:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="doPKvu1g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46A81222CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E63176B0007; Tue, 12 Nov 2019 20:26:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E14016B0008; Tue, 12 Nov 2019 20:26:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D03666B000A; Tue, 12 Nov 2019 20:26:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id BAA2F6B0007 for ; Tue, 12 Nov 2019 20:26:19 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 765478249980 for ; Wed, 13 Nov 2019 01:26:19 +0000 (UTC) X-FDA: 76149513678.05.step18_372dc608e2735 X-HE-Tag: step18_372dc608e2735 X-Filterd-Recvd-Size: 4104 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Nov 2019 01:26:19 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id j7so288543oib.3 for ; Tue, 12 Nov 2019 17:26:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d0MB/SSMpogQj4Fcl4IC+pxpUwq0gyFs7A/amSO1m4Y=; b=doPKvu1gZNpcuqwOmCORE1idu0dAD0+ZV4ybOrLIR70xlU/Ld+eQ7FHZDb7gjt5NSd uISrpZzkm2+LjEtMuDDLkKlB7O2X18chqvg8BtH28z3+X12qZdHaQHtuQushixLAzJg7 t983ph1Tvk4oDHv2V/w4UkB4XE4huboN+gnSOdLM32WdvXQhALzflaDwdfqPOs4q1FDx KHTaYVXq5pc5+JMyRNtd4GCn8D2IdH6SpPmHk2S+B8emEa5gIX6d6TAhG7Nj1WNaSqx/ ZxFw0h3C4SOkt6WE3U5FxbkudR4vKN1cP2Z3YTQ4vcdCMRuvF/2j35Cwczb+P1sv6s+B KzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d0MB/SSMpogQj4Fcl4IC+pxpUwq0gyFs7A/amSO1m4Y=; b=kTKcC8nc2TxHjSrQ7D20Gv3YjCj/qO0tBa/LCPJSoVoHx3DVDBZOuaTIbwPkfddnbC 8trFeBk1Lv/9M1U2qVD1GAJAMV/lqF1NIi1AbMvsaBNyWH2dlfhiUZdSTPL5CLYvUGGO hJL36CN41YjaqQ6UznuTZIpZqYK4sgBwnEjnLO9tLkjFlY9JqfnxuOd4v/QwEehvnBOP x/MgdCAcYHKOW2uVhQOGZhyohu5fHPVFZObBX/C3qBtzvQYwiPdf4n4LQnjxvn+AUjFi YYJwShmcvN65MurDBBjbXnPTx8+THEBehLG23uxvvpkypqzvEP88ACZD6RFXv8zIJtsQ +0jQ== X-Gm-Message-State: APjAAAVGtDcYw0a7xFdAY+Z7wTE6w3yFnDremV370UfnQ6ORUWa9lJ0H ktW5FyH5ZyiJVSRKkX6X5hU+i7YRpJdjpPDweECC0Q== X-Google-Smtp-Source: APXvYqxe6zvqvkMBezUGqzKAEYSTwQ/sNKuj6ffZfvcWwiO9AOk1SDdrnEGOgdcqBDW/SJNVakQKutXfNYK60w6drc8= X-Received: by 2002:aca:ead7:: with SMTP id i206mr499780oih.0.1573608378184; Tue, 12 Nov 2019 17:26:18 -0800 (PST) MIME-Version: 1.0 References: <157309899529.1582359.15358067933360719580.stgit@dwillia2-desk3.amr.corp.intel.com> <157309901655.1582359.18126990555058555754.stgit@dwillia2-desk3.amr.corp.intel.com> <87h839tpo9.fsf@linux.ibm.com> In-Reply-To: <87h839tpo9.fsf@linux.ibm.com> From: Dan Williams Date: Tue, 12 Nov 2019 17:26:07 -0800 Message-ID: Subject: Re: [PATCH 04/16] libnvdimm: Move nd_numa_attribute_group to device_type To: "Aneesh Kumar K.V" Cc: linux-nvdimm , Ira Weiny , Michael Ellerman , "Oliver O'Halloran" , Vishal Verma , Peter Zijlstra , Dave Hansen , Linux Kernel Mailing List , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 12, 2019 at 1:23 AM Aneesh Kumar K.V wrote: > > Dan Williams writes: > > > A 'struct device_type' instance can carry default attributes for the > > device. Use this facility to remove the export of > > nd_numa_attribute_group and put the responsibility on the core rather > > than leaf implementations to define this attribute. > > > > Cc: Ira Weiny > > Cc: Michael Ellerman > > Cc: "Oliver O'Halloran" > > Cc: Vishal Verma > > Cc: Aneesh Kumar K.V > > Signed-off-by: Dan Williams > > > can we also expose target_node in a similar way? This allows application > to better understand the node locality of the SCM device. It is already exported for device-dax instances. See DEVICE_ATTR_RO(target_node) in drivers/dax/bus.c. I did not see a use case for it to be exported for other nvdimm device types.