From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E87C46466 for ; Wed, 7 Oct 2020 02:40:23 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F8AB207EA for ; Wed, 7 Oct 2020 02:40:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="EPjdVqDe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F8AB207EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 8CE67158B62E2; Tue, 6 Oct 2020 19:40:22 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::642; helo=mail-ej1-x642.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A291E1589CF52 for ; Tue, 6 Oct 2020 19:40:19 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id lw21so751850ejb.6 for ; Tue, 06 Oct 2020 19:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=afZ2ku0615X/vbgIsq8uZABQa+HrZmef3/cMOPPeXPE=; b=EPjdVqDeTinUn3xle7QkZRs1c1I777r6WwVNCzmQvuelLMEIhN7D3byY1DbMWiHRAd QgHw7nunbi78JiFNVYPaj+vzDaQToh84mycymDqg79odab44O2bFpy0hTFRZMk6Gq88h gdm22jg2FmT9PYcFKiksCpHH97YYjHNLfkRJqB+XyuOtAK7X6n9Ol7Qc3aWxyX/ubcf1 1Dj3nT3ueZ1gSrXVBd01SuIcMxMF+W8KjeuouHZbfkVWg3QUD53z+H8ypZQCYHGiMbYk lCoLazlQUecuVDEtHUfRDwSsCvcaF59aNbsh9HWw6NNgsgGSQloXWj+DnfN5l7npN3En PmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=afZ2ku0615X/vbgIsq8uZABQa+HrZmef3/cMOPPeXPE=; b=RGLnD+1mdyAL2n7ea/zz2ykw0ik+Uza6Uu/xVtMD/ygO5R4A6hsZPije6TThTRdD0a 8OGSqgtX6XhawleBe5HTX4O5EBYk56FPVtTJtgiRufNQVJETpk78Lo8/PP0lHFvmrPM/ nlizSyy596WSX/UJWyqrfj4/V89GZBQ/G6d/Jp/kXxwYtdNJO9AwJb5F1EwrGO0571q1 vtxtkoSv1P71fgQ+l7bcQc5GulY/iCU//YQ016rdrAbtmBCtwM3wnb6hGUZK/NHa8TZ4 0+PL9YI4Juwx6xM3AFZkl/fmdowZW0F1EFMQUOJbcsOxeYn62Iy0D4fh/vxS2fN1jR/7 Av2g== X-Gm-Message-State: AOAM532xR1ptouCrZi2qvvBzNnrqdjlhnymhji/CW/3ME8TZFpz81xe2 AZxJV/M3NnzHRdqL3gwKSMEE2CC9ledi2vqfYvjttQ== X-Google-Smtp-Source: ABdhPJyzhK0w2iAz2iCMzOOn/0AFV3bEvaxuBmF2mBxx+C4IpyFlFHdfkT/qw+BQgpUSKwf1wNdFiTZy1ImFQ33Wm94= X-Received: by 2002:a17:906:1a0b:: with SMTP id i11mr1116582ejf.472.1602038416463; Tue, 06 Oct 2020 19:40:16 -0700 (PDT) MIME-Version: 1.0 References: <20201006230930.3908-1-rcampbell@nvidia.com> In-Reply-To: <20201006230930.3908-1-rcampbell@nvidia.com> From: Dan Williams Date: Tue, 6 Oct 2020 19:40:05 -0700 Message-ID: Subject: Re: [PATCH] ext4/xfs: add page refcount helper To: Ralph Campbell Message-ID-Hash: 7ANPW2ASME7ZW7GGXC66YW3IRNKOMABA X-Message-ID-Hash: 7ANPW2ASME7ZW7GGXC66YW3IRNKOMABA X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Linux MM , linux-xfs , linux-fsdevel , linux-nvdimm , Linux Kernel Mailing List , linux-ext4 , Matthew Wilcox , Jan Kara , Alexander Viro , Theodore Ts'o , Christoph Hellwig , Andreas Dilger , "Darrick J. Wong" , Andrew Morton X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Oct 6, 2020 at 4:09 PM Ralph Campbell wrote: > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell > Reviewed-by: Christoph Hellwig > --- > > I'm resending this as a separate patch since I think it is ready to > merge. Originally, this was part of an RFC and is unchanged from v3: > https://lore.kernel.org/linux-mm/20201001181715.17416-1-rcampbell@nvidia.com > > It applies cleanly to linux-5.9.0-rc7-mm1 but doesn't really > depend on anything, just simple merge conflicts when applied to > other trees. > I'll let the various maintainers decide which tree and when to merge. > It isn't urgent since it is a clean up patch. Thanks Ralph, it looks good to me. Jan, or Ted care to ack? I don't have much else pending for dax at the moment as Andrew is carrying my dax updates for this cycle. Andrew please take this into -mm if you get a chance. Otherwise I'll cycle back to it when some other dax updates arrive in my queue. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D03C46466 for ; Wed, 7 Oct 2020 02:40:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A092207EA for ; Wed, 7 Oct 2020 02:40:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="EPjdVqDe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726893AbgJGCkS (ORCPT ); Tue, 6 Oct 2020 22:40:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726779AbgJGCkS (ORCPT ); Tue, 6 Oct 2020 22:40:18 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03930C0613D3 for ; Tue, 6 Oct 2020 19:40:17 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id u8so783162ejg.1 for ; Tue, 06 Oct 2020 19:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=afZ2ku0615X/vbgIsq8uZABQa+HrZmef3/cMOPPeXPE=; b=EPjdVqDeTinUn3xle7QkZRs1c1I777r6WwVNCzmQvuelLMEIhN7D3byY1DbMWiHRAd QgHw7nunbi78JiFNVYPaj+vzDaQToh84mycymDqg79odab44O2bFpy0hTFRZMk6Gq88h gdm22jg2FmT9PYcFKiksCpHH97YYjHNLfkRJqB+XyuOtAK7X6n9Ol7Qc3aWxyX/ubcf1 1Dj3nT3ueZ1gSrXVBd01SuIcMxMF+W8KjeuouHZbfkVWg3QUD53z+H8ypZQCYHGiMbYk lCoLazlQUecuVDEtHUfRDwSsCvcaF59aNbsh9HWw6NNgsgGSQloXWj+DnfN5l7npN3En PmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=afZ2ku0615X/vbgIsq8uZABQa+HrZmef3/cMOPPeXPE=; b=gMJz4H/puKKW/TgScdZ7IOOgMcdU4eRr7+aT9h+6WUGUa6sUhWUxae/CbtMkE0SHIs v6tkCtx/Ewwp3QRdAsc4ElwVpWe5Xql2M1rfJ6QhEXsKb8e6rLsL3jlh7jxynPOWMz44 i2+iUTHLIT3235hNV7gx0Tz71jUurWKyS2P0/2qQJyF0urUbPjwKx58fwiO+QkPqYUPC Yeo2NMd1BfWDE+nN8dZFnsBdEeS72piIf2nTRVaMEiQLBZvhTG8ZeO8ae2IUITxv5IDg cKNtzPnEjjWTp8D90WojQKPG7L81I3MlifaUCFhxqj71JaCXqsB4JuqaUBsx0lXxFVcd r9Lw== X-Gm-Message-State: AOAM532yAUtnAeotPjA+JoWLQcJ31im6I1VIoQv0s8dUcCHXpr0uv0KU +oU6e7eeQNF2R6QnrYLcLozK+9m9TSSxPBRdGmpwEA== X-Google-Smtp-Source: ABdhPJyzhK0w2iAz2iCMzOOn/0AFV3bEvaxuBmF2mBxx+C4IpyFlFHdfkT/qw+BQgpUSKwf1wNdFiTZy1ImFQ33Wm94= X-Received: by 2002:a17:906:1a0b:: with SMTP id i11mr1116582ejf.472.1602038416463; Tue, 06 Oct 2020 19:40:16 -0700 (PDT) MIME-Version: 1.0 References: <20201006230930.3908-1-rcampbell@nvidia.com> In-Reply-To: <20201006230930.3908-1-rcampbell@nvidia.com> From: Dan Williams Date: Tue, 6 Oct 2020 19:40:05 -0700 Message-ID: Subject: Re: [PATCH] ext4/xfs: add page refcount helper To: Ralph Campbell Cc: Linux MM , linux-xfs , linux-fsdevel , linux-nvdimm , Linux Kernel Mailing List , linux-ext4 , Matthew Wilcox , Jan Kara , Alexander Viro , "Theodore Ts'o" , Christoph Hellwig , Andreas Dilger , "Darrick J. Wong" , Andrew Morton Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 6, 2020 at 4:09 PM Ralph Campbell wrote: > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell > Reviewed-by: Christoph Hellwig > --- > > I'm resending this as a separate patch since I think it is ready to > merge. Originally, this was part of an RFC and is unchanged from v3: > https://lore.kernel.org/linux-mm/20201001181715.17416-1-rcampbell@nvidia.com > > It applies cleanly to linux-5.9.0-rc7-mm1 but doesn't really > depend on anything, just simple merge conflicts when applied to > other trees. > I'll let the various maintainers decide which tree and when to merge. > It isn't urgent since it is a clean up patch. Thanks Ralph, it looks good to me. Jan, or Ted care to ack? I don't have much else pending for dax at the moment as Andrew is carrying my dax updates for this cycle. Andrew please take this into -mm if you get a chance. Otherwise I'll cycle back to it when some other dax updates arrive in my queue. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D5DC3279D for ; Wed, 7 Oct 2020 02:40:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D95DA207EA for ; Wed, 7 Oct 2020 02:40:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="EPjdVqDe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D95DA207EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F09576B005C; Tue, 6 Oct 2020 22:40:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBAFE6B0062; Tue, 6 Oct 2020 22:40:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA7E6900002; Tue, 6 Oct 2020 22:40:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id A258C6B005C for ; Tue, 6 Oct 2020 22:40:19 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 21A2B824999B for ; Wed, 7 Oct 2020 02:40:19 +0000 (UTC) X-FDA: 77343575358.15.actor79_3e0d2c2271cb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id F27261814B0C1 for ; Wed, 7 Oct 2020 02:40:18 +0000 (UTC) X-HE-Tag: actor79_3e0d2c2271cb X-Filterd-Recvd-Size: 4286 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 7 Oct 2020 02:40:17 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id dt13so722570ejb.12 for ; Tue, 06 Oct 2020 19:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=afZ2ku0615X/vbgIsq8uZABQa+HrZmef3/cMOPPeXPE=; b=EPjdVqDeTinUn3xle7QkZRs1c1I777r6WwVNCzmQvuelLMEIhN7D3byY1DbMWiHRAd QgHw7nunbi78JiFNVYPaj+vzDaQToh84mycymDqg79odab44O2bFpy0hTFRZMk6Gq88h gdm22jg2FmT9PYcFKiksCpHH97YYjHNLfkRJqB+XyuOtAK7X6n9Ol7Qc3aWxyX/ubcf1 1Dj3nT3ueZ1gSrXVBd01SuIcMxMF+W8KjeuouHZbfkVWg3QUD53z+H8ypZQCYHGiMbYk lCoLazlQUecuVDEtHUfRDwSsCvcaF59aNbsh9HWw6NNgsgGSQloXWj+DnfN5l7npN3En PmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=afZ2ku0615X/vbgIsq8uZABQa+HrZmef3/cMOPPeXPE=; b=RWsg6/8iJL0R9GfNndeFkJmyKIh7SgAxmzCR/yiR9NLEUeJPCgK1WHryCGS2o+W7Li 1XKnzj0bXxJnfO56dP/YktaNVcYglHzDnXUdr0MnVvuFggueGstDRMOKpzVOv3jx3NwS 2nQQf0932r71y5hbn12rZgn2WjJ/djxwMJrxxvOBRmZo+XnRSwCK1NPu/LaPNkyjuJuG bXwKGUsHo/Yy3IfMfkzlxJa8XnsdCaGM/yMHRdKD9ROkObpfZRyBB1pTqMiM9es+vbZm PCH1aiRJD6gScUM4DanRLkkIBO7iXD2QsYKW77fRYjDnNju4keVHz2Lc22qkaW//ATex ZY3A== X-Gm-Message-State: AOAM532EjGXfBaN5VXR5Y71cAKAzz5V1oXJIr4BLkiOKp4+Ta0aU7Gdo Ej2SnrxMLvg9UqyCKYMs8v3+8px84Is3RxsUNt+MTg== X-Google-Smtp-Source: ABdhPJyzhK0w2iAz2iCMzOOn/0AFV3bEvaxuBmF2mBxx+C4IpyFlFHdfkT/qw+BQgpUSKwf1wNdFiTZy1ImFQ33Wm94= X-Received: by 2002:a17:906:1a0b:: with SMTP id i11mr1116582ejf.472.1602038416463; Tue, 06 Oct 2020 19:40:16 -0700 (PDT) MIME-Version: 1.0 References: <20201006230930.3908-1-rcampbell@nvidia.com> In-Reply-To: <20201006230930.3908-1-rcampbell@nvidia.com> From: Dan Williams Date: Tue, 6 Oct 2020 19:40:05 -0700 Message-ID: Subject: Re: [PATCH] ext4/xfs: add page refcount helper To: Ralph Campbell Cc: Linux MM , linux-xfs , linux-fsdevel , linux-nvdimm , Linux Kernel Mailing List , linux-ext4 , Matthew Wilcox , Jan Kara , Alexander Viro , "Theodore Ts'o" , Christoph Hellwig , Andreas Dilger , "Darrick J. Wong" , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 6, 2020 at 4:09 PM Ralph Campbell wrote: > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell > Reviewed-by: Christoph Hellwig > --- > > I'm resending this as a separate patch since I think it is ready to > merge. Originally, this was part of an RFC and is unchanged from v3: > https://lore.kernel.org/linux-mm/20201001181715.17416-1-rcampbell@nvidia.com > > It applies cleanly to linux-5.9.0-rc7-mm1 but doesn't really > depend on anything, just simple merge conflicts when applied to > other trees. > I'll let the various maintainers decide which tree and when to merge. > It isn't urgent since it is a clean up patch. Thanks Ralph, it looks good to me. Jan, or Ted care to ack? I don't have much else pending for dax at the moment as Andrew is carrying my dax updates for this cycle. Andrew please take this into -mm if you get a chance. Otherwise I'll cycle back to it when some other dax updates arrive in my queue.