From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_50,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6CB9C433DB for ; Wed, 17 Feb 2021 01:28:09 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 827EB64E6B for ; Wed, 17 Feb 2021 01:28:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 827EB64E6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 674A6100F2251; Tue, 16 Feb 2021 17:28:08 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::233; helo=mail-lj1-x233.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3A9F7100F224F for ; Tue, 16 Feb 2021 17:28:06 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id u4so14201568ljh.6 for ; Tue, 16 Feb 2021 17:28:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gPv9nnPUm1TtsaIpcziIZ0EFUe5FQcNRA0/EfWprXeY=; b=mGOK/Lh9DqKxJSxcLC/cxXGfRCykdF3sEex6bNjqzqqz2wEXNZBz8qBIw/o/GsUdUy JqGdAlqK7l8xfqw4n9s7IjyviTTAuGHuBaeb6qCFKidDFjkZ//uchfJYsIGgwHVtr+F5 5gjY6KulqlRxhZvyySFR+JV5+adv/UPppeptMXju3SPBlKXcZzZ+unOTCVTGvnv+c2ot fXRavbbrvHNb7PTxme8yT8CBwFzOcc+7stZvccs1xfXnQKM4yLPDDsEnnEnMxfaI+3Bw 8uMjxu3dSsu34XskLTm16uo962LYhNuoS6DU4FGoagVodC6dCGiyzDAgW8vA2UrBWvkE o/Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gPv9nnPUm1TtsaIpcziIZ0EFUe5FQcNRA0/EfWprXeY=; b=Je4sE5Hu1mdsb5j1c652ADi2p3CAu1vXeTPMcH8wZ/WJmNJgyPkIcP6iK1PDegnFcK mLRrn+2056PEIX+aycbf6qIOrchOBo1BTj5yZsg08vWjtTdiw0MRAahEnSCjRogcVt3H rk0ujC/95RI9PJDW5KoQoEMW0zWOml4WZLhrs6mc20mQH2JHYbCPXC/QpIJoALJIQjkJ kl+df8ZMi8aa5MRy76y3ilhG2H/AsDBVBqZJn6M2Chf+KKehxEXPdeCmpkrpO1O/czxP 9BRkIxu2EX0QCQ32mVXKmyU5KIpLbpwphl8gbisbXno6IIbOpbDoibJXPmcSLOgr3/sn fXxw== X-Gm-Message-State: AOAM533OSw7KtgS6nQMUsuGbsxE/qBzGxmc0AJxtOHZXygr5eCZ6YdTF uXKWwA1pjf+qiCTcDfD4FdLV8+PCEIVSDVQ8NKXtw/dAbK3zTw== X-Google-Smtp-Source: ABdhPJyjE1eb1Bs0azjhOXFMczp7BzdIXSTzhGuiY/xcrO0h9FgGKkON6FHrIIfzEIYcpgRYGzsqpuUaoa9cw1ekQ9c= X-Received: by 2002:a17:906:5655:: with SMTP id v21mr4481219ejr.264.1613515145917; Tue, 16 Feb 2021 14:39:05 -0800 (PST) MIME-Version: 1.0 References: <20210126021331.1059933-1-ruansy.fnst@cn.fujitsu.com> In-Reply-To: From: Dan Williams Date: Tue, 16 Feb 2021 14:38:55 -0800 Message-ID: Subject: Re: [PATCH] dax: fix default return code of range_parse() To: Joao Martins Message-ID-Hash: LGOQR6WODUOTC7RYFDKZ4FTAEBQGBAPQ X-Message-ID-Hash: LGOQR6WODUOTC7RYFDKZ4FTAEBQGBAPQ X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Linux Kernel Mailing List , linux-nvdimm , Zhang Qilong X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Feb 10, 2021 at 10:19 AM Joao Martins wrote: > > On 1/26/21 2:13 AM, Shiyang Ruan wrote: > > The return value of range_parse() indicates the size when it is > > positive. The error code should be negative. > > > > Signed-off-by: Shiyang Ruan > > Reviewed-by: Joao Martins > > Although, FWIW, there was another patch exactly like this a couple > months ago, albeit it didn't get pulled for some reason: > > https://lore.kernel.org/linux-nvdimm/20201026110425.136629-1-zhangqilong3@huawei.com/ Apologies for missing these... applied now. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9569C433DB for ; Tue, 16 Feb 2021 22:39:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92D3F64E68 for ; Tue, 16 Feb 2021 22:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230495AbhBPWju (ORCPT ); Tue, 16 Feb 2021 17:39:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230059AbhBPWjr (ORCPT ); Tue, 16 Feb 2021 17:39:47 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35D3BC061574 for ; Tue, 16 Feb 2021 14:39:07 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id w1so9989526ejk.6 for ; Tue, 16 Feb 2021 14:39:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gPv9nnPUm1TtsaIpcziIZ0EFUe5FQcNRA0/EfWprXeY=; b=mGOK/Lh9DqKxJSxcLC/cxXGfRCykdF3sEex6bNjqzqqz2wEXNZBz8qBIw/o/GsUdUy JqGdAlqK7l8xfqw4n9s7IjyviTTAuGHuBaeb6qCFKidDFjkZ//uchfJYsIGgwHVtr+F5 5gjY6KulqlRxhZvyySFR+JV5+adv/UPppeptMXju3SPBlKXcZzZ+unOTCVTGvnv+c2ot fXRavbbrvHNb7PTxme8yT8CBwFzOcc+7stZvccs1xfXnQKM4yLPDDsEnnEnMxfaI+3Bw 8uMjxu3dSsu34XskLTm16uo962LYhNuoS6DU4FGoagVodC6dCGiyzDAgW8vA2UrBWvkE o/Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gPv9nnPUm1TtsaIpcziIZ0EFUe5FQcNRA0/EfWprXeY=; b=jMmNM4QcXEfdzXzZlXu564ZXsMPESgvfacIqG2jqUS9RRJQX3J3MZJnJ4eKMlPBH6u Qbapx0xTmBWgVabFnkBQD967dKOxQ2k0Y22McuIy+b11QVxLpFJ5lV2/VjCmekFs4rOA pbz/oKfzQx4p6EFn2diejw/t0kD+AZTKNJcvglLsLHa5P6o78uzH8GGDZPfLdzl02+Wb i2sglAwUXS81YuWPfwhIbavqP0Pk+a26Mfe2N1gMUtAv3xTO17L/VVs/KFkhW8Y+E83g cA0ZrDllm6QPU+99mt7EzQyLRB56Dqi2Z4CON09+LBXQ0R2241jfjaNUZlEpNXe3HNrr ThBw== X-Gm-Message-State: AOAM53040pXr6x/+Oj8yLomxyEtP7s6ZlkFfX7FTvK1SsEyMDfYUoA6D YvuzwVe96tgA1i6cdF8a85IlDt+q5SUhohxpgnvAo2a/4f+mcQ== X-Google-Smtp-Source: ABdhPJyjE1eb1Bs0azjhOXFMczp7BzdIXSTzhGuiY/xcrO0h9FgGKkON6FHrIIfzEIYcpgRYGzsqpuUaoa9cw1ekQ9c= X-Received: by 2002:a17:906:5655:: with SMTP id v21mr4481219ejr.264.1613515145917; Tue, 16 Feb 2021 14:39:05 -0800 (PST) MIME-Version: 1.0 References: <20210126021331.1059933-1-ruansy.fnst@cn.fujitsu.com> In-Reply-To: From: Dan Williams Date: Tue, 16 Feb 2021 14:38:55 -0800 Message-ID: Subject: Re: [PATCH] dax: fix default return code of range_parse() To: Joao Martins Cc: Shiyang Ruan , Linux Kernel Mailing List , linux-nvdimm , Vishal L Verma , Dave Jiang , Zhang Qilong Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 10:19 AM Joao Martins wrote: > > On 1/26/21 2:13 AM, Shiyang Ruan wrote: > > The return value of range_parse() indicates the size when it is > > positive. The error code should be negative. > > > > Signed-off-by: Shiyang Ruan > > Reviewed-by: Joao Martins > > Although, FWIW, there was another patch exactly like this a couple > months ago, albeit it didn't get pulled for some reason: > > https://lore.kernel.org/linux-nvdimm/20201026110425.136629-1-zhangqilong3@huawei.com/ Apologies for missing these... applied now.