From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD06C4741F for ; Fri, 30 Oct 2020 19:24:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC97A20739 for ; Fri, 30 Oct 2020 19:24:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="lEC/i/Ha" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbgJ3TYr (ORCPT ); Fri, 30 Oct 2020 15:24:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727704AbgJ3TXK (ORCPT ); Fri, 30 Oct 2020 15:23:10 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CB31C0613D5 for ; Fri, 30 Oct 2020 12:23:10 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id p9so10124332eji.4 for ; Fri, 30 Oct 2020 12:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cL9WOPO2zHT1vQiE1Idu/YzBY6AJ1/e6GyUyFPMSPBE=; b=lEC/i/HaCAbfQosRN4vmMobfCxVR+WZvnS6eUCNPlKWH+DM9vHMj7SqJcRXOIjY3gR X7fqNKkZHnLb3MSxwodUICF97jfOsHKnuDyEcvSjhdLdPJDHWyuIEcOT1bdngZUgm+fB LnvKGjcJua2dQA5V5B17tvYJrJ6z/kJG7BObCa8rMFSzoI2LQncz5V1J1hPiz0LBLrhB ehP68u5wwlkkRu5765qgLOCoQ/hOKUaoLOB0RlxdEAi5wNF8262oDo5KcRXIkHzdad7I P2+qsjLodK5zSNdL+ykfiARoWE6cSX7jXnihb6GRYo+FQOn/ZAgy9c4PIkYJzVJruoKu pI/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cL9WOPO2zHT1vQiE1Idu/YzBY6AJ1/e6GyUyFPMSPBE=; b=QXwq4doPkdUL7RLO6szd3EtoOjN2oD9q30bmrP+zOxuRK6QMmNSLE3Sa5QwuTDJOTF ia7owDMZjSk3Q/PIXZD5UeSDRsvhxHwl2RmRDebIU6FO/3X06L1DWcBCuVgMohknideK hq7l4ThwHnar6Hjt5YnhWL+foP7txi2cv5iIU/wUW1VK8tL06xtjKqurJWrOrPjd2tR1 qQ4B5ZWx+YhfeAM5qEfeVTd1lS/aFZ4nvygTjhFgDBuSekheEvB+pOF/1Nti8O0N6e5N 2h8n8rBM/GesDMIXq3uX+3hqLbKgwExLRD+rYmQBp4T+YOhDaTXx8dBDMNqqQtr8CyGc zX2g== X-Gm-Message-State: AOAM531QSTND+v5S3gMZirOYE7SOQeWG0BhexfYN5ylZmkjnKo8sVnHA gwaXGoQvdP9/1Z8aTNONQnu08MXDnsSzTgMK+NJssw== X-Google-Smtp-Source: ABdhPJzvRDFG7BoOZiy9coBum22wqezGCSC0O+U29RY5lD3y+GuATCwmUn+7GqLGOYRtTucrFFIslPSSuBYGYUaG5e4= X-Received: by 2002:a17:906:70cf:: with SMTP id g15mr3935941ejk.323.1604085788862; Fri, 30 Oct 2020 12:23:08 -0700 (PDT) MIME-Version: 1.0 References: <20201030100815.2269-1-daniel.vetter@ffwll.ch> <20201030100815.2269-16-daniel.vetter@ffwll.ch> In-Reply-To: <20201030100815.2269-16-daniel.vetter@ffwll.ch> From: Dan Williams Date: Fri, 30 Oct 2020 12:22:54 -0700 Message-ID: Subject: Re: [PATCH v5 15/15] PCI: Revoke mappings like devmem To: Daniel Vetter Cc: DRI Development , LKML , KVM list , Linux MM , Linux ARM , linux-samsung-soc , "Linux-media@vger.kernel.org" , Daniel Vetter , Jason Gunthorpe , Kees Cook , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Greg Kroah-Hartman , Bjorn Helgaas , Linux PCI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 3:09 AM Daniel Vetter wrot= e: > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > the region") /dev/kmem zaps ptes when the kernel requests exclusive > acccess to an iomem region. And with CONFIG_IO_STRICT_DEVMEM, this is > the default for all driver uses. > > Except there's two more ways to access PCI BARs: sysfs and proc mmap > support. Let's plug that hole. > > For revoke_devmem() to work we need to link our vma into the same > address_space, with consistent vma->vm_pgoff. ->pgoff is already > adjusted, because that's how (io_)remap_pfn_range works, but for the > mapping we need to adjust vma->vm_file->f_mapping. The cleanest way is > to adjust this at at ->open time: > > - for sysfs this is easy, now that binary attributes support this. We > just set bin_attr->mapping when mmap is supported > - for procfs it's a bit more tricky, since procfs pci access has only > one file per device, and access to a specific resources first needs > to be set up with some ioctl calls. But mmap is only supported for > the same resources as sysfs exposes with mmap support, and otherwise > rejected, so we can set the mapping unconditionally at open time > without harm. > > A special consideration is for arch_can_pci_mmap_io() - we need to > make sure that the ->f_mapping doesn't alias between ioport and iomem > space. There's only 2 ways in-tree to support mmap of ioports: generic > pci mmap (ARCH_GENERIC_PCI_MMAP_RESOURCE), and sparc as the single > architecture hand-rolling. Both approach support ioport mmap through a > special pfn range and not through magic pte attributes. Aliasing is > therefore not a problem. > > The only difference in access checks left is that sysfs PCI mmap does > not check for CAP_RAWIO. I'm not really sure whether that should be > added or not. > > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Kees Cook > Cc: Dan Williams > Cc: Andrew Morton > Cc: John Hubbard > Cc: J=C3=A9r=C3=B4me Glisse > Cc: Jan Kara > Cc: Dan Williams Looks good to me: Reviewed-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBEB8C55179 for ; Fri, 30 Oct 2020 19:24:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C2FB22202 for ; Fri, 30 Oct 2020 19:24:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P8H1KfCs"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="lEC/i/Ha" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C2FB22202 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S97KwgeC0w66jbwPuu7esRKY0qPRzEAXV8Pd7SMOp4w=; b=P8H1KfCsBwialiJO/9/ojIp9F DQizY3TNZbHsGppjcsZ1w/3Gtsm448YexZldpsj15PrnxnNxeO7TKOSb+6fbux0O/HKVaPJzl2v4D jpiQpgAvAPSC9QSbjWNXSH7vYjWyLr6zq6r1bkELKaWPG6Ru2HhPyhvS6VdFFOqqFm62x63QYUbwT KH2TQjy0fh1Cqw2hL4V+swncmNM2qS4F0R7KO35LFFZE1qU7IOb2JDGEbkr1iLjvO5MdCGyACMGxg wPNcBxCAat1wvTcn/dBognPkbDdejAe/agDqFk4FVazhBnFeaL9LU61dM5NgsegpOgbXSNxIXimsY ot1ct7S6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYZzW-0003Zh-1t; Fri, 30 Oct 2020 19:23:14 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYZzR-0003Y3-TW for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2020 19:23:11 +0000 Received: by mail-ej1-x644.google.com with SMTP id za3so10103842ejb.5 for ; Fri, 30 Oct 2020 12:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cL9WOPO2zHT1vQiE1Idu/YzBY6AJ1/e6GyUyFPMSPBE=; b=lEC/i/HaCAbfQosRN4vmMobfCxVR+WZvnS6eUCNPlKWH+DM9vHMj7SqJcRXOIjY3gR X7fqNKkZHnLb3MSxwodUICF97jfOsHKnuDyEcvSjhdLdPJDHWyuIEcOT1bdngZUgm+fB LnvKGjcJua2dQA5V5B17tvYJrJ6z/kJG7BObCa8rMFSzoI2LQncz5V1J1hPiz0LBLrhB ehP68u5wwlkkRu5765qgLOCoQ/hOKUaoLOB0RlxdEAi5wNF8262oDo5KcRXIkHzdad7I P2+qsjLodK5zSNdL+ykfiARoWE6cSX7jXnihb6GRYo+FQOn/ZAgy9c4PIkYJzVJruoKu pI/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cL9WOPO2zHT1vQiE1Idu/YzBY6AJ1/e6GyUyFPMSPBE=; b=DLGvWe4j+fGX+fXWxp9XBWfY0QzWLor2oPZSpQLc6ZGE+xFrFo4AISYoPQJ3zrns2C SRPQWNpvgEBk/RoLnCeqdqdTQ149tV7JxxkFZfEEmqZ8GbG27z2yW77DW6Z3EHg+RehE 89kI6lTGti5jm6eyNbdzOQQMwwRyfF996YF6h9zqi4nKBfHPM2CBZMVp1x+FeiEWa7zR 1/nv4Tv0KfqpooNnDq6ebqVpK/GryScOXyYJo/qYsWNGBjGJU5R3HyJ786GBkXIe05dy YfoVzVyC4VRmB/x5C3LhZS9IZqF5Gug9LZYoZ98lYoSxynlu5ZmfL+ykhGrwIT6M+GpX I10g== X-Gm-Message-State: AOAM532Z5AOceMPf9+n0yKB0kT8FUnkVpfLHhzEabvwchry3o1wYULPQ o+0iT7D2vyOs2M3NOJ3LBxko0/za3RA9w6QCQVsiKQ== X-Google-Smtp-Source: ABdhPJzvRDFG7BoOZiy9coBum22wqezGCSC0O+U29RY5lD3y+GuATCwmUn+7GqLGOYRtTucrFFIslPSSuBYGYUaG5e4= X-Received: by 2002:a17:906:70cf:: with SMTP id g15mr3935941ejk.323.1604085788862; Fri, 30 Oct 2020 12:23:08 -0700 (PDT) MIME-Version: 1.0 References: <20201030100815.2269-1-daniel.vetter@ffwll.ch> <20201030100815.2269-16-daniel.vetter@ffwll.ch> In-Reply-To: <20201030100815.2269-16-daniel.vetter@ffwll.ch> From: Dan Williams Date: Fri, 30 Oct 2020 12:22:54 -0700 Message-ID: Subject: Re: [PATCH v5 15/15] PCI: Revoke mappings like devmem To: Daniel Vetter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201030_152310_119100_AA7A48D4 X-CRM114-Status: GOOD ( 22.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc , Jan Kara , Kees Cook , KVM list , Jason Gunthorpe , John Hubbard , Linux PCI , LKML , DRI Development , Linux MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Greg Kroah-Hartman , Bjorn Helgaas , Daniel Vetter , Andrew Morton , Linux ARM , "Linux-media@vger.kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBPY3QgMzAsIDIwMjAgYXQgMzowOSBBTSBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0 dGVyQGZmd2xsLmNoPiB3cm90ZToKPgo+IFNpbmNlIDMyMzRhYzY2NGE4NyAoIi9kZXYvbWVtOiBS ZXZva2UgbWFwcGluZ3Mgd2hlbiBhIGRyaXZlciBjbGFpbXMKPiB0aGUgcmVnaW9uIikgL2Rldi9r bWVtIHphcHMgcHRlcyB3aGVuIHRoZSBrZXJuZWwgcmVxdWVzdHMgZXhjbHVzaXZlCj4gYWNjY2Vz cyB0byBhbiBpb21lbSByZWdpb24uIEFuZCB3aXRoIENPTkZJR19JT19TVFJJQ1RfREVWTUVNLCB0 aGlzIGlzCj4gdGhlIGRlZmF1bHQgZm9yIGFsbCBkcml2ZXIgdXNlcy4KPgo+IEV4Y2VwdCB0aGVy ZSdzIHR3byBtb3JlIHdheXMgdG8gYWNjZXNzIFBDSSBCQVJzOiBzeXNmcyBhbmQgcHJvYyBtbWFw Cj4gc3VwcG9ydC4gTGV0J3MgcGx1ZyB0aGF0IGhvbGUuCj4KPiBGb3IgcmV2b2tlX2Rldm1lbSgp IHRvIHdvcmsgd2UgbmVlZCB0byBsaW5rIG91ciB2bWEgaW50byB0aGUgc2FtZQo+IGFkZHJlc3Nf c3BhY2UsIHdpdGggY29uc2lzdGVudCB2bWEtPnZtX3Bnb2ZmLiAtPnBnb2ZmIGlzIGFscmVhZHkK PiBhZGp1c3RlZCwgYmVjYXVzZSB0aGF0J3MgaG93IChpb18pcmVtYXBfcGZuX3JhbmdlIHdvcmtz LCBidXQgZm9yIHRoZQo+IG1hcHBpbmcgd2UgbmVlZCB0byBhZGp1c3Qgdm1hLT52bV9maWxlLT5m X21hcHBpbmcuIFRoZSBjbGVhbmVzdCB3YXkgaXMKPiB0byBhZGp1c3QgdGhpcyBhdCBhdCAtPm9w ZW4gdGltZToKPgo+IC0gZm9yIHN5c2ZzIHRoaXMgaXMgZWFzeSwgbm93IHRoYXQgYmluYXJ5IGF0 dHJpYnV0ZXMgc3VwcG9ydCB0aGlzLiBXZQo+ICAganVzdCBzZXQgYmluX2F0dHItPm1hcHBpbmcg d2hlbiBtbWFwIGlzIHN1cHBvcnRlZAo+IC0gZm9yIHByb2NmcyBpdCdzIGEgYml0IG1vcmUgdHJp Y2t5LCBzaW5jZSBwcm9jZnMgcGNpIGFjY2VzcyBoYXMgb25seQo+ICAgb25lIGZpbGUgcGVyIGRl dmljZSwgYW5kIGFjY2VzcyB0byBhIHNwZWNpZmljIHJlc291cmNlcyBmaXJzdCBuZWVkcwo+ICAg dG8gYmUgc2V0IHVwIHdpdGggc29tZSBpb2N0bCBjYWxscy4gQnV0IG1tYXAgaXMgb25seSBzdXBw b3J0ZWQgZm9yCj4gICB0aGUgc2FtZSByZXNvdXJjZXMgYXMgc3lzZnMgZXhwb3NlcyB3aXRoIG1t YXAgc3VwcG9ydCwgYW5kIG90aGVyd2lzZQo+ICAgcmVqZWN0ZWQsIHNvIHdlIGNhbiBzZXQgdGhl IG1hcHBpbmcgdW5jb25kaXRpb25hbGx5IGF0IG9wZW4gdGltZQo+ICAgd2l0aG91dCBoYXJtLgo+ Cj4gQSBzcGVjaWFsIGNvbnNpZGVyYXRpb24gaXMgZm9yIGFyY2hfY2FuX3BjaV9tbWFwX2lvKCkg LSB3ZSBuZWVkIHRvCj4gbWFrZSBzdXJlIHRoYXQgdGhlIC0+Zl9tYXBwaW5nIGRvZXNuJ3QgYWxp YXMgYmV0d2VlbiBpb3BvcnQgYW5kIGlvbWVtCj4gc3BhY2UuIFRoZXJlJ3Mgb25seSAyIHdheXMg aW4tdHJlZSB0byBzdXBwb3J0IG1tYXAgb2YgaW9wb3J0czogZ2VuZXJpYwo+IHBjaSBtbWFwIChB UkNIX0dFTkVSSUNfUENJX01NQVBfUkVTT1VSQ0UpLCBhbmQgc3BhcmMgYXMgdGhlIHNpbmdsZQo+ IGFyY2hpdGVjdHVyZSBoYW5kLXJvbGxpbmcuIEJvdGggYXBwcm9hY2ggc3VwcG9ydCBpb3BvcnQg bW1hcCB0aHJvdWdoIGEKPiBzcGVjaWFsIHBmbiByYW5nZSBhbmQgbm90IHRocm91Z2ggbWFnaWMg cHRlIGF0dHJpYnV0ZXMuIEFsaWFzaW5nIGlzCj4gdGhlcmVmb3JlIG5vdCBhIHByb2JsZW0uCj4K PiBUaGUgb25seSBkaWZmZXJlbmNlIGluIGFjY2VzcyBjaGVja3MgbGVmdCBpcyB0aGF0IHN5c2Zz IFBDSSBtbWFwIGRvZXMKPiBub3QgY2hlY2sgZm9yIENBUF9SQVdJTy4gSSdtIG5vdCByZWFsbHkg c3VyZSB3aGV0aGVyIHRoYXQgc2hvdWxkIGJlCj4gYWRkZWQgb3Igbm90Lgo+Cj4gU2lnbmVkLW9m Zi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gQ2M6IEphc29u IEd1bnRob3JwZSA8amdnQHppZXBlLmNhPgo+IENjOiBLZWVzIENvb2sgPGtlZXNjb29rQGNocm9t aXVtLm9yZz4KPiBDYzogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4g Q2M6IEFuZHJldyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc+Cj4gQ2M6IEpvaG4g SHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KPiBDYzogSsOpcsO0bWUgR2xpc3NlIDxqZ2xp c3NlQHJlZGhhdC5jb20+Cj4gQ2M6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+Cj4gQ2M6IERhbiBX aWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPgoKTG9va3MgZ29vZCB0byBtZToKClJl dmlld2VkLWJ5OiBEYW4gV2lsbGlhbXMgPGRhbi5qLndpbGxpYW1zQGludGVsLmNvbT4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5912C00A89 for ; Fri, 30 Oct 2020 19:23:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E47E206E3 for ; Fri, 30 Oct 2020 19:23:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="lEC/i/Ha" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E47E206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D7796E9EB; Fri, 30 Oct 2020 19:23:10 +0000 (UTC) Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by gabe.freedesktop.org (Postfix) with ESMTPS id 309506E9EB for ; Fri, 30 Oct 2020 19:23:10 +0000 (UTC) Received: by mail-ej1-x643.google.com with SMTP id o21so3068283ejb.3 for ; Fri, 30 Oct 2020 12:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cL9WOPO2zHT1vQiE1Idu/YzBY6AJ1/e6GyUyFPMSPBE=; b=lEC/i/HaCAbfQosRN4vmMobfCxVR+WZvnS6eUCNPlKWH+DM9vHMj7SqJcRXOIjY3gR X7fqNKkZHnLb3MSxwodUICF97jfOsHKnuDyEcvSjhdLdPJDHWyuIEcOT1bdngZUgm+fB LnvKGjcJua2dQA5V5B17tvYJrJ6z/kJG7BObCa8rMFSzoI2LQncz5V1J1hPiz0LBLrhB ehP68u5wwlkkRu5765qgLOCoQ/hOKUaoLOB0RlxdEAi5wNF8262oDo5KcRXIkHzdad7I P2+qsjLodK5zSNdL+ykfiARoWE6cSX7jXnihb6GRYo+FQOn/ZAgy9c4PIkYJzVJruoKu pI/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cL9WOPO2zHT1vQiE1Idu/YzBY6AJ1/e6GyUyFPMSPBE=; b=GSYAM4RSzqeDZEtWxhKI2GOA81ZafOuHXI+fgY35JgrTTjTYFtIuW8tq0etl6ZmuJ/ 0hw9BKZupW+41/AD+oCA+o6Ks9GEWsMKLXtsLCqYuBPIzzXHYKDtjjnFPo6ge01fQ/do Ud+gZdN/ASFC4IZh0VjwIlHREEJFTp9K7OB27iMG0UwKVpkodoWRDslYr7DnJic1asZv sZFl2TPm1WeLXEqaNKY+9Tg5jaeNtmX0j3FPNgwElEA1vDO7qklhpi6nsdmDfAxqdeQn XpWX41TUaqmdyWaw8Z1bG+ozzyyhOdkjr3Gg+oOy+ANFS29ayWOddv/LuIcYsPnQNTXN p31Q== X-Gm-Message-State: AOAM531EQdvpUwPbyW74MX2f7vQbW6DB+qftDQoDG94LjuMLX/d3Qws9 /MTRiw2xda0Gv9v01MhCTeEO5cQM/7iclCKl98dIIA== X-Google-Smtp-Source: ABdhPJzvRDFG7BoOZiy9coBum22wqezGCSC0O+U29RY5lD3y+GuATCwmUn+7GqLGOYRtTucrFFIslPSSuBYGYUaG5e4= X-Received: by 2002:a17:906:70cf:: with SMTP id g15mr3935941ejk.323.1604085788862; Fri, 30 Oct 2020 12:23:08 -0700 (PDT) MIME-Version: 1.0 References: <20201030100815.2269-1-daniel.vetter@ffwll.ch> <20201030100815.2269-16-daniel.vetter@ffwll.ch> In-Reply-To: <20201030100815.2269-16-daniel.vetter@ffwll.ch> From: Dan Williams Date: Fri, 30 Oct 2020 12:22:54 -0700 Message-ID: Subject: Re: [PATCH v5 15/15] PCI: Revoke mappings like devmem To: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc , Jan Kara , Kees Cook , KVM list , Jason Gunthorpe , John Hubbard , Linux PCI , LKML , DRI Development , Linux MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Greg Kroah-Hartman , Bjorn Helgaas , Daniel Vetter , Andrew Morton , Linux ARM , "Linux-media@vger.kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBPY3QgMzAsIDIwMjAgYXQgMzowOSBBTSBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0 dGVyQGZmd2xsLmNoPiB3cm90ZToKPgo+IFNpbmNlIDMyMzRhYzY2NGE4NyAoIi9kZXYvbWVtOiBS ZXZva2UgbWFwcGluZ3Mgd2hlbiBhIGRyaXZlciBjbGFpbXMKPiB0aGUgcmVnaW9uIikgL2Rldi9r bWVtIHphcHMgcHRlcyB3aGVuIHRoZSBrZXJuZWwgcmVxdWVzdHMgZXhjbHVzaXZlCj4gYWNjY2Vz cyB0byBhbiBpb21lbSByZWdpb24uIEFuZCB3aXRoIENPTkZJR19JT19TVFJJQ1RfREVWTUVNLCB0 aGlzIGlzCj4gdGhlIGRlZmF1bHQgZm9yIGFsbCBkcml2ZXIgdXNlcy4KPgo+IEV4Y2VwdCB0aGVy ZSdzIHR3byBtb3JlIHdheXMgdG8gYWNjZXNzIFBDSSBCQVJzOiBzeXNmcyBhbmQgcHJvYyBtbWFw Cj4gc3VwcG9ydC4gTGV0J3MgcGx1ZyB0aGF0IGhvbGUuCj4KPiBGb3IgcmV2b2tlX2Rldm1lbSgp IHRvIHdvcmsgd2UgbmVlZCB0byBsaW5rIG91ciB2bWEgaW50byB0aGUgc2FtZQo+IGFkZHJlc3Nf c3BhY2UsIHdpdGggY29uc2lzdGVudCB2bWEtPnZtX3Bnb2ZmLiAtPnBnb2ZmIGlzIGFscmVhZHkK PiBhZGp1c3RlZCwgYmVjYXVzZSB0aGF0J3MgaG93IChpb18pcmVtYXBfcGZuX3JhbmdlIHdvcmtz LCBidXQgZm9yIHRoZQo+IG1hcHBpbmcgd2UgbmVlZCB0byBhZGp1c3Qgdm1hLT52bV9maWxlLT5m X21hcHBpbmcuIFRoZSBjbGVhbmVzdCB3YXkgaXMKPiB0byBhZGp1c3QgdGhpcyBhdCBhdCAtPm9w ZW4gdGltZToKPgo+IC0gZm9yIHN5c2ZzIHRoaXMgaXMgZWFzeSwgbm93IHRoYXQgYmluYXJ5IGF0 dHJpYnV0ZXMgc3VwcG9ydCB0aGlzLiBXZQo+ICAganVzdCBzZXQgYmluX2F0dHItPm1hcHBpbmcg d2hlbiBtbWFwIGlzIHN1cHBvcnRlZAo+IC0gZm9yIHByb2NmcyBpdCdzIGEgYml0IG1vcmUgdHJp Y2t5LCBzaW5jZSBwcm9jZnMgcGNpIGFjY2VzcyBoYXMgb25seQo+ICAgb25lIGZpbGUgcGVyIGRl dmljZSwgYW5kIGFjY2VzcyB0byBhIHNwZWNpZmljIHJlc291cmNlcyBmaXJzdCBuZWVkcwo+ICAg dG8gYmUgc2V0IHVwIHdpdGggc29tZSBpb2N0bCBjYWxscy4gQnV0IG1tYXAgaXMgb25seSBzdXBw b3J0ZWQgZm9yCj4gICB0aGUgc2FtZSByZXNvdXJjZXMgYXMgc3lzZnMgZXhwb3NlcyB3aXRoIG1t YXAgc3VwcG9ydCwgYW5kIG90aGVyd2lzZQo+ICAgcmVqZWN0ZWQsIHNvIHdlIGNhbiBzZXQgdGhl IG1hcHBpbmcgdW5jb25kaXRpb25hbGx5IGF0IG9wZW4gdGltZQo+ICAgd2l0aG91dCBoYXJtLgo+ Cj4gQSBzcGVjaWFsIGNvbnNpZGVyYXRpb24gaXMgZm9yIGFyY2hfY2FuX3BjaV9tbWFwX2lvKCkg LSB3ZSBuZWVkIHRvCj4gbWFrZSBzdXJlIHRoYXQgdGhlIC0+Zl9tYXBwaW5nIGRvZXNuJ3QgYWxp YXMgYmV0d2VlbiBpb3BvcnQgYW5kIGlvbWVtCj4gc3BhY2UuIFRoZXJlJ3Mgb25seSAyIHdheXMg aW4tdHJlZSB0byBzdXBwb3J0IG1tYXAgb2YgaW9wb3J0czogZ2VuZXJpYwo+IHBjaSBtbWFwIChB UkNIX0dFTkVSSUNfUENJX01NQVBfUkVTT1VSQ0UpLCBhbmQgc3BhcmMgYXMgdGhlIHNpbmdsZQo+ IGFyY2hpdGVjdHVyZSBoYW5kLXJvbGxpbmcuIEJvdGggYXBwcm9hY2ggc3VwcG9ydCBpb3BvcnQg bW1hcCB0aHJvdWdoIGEKPiBzcGVjaWFsIHBmbiByYW5nZSBhbmQgbm90IHRocm91Z2ggbWFnaWMg cHRlIGF0dHJpYnV0ZXMuIEFsaWFzaW5nIGlzCj4gdGhlcmVmb3JlIG5vdCBhIHByb2JsZW0uCj4K PiBUaGUgb25seSBkaWZmZXJlbmNlIGluIGFjY2VzcyBjaGVja3MgbGVmdCBpcyB0aGF0IHN5c2Zz IFBDSSBtbWFwIGRvZXMKPiBub3QgY2hlY2sgZm9yIENBUF9SQVdJTy4gSSdtIG5vdCByZWFsbHkg c3VyZSB3aGV0aGVyIHRoYXQgc2hvdWxkIGJlCj4gYWRkZWQgb3Igbm90Lgo+Cj4gU2lnbmVkLW9m Zi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gQ2M6IEphc29u IEd1bnRob3JwZSA8amdnQHppZXBlLmNhPgo+IENjOiBLZWVzIENvb2sgPGtlZXNjb29rQGNocm9t aXVtLm9yZz4KPiBDYzogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4g Q2M6IEFuZHJldyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc+Cj4gQ2M6IEpvaG4g SHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KPiBDYzogSsOpcsO0bWUgR2xpc3NlIDxqZ2xp c3NlQHJlZGhhdC5jb20+Cj4gQ2M6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+Cj4gQ2M6IERhbiBX aWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPgoKTG9va3MgZ29vZCB0byBtZToKClJl dmlld2VkLWJ5OiBEYW4gV2lsbGlhbXMgPGRhbi5qLndpbGxpYW1zQGludGVsLmNvbT4KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==