From: Dan Williams <dan.j.williams@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Tejun Heo <tj@kernel.org>,
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Laurent Dufour <ldufour@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/4 v2] BDI lifetime fix
Date: Wed, 8 Feb 2017 08:00:26 -0800 [thread overview]
Message-ID: <CAPcyv4gk3HMFcxb3WTp-e+XkANH-KLofnaA2oKU7FpTOLs3T+g@mail.gmail.com> (raw)
In-Reply-To: <20170208102349.GA27541@quack2.suse.cz>
On Wed, Feb 8, 2017 at 2:23 AM, Jan Kara <jack@suse.cz> wrote:
> On Wed 08-02-17 08:51:42, Jan Kara wrote:
[..]
> <DETOUR BEGIN>
> This ordering seems to be the real culprit of the bdi name reuse problems
> Omar has reported? Same as described in commit 6cd18e711dd8 for MD BTW and
> Dan's patch could be IMHO replaced by a move of bdi_unregister() from
> blk_cleanup_queue() to del_gendisk() where it logically belongs as a
> counterpart of device_add_disk(). I'll test that.
> <DETOUR END>
I'd support that change. This is is why I called my fix "brute-force",
it just accommodated the existing problematic ordering.
prev parent reply other threads:[~2017-02-08 16:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 12:54 [PATCH 0/4 v2] BDI lifetime fix Jan Kara
2017-01-31 12:54 ` [PATCH 1/4] block: Unhash block device inodes on gendisk destruction Jan Kara
2017-02-01 9:48 ` Christoph Hellwig
2017-01-31 12:54 ` [PATCH 2/4] block: Use pointer to backing_dev_info from request_queue Jan Kara
2017-02-01 9:48 ` Christoph Hellwig
2017-01-31 12:54 ` [PATCH 3/4] block: Dynamically allocate and refcount backing_dev_info Jan Kara
2017-02-01 9:50 ` Christoph Hellwig
2017-02-01 12:22 ` Jan Kara
2017-02-01 22:45 ` Jens Axboe
2017-02-02 13:32 ` Jan Kara
2017-01-31 12:54 ` [PATCH 4/4] block: Make blk_get_backing_dev_info() safe without open bdev Jan Kara
2017-02-01 9:53 ` Christoph Hellwig
2017-02-01 12:28 ` Jan Kara
2017-02-01 12:52 ` Christoph Hellwig
2017-02-01 19:25 ` Dan Williams
2017-02-06 14:48 ` [PATCH 0/4 v2] BDI lifetime fix Thiago Jung Bauermann
2017-02-06 15:26 ` Thiago Jung Bauermann
2017-02-07 12:33 ` Jan Kara
2017-02-07 17:21 ` Tejun Heo
2017-02-08 7:51 ` Jan Kara
2017-02-08 10:23 ` Jan Kara
2017-02-08 16:00 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4gk3HMFcxb3WTp-e+XkANH-KLofnaA2oKU7FpTOLs3T+g@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=axboe@kernel.dk \
--cc=bauerman@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.