From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE33D72 for ; Fri, 20 Aug 2021 03:08:20 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id w6so5148694plg.9 for ; Thu, 19 Aug 2021 20:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=th+3o8zziVHjvxzUP987Ww05j4TcgD1JnSG4koxybv0=; b=q6wVy4gsAMeGwkQk1GUOlCv3RL83jjFdSVgzVK6FKAVlTxnluo0nxdXMv090oS+6v5 g/bsuD3TnVs6GjejENx6Ypc13QJi/TkgLHU9+HcG4DHRHbsowvEEqntPZXYalrUu+j31 syDAnCHyvx3HduCFB+iILfPCIv+IleAOlCNuCLhbaR1BW+2UQ0tOrUKFxEdC+UO92K1/ 4QLTyL7EAEUhfv9vEPkShzVSM6rjyvX4GxezOP/i3Yoj+vduXuzI5RGoQbgTNemm6050 3oyP1/6v7jPKCnfIP9AKLiBGwOOTQxTStdJIfOldCpt5V13LoApTXFCa0YTEXgvKOvuY g4MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=th+3o8zziVHjvxzUP987Ww05j4TcgD1JnSG4koxybv0=; b=A02CMfF5HOCJvYYLwhqKS2c40TwTvxsSOj7OiLj9DiUbrttI5TeWYd/UUADcmePb7E ywsqHCA5Yq4c3aK8J+4ZBwTW5O7tnehMGtAv5OEGpoQNbM+tTVv7fP5TNXOaVxxrAtKe uvbt60Yw3iVA/ibjUqbStyXJuh3EVQxZslv0a8k1UaVmi37Moi0T7Y4REJdcnZGDwCYA KmS1VH1wHmRAvCqf1N7IfF9jFfAFAs3IssvmPBCirpBBeEbJBSOUD9eo5C2Nvjh/5Jfl 3m3FNYFg5ndx3FS64D8v6W6Q9bDpyS9ctbs6eFSKAz3RERghMFDAdYRNTWZ5IG2u/eTP kccw== X-Gm-Message-State: AOAM533gxLezVtG8kt3x7FtvzAU/PfRy20ovI5bMSdQQXZVBZyBbnGgM UcFqvVqIoA2XpuVWH8ylMmVxXRalsZhNJoRo+Lo9IQ== X-Google-Smtp-Source: ABdhPJzbHC0+k8uuKZo5a6LFCnA40ZeG97Zg4M+zrZCKnhkWtnjKBCnLq4cagjtK6xI7c9K//8I6Ath0AByLrXcFmCU= X-Received: by 2002:a17:902:e54e:b0:12d:cca1:2c1f with SMTP id n14-20020a170902e54e00b0012dcca12c1fmr14381234plf.79.1629428900343; Thu, 19 Aug 2021 20:08:20 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210816060359.1442450-1-ruansy.fnst@fujitsu.com> <20210816060359.1442450-9-ruansy.fnst@fujitsu.com> In-Reply-To: <20210816060359.1442450-9-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Thu, 19 Aug 2021 20:08:09 -0700 Message-ID: Subject: Re: [PATCH v7 8/8] fs/xfs: Add dax dedupe support To: Shiyang Ruan Cc: "Darrick J. Wong" , Christoph Hellwig , linux-xfs , david , linux-fsdevel , Linux Kernel Mailing List , Linux NVDIMM , Goldwyn Rodrigues , Al Viro , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" On Sun, Aug 15, 2021 at 11:05 PM Shiyang Ruan wrote: > > Introduce xfs_mmaplock_two_inodes_and_break_dax_layout() for dax files > who are going to be deduped. After that, call compare range function > only when files are both DAX or not. > > Signed-off-by: Shiyang Ruan > Reviewed-by: Darrick J. Wong > --- > fs/xfs/xfs_file.c | 2 +- > fs/xfs/xfs_inode.c | 57 ++++++++++++++++++++++++++++++++++++++++++++ > fs/xfs/xfs_inode.h | 1 + > fs/xfs/xfs_reflink.c | 4 ++-- > 4 files changed, 61 insertions(+), 3 deletions(-) [..] > diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c > index 13e461cf2055..86c737c2baeb 100644 > --- a/fs/xfs/xfs_reflink.c > +++ b/fs/xfs/xfs_reflink.c > @@ -1327,8 +1327,8 @@ xfs_reflink_remap_prep( > if (XFS_IS_REALTIME_INODE(src) || XFS_IS_REALTIME_INODE(dest)) > goto out_unlock; > > - /* Don't share DAX file data for now. */ > - if (IS_DAX(inode_in) || IS_DAX(inode_out)) > + /* Don't share DAX file data with non-DAX file. */ > + if (IS_DAX(inode_in) != IS_DAX(inode_out)) > goto out_unlock; What if you have 2 DAX inodes sharing data and one is flipped to non-DAX? Does that operation need to first go undo all sharing? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F33E9C432BE for ; Fri, 20 Aug 2021 03:08:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6DD5610A5 for ; Fri, 20 Aug 2021 03:08:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238079AbhHTDI7 (ORCPT ); Thu, 19 Aug 2021 23:08:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237933AbhHTDI5 (ORCPT ); Thu, 19 Aug 2021 23:08:57 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9787C061756 for ; Thu, 19 Aug 2021 20:08:20 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id u11-20020a17090adb4b00b00181668a56d6so50214pjx.5 for ; Thu, 19 Aug 2021 20:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=th+3o8zziVHjvxzUP987Ww05j4TcgD1JnSG4koxybv0=; b=q6wVy4gsAMeGwkQk1GUOlCv3RL83jjFdSVgzVK6FKAVlTxnluo0nxdXMv090oS+6v5 g/bsuD3TnVs6GjejENx6Ypc13QJi/TkgLHU9+HcG4DHRHbsowvEEqntPZXYalrUu+j31 syDAnCHyvx3HduCFB+iILfPCIv+IleAOlCNuCLhbaR1BW+2UQ0tOrUKFxEdC+UO92K1/ 4QLTyL7EAEUhfv9vEPkShzVSM6rjyvX4GxezOP/i3Yoj+vduXuzI5RGoQbgTNemm6050 3oyP1/6v7jPKCnfIP9AKLiBGwOOTQxTStdJIfOldCpt5V13LoApTXFCa0YTEXgvKOvuY g4MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=th+3o8zziVHjvxzUP987Ww05j4TcgD1JnSG4koxybv0=; b=ot7AuhzDLQ2UASQR/Wk7kkOpOwy6m6YiztX83lE8gqq6wB48rng7BiKE6mtq/vOlf0 9/I4NLpV1l4xxRyw+UoDo+Ug29AV7hWSaDueks1uW4swgtuMDCkc56i9BmZhEjDhJJOq BfVadyZsTG8M1xFbRALeb6tEICF8aB8h17gUC2T8nwdUuyx6o4HcQVuK2ixS9Mmsr+aI htB2NhOoawhENF9pGtrRDK8TQiKV3gz4jc9GKWqX/sjWALdn0JfEW7Xe6dE7BRvRrigf yRizbaYZX3nLcH+WlLRu/A2Hq1EglRmXtxg6tkLA40857YvdhlmchKQNtUhiUMAR9q0e bdDA== X-Gm-Message-State: AOAM532X0vOv/e8gek5T/VLC1b40wZMsJeQlGRc083Kht2qaasrtfsyH K+z2LKgHuoGhwKh4reIa917L+gPO9BV7NGFwEA2HDw== X-Google-Smtp-Source: ABdhPJzbHC0+k8uuKZo5a6LFCnA40ZeG97Zg4M+zrZCKnhkWtnjKBCnLq4cagjtK6xI7c9K//8I6Ath0AByLrXcFmCU= X-Received: by 2002:a17:902:e54e:b0:12d:cca1:2c1f with SMTP id n14-20020a170902e54e00b0012dcca12c1fmr14381234plf.79.1629428900343; Thu, 19 Aug 2021 20:08:20 -0700 (PDT) MIME-Version: 1.0 References: <20210816060359.1442450-1-ruansy.fnst@fujitsu.com> <20210816060359.1442450-9-ruansy.fnst@fujitsu.com> In-Reply-To: <20210816060359.1442450-9-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Thu, 19 Aug 2021 20:08:09 -0700 Message-ID: Subject: Re: [PATCH v7 8/8] fs/xfs: Add dax dedupe support To: Shiyang Ruan Cc: "Darrick J. Wong" , Christoph Hellwig , linux-xfs , david , linux-fsdevel , Linux Kernel Mailing List , Linux NVDIMM , Goldwyn Rodrigues , Al Viro , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 15, 2021 at 11:05 PM Shiyang Ruan wrote: > > Introduce xfs_mmaplock_two_inodes_and_break_dax_layout() for dax files > who are going to be deduped. After that, call compare range function > only when files are both DAX or not. > > Signed-off-by: Shiyang Ruan > Reviewed-by: Darrick J. Wong > --- > fs/xfs/xfs_file.c | 2 +- > fs/xfs/xfs_inode.c | 57 ++++++++++++++++++++++++++++++++++++++++++++ > fs/xfs/xfs_inode.h | 1 + > fs/xfs/xfs_reflink.c | 4 ++-- > 4 files changed, 61 insertions(+), 3 deletions(-) [..] > diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c > index 13e461cf2055..86c737c2baeb 100644 > --- a/fs/xfs/xfs_reflink.c > +++ b/fs/xfs/xfs_reflink.c > @@ -1327,8 +1327,8 @@ xfs_reflink_remap_prep( > if (XFS_IS_REALTIME_INODE(src) || XFS_IS_REALTIME_INODE(dest)) > goto out_unlock; > > - /* Don't share DAX file data for now. */ > - if (IS_DAX(inode_in) || IS_DAX(inode_out)) > + /* Don't share DAX file data with non-DAX file. */ > + if (IS_DAX(inode_in) != IS_DAX(inode_out)) > goto out_unlock; What if you have 2 DAX inodes sharing data and one is flipped to non-DAX? Does that operation need to first go undo all sharing?