From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=3.0 tests=BAYES_50,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA01C433C1 for ; Mon, 29 Mar 2021 23:24:37 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFE0D6196C for ; Mon, 29 Mar 2021 23:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFE0D6196C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C1F00100EBB98; Mon, 29 Mar 2021 16:24:36 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::630; helo=mail-ej1-x630.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F78E100EBB8F for ; Mon, 29 Mar 2021 16:24:32 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id u9so21950570ejj.7 for ; Mon, 29 Mar 2021 16:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XF4To2Y7zgtF2QAVYiT7BBwCvauONTod77W3/2lXGW8=; b=Vsx9drBV7ccArQSqmDPqC+lTIb/A77ziMCx5iPDxYzAHz5bdXrgSzOciH2G+olKEzH JH+aiwgu7Hdc7Js/CFjZeYUNpwx0+EJ4WO1eE2x1fsFGzMOLBuWvUcrIpPIC/BzArvmG SoSbsrr1a84pxS45T+LCHCPrZ4YT1EgHckSDx8IT4d9M/APuB7pnuC8BPH8hgLx1YKnX 8mmS8RFApDIqRbHB5XlYzw5cDHp5hIR3/bxLlGci8wVKnPeuvAPgpq7rHtbNCE/aUyzk mUztjRYlXDhIeGmczBxkjzDSdIyVqVIUQsrF4xS7Qy5pZtzbw/waLYA0DM0/VC+iNd0Y Zt3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XF4To2Y7zgtF2QAVYiT7BBwCvauONTod77W3/2lXGW8=; b=OF6RbvslAQBHGalnjg+DrXCup6HgtvLpfQufSjuE/lcFgSuEZMJ/lAxNuYaL8qeEEB dZv2PzeThgpDp+11X4U2D6h8vFahx2gVQD45YhlIWiIy2WQgIqXbKLXbjGLRnbZ0y+TS 6ax2y3zH+m8+/FSXgzmHd0GveihNS4QS0uTQ0neCihG4RPKiBzMJLoRPqwvbN9kLUWVX WwwO6rb1CzH4XboRfCiYhaJk9DCAyvjDlax8E9KlbeJM6hV5D2kNgEtHxl5X06o+Bmt6 tpgzCbtj7Wn7Uz+WS2rzI7I0NOLOOsGsEEkve9Pwq1LkwS4qTFUlksBu4ltZ9Q5K71cd kbkQ== X-Gm-Message-State: AOAM5329MzgsxSbtoO7iCWvHLw3M0UuMfGXhxBXnw6m+HLYQwMc8FawR 5F43l8Tb/a0vOJRn+3JPQvsgbmwUQt5H5fvCVklDEQ== X-Google-Smtp-Source: ABdhPJzf7VrSfLTELhnrW6mwobm/98+lZofBo3iswIzq94rBp2GFqTi32x/lL+dUXpEu98/zFDAR5BEkXvlHn9IcDz4= X-Received: by 2002:a17:906:ae88:: with SMTP id md8mr29769425ejb.264.1617060270344; Mon, 29 Mar 2021 16:24:30 -0700 (PDT) MIME-Version: 1.0 References: <161604048257.1463742.1374527716381197629.stgit@dwillia2-desk3.amr.corp.intel.com> <161604050866.1463742.7759521510383551055.stgit@dwillia2-desk3.amr.corp.intel.com> <66514812-6a24-8e2e-7be5-c61e188fecc4@oracle.com> <20210325143419.GK2710221@ziepe.ca> In-Reply-To: <20210325143419.GK2710221@ziepe.ca> From: Dan Williams Date: Mon, 29 Mar 2021 16:24:19 -0700 Message-ID: Subject: Re: [PATCH 3/3] mm/devmap: Remove pgmap accounting in the get_user_pages_fast() path To: Jason Gunthorpe Message-ID-Hash: ALWSP4RA4RGS7AJ2L76Q3UC2AZ437JEZ X-Message-ID-Hash: ALWSP4RA4RGS7AJ2L76Q3UC2AZ437JEZ X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Joao Martins , Christoph Hellwig , Shiyang Ruan , Matthew Wilcox , Jan Kara , Andrew Morton , david , linux-fsdevel , Linux Kernel Mailing List , Linux MM , linux-nvdimm X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Mar 25, 2021 at 7:34 AM Jason Gunthorpe wrote: > > On Thu, Mar 18, 2021 at 10:03:06AM -0700, Dan Williams wrote: > > Yes. I still need to answer the question of whether mapping > > invalidation triggers longterm pin holders to relinquish their hold, > > but that's a problem regardless of whether gup-fast is supported or > > not. > > It does not, GUP users do not interact with addres_space or mmu > notifiers > Ok, but the SIGKILL from the memory_failure() will drop the pin? Can memory_failure() find the right processes to kill if the memory registration has been passed by SCM_RIGHTS? _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAD1C433E0 for ; Mon, 29 Mar 2021 23:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAE236196C for ; Mon, 29 Mar 2021 23:25:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229950AbhC2XYv (ORCPT ); Mon, 29 Mar 2021 19:24:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230248AbhC2XYc (ORCPT ); Mon, 29 Mar 2021 19:24:32 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BAD9C061764 for ; Mon, 29 Mar 2021 16:24:31 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id kt15so21930413ejb.12 for ; Mon, 29 Mar 2021 16:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XF4To2Y7zgtF2QAVYiT7BBwCvauONTod77W3/2lXGW8=; b=Vsx9drBV7ccArQSqmDPqC+lTIb/A77ziMCx5iPDxYzAHz5bdXrgSzOciH2G+olKEzH JH+aiwgu7Hdc7Js/CFjZeYUNpwx0+EJ4WO1eE2x1fsFGzMOLBuWvUcrIpPIC/BzArvmG SoSbsrr1a84pxS45T+LCHCPrZ4YT1EgHckSDx8IT4d9M/APuB7pnuC8BPH8hgLx1YKnX 8mmS8RFApDIqRbHB5XlYzw5cDHp5hIR3/bxLlGci8wVKnPeuvAPgpq7rHtbNCE/aUyzk mUztjRYlXDhIeGmczBxkjzDSdIyVqVIUQsrF4xS7Qy5pZtzbw/waLYA0DM0/VC+iNd0Y Zt3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XF4To2Y7zgtF2QAVYiT7BBwCvauONTod77W3/2lXGW8=; b=gNMK9thvbJ7uRM3dgXfuC5MZ8SF/Fi4RaaVIQ0Vzuos03CV7LwtMcjVy0eZYHqa9Dn 6ROflvcYNdPzrGFb4tUs1S8iX7ge9P6eldLOJ6b0AVdW+IDQQPbNf2qqc7Z5g1YfKCxJ QfBMzrZP3Bqri9F3zzABl56ifDSIEHT2I40ezdMqOPD3llec/Ncku7cFZjbQndJlnwO4 TdMj8PQTQUmmno7bvt7t2GiufD4WorcYsTK/+M9FWQVIuPVlYp6sBl+hHp5GjP0/ovmj MMK2hqSXjPBLP1Kn1WAkfk7Wek7mUyWluxCMeLwc2gJpPACswgDgiDsrbxhxzphuRWaF MU8w== X-Gm-Message-State: AOAM532om1+ycekkJ9EI6lv7S00pZQ+MwUXHpV4J5faBuBjXEqBKvc5n 5Qd7Ih4Gwl46QmrZAErHFj9wPULVbLwpcl5oK/ZjlQ== X-Google-Smtp-Source: ABdhPJzf7VrSfLTELhnrW6mwobm/98+lZofBo3iswIzq94rBp2GFqTi32x/lL+dUXpEu98/zFDAR5BEkXvlHn9IcDz4= X-Received: by 2002:a17:906:ae88:: with SMTP id md8mr29769425ejb.264.1617060270344; Mon, 29 Mar 2021 16:24:30 -0700 (PDT) MIME-Version: 1.0 References: <161604048257.1463742.1374527716381197629.stgit@dwillia2-desk3.amr.corp.intel.com> <161604050866.1463742.7759521510383551055.stgit@dwillia2-desk3.amr.corp.intel.com> <66514812-6a24-8e2e-7be5-c61e188fecc4@oracle.com> <20210325143419.GK2710221@ziepe.ca> In-Reply-To: <20210325143419.GK2710221@ziepe.ca> From: Dan Williams Date: Mon, 29 Mar 2021 16:24:19 -0700 Message-ID: Subject: Re: [PATCH 3/3] mm/devmap: Remove pgmap accounting in the get_user_pages_fast() path To: Jason Gunthorpe Cc: Joao Martins , Christoph Hellwig , Shiyang Ruan , Vishal Verma , Dave Jiang , Ira Weiny , Matthew Wilcox , Jan Kara , Andrew Morton , david , linux-fsdevel , Linux Kernel Mailing List , Linux MM , linux-nvdimm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 7:34 AM Jason Gunthorpe wrote: > > On Thu, Mar 18, 2021 at 10:03:06AM -0700, Dan Williams wrote: > > Yes. I still need to answer the question of whether mapping > > invalidation triggers longterm pin holders to relinquish their hold, > > but that's a problem regardless of whether gup-fast is supported or > > not. > > It does not, GUP users do not interact with addres_space or mmu > notifiers > Ok, but the SIGKILL from the memory_failure() will drop the pin? Can memory_failure() find the right processes to kill if the memory registration has been passed by SCM_RIGHTS? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B639C433C1 for ; Mon, 29 Mar 2021 23:24:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F26F761990 for ; Mon, 29 Mar 2021 23:24:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F26F761990 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 698E96B007D; Mon, 29 Mar 2021 19:24:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66EB86B007E; Mon, 29 Mar 2021 19:24:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53A766B0080; Mon, 29 Mar 2021 19:24:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 36FB96B007D for ; Mon, 29 Mar 2021 19:24:32 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E8DEE181AF5C6 for ; Mon, 29 Mar 2021 23:24:31 +0000 (UTC) X-FDA: 77974493142.34.07107C0 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf12.hostedemail.com (Postfix) with ESMTP id E81FA130 for ; Mon, 29 Mar 2021 23:24:28 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id r12so21964761ejr.5 for ; Mon, 29 Mar 2021 16:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XF4To2Y7zgtF2QAVYiT7BBwCvauONTod77W3/2lXGW8=; b=Vsx9drBV7ccArQSqmDPqC+lTIb/A77ziMCx5iPDxYzAHz5bdXrgSzOciH2G+olKEzH JH+aiwgu7Hdc7Js/CFjZeYUNpwx0+EJ4WO1eE2x1fsFGzMOLBuWvUcrIpPIC/BzArvmG SoSbsrr1a84pxS45T+LCHCPrZ4YT1EgHckSDx8IT4d9M/APuB7pnuC8BPH8hgLx1YKnX 8mmS8RFApDIqRbHB5XlYzw5cDHp5hIR3/bxLlGci8wVKnPeuvAPgpq7rHtbNCE/aUyzk mUztjRYlXDhIeGmczBxkjzDSdIyVqVIUQsrF4xS7Qy5pZtzbw/waLYA0DM0/VC+iNd0Y Zt3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XF4To2Y7zgtF2QAVYiT7BBwCvauONTod77W3/2lXGW8=; b=BHzdAXGiQZDs4V1nvpTKHaJZPohUeYc1Sfg7SqGPJFDeTp+WtCtSqK4ooJCmfbDfOg p1OFvRSIF12wTYxF+ljqhvUUb7USabY9ztBWE4/8u/JH/y+einrKbh0289JMRHMAkJUK lCDD/RbA5kXBP8ipkLeQrUZraCAUJUIVJugGdJV8vjVDbPjrtFFzmiiVur7GfwRsEyv4 5qeU0ZdkLw0GL1Jtgjz8uCXlKCyXYP829YgRjtscXUTkecqIt9kTfScfctylJnRZx4ii D6lI5hxdfG+61r11m2QnTTvNxyCKQGBWTIE5WeNhV/FlQdZponBmH/qOPTMlj4PXhGXe xo/g== X-Gm-Message-State: AOAM532q8CS97vFZAmO5yZMq6/2miG3M+uiBJpn1pDRGiNWZvpsUxrQV lchLPIFEMLQXP5nZ3EnM5f5D9jwT0i1q93+Kz8iYCQ== X-Google-Smtp-Source: ABdhPJzf7VrSfLTELhnrW6mwobm/98+lZofBo3iswIzq94rBp2GFqTi32x/lL+dUXpEu98/zFDAR5BEkXvlHn9IcDz4= X-Received: by 2002:a17:906:ae88:: with SMTP id md8mr29769425ejb.264.1617060270344; Mon, 29 Mar 2021 16:24:30 -0700 (PDT) MIME-Version: 1.0 References: <161604048257.1463742.1374527716381197629.stgit@dwillia2-desk3.amr.corp.intel.com> <161604050866.1463742.7759521510383551055.stgit@dwillia2-desk3.amr.corp.intel.com> <66514812-6a24-8e2e-7be5-c61e188fecc4@oracle.com> <20210325143419.GK2710221@ziepe.ca> In-Reply-To: <20210325143419.GK2710221@ziepe.ca> From: Dan Williams Date: Mon, 29 Mar 2021 16:24:19 -0700 Message-ID: Subject: Re: [PATCH 3/3] mm/devmap: Remove pgmap accounting in the get_user_pages_fast() path To: Jason Gunthorpe Cc: Joao Martins , Christoph Hellwig , Shiyang Ruan , Vishal Verma , Dave Jiang , Ira Weiny , Matthew Wilcox , Jan Kara , Andrew Morton , david , linux-fsdevel , Linux Kernel Mailing List , Linux MM , linux-nvdimm Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: kk5zsqccytpdundd8xckxkwx6bnyftac X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E81FA130 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=mail-ej1-f51.google.com; client-ip=209.85.218.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617060268-226350 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 25, 2021 at 7:34 AM Jason Gunthorpe wrote: > > On Thu, Mar 18, 2021 at 10:03:06AM -0700, Dan Williams wrote: > > Yes. I still need to answer the question of whether mapping > > invalidation triggers longterm pin holders to relinquish their hold, > > but that's a problem regardless of whether gup-fast is supported or > > not. > > It does not, GUP users do not interact with addres_space or mmu > notifiers > Ok, but the SIGKILL from the memory_failure() will drop the pin? Can memory_failure() find the right processes to kill if the memory registration has been passed by SCM_RIGHTS?