From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932293AbbCaPR7 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 Mar 2015 11:17:59 -0400
Received: from mail-wi0-f180.google.com ([209.85.212.180]:38371 "EHLO
	mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754889AbbCaPRx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 Mar 2015 11:17:53 -0400
MIME-Version: 1.0
In-Reply-To: <551AA0AD.4000604@plexistor.com>
References: <1427358764-6126-1-git-send-email-hch@lst.de>
	<55143A8B.2060304@plexistor.com>
	<20150331092526.GA25958@lst.de>
	<551A9EB3.8000605@plexistor.com>
	<551AA0AD.4000604@plexistor.com>
Date: Tue, 31 Mar 2015 08:17:51 -0700
Message-ID: <CAPcyv4hLL0o2DHtFhBeBdZ-B5zYjXYBBbp-Xn70UMgoO-kB8vA@mail.gmail.com>
Subject: Re: [Linux-nvdimm] [PATCH 4/6] SQUSHME: pmem: Micro cleaning
From: Dan Williams <dan.j.williams@intel.com>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        linux-nvdimm <linux-nvdimm@ml01.01.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 31, 2015 at 6:27 AM, Boaz Harrosh <boaz@plexistor.com> wrote:
>
> Some error checks had unlikely some did not. Put unlikely
> on all error handling paths.
> (I like unlikely for error paths specially for readability)

"unlikely()" is not a readability hint, it's specifically for branches
that profiling shows adding it makes a difference.  Just delete them
all until profiling show they make a difference.  They certainly don't
make a difference in the slow paths.