From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14AA3C33CB1 for ; Wed, 15 Jan 2020 06:02:51 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D65172187F for ; Wed, 15 Jan 2020 06:02:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="HNS/MuCy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D65172187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 29E3710097DC2; Tue, 14 Jan 2020 22:06:09 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::244; helo=mail-oi1-x244.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 803DB10097DBE for ; Tue, 14 Jan 2020 22:06:06 -0800 (PST) Received: by mail-oi1-x244.google.com with SMTP id c77so14313891oib.7 for ; Tue, 14 Jan 2020 22:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WyKlBkScoVZ6BBeE/lvKOUnxM2fwU6k2+3ORlYeQ1JU=; b=HNS/MuCyM2Y0rPTycj0ERFuxRvMu1QHpp95g6CP0C2mcOOP17W3rjfRnyo8mZNws9l Bcv17zUUAkkGTvOLwd1IP1Q6kQdxkNC/BtRTUsWN9in2f4VRO4DjkljU1DghPGI42WVQ jUuVLY3zCBFOvviuNPlx0NRWZKXOYYWOD0An0XLByT1bn95S8DuHxEUEKSnrL30YhlyT +h+l0ymO2e0tgatyf84uKe0HDE06uZYrHOHGYewqXSfc7NmSlTYA6qssHrbd2ft+e7BG Ov/+58wifUZ6rKsf/zQwYB50hnJMVNNyZF84Dl5dZNk3GBE3TR4AQ7f8vv5m0rnBpM3q yzGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WyKlBkScoVZ6BBeE/lvKOUnxM2fwU6k2+3ORlYeQ1JU=; b=rjQSJY8kN68RHFX1AJQhag20xrLtf6PTviza9LdFiwlpnyF5Wus0IkMr4RGVAOM8GJ I3IHiKmgsowtb3lUSFPqSfpM1zjt/iC4gUh/lIgR1QM/kecX/MwyYxu1z8gmuJYR67gP 4LqhabJ+P9TcX2nkOkRCLSVZDtthicicSC3UZyjLr0kDV129Ozm4P7neFBGvhpkArWrb pMZVCdadeamGBpJrGysHxZrl52AiOZ7ly76KD6NGjg5SaBHS7p2lvg/H+nuClGKx7rHr hvdObsYWZzh3QJ86Ntic+pMNqRWTrPgYxZgnMhO76OrHmOCtFj+QxpM3CY4OMWwnNz6j Kn2g== X-Gm-Message-State: APjAAAUDiqtnFuPXrnkf2Qgb2+pVl+3XS6wofN6SMmByWzIcACPWe5TJ LQDPCNbQ2Z1oul0acK+ImBmrPCndQniKoII5lrzK0A== X-Google-Smtp-Source: APXvYqzeuAG8OGRFPj/VxBeMJvbxWakGlATFxZiTEHM5ApidHx987T6zad1F65AWRIeqz6hwenMYEqMe9i/yHCxcJeM= X-Received: by 2002:a05:6808:b37:: with SMTP id t23mr20144974oij.149.1579068165602; Tue, 14 Jan 2020 22:02:45 -0800 (PST) MIME-Version: 1.0 References: <20191225054227.gii6ctjkuddjnprs@xzhoux.usersys.redhat.com> In-Reply-To: <20191225054227.gii6ctjkuddjnprs@xzhoux.usersys.redhat.com> From: Dan Williams Date: Tue, 14 Jan 2020 22:02:34 -0800 Message-ID: Subject: Re: [PATCH] mm: get rid of WARN if failed to cow user pages To: Murphy Zhou Message-ID-Hash: INW7MIJAQ3VZQ4QXPDGEDPFXKOOY557R X-Message-ID-Hash: INW7MIJAQ3VZQ4QXPDGEDPFXKOOY557R X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-nvdimm , Jia He , Linux MM , "Shutemov, Kirill" , Linux Kernel Mailing List X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit [ drop Ross, add Kirill, linux-mm, and lkml ] On Tue, Dec 24, 2019 at 9:42 PM Murphy Zhou wrote: > > By running xfstests with fsdax enabled, generic/437 always hits this > warning[1] since this commit: > > commit 83d116c53058d505ddef051e90ab27f57015b025 > Author: Jia He > Date: Fri Oct 11 22:09:39 2019 +0800 > > mm: fix double page fault on arm64 if PTE_AF is cleared > > Looking at the test program[2] generic/437 uses, it's pretty easy > to hit this warning. Remove this WARN as it seems not necessary. This is not sufficient justification. Does this same test fail without DAX? If not, why not? At a minimum you need to explain why this is not indicating a problem. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6648C33CB1 for ; Wed, 15 Jan 2020 06:02:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CB092187F for ; Wed, 15 Jan 2020 06:02:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="HNS/MuCy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729066AbgAOGCr (ORCPT ); Wed, 15 Jan 2020 01:02:47 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:39836 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbgAOGCq (ORCPT ); Wed, 15 Jan 2020 01:02:46 -0500 Received: by mail-oi1-f193.google.com with SMTP id a67so14337929oib.6 for ; Tue, 14 Jan 2020 22:02:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WyKlBkScoVZ6BBeE/lvKOUnxM2fwU6k2+3ORlYeQ1JU=; b=HNS/MuCyM2Y0rPTycj0ERFuxRvMu1QHpp95g6CP0C2mcOOP17W3rjfRnyo8mZNws9l Bcv17zUUAkkGTvOLwd1IP1Q6kQdxkNC/BtRTUsWN9in2f4VRO4DjkljU1DghPGI42WVQ jUuVLY3zCBFOvviuNPlx0NRWZKXOYYWOD0An0XLByT1bn95S8DuHxEUEKSnrL30YhlyT +h+l0ymO2e0tgatyf84uKe0HDE06uZYrHOHGYewqXSfc7NmSlTYA6qssHrbd2ft+e7BG Ov/+58wifUZ6rKsf/zQwYB50hnJMVNNyZF84Dl5dZNk3GBE3TR4AQ7f8vv5m0rnBpM3q yzGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WyKlBkScoVZ6BBeE/lvKOUnxM2fwU6k2+3ORlYeQ1JU=; b=b6kUyGbWdEwDsUY9+XmvTnR1qV1J86FRTu3Z3DplPWpHRJZ5sRUIioDpw3wY0bfavg kD0Ijy9xrKRKfET0gajTJmbpUNvP2CsBYsi4jRawv2xXGh/X2neP6yDHwDe+UsxsQB0t foI3z3SD33t/15hLGwT0cVpCdHZSmRlJuLn0fkARR54clifxpSLPwp/XUhYNl++ypB8k Ayy0gQKO17uMayOmKAjk80K/+sOymx81qPIC0YrJxy60au9i1eKMudUuY5j/Wo7+7+8U wdnFo60RboDyyje7k3sg4RarW8h2xm8iVQzt4oW4TGd3lYXMoRSQEp7BZwCegRh/GWh2 M0Rw== X-Gm-Message-State: APjAAAW+olgRO95zQJLPEl8JPTv+sGxUW3+3hr062CUBHa6943ybOE9f +TD8cG1+qUu3ltWhpgkHR9OuZ0AHKXlPWIy+fu0S7B7q X-Google-Smtp-Source: APXvYqzeuAG8OGRFPj/VxBeMJvbxWakGlATFxZiTEHM5ApidHx987T6zad1F65AWRIeqz6hwenMYEqMe9i/yHCxcJeM= X-Received: by 2002:a05:6808:b37:: with SMTP id t23mr20144974oij.149.1579068165602; Tue, 14 Jan 2020 22:02:45 -0800 (PST) MIME-Version: 1.0 References: <20191225054227.gii6ctjkuddjnprs@xzhoux.usersys.redhat.com> In-Reply-To: <20191225054227.gii6ctjkuddjnprs@xzhoux.usersys.redhat.com> From: Dan Williams Date: Tue, 14 Jan 2020 22:02:34 -0800 Message-ID: Subject: Re: [PATCH] mm: get rid of WARN if failed to cow user pages To: Murphy Zhou Cc: linux-nvdimm , Jia He , Linux MM , "Shutemov, Kirill" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ drop Ross, add Kirill, linux-mm, and lkml ] On Tue, Dec 24, 2019 at 9:42 PM Murphy Zhou wrote: > > By running xfstests with fsdax enabled, generic/437 always hits this > warning[1] since this commit: > > commit 83d116c53058d505ddef051e90ab27f57015b025 > Author: Jia He > Date: Fri Oct 11 22:09:39 2019 +0800 > > mm: fix double page fault on arm64 if PTE_AF is cleared > > Looking at the test program[2] generic/437 uses, it's pretty easy > to hit this warning. Remove this WARN as it seems not necessary. This is not sufficient justification. Does this same test fail without DAX? If not, why not? At a minimum you need to explain why this is not indicating a problem. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EEF2C33CB3 for ; Wed, 15 Jan 2020 06:02:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C9BDF2187F for ; Wed, 15 Jan 2020 06:02:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="HNS/MuCy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9BDF2187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6703E8E0005; Wed, 15 Jan 2020 01:02:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 620948E0003; Wed, 15 Jan 2020 01:02:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 536668E0005; Wed, 15 Jan 2020 01:02:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 3A7FA8E0003 for ; Wed, 15 Jan 2020 01:02:48 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id E697A34A4 for ; Wed, 15 Jan 2020 06:02:47 +0000 (UTC) X-FDA: 76378824774.11.sea46_183aa3059931d X-HE-Tag: sea46_183aa3059931d X-Filterd-Recvd-Size: 3518 Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jan 2020 06:02:46 +0000 (UTC) Received: by mail-oi1-f195.google.com with SMTP id v140so14361917oie.0 for ; Tue, 14 Jan 2020 22:02:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WyKlBkScoVZ6BBeE/lvKOUnxM2fwU6k2+3ORlYeQ1JU=; b=HNS/MuCyM2Y0rPTycj0ERFuxRvMu1QHpp95g6CP0C2mcOOP17W3rjfRnyo8mZNws9l Bcv17zUUAkkGTvOLwd1IP1Q6kQdxkNC/BtRTUsWN9in2f4VRO4DjkljU1DghPGI42WVQ jUuVLY3zCBFOvviuNPlx0NRWZKXOYYWOD0An0XLByT1bn95S8DuHxEUEKSnrL30YhlyT +h+l0ymO2e0tgatyf84uKe0HDE06uZYrHOHGYewqXSfc7NmSlTYA6qssHrbd2ft+e7BG Ov/+58wifUZ6rKsf/zQwYB50hnJMVNNyZF84Dl5dZNk3GBE3TR4AQ7f8vv5m0rnBpM3q yzGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WyKlBkScoVZ6BBeE/lvKOUnxM2fwU6k2+3ORlYeQ1JU=; b=eG+bAct6lxXLuwmqxGa76uxZiezELJ7eOcpiBXmZtHd27umI5t44WwXx0aK1Ge+DKS f7IbXnf/j72Ymq3cALC9u712yL9yhEanPoL7rCXoKkuJIduVlyCl9XvD4iptVJjEAHmi w5sJ23gcY424QAH/O4n5MEAmubZsE1kHQy9Uv+/hVt3w+o7qQ9ypIN9GlYQFD20i4m8i 978Ux60Le47+Y7Ecdqk72Cqae4KAaUNR7fEZ95GmLlVoYD8zNVGKFcsamW82E24zhiuA q2PqG7P+qgOabZYQthpUMxO+ggoeXZWMfROgsa5zgrSsEut+dizKBuRT0/Gtd/+QmbWu kYfg== X-Gm-Message-State: APjAAAXg1DmR5/KSttoiE3xqADezNmRWYI+2mS84AmZ6yNljMgwhq3Ch CgoKMJP2i1yOWD7zq4oE+eakKuUJBSoD1AnrVCc1cQ== X-Google-Smtp-Source: APXvYqzeuAG8OGRFPj/VxBeMJvbxWakGlATFxZiTEHM5ApidHx987T6zad1F65AWRIeqz6hwenMYEqMe9i/yHCxcJeM= X-Received: by 2002:a05:6808:b37:: with SMTP id t23mr20144974oij.149.1579068165602; Tue, 14 Jan 2020 22:02:45 -0800 (PST) MIME-Version: 1.0 References: <20191225054227.gii6ctjkuddjnprs@xzhoux.usersys.redhat.com> In-Reply-To: <20191225054227.gii6ctjkuddjnprs@xzhoux.usersys.redhat.com> From: Dan Williams Date: Tue, 14 Jan 2020 22:02:34 -0800 Message-ID: Subject: Re: [PATCH] mm: get rid of WARN if failed to cow user pages To: Murphy Zhou Cc: linux-nvdimm , Jia He , Linux MM , "Shutemov, Kirill" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [ drop Ross, add Kirill, linux-mm, and lkml ] On Tue, Dec 24, 2019 at 9:42 PM Murphy Zhou wrote: > > By running xfstests with fsdax enabled, generic/437 always hits this > warning[1] since this commit: > > commit 83d116c53058d505ddef051e90ab27f57015b025 > Author: Jia He > Date: Fri Oct 11 22:09:39 2019 +0800 > > mm: fix double page fault on arm64 if PTE_AF is cleared > > Looking at the test program[2] generic/437 uses, it's pretty easy > to hit this warning. Remove this WARN as it seems not necessary. This is not sufficient justification. Does this same test fail without DAX? If not, why not? At a minimum you need to explain why this is not indicating a problem.