On Wed, Jul 4, 2018 at 6:07 AM, Huaisheng Ye wrote: > ---- On Wed, 04 Jul 2018 19:30:12 +0800 Jan Kara wrote ---- > > On Wed 04-07-18 14:40:58, Huaisheng Ye wrote: > > > From: Huaisheng Ye > > > > > > Some functions within fs/dax don't need to get gfn from direct_access. > > > Assigning NULL to gfn of dax_direct_access is more intuitive and simple > > > than offering a useless local variable. > > > > > > Signed-off-by: Huaisheng Ye > > > > I like this. You can add: > > > > Reviewed-by: Jan Kara > > > > for the series. > > > > Honza > > > I am so happy you like them, thank you very much. Yes, I like this too. In fact I have a similar patch in my tree already that I have been preparing to send out. I am using it to delay when we need to have the 'struct page' memmap for dax initialized. Attached is the full patch, but the series is still a work in progress.