From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x244.google.com (mail-oi0-x244.google.com [IPv6:2607:f8b0:4003:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E301202E5CFD for ; Fri, 20 Oct 2017 21:12:43 -0700 (PDT) Received: by mail-oi0-x244.google.com with SMTP id h200so23261966oib.4 for ; Fri, 20 Oct 2017 21:16:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20171021032008.GA27694@bombadil.infradead.org> References: <150846713528.24336.4459262264611579791.stgit@dwillia2-desk3.amr.corp.intel.com> <150846714747.24336.14704246566580871364.stgit@dwillia2-desk3.amr.corp.intel.com> <20171020075735.GA14378@lst.de> <20171020162933.GA26320@lst.de> <20171021032008.GA27694@bombadil.infradead.org> From: Dan Williams Date: Fri, 20 Oct 2017 21:16:21 -0700 Message-ID: Subject: Re: [PATCH v3 02/13] dax: require 'struct page' for filesystem dax List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Matthew Wilcox Cc: Jan Kara , "linux-nvdimm@lists.01.org" , Benjamin Herrenschmidt , Heiko Carstens , "linux-kernel@vger.kernel.org" , linux-xfs@vger.kernel.org, Linux MM , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , linux-fsdevel , Andrew Morton , Christoph Hellwig , Gerald Schaefer List-ID: On Fri, Oct 20, 2017 at 8:20 PM, Matthew Wilcox wrote: > On Fri, Oct 20, 2017 at 03:29:57PM -0700, Dan Williams wrote: >> Ok, I'd also like to kill DAX support in the brd driver. It's a source >> of complexity and maintenance burden for zero benefit. It's the only >> ->direct_access() implementation that sleeps and it's the only >> implementation where there is a non-linear relationship between >> sectors and pfns. Having a 1:1 sector to pfn relationship will help >> with the dma-extent-busy management since we don't need to keep >> calling into the driver to map pfns back to sectors once we know the >> pfn[0] sector[0] relationship. > > But these are important things that other block devices may / will want. > > For example, I think it's entirely sensible to support ->direct_access > for RAID-0. Dell are looking at various different options for having > one pmemX device per DIMM and using RAID to lash them together. > ->direct_access makes no sense for RAID-5 or RAID-1, but RAID-0 makes > sense to me. > > Last time we tried to take sleeping out, there were grumblings from people > with network block devices who thought they'd want to bring pages in > across the network. I'm a bit less sympathetic to this because I don't > know anyone actively working on it, but the RAID-0 case is something I > think we should care about. True, good point. In fact we already support device-mapper striping with ->direct_access(). I'd still like to go ahead with the sleeping removal. When those folks come back and add network direct_access they can do the hard work of figuring out cases where we need to call direct_access in atomic contexts. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751062AbdJUEQZ (ORCPT ); Sat, 21 Oct 2017 00:16:25 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:46678 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbdJUEQX (ORCPT ); Sat, 21 Oct 2017 00:16:23 -0400 X-Google-Smtp-Source: ABhQp+TZ6njbeMZLnZBc7Aa2gzxqnF9PTmLNCIqSi0DWBcj1LNvOKtwGPrlOm9hXrVFmDQCw9vs14XDCKaeFgPkHvEI= MIME-Version: 1.0 In-Reply-To: <20171021032008.GA27694@bombadil.infradead.org> References: <150846713528.24336.4459262264611579791.stgit@dwillia2-desk3.amr.corp.intel.com> <150846714747.24336.14704246566580871364.stgit@dwillia2-desk3.amr.corp.intel.com> <20171020075735.GA14378@lst.de> <20171020162933.GA26320@lst.de> <20171021032008.GA27694@bombadil.infradead.org> From: Dan Williams Date: Fri, 20 Oct 2017 21:16:21 -0700 Message-ID: Subject: Re: [PATCH v3 02/13] dax: require 'struct page' for filesystem dax To: Matthew Wilcox Cc: Christoph Hellwig , Andrew Morton , Jan Kara , "linux-nvdimm@lists.01.org" , Benjamin Herrenschmidt , Heiko Carstens , "linux-kernel@vger.kernel.org" , linux-xfs@vger.kernel.org, Linux MM , Jeff Moyer , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , linux-fsdevel , Ross Zwisler , Gerald Schaefer Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 20, 2017 at 8:20 PM, Matthew Wilcox wrote: > On Fri, Oct 20, 2017 at 03:29:57PM -0700, Dan Williams wrote: >> Ok, I'd also like to kill DAX support in the brd driver. It's a source >> of complexity and maintenance burden for zero benefit. It's the only >> ->direct_access() implementation that sleeps and it's the only >> implementation where there is a non-linear relationship between >> sectors and pfns. Having a 1:1 sector to pfn relationship will help >> with the dma-extent-busy management since we don't need to keep >> calling into the driver to map pfns back to sectors once we know the >> pfn[0] sector[0] relationship. > > But these are important things that other block devices may / will want. > > For example, I think it's entirely sensible to support ->direct_access > for RAID-0. Dell are looking at various different options for having > one pmemX device per DIMM and using RAID to lash them together. > ->direct_access makes no sense for RAID-5 or RAID-1, but RAID-0 makes > sense to me. > > Last time we tried to take sleeping out, there were grumblings from people > with network block devices who thought they'd want to bring pages in > across the network. I'm a bit less sympathetic to this because I don't > know anyone actively working on it, but the RAID-0 case is something I > think we should care about. True, good point. In fact we already support device-mapper striping with ->direct_access(). I'd still like to go ahead with the sleeping removal. When those folks come back and add network direct_access they can do the hard work of figuring out cases where we need to call direct_access in atomic contexts. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20171021032008.GA27694@bombadil.infradead.org> References: <150846713528.24336.4459262264611579791.stgit@dwillia2-desk3.amr.corp.intel.com> <150846714747.24336.14704246566580871364.stgit@dwillia2-desk3.amr.corp.intel.com> <20171020075735.GA14378@lst.de> <20171020162933.GA26320@lst.de> <20171021032008.GA27694@bombadil.infradead.org> From: Dan Williams Date: Fri, 20 Oct 2017 21:16:21 -0700 Message-ID: Subject: Re: [PATCH v3 02/13] dax: require 'struct page' for filesystem dax To: Matthew Wilcox Cc: Christoph Hellwig , Andrew Morton , Jan Kara , "linux-nvdimm@lists.01.org" , Benjamin Herrenschmidt , Heiko Carstens , "linux-kernel@vger.kernel.org" , linux-xfs@vger.kernel.org, Linux MM , Jeff Moyer , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , linux-fsdevel , Ross Zwisler , Gerald Schaefer Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: On Fri, Oct 20, 2017 at 8:20 PM, Matthew Wilcox wrote: > On Fri, Oct 20, 2017 at 03:29:57PM -0700, Dan Williams wrote: >> Ok, I'd also like to kill DAX support in the brd driver. It's a source >> of complexity and maintenance burden for zero benefit. It's the only >> ->direct_access() implementation that sleeps and it's the only >> implementation where there is a non-linear relationship between >> sectors and pfns. Having a 1:1 sector to pfn relationship will help >> with the dma-extent-busy management since we don't need to keep >> calling into the driver to map pfns back to sectors once we know the >> pfn[0] sector[0] relationship. > > But these are important things that other block devices may / will want. > > For example, I think it's entirely sensible to support ->direct_access > for RAID-0. Dell are looking at various different options for having > one pmemX device per DIMM and using RAID to lash them together. > ->direct_access makes no sense for RAID-5 or RAID-1, but RAID-0 makes > sense to me. > > Last time we tried to take sleeping out, there were grumblings from people > with network block devices who thought they'd want to bring pages in > across the network. I'm a bit less sympathetic to this because I don't > know anyone actively working on it, but the RAID-0 case is something I > think we should care about. True, good point. In fact we already support device-mapper striping with ->direct_access(). I'd still like to go ahead with the sleeping removal. When those folks come back and add network direct_access they can do the hard work of figuring out cases where we need to call direct_access in atomic contexts. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org