From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x235.google.com (mail-oi0-x235.google.com [IPv6:2607:f8b0:4003:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9C7CF20957AE7 for ; Wed, 2 May 2018 06:52:21 -0700 (PDT) Received: by mail-oi0-x235.google.com with SMTP id k17-v6so12973507oih.5 for ; Wed, 02 May 2018 06:52:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180502083021.GC2851@pd.tnic> References: <152520750404.36522.15462513519590065300.stgit@dwillia2-desk3.amr.corp.intel.com> <20180502083021.GC2851@pd.tnic> From: Dan Williams Date: Wed, 2 May 2018 06:52:19 -0700 Message-ID: Subject: Re: [PATCH 0/6] use memcpy_mcsafe() for copy_to_iter() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Borislav Petkov Cc: Tony Luck , "linux-nvdimm@lists.01.org" , Peter Zijlstra , the arch/x86 maintainers , Linux Kernel Mailing List , Andy Lutomirski , Ingo Molnar , Al Viro , Thomas Gleixner , Linus Torvalds , Andrew Morton List-ID: On Wed, May 2, 2018 at 1:30 AM, Borislav Petkov wrote: > On Tue, May 01, 2018 at 07:25:57PM -0700, Dan Williams wrote: >> Right, but the only way to make MCE non-fatal is to teach the machine >> check handler about recoverable conditions. This patch teaches the >> machine check handler how to recover copy_to_iter() errors. > > Yeah, about that: maybe we talked about this at the time but does the > actual MCE signature state the error was caused by a read from an nvdimm > range? It does not, and this routine would still need to support emulated persistent memory, or physical address ranges that the administrator has forced the kernel to treat as pmem that are otherwise not known to platform firmware. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371AbeEBNw0 (ORCPT ); Wed, 2 May 2018 09:52:26 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:39168 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbeEBNwV (ORCPT ); Wed, 2 May 2018 09:52:21 -0400 X-Google-Smtp-Source: AB8JxZrtvZeDf0mb5QLSr/MSM+SqGA6BbT2L+ihdspI0rut3GyVY2MNXvoB+Vy8s/hyGaCTETovJlH+Wr/G9uFOSmaw= MIME-Version: 1.0 In-Reply-To: <20180502083021.GC2851@pd.tnic> References: <152520750404.36522.15462513519590065300.stgit@dwillia2-desk3.amr.corp.intel.com> <20180502083021.GC2851@pd.tnic> From: Dan Williams Date: Wed, 2 May 2018 06:52:19 -0700 Message-ID: Subject: Re: [PATCH 0/6] use memcpy_mcsafe() for copy_to_iter() To: Borislav Petkov Cc: Linus Torvalds , "linux-nvdimm@lists.01.org" , Tony Luck , Peter Zijlstra , "the arch/x86 maintainers" , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , Al Viro , Andrew Morton , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 2, 2018 at 1:30 AM, Borislav Petkov wrote: > On Tue, May 01, 2018 at 07:25:57PM -0700, Dan Williams wrote: >> Right, but the only way to make MCE non-fatal is to teach the machine >> check handler about recoverable conditions. This patch teaches the >> machine check handler how to recover copy_to_iter() errors. > > Yeah, about that: maybe we talked about this at the time but does the > actual MCE signature state the error was caused by a read from an nvdimm > range? It does not, and this routine would still need to support emulated persistent memory, or physical address ranges that the administrator has forced the kernel to treat as pmem that are otherwise not known to platform firmware.