From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B80B72 for ; Wed, 27 Oct 2021 23:37:13 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id k26so4216030pfi.5 for ; Wed, 27 Oct 2021 16:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WMTMh4JidQFbMhcZT2VkZGNAi1C8CcA8jtm6BrftSss=; b=6OnySiysF1hhuv+2jxJ9FfAfSmA8y9LXelAKat7WynBZQg+6PZ/Y6CL3zM18cMG3JD GEnUquiuE3quJvpTuotuNPBGhT162UmD7avG0jDOAcziSvLYUVDywCngB4p3fQ58ZM0M zEqOMtq2uc82z3Hyo8SHcJ4wrgy4SICUQMJg3EUzEQ97cTDTxpAJL+ZjXMrC9Pd6Yd4I Hv+o6S8B5+bjhFZmSyXmvoK3vkD+a/tR7V2R1bzY3az6V1C7tt1S3O/yFi5MScIMNOJo whD2gxewZ5pTPcAORmeXbNAMaeToO/lIBwIX5Bv5eefUsLjTlEzVx3onl1Zq5iL+vzm0 cGOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WMTMh4JidQFbMhcZT2VkZGNAi1C8CcA8jtm6BrftSss=; b=QRpDCo+rhOsEIffqmfwY0XHDz3eUdTIdFwh79wBvCV6ZEB5G1Fi1Gj4nt2PNedgnJ7 tTysRhItuEvVeQgvtIfNiogjcOoFVUzUfJK23Pw4p5aUr+tGYeAt1JhTdHiaGG3ZRw8T fE6CoMIfFFp0rqk5RYCBBKWfFW/nxgEcKD1lKOjo7ackEJ8V+9pNjEdQyvKel7P+kaBU CbT4YEklOnl1az1h9/6ZUUYPfIY4ADu7fZLMW2AHmDsBDCddsqw5UGG2SvIK4IRplzM7 Tja1OtSjafgRL5RkP8oCmqnSAZdgl2PoMgzm1uklg6cB8jgMODibvcavnkhjyf0+8HWd Q5XA== X-Gm-Message-State: AOAM530SkYzIZw+1E09ur4PFqxIOM0TYPMCDRlh2XuhxS7UYDVwPhWTP kEoUrRzqFOVMlrBrLAut56K+TJ9mNDVfkyPe6r9+MQ== X-Google-Smtp-Source: ABdhPJxcsU50q4uGsTOaoj9w67NPN0ee0O0WC5tw2bEynUFc2bhlW22w0QMQKH9wvcSAfLnnolzJDk1LCiKsNt9RVYY= X-Received: by 2002:a63:1e0e:: with SMTP id e14mr608862pge.5.1635377832818; Wed, 27 Oct 2021 16:37:12 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> <20211019072326.GA23171@lst.de> In-Reply-To: <20211019072326.GA23171@lst.de> From: Dan Williams Date: Wed, 27 Oct 2021 16:37:01 -0700 Message-ID: Subject: Re: [PATCH 06/11] xfs: factor out a xfs_setup_dax helper To: Christoph Hellwig Cc: "Darrick J. Wong" , Mike Snitzer , Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" On Tue, Oct 19, 2021 at 12:24 AM Christoph Hellwig wrote: > > On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > > --- a/fs/xfs/xfs_super.c > > > +++ b/fs/xfs/xfs_super.c > > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > > bdev_nr_sectors(bt->bt_bdev)); > > > } > > > > > > +static int > > > +xfs_setup_dax( > > > > /me wonders if this should be named xfs_setup_dax_always, since this > > doesn't handle the dax=inode mode? > > Sure, why not. I went ahead and made that change locally. > > > The only reason I bring that up is that Eric reminded me a while ago > > that we don't actually print any kind of EXPERIMENTAL warning for the > > auto-detection behavior. > > Yes, I actually noticed that as well when preparing this series. The rest looks good to me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E68C433FE for ; Wed, 27 Oct 2021 23:37:17 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F148361039 for ; Wed, 27 Oct 2021 23:37:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F148361039 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id ADDC4405AA; Wed, 27 Oct 2021 23:37:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LeCiklc3T5Ol; Wed, 27 Oct 2021 23:37:16 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 618B2405A7; Wed, 27 Oct 2021 23:37:15 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 382DFC0012; Wed, 27 Oct 2021 23:37:15 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 117B5C000E for ; Wed, 27 Oct 2021 23:37:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id ED16D60B38 for ; Wed, 27 Oct 2021 23:37:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel-com.20210112.gappssmtp.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FCBe7hmg1el5 for ; Wed, 27 Oct 2021 23:37:13 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6337D6071D for ; Wed, 27 Oct 2021 23:37:13 +0000 (UTC) Received: by mail-pg1-x536.google.com with SMTP id t7so4517324pgl.9 for ; Wed, 27 Oct 2021 16:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WMTMh4JidQFbMhcZT2VkZGNAi1C8CcA8jtm6BrftSss=; b=6OnySiysF1hhuv+2jxJ9FfAfSmA8y9LXelAKat7WynBZQg+6PZ/Y6CL3zM18cMG3JD GEnUquiuE3quJvpTuotuNPBGhT162UmD7avG0jDOAcziSvLYUVDywCngB4p3fQ58ZM0M zEqOMtq2uc82z3Hyo8SHcJ4wrgy4SICUQMJg3EUzEQ97cTDTxpAJL+ZjXMrC9Pd6Yd4I Hv+o6S8B5+bjhFZmSyXmvoK3vkD+a/tR7V2R1bzY3az6V1C7tt1S3O/yFi5MScIMNOJo whD2gxewZ5pTPcAORmeXbNAMaeToO/lIBwIX5Bv5eefUsLjTlEzVx3onl1Zq5iL+vzm0 cGOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WMTMh4JidQFbMhcZT2VkZGNAi1C8CcA8jtm6BrftSss=; b=LKDXUlqvJELH3NjPRzP2fEFpV1UT/3N7BetK0DFtemuCTWBV0xOTO/ha+Vm2zOuKBx NSlUrK3OgqYKHsN0TvVNLWUu7jHffB31UbT2O2Gk4DeU0QWxqOE0KJy/B/3JvlH+MKvb OhEq1Pzpku3BWQEbTfEIJ4aAx53wZPw6nxCKG8uwVdlaHkYKZi1xGaMtCez79g0/W7Op Ek3jhKaQDGK3SqAtlQuAoneOwhBiG//6MQfZaMTkOWHK/+geCfNzHQPGGqGx8qiuYisn aKScBDDzMiOl+ezBnNS64KB9IW1NhBPdhAIn5tPWevlQh29HzD0BWZ0JAeMPRjCQkuAn S9NQ== X-Gm-Message-State: AOAM530TmfBb/bYlmQPRV+rRjmRI0egCsrcN8dQC8hnoo8g4IQI+Xdsf DQYjk+uz1HRU/fPQ/GsihbWZbc97/djXHd8Iz+ZYjQ== X-Google-Smtp-Source: ABdhPJxcsU50q4uGsTOaoj9w67NPN0ee0O0WC5tw2bEynUFc2bhlW22w0QMQKH9wvcSAfLnnolzJDk1LCiKsNt9RVYY= X-Received: by 2002:a63:1e0e:: with SMTP id e14mr608862pge.5.1635377832818; Wed, 27 Oct 2021 16:37:12 -0700 (PDT) MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> <20211019072326.GA23171@lst.de> In-Reply-To: <20211019072326.GA23171@lst.de> From: Dan Williams Date: Wed, 27 Oct 2021 16:37:01 -0700 Message-ID: Subject: Re: [PATCH 06/11] xfs: factor out a xfs_setup_dax helper To: Christoph Hellwig Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , "Darrick J. Wong" , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Oct 19, 2021 at 12:24 AM Christoph Hellwig wrote: > > On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > > --- a/fs/xfs/xfs_super.c > > > +++ b/fs/xfs/xfs_super.c > > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > > bdev_nr_sectors(bt->bt_bdev)); > > > } > > > > > > +static int > > > +xfs_setup_dax( > > > > /me wonders if this should be named xfs_setup_dax_always, since this > > doesn't handle the dax=inode mode? > > Sure, why not. I went ahead and made that change locally. > > > The only reason I bring that up is that Eric reminded me a while ago > > that we don't actually print any kind of EXPERIMENTAL warning for the > > auto-detection behavior. > > Yes, I actually noticed that as well when preparing this series. The rest looks good to me. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB7FC433F5 for ; Wed, 27 Oct 2021 23:37:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE2AA60232 for ; Wed, 27 Oct 2021 23:37:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE2AA60232 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HflV31hZGz2yPW for ; Thu, 28 Oct 2021 10:37:31 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel-com.20210112.gappssmtp.com header.i=@intel-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=6OnySiys; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=2607:f8b0:4864:20::42b; helo=mail-pf1-x42b.google.com; envelope-from=dan.j.williams@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel-com.20210112.gappssmtp.com header.i=@intel-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=6OnySiys; dkim-atps=neutral Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HflTy2sjVz2x9P for ; Thu, 28 Oct 2021 10:37:16 +1100 (AEDT) Received: by mail-pf1-x42b.google.com with SMTP id b1so684761pfm.6 for ; Wed, 27 Oct 2021 16:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WMTMh4JidQFbMhcZT2VkZGNAi1C8CcA8jtm6BrftSss=; b=6OnySiysF1hhuv+2jxJ9FfAfSmA8y9LXelAKat7WynBZQg+6PZ/Y6CL3zM18cMG3JD GEnUquiuE3quJvpTuotuNPBGhT162UmD7avG0jDOAcziSvLYUVDywCngB4p3fQ58ZM0M zEqOMtq2uc82z3Hyo8SHcJ4wrgy4SICUQMJg3EUzEQ97cTDTxpAJL+ZjXMrC9Pd6Yd4I Hv+o6S8B5+bjhFZmSyXmvoK3vkD+a/tR7V2R1bzY3az6V1C7tt1S3O/yFi5MScIMNOJo whD2gxewZ5pTPcAORmeXbNAMaeToO/lIBwIX5Bv5eefUsLjTlEzVx3onl1Zq5iL+vzm0 cGOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WMTMh4JidQFbMhcZT2VkZGNAi1C8CcA8jtm6BrftSss=; b=oyqXCVSBxwXlC6YtMnnaKxKD0KJiljQ4k20d6yK7YEo3ImiN6GywSnxCym+sP1BVeU 6sGKejeh4SrvhY6zGngTI4OEozV48p4R943qIAh0QsIPzIg5N0J2F+EmDTJ9hRz6bX0t Su263Qh1DUVvqk8qfhQln0E3GXhNJcBsNsUsjC1AzGTXLwLgUfxCTx0PDVzuhA8ewRYG 2iER7cJ2N4vHcPs791esEL1llBkBN+EaQbXoZWQJ4gHLhuZXLzNpK/3ijkxkliKyeN4U 0QCieKjjcm3OtwFBv9awJcfwhFGcI8FNzE/Mmbub10x/aqvFdzxd04BoQu74z2xrExuI Ljvg== X-Gm-Message-State: AOAM530uBgpwdE3tXXpogBivdFpBNMRHjqZr4ZxwepWeADggm4vXFW7Y 6mWn678D6fKCaZNVZXWovXIy0NGfA4kbhItYEwWcRg== X-Google-Smtp-Source: ABdhPJxcsU50q4uGsTOaoj9w67NPN0ee0O0WC5tw2bEynUFc2bhlW22w0QMQKH9wvcSAfLnnolzJDk1LCiKsNt9RVYY= X-Received: by 2002:a63:1e0e:: with SMTP id e14mr608862pge.5.1635377832818; Wed, 27 Oct 2021 16:37:12 -0700 (PDT) MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> <20211019072326.GA23171@lst.de> In-Reply-To: <20211019072326.GA23171@lst.de> From: Dan Williams Date: Wed, 27 Oct 2021 16:37:01 -0700 Message-ID: Subject: Re: [PATCH 06/11] xfs: factor out a xfs_setup_dax helper To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , "Darrick J. Wong" , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Tue, Oct 19, 2021 at 12:24 AM Christoph Hellwig wrote: > > On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > > --- a/fs/xfs/xfs_super.c > > > +++ b/fs/xfs/xfs_super.c > > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > > bdev_nr_sectors(bt->bt_bdev)); > > > } > > > > > > +static int > > > +xfs_setup_dax( > > > > /me wonders if this should be named xfs_setup_dax_always, since this > > doesn't handle the dax=inode mode? > > Sure, why not. I went ahead and made that change locally. > > > The only reason I bring that up is that Eric reminded me a while ago > > that we don't actually print any kind of EXPERIMENTAL warning for the > > auto-detection behavior. > > Yes, I actually noticed that as well when preparing this series. The rest looks good to me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240CDC433F5 for ; Wed, 27 Oct 2021 23:37:28 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6C4A60F38 for ; Wed, 27 Oct 2021 23:37:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A6C4A60F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-JQRJMvhUNrOJB9w3nSD2kg-1; Wed, 27 Oct 2021 19:37:23 -0400 X-MC-Unique: JQRJMvhUNrOJB9w3nSD2kg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6727108088C; Wed, 27 Oct 2021 23:37:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7088C1980E; Wed, 27 Oct 2021 23:37:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9FA0F4A703; Wed, 27 Oct 2021 23:37:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19RNbGJT019519 for ; Wed, 27 Oct 2021 19:37:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2C0BE40CFD10; Wed, 27 Oct 2021 23:37:16 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 270B440CFD0C for ; Wed, 27 Oct 2021 23:37:16 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0E9D4185A79C for ; Wed, 27 Oct 2021 23:37:16 +0000 (UTC) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-538-jYyfgW7rPpau7nKxFBug5g-1; Wed, 27 Oct 2021 19:37:13 -0400 X-MC-Unique: jYyfgW7rPpau7nKxFBug5g-1 Received: by mail-pg1-f171.google.com with SMTP id r28so4602307pga.0 for ; Wed, 27 Oct 2021 16:37:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WMTMh4JidQFbMhcZT2VkZGNAi1C8CcA8jtm6BrftSss=; b=sJ6sNA6iHFLR+i7geRWMQ2e4+GimsY8ts8dPBpSQfon7SiVFromi4pA8rjFuhMeomB k+0KWOyFIJAb3D/lCd+HVRmNjVgM8NFx+qu1ZE3Z7jLMUHApLqjn+DTq2DQL+iF2+pT1 bfkMAFh+kmaYVbuCMIeY6+Tq6l7l15UIy648JjdzKN9+WM4UQFv5gNOL8KLmldKs6vth kdbyoaliotNCj2GMppKbCBRkO0FryM0bMfubMGOXxYD0VvU82b++Z/yToG4I2ddeRx5b isUBSfBKguJXly9pum4exJCqBcE6cVWUq1H8gDTczhjVcstj241WKcOyh6xYLcjqu/7a wlRw== X-Gm-Message-State: AOAM531vsuv1e/2PmTpWEJ+OYkYXunQwwfCpiilUb9mut3stj4NiKBD8 3LDcBk1eedMiXFLT1xl+ntR386I3FFHt+EJOtzJDEw== X-Google-Smtp-Source: ABdhPJxcsU50q4uGsTOaoj9w67NPN0ee0O0WC5tw2bEynUFc2bhlW22w0QMQKH9wvcSAfLnnolzJDk1LCiKsNt9RVYY= X-Received: by 2002:a63:1e0e:: with SMTP id e14mr608862pge.5.1635377832818; Wed, 27 Oct 2021 16:37:12 -0700 (PDT) MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> <20211019072326.GA23171@lst.de> In-Reply-To: <20211019072326.GA23171@lst.de> From: Dan Williams Date: Wed, 27 Oct 2021 16:37:01 -0700 Message-ID: To: Christoph Hellwig X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: dm-devel@redhat.com Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , "Darrick J. Wong" , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny Subject: Re: [dm-devel] [PATCH 06/11] xfs: factor out a xfs_setup_dax helper X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Oct 19, 2021 at 12:24 AM Christoph Hellwig wrote: > > On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > > --- a/fs/xfs/xfs_super.c > > > +++ b/fs/xfs/xfs_super.c > > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > > bdev_nr_sectors(bt->bt_bdev)); > > > } > > > > > > +static int > > > +xfs_setup_dax( > > > > /me wonders if this should be named xfs_setup_dax_always, since this > > doesn't handle the dax=inode mode? > > Sure, why not. I went ahead and made that change locally. > > > The only reason I bring that up is that Eric reminded me a while ago > > that we don't actually print any kind of EXPERIMENTAL warning for the > > auto-detection behavior. > > Yes, I actually noticed that as well when preparing this series. The rest looks good to me. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel