From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com [IPv6:2607:f8b0:4003:c01::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 926C81A1ECA for ; Tue, 29 Mar 2016 12:38:26 -0700 (PDT) Received: by mail-ob0-x22e.google.com with SMTP id m7so23066942obh.3 for ; Tue, 29 Mar 2016 12:37:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1459277829.6412.3.camel@intel.com> References: <1458861450-17705-1-git-send-email-vishal.l.verma@intel.com> <1458861450-17705-5-git-send-email-vishal.l.verma@intel.com> <1458939796.5501.8.camel@intel.com> <1459195288.15523.3.camel@intel.com> <1459277829.6412.3.camel@intel.com> Date: Tue, 29 Mar 2016 12:37:14 -0700 Message-ID: Subject: Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors From: Dan Williams List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Verma, Vishal L" Cc: "axboe@fb.com" , "jack@suse.cz" , "linux-nvdimm@lists.01.org" , "david@fromorbit.com" , "xfs@oss.sgi.com" , "linux-block@vger.kernel.org" , "linux-mm@kvack.org" , "viro@zeniv.linux.org.uk" , "linux-fsdevel@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-ext4@vger.kernel.org" , Wilcox, List-ID: On Tue, Mar 29, 2016 at 11:57 AM, Verma, Vishal L wrote: > On Mon, 2016-03-28 at 16:34 -0700, Dan Williams wrote: > > <> > >> Seems kind of sad to fail the fault due to a bad block when we were >> going to zero it anyway, right? I'm not seeing a compelling reason to >> keep any zeroing in fs/dax.c. > > Agreed - but how do we do this? clear_pmem needs to be able to clear an > arbitrary number of bytes, but to go through the driver, we'd need to > send down a bio? If only the driver had an rw_bytes like interface that > could be used by anyone... :) I think we're ok because clear_pmem() will always happen on PAGE_SIZE, or HPAGE_SIZE boundaries. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <1459277829.6412.3.camel@intel.com> References: <1458861450-17705-1-git-send-email-vishal.l.verma@intel.com> <1458861450-17705-5-git-send-email-vishal.l.verma@intel.com> <1458939796.5501.8.camel@intel.com> <1459195288.15523.3.camel@intel.com> <1459277829.6412.3.camel@intel.com> Date: Tue, 29 Mar 2016 12:37:14 -0700 Message-ID: Subject: Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors From: Dan Williams To: "Verma, Vishal L" Cc: "linux-block@vger.kernel.org" , "xfs@oss.sgi.com" , "linux-mm@kvack.org" , "viro@zeniv.linux.org.uk" , "axboe@fb.com" , "akpm@linux-foundation.org" , "linux-nvdimm@lists.01.org" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "linux-ext4@vger.kernel.org" , "Wilcox, Matthew R" , "david@fromorbit.com" , "jack@suse.cz" Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: On Tue, Mar 29, 2016 at 11:57 AM, Verma, Vishal L wrote: > On Mon, 2016-03-28 at 16:34 -0700, Dan Williams wrote: > > <> > >> Seems kind of sad to fail the fault due to a bad block when we were >> going to zero it anyway, right? I'm not seeing a compelling reason to >> keep any zeroing in fs/dax.c. > > Agreed - but how do we do this? clear_pmem needs to be able to clear an > arbitrary number of bytes, but to go through the driver, we'd need to > send down a bio? If only the driver had an rw_bytes like interface that > could be used by anyone... :) I think we're ok because clear_pmem() will always happen on PAGE_SIZE, or HPAGE_SIZE boundaries. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Date: Tue, 29 Mar 2016 12:37:14 -0700 Message-ID: References: <1458861450-17705-1-git-send-email-vishal.l.verma@intel.com> <1458861450-17705-5-git-send-email-vishal.l.verma@intel.com> <1458939796.5501.8.camel@intel.com> <1459195288.15523.3.camel@intel.com> <1459277829.6412.3.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "linux-block@vger.kernel.org" , "xfs@oss.sgi.com" , "linux-mm@kvack.org" , "viro@zeniv.linux.org.uk" , "axboe@fb.com" , "akpm@linux-foundation.org" , "linux-nvdimm@lists.01.org" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "linux-ext4@vger.kernel.org" , "Wilcox, Matthew R" , "david@fromorbit.com" , "jack@suse.cz" To: "Verma, Vishal L" Return-path: In-Reply-To: <1459277829.6412.3.camel@intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Tue, Mar 29, 2016 at 11:57 AM, Verma, Vishal L wrote: > On Mon, 2016-03-28 at 16:34 -0700, Dan Williams wrote: > > <> > >> Seems kind of sad to fail the fault due to a bad block when we were >> going to zero it anyway, right? I'm not seeing a compelling reason to >> keep any zeroing in fs/dax.c. > > Agreed - but how do we do this? clear_pmem needs to be able to clear an > arbitrary number of bytes, but to go through the driver, we'd need to > send down a bio? If only the driver had an rw_bytes like interface that > could be used by anyone... :) I think we're ok because clear_pmem() will always happen on PAGE_SIZE, or HPAGE_SIZE boundaries. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 306C97CA1 for ; Tue, 29 Mar 2016 14:38:44 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id CA4F2304053 for ; Tue, 29 Mar 2016 12:38:43 -0700 (PDT) Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by cuda.sgi.com with ESMTP id CrFjg0ANZCZ8EIqR (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Tue, 29 Mar 2016 12:38:41 -0700 (PDT) Received: by mail-ob0-f169.google.com with SMTP id kf9so23816189obc.1 for ; Tue, 29 Mar 2016 12:38:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1459277829.6412.3.camel@intel.com> References: <1458861450-17705-1-git-send-email-vishal.l.verma@intel.com> <1458861450-17705-5-git-send-email-vishal.l.verma@intel.com> <1458939796.5501.8.camel@intel.com> <1459195288.15523.3.camel@intel.com> <1459277829.6412.3.camel@intel.com> Date: Tue, 29 Mar 2016 12:37:14 -0700 Message-ID: Subject: Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors From: Dan Williams List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: "Verma, Vishal L" Cc: "axboe@fb.com" , "jack@suse.cz" , "linux-nvdimm@lists.01.org" , "xfs@oss.sgi.com" , "linux-block@vger.kernel.org" , "linux-mm@kvack.org" , "viro@zeniv.linux.org.uk" , "linux-fsdevel@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-ext4@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "Wilcox, Matthew R" On Tue, Mar 29, 2016 at 11:57 AM, Verma, Vishal L wrote: > On Mon, 2016-03-28 at 16:34 -0700, Dan Williams wrote: > > <> > >> Seems kind of sad to fail the fault due to a bad block when we were >> going to zero it anyway, right? I'm not seeing a compelling reason to >> keep any zeroing in fs/dax.c. > > Agreed - but how do we do this? clear_pmem needs to be able to clear an > arbitrary number of bytes, but to go through the driver, we'd need to > send down a bio? If only the driver had an rw_bytes like interface that > could be used by anyone... :) I think we're ok because clear_pmem() will always happen on PAGE_SIZE, or HPAGE_SIZE boundaries. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs