From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 267F6C432BE for ; Mon, 23 Aug 2021 21:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10FE5604AC for ; Mon, 23 Aug 2021 21:16:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232787AbhHWVQl (ORCPT ); Mon, 23 Aug 2021 17:16:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232710AbhHWVQl (ORCPT ); Mon, 23 Aug 2021 17:16:41 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70917C061757 for ; Mon, 23 Aug 2021 14:15:58 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id 28-20020a17090a031cb0290178dcd8a4d1so705079pje.0 for ; Mon, 23 Aug 2021 14:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0HdgMfJjfBUm06w/tbdcTogg+ww6k//RogO3PbAJzw0=; b=QxjpQlOpuTkQV12epR2VAzo/40qiPmok1VA6W1DpNVqrUjJZzo6eDTeOAHSllTPRk5 PCHJj4sa6Cc+zFYb+qagXaPuZIVnelMvGgQSrmER0WaH8FCD6WbClmdwL/5ivRwnh7Tr OlxIZtj6qvJP26iCb46k2X+oYiRGJnM7szuyUAAjyWh/ew+lAPB9DLrS/JNm80ahAaQ3 OCezKZoWmAZh/d3UXDKW6re2ffhwpL/CbGe+scowDWt4jGvMyKioieZ/cTqBW3/sPEsw yQi9J5uIeeS+cZ9Q278rjGN4pnDH5ekMzhp0L914a+t9gnxjIOixK5iNFQn+7bU0o7zt ESCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0HdgMfJjfBUm06w/tbdcTogg+ww6k//RogO3PbAJzw0=; b=tcoLpMfmMS9amo6rDRqlBP4IYllmi3s/jnmKDLCjDMyifChjCW2L51PCkCaZ+lAx0j nevtCgkgSbEJlX4qHkU4thAfPEYYriTcs++IYPSskuRMeJG5ehHsUFCaLdulEo9xVa+L s5ipbJqZJVZIxHxnbKzTBxjiM8Sza1zTa9fRx2xiZk14YOe2t3M/eU6ADMf92+KE7Csa t+tDcA/URhhNvH1J+Rl1L2N5IT/vQ12orOsHzULtZN40tkNnscb+ujyadyufZHhc3Rcn 8Jx6OewY8AEdxWmj3VBlDNsSHH1GqwLRnnbSmgRNiae8wHRLHwQFHS+Td1Y0S7Z/BRJR PPHA== X-Gm-Message-State: AOAM5308y1AAGI/78pFyDx8ZFf35o65S9ODD7kC+IC4mwLnGqUj8xmtz eHeA0dg6aMPNnjGyhJhzs1q0qmtRuFjrkV7n1NCondeF7yVyNg== X-Google-Smtp-Source: ABdhPJwH2kZSUy5ZuN/S6Vj/YVaQMRJ9BeKt4NxFFtK5ME19C8ip4tZgOdf3QfLPpgM4bV40q4bP/8FpdYJXB3P7rOI= X-Received: by 2002:a17:90b:23d6:: with SMTP id md22mr517969pjb.149.1629753357862; Mon, 23 Aug 2021 14:15:57 -0700 (PDT) MIME-Version: 1.0 References: <20210823123516.969486-1-hch@lst.de> <20210823123516.969486-8-hch@lst.de> In-Reply-To: <20210823123516.969486-8-hch@lst.de> From: Dan Williams Date: Mon, 23 Aug 2021 14:15:47 -0700 Message-ID: Subject: Re: [PATCH 7/9] dax: stub out dax_supported for !CONFIG_FS_DAX To: Christoph Hellwig Cc: Vishal Verma , Dave Jiang , Mike Snitzer , Matthew Wilcox , linux-xfs , Linux NVDIMM , linux-fsdevel , linux-ext4 Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Aug 23, 2021 at 5:43 AM Christoph Hellwig wrote: > > dax_supported calls into ->dax_supported which checks for fsdax support. > Don't bother building it for !CONFIG_FS_DAX as it will always return > false. > Looks good, modulo formatting question below: Reviewed-by: Dan Williams > diff --git a/include/linux/dax.h b/include/linux/dax.h > index 0a3ef9701e03..32dce5763f2c 100644 > --- a/include/linux/dax.h > +++ b/include/linux/dax.h [..] > @@ -149,6 +144,13 @@ static inline bool bdev_dax_supported(struct block_device *bdev, > > #define generic_fsdax_supported NULL > > +static inline bool dax_supported(struct dax_device *dax_dev, > + struct block_device *bdev, int blocksize, sector_t start, > + sector_t len) > +{ > + return false; > +} I've started clang-formatting new dax and nvdimm code: static inline bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev, int blocksize, sector_t start, sector_t len) { return false; } ...but I also don't mind staying consistent with the surrounding code for now. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AFB23FC2 for ; Mon, 23 Aug 2021 21:15:58 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id b9so6562591plx.2 for ; Mon, 23 Aug 2021 14:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0HdgMfJjfBUm06w/tbdcTogg+ww6k//RogO3PbAJzw0=; b=QxjpQlOpuTkQV12epR2VAzo/40qiPmok1VA6W1DpNVqrUjJZzo6eDTeOAHSllTPRk5 PCHJj4sa6Cc+zFYb+qagXaPuZIVnelMvGgQSrmER0WaH8FCD6WbClmdwL/5ivRwnh7Tr OlxIZtj6qvJP26iCb46k2X+oYiRGJnM7szuyUAAjyWh/ew+lAPB9DLrS/JNm80ahAaQ3 OCezKZoWmAZh/d3UXDKW6re2ffhwpL/CbGe+scowDWt4jGvMyKioieZ/cTqBW3/sPEsw yQi9J5uIeeS+cZ9Q278rjGN4pnDH5ekMzhp0L914a+t9gnxjIOixK5iNFQn+7bU0o7zt ESCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0HdgMfJjfBUm06w/tbdcTogg+ww6k//RogO3PbAJzw0=; b=ZDnSi7Gf3hI8v5XASK3HdjyNNyLStZQubRomNhkZLE5UxdAQup7u+b1eylS27ynmtB noAlRjUI+QkLod6NTb/31Dz7JcskoecArDvR4FsUzffO6YmZZacM4hiEIRyKcA/9tFnb s6zxtEMFMA5Maj+GIQWS0yDv0W0PZneVQMIZV/2elAV6gtQk6YLIJDnE8d84zWi3R04X zUvuvWqsUcTXfSJizfx9KZ+ZAYbB5UDl7eq2hc9GTQXi2ahKQ/5wHSUyb31J6NfLFWl4 rnvNDM5Ehpp8evy8TWFmN5zHYYs5BU5LpJAHnMZyKdMpxf0EBYIrGN2ldhYprQwDvO4U c9qA== X-Gm-Message-State: AOAM532nqD8cTF5xdt3xnM4wNGV8VbHCoe7hqsyyGiz6p/q6NhqimtJ/ eH7fKp9LNifQEBkmfd1vUfFm1RwqnCG90OL7Jw8uWQ== X-Google-Smtp-Source: ABdhPJwH2kZSUy5ZuN/S6Vj/YVaQMRJ9BeKt4NxFFtK5ME19C8ip4tZgOdf3QfLPpgM4bV40q4bP/8FpdYJXB3P7rOI= X-Received: by 2002:a17:90b:23d6:: with SMTP id md22mr517969pjb.149.1629753357862; Mon, 23 Aug 2021 14:15:57 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210823123516.969486-1-hch@lst.de> <20210823123516.969486-8-hch@lst.de> In-Reply-To: <20210823123516.969486-8-hch@lst.de> From: Dan Williams Date: Mon, 23 Aug 2021 14:15:47 -0700 Message-ID: Subject: Re: [PATCH 7/9] dax: stub out dax_supported for !CONFIG_FS_DAX To: Christoph Hellwig Cc: Vishal Verma , Dave Jiang , Mike Snitzer , Matthew Wilcox , linux-xfs , Linux NVDIMM , linux-fsdevel , linux-ext4 Content-Type: text/plain; charset="UTF-8" On Mon, Aug 23, 2021 at 5:43 AM Christoph Hellwig wrote: > > dax_supported calls into ->dax_supported which checks for fsdax support. > Don't bother building it for !CONFIG_FS_DAX as it will always return > false. > Looks good, modulo formatting question below: Reviewed-by: Dan Williams > diff --git a/include/linux/dax.h b/include/linux/dax.h > index 0a3ef9701e03..32dce5763f2c 100644 > --- a/include/linux/dax.h > +++ b/include/linux/dax.h [..] > @@ -149,6 +144,13 @@ static inline bool bdev_dax_supported(struct block_device *bdev, > > #define generic_fsdax_supported NULL > > +static inline bool dax_supported(struct dax_device *dax_dev, > + struct block_device *bdev, int blocksize, sector_t start, > + sector_t len) > +{ > + return false; > +} I've started clang-formatting new dax and nvdimm code: static inline bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev, int blocksize, sector_t start, sector_t len) { return false; } ...but I also don't mind staying consistent with the surrounding code for now.