From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD0AC43331 for ; Tue, 24 Mar 2020 01:21:43 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74E942070A for ; Tue, 24 Mar 2020 01:21:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="hdG3K0QG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74E942070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 75C0F10FC389A; Mon, 23 Mar 2020 18:22:33 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::242; helo=mail-oi1-x242.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7DDA710FC362D for ; Mon, 23 Mar 2020 18:22:30 -0700 (PDT) Received: by mail-oi1-x242.google.com with SMTP id k8so16989733oik.2 for ; Mon, 23 Mar 2020 18:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+4Gkwa2G1ZvtAVtLLGAEnxqc8kb/47goUTTzJiwNkCw=; b=hdG3K0QGGf0OSVfqsu+FIJ5ZZAFSUtp6tH1qczcvKGNR9xYLbHKOG8boELnc4B1SgD d2aUAPTzFxP6R5O+d/Rjd/NhrqxLVARqIt6n5IxywosSeJ3LhNmEkYtaMc2y2fjr6o30 Gg7M8th80lb65ZijeOO6hmL8DcJVMiPwqK9uryklEKAM/ZpNURuf1UThR01v8QkHj2Vm up7m+UTcQbiC7oOmUmKJ4Vhjgr5kjiG5phnPAZXBW7EfUyAWJPGSKQs9SnMRZUdcNSpH wKUV7f85qztZrSErNG/BD8aGSTBOugqWu+i86DCV8mM3B+JUZPlHGT8iY9zDrYZrY5hP KYsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+4Gkwa2G1ZvtAVtLLGAEnxqc8kb/47goUTTzJiwNkCw=; b=Eajnjls494m90vbqC16/LBEeycKAu+MlAvA15qynj4buAE8JX/Po2xdu/8w5ehReqM T0Gs9oODOGrjOvlnODGB4sEKOamecXeuv+Jll8ecCPU9r8oQ/Lw1nh5/wPjndWq+ZGuI NED/Bv/vTpq/0IFsktlsTp048Ej/KZ6f6uD+e8qFZsa8es3tSjeKhRl2vjQviiIla1Iu +DK5lC8b3KulPaDqBBJZumYhHum9r9MZVPk4y65d0QIB4MpNQMl70ybwHYqaf6A55z/P MTSWlV5EaUw4ZlvSZAW87d4wOPgBMGXMvv0XqX1uzFF1QmVt/KuKtVrkqOKxVgsz4m8J 2sVg== X-Gm-Message-State: ANhLgQ2btmgpaaBnMyJHZrMPDk7GACov82BJfJF5trErc1UR/9Zsuk2s 7KkrY4wQJvYSoBfWLv7H0NhV1epQ30ZIEt1coOB9ng== X-Google-Smtp-Source: ADFU+vtR+zfDGu6b9EvlKwPHbaugAQTL77/k93YOHOTwCOIL3riH+keQFZWvZt4YHPs0IL1wVEEMyLWti3Do08G4gIM= X-Received: by 2002:aca:ef82:: with SMTP id n124mr1623535oih.73.1585012898928; Mon, 23 Mar 2020 18:21:38 -0700 (PDT) MIME-Version: 1.0 References: <20200205052056.74604-1-aneesh.kumar@linux.ibm.com> <87y2ta8qy7.fsf@linux.ibm.com> <25eabdd9-410f-e4c3-6b0e-41a5e6daba10@linux.ibm.com> <87k13fnzt8.fsf@linux.ibm.com> In-Reply-To: <87k13fnzt8.fsf@linux.ibm.com> From: Dan Williams Date: Mon, 23 Mar 2020 18:21:27 -0700 Message-ID: Subject: Re: [PATCH v2] libnvdimm: Update persistence domain value for of_pmem and papr_scm device To: "Aneesh Kumar K.V" Message-ID-Hash: LF7CW6WBBK4WDBFWSNVYWXABVLLBYKLP X-Message-ID-Hash: LF7CW6WBBK4WDBFWSNVYWXABVLLBYKLP X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-nvdimm , linuxppc-dev X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Mar 20, 2020 at 2:25 AM Aneesh Kumar K.V wrote: > > > Hi Dan, > > > Dan Williams writes: > > ... > > > > > >> > >> Or are you suggesting that application should not infer any of those > >> details looking at persistence_domain value? If so what is the purpose > >> of exporting that attribute? > > > > The way the patch was worded I thought it was referring to an explicit > > mechanism outside cpu cache flushes, i.e. a mechanism that required a > > driver call. > > > > This patch is blocked because I am not expressing the details correctly. > I updates this as below. Can you suggest if this is ok? If not what > alternate wording do you suggest to document "memory controller" > > > commit 329b46e88f8cd30eee4776b0de7913ab4d496bd8 > Author: Aneesh Kumar K.V > Date: Wed Dec 18 13:53:16 2019 +0530 > > libnvdimm: Update persistence domain value for of_pmem and papr_scm device > > Currently, kernel shows the below values > "persistence_domain":"cpu_cache" > "persistence_domain":"memory_controller" > "persistence_domain":"unknown" > > "cpu_cache" indicates no extra instructions is needed to ensure the persistence > of data in the pmem media on power failure. > > "memory_controller" indicates cpu cache flush instructions is required to flush > the data. Platform provides mechanisms to automatically flush outstanding > write data from memory controler to pmem on system power loss. > > Based on the above use memory_controller for non volatile regions on ppc64. Looks good to me, want to resend via git-format-patch? _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5DBC43331 for ; Tue, 24 Mar 2020 01:23:28 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 378C02070A for ; Tue, 24 Mar 2020 01:23:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="hdG3K0QG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 378C02070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48mYRL0l6nzDqwJ for ; Tue, 24 Mar 2020 12:23:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=2607:f8b0:4864:20::244; helo=mail-oi1-x244.google.com; envelope-from=dan.j.williams@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=hdG3K0QG; dkim-atps=neutral Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48mYPN0NWlzDqjW for ; Tue, 24 Mar 2020 12:21:42 +1100 (AEDT) Received: by mail-oi1-x244.google.com with SMTP id m14so500502oic.0 for ; Mon, 23 Mar 2020 18:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+4Gkwa2G1ZvtAVtLLGAEnxqc8kb/47goUTTzJiwNkCw=; b=hdG3K0QGGf0OSVfqsu+FIJ5ZZAFSUtp6tH1qczcvKGNR9xYLbHKOG8boELnc4B1SgD d2aUAPTzFxP6R5O+d/Rjd/NhrqxLVARqIt6n5IxywosSeJ3LhNmEkYtaMc2y2fjr6o30 Gg7M8th80lb65ZijeOO6hmL8DcJVMiPwqK9uryklEKAM/ZpNURuf1UThR01v8QkHj2Vm up7m+UTcQbiC7oOmUmKJ4Vhjgr5kjiG5phnPAZXBW7EfUyAWJPGSKQs9SnMRZUdcNSpH wKUV7f85qztZrSErNG/BD8aGSTBOugqWu+i86DCV8mM3B+JUZPlHGT8iY9zDrYZrY5hP KYsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+4Gkwa2G1ZvtAVtLLGAEnxqc8kb/47goUTTzJiwNkCw=; b=Z4/6SniJayfAnReYBWEfXdhUDmzV8PkPl4wVaGK1YyNY/BqpB6iSRzf/TRjKr7DS4V RpB460QW9Dy/AaJ5iwVYuZzlQk20u4QNOR0JSLIzgUjIg+A1KykQsn45GfNtWPTRjndk J0kgSl4wAqIOYJvjDgaTNStqU7ETKymU4sp1aWFxYp9WI82h88aApMgV39HF6HkJ4Soo H4l76WD7DtLGg2u4kut3wdfF2prx6bbO7w0125Kuzzy1YHKZxZ2GZZ3/DZAJZN40ViY7 hO4r0R2yRcyGwwfuLExu2g3Upq1TNHcVVgTYdIYQzHa29VbfG7ukjIdtYmJ+mbVZ+qaF FgWg== X-Gm-Message-State: ANhLgQ2Wfw+nec/gGNh27d0NjqgWa0xuTqb7KckHOQFYV+Q3E9e9G2yt n2HtN8dMFJlIRYpH/7jhvIoIrtQaG+cS7MCB353KxkTZ X-Google-Smtp-Source: ADFU+vtR+zfDGu6b9EvlKwPHbaugAQTL77/k93YOHOTwCOIL3riH+keQFZWvZt4YHPs0IL1wVEEMyLWti3Do08G4gIM= X-Received: by 2002:aca:ef82:: with SMTP id n124mr1623535oih.73.1585012898928; Mon, 23 Mar 2020 18:21:38 -0700 (PDT) MIME-Version: 1.0 References: <20200205052056.74604-1-aneesh.kumar@linux.ibm.com> <87y2ta8qy7.fsf@linux.ibm.com> <25eabdd9-410f-e4c3-6b0e-41a5e6daba10@linux.ibm.com> <87k13fnzt8.fsf@linux.ibm.com> In-Reply-To: <87k13fnzt8.fsf@linux.ibm.com> From: Dan Williams Date: Mon, 23 Mar 2020 18:21:27 -0700 Message-ID: Subject: Re: [PATCH v2] libnvdimm: Update persistence domain value for of_pmem and papr_scm device To: "Aneesh Kumar K.V" Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev , linux-nvdimm Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Mar 20, 2020 at 2:25 AM Aneesh Kumar K.V wrote: > > > Hi Dan, > > > Dan Williams writes: > > ... > > > > > >> > >> Or are you suggesting that application should not infer any of those > >> details looking at persistence_domain value? If so what is the purpose > >> of exporting that attribute? > > > > The way the patch was worded I thought it was referring to an explicit > > mechanism outside cpu cache flushes, i.e. a mechanism that required a > > driver call. > > > > This patch is blocked because I am not expressing the details correctly. > I updates this as below. Can you suggest if this is ok? If not what > alternate wording do you suggest to document "memory controller" > > > commit 329b46e88f8cd30eee4776b0de7913ab4d496bd8 > Author: Aneesh Kumar K.V > Date: Wed Dec 18 13:53:16 2019 +0530 > > libnvdimm: Update persistence domain value for of_pmem and papr_scm device > > Currently, kernel shows the below values > "persistence_domain":"cpu_cache" > "persistence_domain":"memory_controller" > "persistence_domain":"unknown" > > "cpu_cache" indicates no extra instructions is needed to ensure the persistence > of data in the pmem media on power failure. > > "memory_controller" indicates cpu cache flush instructions is required to flush > the data. Platform provides mechanisms to automatically flush outstanding > write data from memory controler to pmem on system power loss. > > Based on the above use memory_controller for non volatile regions on ppc64. Looks good to me, want to resend via git-format-patch?