From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver Date: Fri, 20 Oct 2017 09:11:13 -0700 Message-ID: References: <20171017071633.GA9207@infradead.org> <1441791227.21027037.1508226056893.JavaMail.zimbra@redhat.com> <20171017080236.GA27649@infradead.org> <670833322.21037148.1508229041158.JavaMail.zimbra@redhat.com> <20171018130339.GB29767@stefanha-x1.localdomain> <20171019080149.GB10089@infradead.org> <20171020080049.GA25471@infradead.org> <20171020160644.GA27946@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20171020160644.GA27946@infradead.org> Sender: owner-linux-mm@kvack.org To: Christoph Hellwig Cc: Kevin Wolf , Jan Kara , xiaoguangrong eric , KVM list , Pankaj Gupta , Stefan Hajnoczi , David Hildenbrand , ross zwisler , "linux-kernel@vger.kernel.org" , Qemu Developers , Linux MM , Stefan Hajnoczi , linux-nvdimm , Paolo Bonzini , Nitesh Narayan Lal List-Id: linux-nvdimm@lists.01.org On Fri, Oct 20, 2017 at 9:06 AM, Christoph Hellwig wrote: > On Fri, Oct 20, 2017 at 08:05:09AM -0700, Dan Williams wrote: >> Right, that's the same recommendation I gave. >> >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg08404.html >> >> ...so maybe I'm misunderstanding your concern? It sounds like we're on >> the same page. > > Yes, the above is exactly what I think we should do it. And in many > ways virtio seems overkill if we could just have a hypercall or doorbell > page as the queueing infrastructure in virtio shouldn't really be > needed. Ah ok, yes, get rid of the virtio-pmem driver and just make nvdimm_flush() do a hypercall based on region-type flag. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbdJTQLQ (ORCPT ); Fri, 20 Oct 2017 12:11:16 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:51000 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbdJTQLP (ORCPT ); Fri, 20 Oct 2017 12:11:15 -0400 X-Google-Smtp-Source: ABhQp+Q9tOqxSjXTeHT5Du5rthlusddrYOgM/hl1yaRO3XzA/ZiW3A3AG9g5pM/TYzM8ZgDTZt9a+IbW5rs2YfQHFwY= MIME-Version: 1.0 In-Reply-To: <20171020160644.GA27946@infradead.org> References: <20171017071633.GA9207@infradead.org> <1441791227.21027037.1508226056893.JavaMail.zimbra@redhat.com> <20171017080236.GA27649@infradead.org> <670833322.21037148.1508229041158.JavaMail.zimbra@redhat.com> <20171018130339.GB29767@stefanha-x1.localdomain> <20171019080149.GB10089@infradead.org> <20171020080049.GA25471@infradead.org> <20171020160644.GA27946@infradead.org> From: Dan Williams Date: Fri, 20 Oct 2017 09:11:13 -0700 Message-ID: Subject: Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver To: Christoph Hellwig Cc: Kevin Wolf , Jan Kara , xiaoguangrong eric , KVM list , Pankaj Gupta , Stefan Hajnoczi , David Hildenbrand , ross zwisler , "linux-kernel@vger.kernel.org" , Qemu Developers , Linux MM , Stefan Hajnoczi , linux-nvdimm , Paolo Bonzini , Nitesh Narayan Lal Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 20, 2017 at 9:06 AM, Christoph Hellwig wrote: > On Fri, Oct 20, 2017 at 08:05:09AM -0700, Dan Williams wrote: >> Right, that's the same recommendation I gave. >> >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg08404.html >> >> ...so maybe I'm misunderstanding your concern? It sounds like we're on >> the same page. > > Yes, the above is exactly what I think we should do it. And in many > ways virtio seems overkill if we could just have a hypercall or doorbell > page as the queueing infrastructure in virtio shouldn't really be > needed. Ah ok, yes, get rid of the virtio-pmem driver and just make nvdimm_flush() do a hypercall based on region-type flag.