From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDCC22C82 for ; Fri, 19 Nov 2021 17:21:20 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id gt5so8443696pjb.1 for ; Fri, 19 Nov 2021 09:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2U/4HYKnAZR7qNMIeDCg5S//595luEluzFk14uv4gBU=; b=FQ6M7eMMvPf80QsdTpoBZi0VrX8bn7QeX7OvbRABdgkNvCMNjXzl7/FKjSfSUjRkzX F1usfPnFQYNtajLRg0QRwSSgzt8mzXj0XCG2cnk0+F0m/6Zhw3KmrGwYuAHqWjDxU8h7 LoqDBYl4kQUeXb8kAZzT8ViJ+hkv5vLV1Goy6Yaluym7CVIoftX3Jldatma/nAYXl27p pclrbJHG5C0Blu/232w4rLGJUG53x/PsyFdu4/UMHnSQZ8XMlr5FFqwE0la2E0Wy9pBi QLaClBcQjJDmbuAEv+kCOvcY8AEg2J0pE5d377NWsFamWj8v0zJjbYMN2j8PjhK8WH2h Pe+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2U/4HYKnAZR7qNMIeDCg5S//595luEluzFk14uv4gBU=; b=VALmImNKEcVte8GOiS1jwtXdXFO7iiVAnr+00JGbDNswVJlm6rS0Ko5GWFtKgtftGm OerLDu5yvWdOhUGHjP5+7O0lHoPnRdmqsgbTQp5Pw/TNkbujis83Zm9FrY/D1dymI8UF VDQgnxFC/3kF7mxYX4W6bc2ikCSMGbepyiEHyVvoDkq78zluyElhykwnXN43tUahFGos +kXCl8GyYT5OOEArA6zPizN6qbU95hSIhUkUyUsiMEs6uaoYv74hqmW4YCIe6IQRdhcv daSBuAlWSM7B4sxA0IN8T2OIoHawHq+wHxkePPsr+pbuG2YH5PWfJoa4nVF3f8+dvcXC 7+ZA== X-Gm-Message-State: AOAM532QQ8LGch8L/EaqrkCxPEzdxh2iWRvrTLZXoEoK2USEp/4lCFLp HuMw9xBqsD92pH/JYP2j66RaEk4MOh1+TyvutGPyaA== X-Google-Smtp-Source: ABdhPJxOTsb7kpZ1mbQBZyHvrw/GjkoPNdlC1Mnmi7QTa5v33P77eZ447VYbGdz8Hsj3aBiYzZhGTejFWOktm98P3BA= X-Received: by 2002:a17:90b:1e49:: with SMTP id pi9mr1505670pjb.220.1637342480174; Fri, 19 Nov 2021 09:21:20 -0800 (PST) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-2-hch@lst.de> <20211119065645.GB15524@lst.de> In-Reply-To: <20211119065645.GB15524@lst.de> From: Dan Williams Date: Fri, 19 Nov 2021 09:21:09 -0800 Message-ID: Subject: Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem To: Christoph Hellwig Cc: Mike Snitzer , Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" On Thu, Nov 18, 2021 at 10:56 PM Christoph Hellwig wrote: > > On Wed, Nov 17, 2021 at 09:44:25AM -0800, Dan Williams wrote: > > On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > > > > > dax_attribute_group is only used by the pmem driver, and can avoid the > > > completely pointless lookup by the disk name if moved there. This > > > leaves just a single caller of dax_get_by_host, so move dax_get_by_host > > > into the same ifdef block as that caller. > > > > > > Signed-off-by: Christoph Hellwig > > > Reviewed-by: Dan Williams > > > Link: https://lore.kernel.org/r/20210922173431.2454024-3-hch@lst.de > > > Signed-off-by: Dan Williams > > > > This one already made v5.16-rc1. > > Yes, but 5.16-rc1 did not exist yet when I pointed the series. > > Note that the series also has a conflict against 5.16-rc1 in pmem.c, > and buildbot pointed out the file systems need explicit dax.h > includes in a few files for some configurations. > > The current branch is here, I just did not bother to repost without > any comments: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dax-block-cleanup > > no functional changes. Do you just want to send me a pull request after you add all the acks? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3033BC433EF for ; Fri, 19 Nov 2021 17:21:25 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC0D161A79 for ; Fri, 19 Nov 2021 17:21:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC0D161A79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 899AA400F3; Fri, 19 Nov 2021 17:21:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4USbbb4KU4eY; Fri, 19 Nov 2021 17:21:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id DFD2D400DA; Fri, 19 Nov 2021 17:21:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AFF94C002E; Fri, 19 Nov 2021 17:21:22 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id C8F80C0012 for ; Fri, 19 Nov 2021 17:21:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A5DE0828DF for ; Fri, 19 Nov 2021 17:21:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel-com.20210112.gappssmtp.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tDGn2YgGMIx4 for ; Fri, 19 Nov 2021 17:21:20 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by smtp1.osuosl.org (Postfix) with ESMTPS id AC142828B5 for ; Fri, 19 Nov 2021 17:21:20 +0000 (UTC) Received: by mail-pl1-x632.google.com with SMTP id m24so8617496pls.10 for ; Fri, 19 Nov 2021 09:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2U/4HYKnAZR7qNMIeDCg5S//595luEluzFk14uv4gBU=; b=FQ6M7eMMvPf80QsdTpoBZi0VrX8bn7QeX7OvbRABdgkNvCMNjXzl7/FKjSfSUjRkzX F1usfPnFQYNtajLRg0QRwSSgzt8mzXj0XCG2cnk0+F0m/6Zhw3KmrGwYuAHqWjDxU8h7 LoqDBYl4kQUeXb8kAZzT8ViJ+hkv5vLV1Goy6Yaluym7CVIoftX3Jldatma/nAYXl27p pclrbJHG5C0Blu/232w4rLGJUG53x/PsyFdu4/UMHnSQZ8XMlr5FFqwE0la2E0Wy9pBi QLaClBcQjJDmbuAEv+kCOvcY8AEg2J0pE5d377NWsFamWj8v0zJjbYMN2j8PjhK8WH2h Pe+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2U/4HYKnAZR7qNMIeDCg5S//595luEluzFk14uv4gBU=; b=Vk3o0FX2k02/STs2zrPW9HZoWm10mWyUGcvE9nZnb8aGDbf1jgdf8Ao5++5eDxULkZ l3RPh5V+Kr3h5aDZRgOGWeEy81SN6RJIwzbY/4WO1g2UY5h8X0unie2EoQoxu2F0VVQC ZrzWgk3WCnzZTL1s4j6gA5st50Z/F4OPZqVCVvzsuDNapc6g01bhgQvZHdlrfzezlZ/q /wRo5N/+jhskpiLQw8KGmsSsCReZQCX1iP+2/V1k7pH5lh2dbpHub1O1AkLdOoPy7SAu Je8aSfSo5AD2d4PUOJ7a9z3poahv1w4A5/6cLXY1LBkjhcVxx13qkZuAkiaTE147PDSA gAzg== X-Gm-Message-State: AOAM530GpdtqUofq+kIaQDdvhkiX1979eMyBjCOiYtH5Mgx5ZocLLVU9 5xetDb7VizfhlKTw2yjtJCPZbRlYD9G0SlrSbxXZKA== X-Google-Smtp-Source: ABdhPJxOTsb7kpZ1mbQBZyHvrw/GjkoPNdlC1Mnmi7QTa5v33P77eZ447VYbGdz8Hsj3aBiYzZhGTejFWOktm98P3BA= X-Received: by 2002:a17:90b:1e49:: with SMTP id pi9mr1505670pjb.220.1637342480174; Fri, 19 Nov 2021 09:21:20 -0800 (PST) MIME-Version: 1.0 References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-2-hch@lst.de> <20211119065645.GB15524@lst.de> In-Reply-To: <20211119065645.GB15524@lst.de> From: Dan Williams Date: Fri, 19 Nov 2021 09:21:09 -0800 Message-ID: Subject: Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem To: Christoph Hellwig Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Thu, Nov 18, 2021 at 10:56 PM Christoph Hellwig wrote: > > On Wed, Nov 17, 2021 at 09:44:25AM -0800, Dan Williams wrote: > > On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > > > > > dax_attribute_group is only used by the pmem driver, and can avoid the > > > completely pointless lookup by the disk name if moved there. This > > > leaves just a single caller of dax_get_by_host, so move dax_get_by_host > > > into the same ifdef block as that caller. > > > > > > Signed-off-by: Christoph Hellwig > > > Reviewed-by: Dan Williams > > > Link: https://lore.kernel.org/r/20210922173431.2454024-3-hch@lst.de > > > Signed-off-by: Dan Williams > > > > This one already made v5.16-rc1. > > Yes, but 5.16-rc1 did not exist yet when I pointed the series. > > Note that the series also has a conflict against 5.16-rc1 in pmem.c, > and buildbot pointed out the file systems need explicit dax.h > includes in a few files for some configurations. > > The current branch is here, I just did not bother to repost without > any comments: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dax-block-cleanup > > no functional changes. Do you just want to send me a pull request after you add all the acks? _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7EAC433EF for ; Fri, 19 Nov 2021 17:21:40 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93D4D61A79 for ; Fri, 19 Nov 2021 17:21:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 93D4D61A79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hwk3k0pB6z3bXW for ; Sat, 20 Nov 2021 04:21:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel-com.20210112.gappssmtp.com header.i=@intel-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=FQ6M7eMM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=2607:f8b0:4864:20::632; helo=mail-pl1-x632.google.com; envelope-from=dan.j.williams@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel-com.20210112.gappssmtp.com header.i=@intel-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=FQ6M7eMM; dkim-atps=neutral Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hwk3Y5fZbz2ywV for ; Sat, 20 Nov 2021 04:21:21 +1100 (AEDT) Received: by mail-pl1-x632.google.com with SMTP id k4so8603210plx.8 for ; Fri, 19 Nov 2021 09:21:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2U/4HYKnAZR7qNMIeDCg5S//595luEluzFk14uv4gBU=; b=FQ6M7eMMvPf80QsdTpoBZi0VrX8bn7QeX7OvbRABdgkNvCMNjXzl7/FKjSfSUjRkzX F1usfPnFQYNtajLRg0QRwSSgzt8mzXj0XCG2cnk0+F0m/6Zhw3KmrGwYuAHqWjDxU8h7 LoqDBYl4kQUeXb8kAZzT8ViJ+hkv5vLV1Goy6Yaluym7CVIoftX3Jldatma/nAYXl27p pclrbJHG5C0Blu/232w4rLGJUG53x/PsyFdu4/UMHnSQZ8XMlr5FFqwE0la2E0Wy9pBi QLaClBcQjJDmbuAEv+kCOvcY8AEg2J0pE5d377NWsFamWj8v0zJjbYMN2j8PjhK8WH2h Pe+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2U/4HYKnAZR7qNMIeDCg5S//595luEluzFk14uv4gBU=; b=d2Nyh8bnOyM6Ggq83RPPn1nUExJhXKSs/BhSVonhS80q/ZqaW9WZEPyQLO7ygU9Nic pr9vZCKTuJcz8DCZ5c6PEFu+rnF9Tbuo5DYpRwZcPBwPRTFjPoAT+XmtxgV1BYSA+vx2 koTVGbIVxE8CBmPlOMiaLIXDyC8E6Kb5S6iHPN2RoelBOJ2KhBr5x1wy86R6L5UHf1on 0anTBclxPJwkO9A6lRULCH7/W/Qr/o1wXvq2pnqaIogo8qjbYzBudcq3bwJLLbwPz06X XupstiNIGKw0OX32avLgCV5KHDoBQONGHXtRXfQTJoipqBf3UrK4jdRb/GAKeZ0Ji/sN 2QGA== X-Gm-Message-State: AOAM530M8gWfxFD9xC4B6cVlJj0KVNCn7pE2NFx/ylb8vlIct2aMdw5d v8FOvK3x0BsOnB7MCQTpR74jtEO1gROna8cuZ/5vYw== X-Google-Smtp-Source: ABdhPJxOTsb7kpZ1mbQBZyHvrw/GjkoPNdlC1Mnmi7QTa5v33P77eZ447VYbGdz8Hsj3aBiYzZhGTejFWOktm98P3BA= X-Received: by 2002:a17:90b:1e49:: with SMTP id pi9mr1505670pjb.220.1637342480174; Fri, 19 Nov 2021 09:21:20 -0800 (PST) MIME-Version: 1.0 References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-2-hch@lst.de> <20211119065645.GB15524@lst.de> In-Reply-To: <20211119065645.GB15524@lst.de> From: Dan Williams Date: Fri, 19 Nov 2021 09:21:09 -0800 Message-ID: Subject: Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Thu, Nov 18, 2021 at 10:56 PM Christoph Hellwig wrote: > > On Wed, Nov 17, 2021 at 09:44:25AM -0800, Dan Williams wrote: > > On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > > > > > dax_attribute_group is only used by the pmem driver, and can avoid the > > > completely pointless lookup by the disk name if moved there. This > > > leaves just a single caller of dax_get_by_host, so move dax_get_by_host > > > into the same ifdef block as that caller. > > > > > > Signed-off-by: Christoph Hellwig > > > Reviewed-by: Dan Williams > > > Link: https://lore.kernel.org/r/20210922173431.2454024-3-hch@lst.de > > > Signed-off-by: Dan Williams > > > > This one already made v5.16-rc1. > > Yes, but 5.16-rc1 did not exist yet when I pointed the series. > > Note that the series also has a conflict against 5.16-rc1 in pmem.c, > and buildbot pointed out the file systems need explicit dax.h > includes in a few files for some configurations. > > The current branch is here, I just did not bother to repost without > any comments: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dax-block-cleanup > > no functional changes. Do you just want to send me a pull request after you add all the acks? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33049C433F5 for ; Fri, 19 Nov 2021 17:24:00 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB82F61056 for ; Fri, 19 Nov 2021 17:23:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BB82F61056 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-232-mrFgSaSwMzeURqimX7e7sg-1; Fri, 19 Nov 2021 12:23:55 -0500 X-MC-Unique: mrFgSaSwMzeURqimX7e7sg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 18035100D0CF; Fri, 19 Nov 2021 17:23:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E349F5F4F6; Fri, 19 Nov 2021 17:23:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5E31D4A704; Fri, 19 Nov 2021 17:23:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AJHLTZ8029641 for ; Fri, 19 Nov 2021 12:21:29 -0500 Received: by smtp.corp.redhat.com (Postfix) id E02A91121318; Fri, 19 Nov 2021 17:21:28 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB2351121319 for ; Fri, 19 Nov 2021 17:21:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19A4480A0AC for ; Fri, 19 Nov 2021 17:21:23 +0000 (UTC) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-119-iRw_-P0hMVmntBFoztU-Mg-1; Fri, 19 Nov 2021 12:21:21 -0500 X-MC-Unique: iRw_-P0hMVmntBFoztU-Mg-1 Received: by mail-pl1-f174.google.com with SMTP id p18so8593180plf.13 for ; Fri, 19 Nov 2021 09:21:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2U/4HYKnAZR7qNMIeDCg5S//595luEluzFk14uv4gBU=; b=tLs8EEw6PKslABtY+XIK3z5HOnBlVDI6S+eNJChhBxJjjGnPvw/5wjOJQcjAScdmCw Pnbcy4PeOAxyehxEsqnNjbNY63hPRhTeX/gJvG8MBeOmV5sqVJZEoWuxFlao53kBTEmJ il/mBlVwD4C6AeZx4yHY+nH99tC0eTbLaDW5C5O/uvGmfrdRFEoc/Ry0qD2vlsPwZQD+ c1I2oHL4B/P/gi1bqWwHGGIE0YwMmSHOuRvg059+EPK4nHe4hXbIbLfgxtsxTcXciBk9 gSnvhFU/a0wulndccNNPdIcCBSEPPMzU4pVcbhTlLUrS/koIlxhKuFZ00IqC5KcRrewD E4vw== X-Gm-Message-State: AOAM531dQ3J+zJOn0rYdjay8yCtTlN3fJxUsx8wBC1lTfV69B9968KHR E+0lToET34oUVhB0PwjBN06SyiFCw346zYV/6wkex65gZRE= X-Google-Smtp-Source: ABdhPJxOTsb7kpZ1mbQBZyHvrw/GjkoPNdlC1Mnmi7QTa5v33P77eZ447VYbGdz8Hsj3aBiYzZhGTejFWOktm98P3BA= X-Received: by 2002:a17:90b:1e49:: with SMTP id pi9mr1505670pjb.220.1637342480174; Fri, 19 Nov 2021 09:21:20 -0800 (PST) MIME-Version: 1.0 References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-2-hch@lst.de> <20211119065645.GB15524@lst.de> In-Reply-To: <20211119065645.GB15524@lst.de> From: Dan Williams Date: Fri, 19 Nov 2021 09:21:09 -0800 Message-ID: To: Christoph Hellwig X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: Linux NVDIMM , Mike Snitzer , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny Subject: Re: [dm-devel] [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 18, 2021 at 10:56 PM Christoph Hellwig wrote: > > On Wed, Nov 17, 2021 at 09:44:25AM -0800, Dan Williams wrote: > > On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > > > > > dax_attribute_group is only used by the pmem driver, and can avoid the > > > completely pointless lookup by the disk name if moved there. This > > > leaves just a single caller of dax_get_by_host, so move dax_get_by_host > > > into the same ifdef block as that caller. > > > > > > Signed-off-by: Christoph Hellwig > > > Reviewed-by: Dan Williams > > > Link: https://lore.kernel.org/r/20210922173431.2454024-3-hch@lst.de > > > Signed-off-by: Dan Williams > > > > This one already made v5.16-rc1. > > Yes, but 5.16-rc1 did not exist yet when I pointed the series. > > Note that the series also has a conflict against 5.16-rc1 in pmem.c, > and buildbot pointed out the file systems need explicit dax.h > includes in a few files for some configurations. > > The current branch is here, I just did not bother to repost without > any comments: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dax-block-cleanup > > no functional changes. Do you just want to send me a pull request after you add all the acks? -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel