From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755471AbcK1WNo (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Nov 2016 17:13:44 -0500
Received: from mail-oi0-f48.google.com ([209.85.218.48]:36584 "EHLO
        mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755337AbcK1WNb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Nov 2016 17:13:31 -0500
MIME-Version: 1.0
In-Reply-To: <20161128212400.GA16225@linux.intel.com>
References: <20161128211233.2446605-1-arnd@arndb.de> <20161128212400.GA16225@linux.intel.com>
From: Dan Williams <dan.j.williams@intel.com>
Date: Mon, 28 Nov 2016 14:13:29 -0800
Message-ID: <CAPcyv4iHKqYcq2OZZynUzMe8aF4JiKCUZa2JnERGC9MC7aY8Lg@mail.gmail.com>
Subject: Re: [PATCH] dax: try to avoid unused function warnings
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
        Arnd Bergmann <arnd@arndb.de>, "Theodore Ts'o" <tytso@mit.edu>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Matthew Wilcox <willy@linux.intel.com>, Jan Kara <jack@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dave Chinner <dchinner@redhat.com>,
        Dan Williams <dan.j.williams@intel.com>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uASMDpBE025213

On Mon, Nov 28, 2016 at 1:24 PM, Ross Zwisler
<ross.zwisler@linux.intel.com> wrote:
> On Mon, Nov 28, 2016 at 10:12:17PM +0100, Arnd Bergmann wrote:
>> Without the get_block based I/O, we get warnings when CONFIG_FS_IOMAP
>> is disabled:
>>
>> fs/dax.c:736:12: error: ‘dax_insert_mapping’ defined but not used [-Werror=unused-function]
>> fs/dax.c:512:12: error: ‘copy_user_dax’ defined but not used [-Werror=unused-function]
>> fs/dax.c:490:12: error: ‘dax_load_hole’ defined but not used [-Werror=unused-function]
>> fs/dax.c:294:14: error: ‘grab_mapping_entry’ defined but not used [-Werror=unused-function]
>>
>> This patch blindly marks those as __maybe_unused, which avoids the warnings.
>> However, I suspect that there is actually more code in this file that should
>> not be provided without CONFIG_FS_IOMAP even though we don't get a warning
>> for it, and that we actually want a different rework, so please treat this
>> as a bug report. I have applied the patch locally in my randconfig build
>> setup to avoid seeing the warnings.
>>
>> Fixes: 5ac65736f740 ("dax: rip out get_block based IO support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for the report.  I think the right way to deal with this is to just
> select FS_IOMAP when we pull in the DAX code.  I sent out a patch last week
> that does this:
>
> https://lkml.org/lkml/2016/11/23/591

It seems awkward for both filesystems and the FS_DAX core to be
selecting FS_IOMAP.  In the end FS_DAX and FS_IOMAP are both libraries
of functionality that a filesystem can optionally use.  I think the
longer term FS_DAX stops being an independent user visible setting and
is instead selected by filesystems that want DAX.