From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD5B52F27 for ; Mon, 7 Feb 2022 18:08:12 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id k17so11797179plk.0 for ; Mon, 07 Feb 2022 10:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nxHF7bigQnfZfNGCQpq6EtXcG8/j6GHHAEIHGHy2fyU=; b=W2DDXQJis+1qeQfXY6E/rxnSkSH+QKQccGw4pZqh3cKQQ7Ll28D21ZTANWBpjdTXkB +oBg0dRp7zXiF2K9fvNxjOnqLQ0NU4tSCX/uoDUgYXiPcW3lrnrEZ8WrBiPWSBgY4/tx 9wQBgc3U+/16XX6zr1IGWZp+OTMhC+7AmHWl4HQOtmJdf1TDvqV9PwZseP44xIAvTKTJ lY9+rCsDVlGtJn+K+JfRbJQJUoxEyKL8bHmbimQ1ptdoTfcpwUfxMxs8lIMS2tr1n+Up 0WNvMspuYRbKnLIowW6FPQwT66Mrqlup7UTEmGoUmJqEmINAArubT4xrd5hjAe0QVo24 gEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nxHF7bigQnfZfNGCQpq6EtXcG8/j6GHHAEIHGHy2fyU=; b=5ejBffvDd7IwcEXXMYeFt+PMHoP3vbcbU6n/imwtMMLzWXO6B/7j3h4z4ZK7+3ev1m jhbNYXFBi3O2p98wu2e1ecfJRTT6fdDHqrdzugkFVpXTGHdc+7a0jcgETf9y+AjsghIV 6tTThvR7wQClc8jl3eDtK4b5ND9tR2E6baMLzJsnGMhj9YPbmn/VHiGI4Ow1qAunpEbu rbMjYts1DPNd19s4/ognOGu72ZIk/HFKG4muNyscRQDq8dTC/htWdpdo1AKq5dR68GtM nm8JL+UDVhfFDwamoBCo0GImcm1zMLJQEyNg61zq4jgDPf73bpy243aIbbhUrO0cSuIz OGlw== X-Gm-Message-State: AOAM5337PVrxaJjRnFDvIzMd+Eg+WOY839i3u/gLUnN3B478GMgtVMM0 AbaTVXAcKMuP4jJKeCJ/wa//JCWtrmWkdI+TjqZ5tw== X-Google-Smtp-Source: ABdhPJxbjfLp1vymzfVN/rUSu7NFfwM27TjFOxcEJErT+R82ivD+XXC3ZWylDTpvE/Ebzm6hUwz4bOsdTAqXcC6BA2A= X-Received: by 2002:a17:902:ccce:: with SMTP id z14mr815477ple.34.1644257292200; Mon, 07 Feb 2022 10:08:12 -0800 (PST) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-2-hch@lst.de> In-Reply-To: <20220207063249.1833066-2-hch@lst.de> From: Dan Williams Date: Mon, 7 Feb 2022 10:08:01 -0800 Message-ID: Subject: Re: [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages To: Christoph Hellwig Cc: Andrew Morton , Felix Kuehling , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Jason Gunthorpe , Alistair Popple , Logan Gunthorpe , Ralph Campbell , Linux Kernel Mailing List , amd-gfx list , Maling list - DRI developers , nouveau@lists.freedesktop.org, Linux NVDIMM , Linux MM Content-Type: text/plain; charset="UTF-8" On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. Looks good to me. Reviewed-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1A68C433F5 for ; Mon, 7 Feb 2022 18:08:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B0CF10E3A2; Mon, 7 Feb 2022 18:08:13 +0000 (UTC) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E64D10E3A2 for ; Mon, 7 Feb 2022 18:08:12 +0000 (UTC) Received: by mail-pj1-x1033.google.com with SMTP id on2so5263111pjb.4 for ; Mon, 07 Feb 2022 10:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nxHF7bigQnfZfNGCQpq6EtXcG8/j6GHHAEIHGHy2fyU=; b=W2DDXQJis+1qeQfXY6E/rxnSkSH+QKQccGw4pZqh3cKQQ7Ll28D21ZTANWBpjdTXkB +oBg0dRp7zXiF2K9fvNxjOnqLQ0NU4tSCX/uoDUgYXiPcW3lrnrEZ8WrBiPWSBgY4/tx 9wQBgc3U+/16XX6zr1IGWZp+OTMhC+7AmHWl4HQOtmJdf1TDvqV9PwZseP44xIAvTKTJ lY9+rCsDVlGtJn+K+JfRbJQJUoxEyKL8bHmbimQ1ptdoTfcpwUfxMxs8lIMS2tr1n+Up 0WNvMspuYRbKnLIowW6FPQwT66Mrqlup7UTEmGoUmJqEmINAArubT4xrd5hjAe0QVo24 gEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nxHF7bigQnfZfNGCQpq6EtXcG8/j6GHHAEIHGHy2fyU=; b=bweFrrBH+ZHO0xgehvo12K8z/IDlGMyiBfnA9ZpgTIvlgYfMStLGwrjsuwwiQlPV5g F89SqL3KiV5K0Nv+QyrDVJNhPrff0eptIwqZU8RDD1FsENxDSKgfyxNx5hVc8iwVBy/p f9aMLfjTIimq2xbjhCItHcBTGZIiTeA1jqNqB63x7Fkgd57PE33lu3A6V9uRal0QFLiY OIks+yMMAG4Jd/ehhXoR7GOA+05basdpc2U1i9r+8kBrlJ6b1GRLEOEuKbQzMzUIMybH jYGBSdR637NzmL42BnTBcUt0sq1EYWk5di8Cfiie4t80IHuEdMfaNCwqTlF7Aas3OpYe CUYA== X-Gm-Message-State: AOAM532e2Zw0VqH1loIs2AgnRSzF32YQVFOvUz6wzXHj3pJr+6jprNAc OIJRf9Aw+3DZEGSrF0Z0EOmykziOujvoDK/ie262fA== X-Google-Smtp-Source: ABdhPJxbjfLp1vymzfVN/rUSu7NFfwM27TjFOxcEJErT+R82ivD+XXC3ZWylDTpvE/Ebzm6hUwz4bOsdTAqXcC6BA2A= X-Received: by 2002:a17:902:ccce:: with SMTP id z14mr815477ple.34.1644257292200; Mon, 07 Feb 2022 10:08:12 -0800 (PST) MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-2-hch@lst.de> In-Reply-To: <20220207063249.1833066-2-hch@lst.de> From: Dan Williams Date: Mon, 7 Feb 2022 10:08:01 -0800 Message-ID: To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Subject: Re: [Nouveau] [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , Linux MM , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. Looks good to me. Reviewed-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61B96C433FE for ; Mon, 7 Feb 2022 18:08:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A84D310E3A5; Mon, 7 Feb 2022 18:08:13 +0000 (UTC) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F61110E3AC for ; Mon, 7 Feb 2022 18:08:12 +0000 (UTC) Received: by mail-pj1-x1030.google.com with SMTP id m7so13615818pjk.0 for ; Mon, 07 Feb 2022 10:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nxHF7bigQnfZfNGCQpq6EtXcG8/j6GHHAEIHGHy2fyU=; b=W2DDXQJis+1qeQfXY6E/rxnSkSH+QKQccGw4pZqh3cKQQ7Ll28D21ZTANWBpjdTXkB +oBg0dRp7zXiF2K9fvNxjOnqLQ0NU4tSCX/uoDUgYXiPcW3lrnrEZ8WrBiPWSBgY4/tx 9wQBgc3U+/16XX6zr1IGWZp+OTMhC+7AmHWl4HQOtmJdf1TDvqV9PwZseP44xIAvTKTJ lY9+rCsDVlGtJn+K+JfRbJQJUoxEyKL8bHmbimQ1ptdoTfcpwUfxMxs8lIMS2tr1n+Up 0WNvMspuYRbKnLIowW6FPQwT66Mrqlup7UTEmGoUmJqEmINAArubT4xrd5hjAe0QVo24 gEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nxHF7bigQnfZfNGCQpq6EtXcG8/j6GHHAEIHGHy2fyU=; b=dw5P73RBgANhBBV/2EcoVSRKvpFOkm4Uw/IawEa1WGvsNySjVbNZIv/g5RNKfwKXdv aupi8pyfeq5RcvK+8Etk1FVlnnfZkO0RTLzSBn5OVNn+R//IrBZUWsBLAvX2pTS7BRgx ZQWcJ7wmXIf3DsOOywkYxzYsXymQvl+jN1cEt0vQKVthXBXAmDrLRMkFvI+EQa3gmkNa MvC0SL34oake+mu3iwkYL8QhYywCL6mMuuRwvQVe/edZMDOjN+8mAj1dTxmnCa/OUFyQ pRgscFVsPvxf/4n2C0sH2Sd7iM3A0VK34nbvjuTbjIQ6/WUC/mdj+CUzeace2CcqHmfr oi/Q== X-Gm-Message-State: AOAM533zGZWaDtCr2mEjKnzFFB8PG62Hyr26ezC0FnzAtyp+1Inok0kz 2vMc/wOeENRahEKOKVdR7iOPWYcEgxzd4MahkmyCvw== X-Google-Smtp-Source: ABdhPJxbjfLp1vymzfVN/rUSu7NFfwM27TjFOxcEJErT+R82ivD+XXC3ZWylDTpvE/Ebzm6hUwz4bOsdTAqXcC6BA2A= X-Received: by 2002:a17:902:ccce:: with SMTP id z14mr815477ple.34.1644257292200; Mon, 07 Feb 2022 10:08:12 -0800 (PST) MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-2-hch@lst.de> In-Reply-To: <20220207063249.1833066-2-hch@lst.de> From: Dan Williams Date: Mon, 7 Feb 2022 10:08:01 -0800 Message-ID: Subject: Re: [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , Karol Herbst , Linux MM , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. Looks good to me. Reviewed-by: Dan Williams