From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56A1C4727E for ; Wed, 7 Oct 2020 22:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91BC320882 for ; Wed, 7 Oct 2020 22:29:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="C9Ia3VCK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728875AbgJGW3e (ORCPT ); Wed, 7 Oct 2020 18:29:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728849AbgJGW3e (ORCPT ); Wed, 7 Oct 2020 18:29:34 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF9BEC0613D5 for ; Wed, 7 Oct 2020 15:29:33 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id i5so3850851edr.5 for ; Wed, 07 Oct 2020 15:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CTESbqWcckMo/4i92TzIl4y3TmAuiek3Eq/3qJ27aVE=; b=C9Ia3VCKylLvch2Mm4CFE1Tgnfv5R+vpt+Gkie2pCUYaMg+MkmANBvB5fv/6gLxHxE bqKJ+r7mFS4NA8UmxE4KYJZ33h0CYTX0aZwWDh5/vd1BekkHTnqpnKypSF28zWn4K8H0 LKnkgKM1Z6rkuZBOAzYfh5nH/xOSDZ3VaVqsFGiTKhdbNpRTH5LDgJn++bCaD2RQJ9I2 b/yb82cHyyvSeJ6CHCNH7JIYmVCxoXypsBHBMmGij+CrG19A8lbexSM+QLvs1Sqc47pm mzhEavRU8o1d5Wa2DTKdErhBCi8bj8r7+t/oYkUYIZbU0ZApbdX2cmoy5guFURB/fOut NK3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CTESbqWcckMo/4i92TzIl4y3TmAuiek3Eq/3qJ27aVE=; b=VTBZu8nVWfuDd4JSjTm0p/z6NIxQkO81QxDt5NLd/7z4pkd3XOilV8D0e7g6EPxDKc L8TyLmgB0952HCTgEiOeWpewKu1DEJCxXYY0+qEhIASmFAq4S0nhvLF/kX2cDcGJpduH hIfpJgnuPNXqebHFI7oVyNR9D1W92AbgP+3LxOeRRdUVtUcZ2N1b9pD3dNPjZlGLeJ+2 ZwNRwyYte2vOyB+7QmFVQCEl+G3KDbF0etMYE5NBgdbXjh/aAtksAEWPZpemliKnX/nG mg2SF8ARdbLsyX8rCW9zY5OIWnahi58Vq5urzaACMmbgdtSTRTQZF5Fvk48gWezu05Va 1WZQ== X-Gm-Message-State: AOAM533cz/1NDSLqXhkigGjoQqdn1BPtdQOlEvC5AUZLoXjuoL3VsqOv ld+Wd3yjk7XqmZ219kVkHvdPJxc8H7eYoB/dGLo8nsfqCb+YCg== X-Google-Smtp-Source: ABdhPJz1RyJuGe8nKXGB7ItsvvZPLSvoGDx42NmD5N6TVh8ahpXgSpJt+qJCvPDzRQV+I/1aLUWOgK4iRugm3Y5SJFU= X-Received: by 2002:a50:9ea6:: with SMTP id a35mr6269472edf.52.1602109772370; Wed, 07 Oct 2020 15:29:32 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-11-daniel.vetter@ffwll.ch> In-Reply-To: From: Dan Williams Date: Wed, 7 Oct 2020 15:29:21 -0700 Message-ID: Subject: Re: [PATCH 10/13] PCI: revoke mappings like devmem To: Daniel Vetter Cc: DRI Development , LKML , KVM list , Linux MM , Linux ARM , linux-samsung-soc , "Linux-media@vger.kernel.org" , linux-s390 , Daniel Vetter , Jason Gunthorpe , Kees Cook , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Bjorn Helgaas , Linux PCI Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 7, 2020 at 3:23 PM Dan Williams wrote: > > On Wed, Oct 7, 2020 at 12:49 PM Daniel Vetter wrote: > > > > On Wed, Oct 7, 2020 at 9:33 PM Dan Williams wrote: > > > > > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter wrote: > > > > > > > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > > > the region") /dev/kmem zaps ptes when the kernel requests exclusive > > > > acccess to an iomem region. And with CONFIG_IO_STRICT_DEVMEM, this is > > > > the default for all driver uses. > > > > > > > > Except there's two more ways to access pci bars: sysfs and proc mmap > > > > support. Let's plug that hole. > > > > > > Ooh, yes, lets. > > > > > > > For revoke_devmem() to work we need to link our vma into the same > > > > address_space, with consistent vma->vm_pgoff. ->pgoff is already > > > > adjusted, because that's how (io_)remap_pfn_range works, but for the > > > > mapping we need to adjust vma->vm_file->f_mapping. Usually that's done > > > > at ->open time, but that's a bit tricky here with all the entry points > > > > and arch code. So instead create a fake file and adjust vma->vm_file. > > > > > > I don't think you want to share the devmem inode for this, this should > > > be based off the sysfs inode which I believe there is already only one > > > instance per resource. In contrast /dev/mem can have multiple inodes > > > because anyone can just mknod a new character device file, the same > > > problem does not exist for sysfs. > > > > But then I need to find the right one, plus I also need to find the > > right one for the procfs side. That gets messy, and I already have no > > idea how to really test this. Shared address_space is the same trick > > we're using in drm (where we have multiple things all pointing to the > > same underlying resources, through different files), and it gets the > > job done. So that's why I figured the shared address_space is the > > cleaner solution since then unmap_mapping_range takes care of > > iterating over all vma for us. I guess I could reimplement that logic > > with our own locking and everything in revoke_devmem, but feels a bit > > silly. But it would also solve the problem of having mutliple > > different mknod of /dev/kmem with different address_space behind them. > > Also because of how remap_pfn_range works, all these vma do use the > > same pgoff already anyway. > > True, remap_pfn_range() makes sure that ->pgoff is an absolute > physical address offset for all use cases. So you might be able to > just point proc_bus_pci_open() at the shared devmem address space. For > sysfs it's messier. I think you would need to somehow get the inode > from kernfs_fop_open() to adjust its address space, but only if the > bin_file will ultimately be used for PCI memory. To me this seems like a new sysfs_create_bin_file() flavor that registers the file with the common devmem address_space. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08327C4363D for ; Wed, 7 Oct 2020 22:31:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C3D82083B for ; Wed, 7 Oct 2020 22:31:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BbeOHRvp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="C9Ia3VCK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C3D82083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s8rUvmGs1xVb2OOw3+4Cc4Oa1cqUxWQWazESjEJ8/oU=; b=BbeOHRvpgDbqipV24Yxo5x6Nc 8Vr7bEvOoaX/SWLK8p0MVE5yBlUJjIL2a6M6Ztc3j684u7JK/KJxTBmdIE4EEJv0U1V5cZdQ6KrHI D+Iw9ztrjOAXnkoBJvNxa29lOW2r5I+sP4o2CPb6+GmI5f2zkznJu5xgiENW5UZY8lF6ldNDEvAvi rjuT8c5LLnNWdDcha6bkgaV+/ExFiERwKMb21Zd5DXcmtQDJt9o26vZdtYFl+4bw6VDrG1Rk5hAbh p1bUYLW7skxYhEuFWDX0RKazfBkSxg2EPWUdBSEF09E1/bVUbSeMbIXEFkca6/XCl5uA3UK+H/JMr oaZ+c8QhA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQHwG-0004tE-Nf; Wed, 07 Oct 2020 22:29:36 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQHwD-0004sW-KY for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 22:29:34 +0000 Received: by mail-ed1-x542.google.com with SMTP id cq12so3864582edb.2 for ; Wed, 07 Oct 2020 15:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CTESbqWcckMo/4i92TzIl4y3TmAuiek3Eq/3qJ27aVE=; b=C9Ia3VCKylLvch2Mm4CFE1Tgnfv5R+vpt+Gkie2pCUYaMg+MkmANBvB5fv/6gLxHxE bqKJ+r7mFS4NA8UmxE4KYJZ33h0CYTX0aZwWDh5/vd1BekkHTnqpnKypSF28zWn4K8H0 LKnkgKM1Z6rkuZBOAzYfh5nH/xOSDZ3VaVqsFGiTKhdbNpRTH5LDgJn++bCaD2RQJ9I2 b/yb82cHyyvSeJ6CHCNH7JIYmVCxoXypsBHBMmGij+CrG19A8lbexSM+QLvs1Sqc47pm mzhEavRU8o1d5Wa2DTKdErhBCi8bj8r7+t/oYkUYIZbU0ZApbdX2cmoy5guFURB/fOut NK3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CTESbqWcckMo/4i92TzIl4y3TmAuiek3Eq/3qJ27aVE=; b=pgPv33L72g0FQRH183tIdLXnqDWPK1/whNYX2rcdDtZfkTr0JMQ/gwlzfPaG6N90Fe 904cWoDtKXU2fRKgwdBmV3zKovtHDmFpvJlGUojtQW0WKmJkPHVTwAzo6NFlfK7cRQ0b vqUmX2LyHg4nPouKhss1Te9RqN1T3Q8oHVV/Hbmw7JR0wrkdafLYknHtV9mCwUUb0/JA 6cIypxdqcEWoPUu/xDyl5U27Ti7ghRP5ne8t/9SA2tyMslc3cfwXqkYq0yVJcP1ql31I M7tlIc5lRnsOxWZxtOsdzCIGn2eLD8TXukbwZ01ETMrRy8mPUZpja40bnYEMv0deQCnu rd0Q== X-Gm-Message-State: AOAM531YqerWjSG0MTw/+8TPnO+Bjk3vSPPKF1b+5egR3IiKgntRIqIe c8rTRitdXQQ/R636zbY7CYYWn7owLo1h9eTtKiWiUg== X-Google-Smtp-Source: ABdhPJz1RyJuGe8nKXGB7ItsvvZPLSvoGDx42NmD5N6TVh8ahpXgSpJt+qJCvPDzRQV+I/1aLUWOgK4iRugm3Y5SJFU= X-Received: by 2002:a50:9ea6:: with SMTP id a35mr6269472edf.52.1602109772370; Wed, 07 Oct 2020 15:29:32 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-11-daniel.vetter@ffwll.ch> In-Reply-To: From: Dan Williams Date: Wed, 7 Oct 2020 15:29:21 -0700 Message-ID: Subject: Re: [PATCH 10/13] PCI: revoke mappings like devmem To: Daniel Vetter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_182933_710021_52D44474 X-CRM114-Status: GOOD ( 29.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390 , linux-samsung-soc , Jan Kara , Kees Cook , KVM list , Jason Gunthorpe , John Hubbard , LKML , DRI Development , Linux MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Linux PCI , Bjorn Helgaas , Daniel Vetter , Andrew Morton , Linux ARM , "Linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 7, 2020 at 3:23 PM Dan Williams wrote: > > On Wed, Oct 7, 2020 at 12:49 PM Daniel Vetter wrote: > > > > On Wed, Oct 7, 2020 at 9:33 PM Dan Williams wrote: > > > > > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter wrote: > > > > > > > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > > > the region") /dev/kmem zaps ptes when the kernel requests exclusive > > > > acccess to an iomem region. And with CONFIG_IO_STRICT_DEVMEM, this is > > > > the default for all driver uses. > > > > > > > > Except there's two more ways to access pci bars: sysfs and proc mmap > > > > support. Let's plug that hole. > > > > > > Ooh, yes, lets. > > > > > > > For revoke_devmem() to work we need to link our vma into the same > > > > address_space, with consistent vma->vm_pgoff. ->pgoff is already > > > > adjusted, because that's how (io_)remap_pfn_range works, but for the > > > > mapping we need to adjust vma->vm_file->f_mapping. Usually that's done > > > > at ->open time, but that's a bit tricky here with all the entry points > > > > and arch code. So instead create a fake file and adjust vma->vm_file. > > > > > > I don't think you want to share the devmem inode for this, this should > > > be based off the sysfs inode which I believe there is already only one > > > instance per resource. In contrast /dev/mem can have multiple inodes > > > because anyone can just mknod a new character device file, the same > > > problem does not exist for sysfs. > > > > But then I need to find the right one, plus I also need to find the > > right one for the procfs side. That gets messy, and I already have no > > idea how to really test this. Shared address_space is the same trick > > we're using in drm (where we have multiple things all pointing to the > > same underlying resources, through different files), and it gets the > > job done. So that's why I figured the shared address_space is the > > cleaner solution since then unmap_mapping_range takes care of > > iterating over all vma for us. I guess I could reimplement that logic > > with our own locking and everything in revoke_devmem, but feels a bit > > silly. But it would also solve the problem of having mutliple > > different mknod of /dev/kmem with different address_space behind them. > > Also because of how remap_pfn_range works, all these vma do use the > > same pgoff already anyway. > > True, remap_pfn_range() makes sure that ->pgoff is an absolute > physical address offset for all use cases. So you might be able to > just point proc_bus_pci_open() at the shared devmem address space. For > sysfs it's messier. I think you would need to somehow get the inode > from kernfs_fop_open() to adjust its address space, but only if the > bin_file will ultimately be used for PCI memory. To me this seems like a new sysfs_create_bin_file() flavor that registers the file with the common devmem address_space. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57EFC4363D for ; Wed, 7 Oct 2020 22:29:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 579412083B for ; Wed, 7 Oct 2020 22:29:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="C9Ia3VCK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 579412083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DDE8E6E9BA; Wed, 7 Oct 2020 22:29:34 +0000 (UTC) Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id C84716E9BA for ; Wed, 7 Oct 2020 22:29:33 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id b12so3819379edz.11 for ; Wed, 07 Oct 2020 15:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CTESbqWcckMo/4i92TzIl4y3TmAuiek3Eq/3qJ27aVE=; b=C9Ia3VCKylLvch2Mm4CFE1Tgnfv5R+vpt+Gkie2pCUYaMg+MkmANBvB5fv/6gLxHxE bqKJ+r7mFS4NA8UmxE4KYJZ33h0CYTX0aZwWDh5/vd1BekkHTnqpnKypSF28zWn4K8H0 LKnkgKM1Z6rkuZBOAzYfh5nH/xOSDZ3VaVqsFGiTKhdbNpRTH5LDgJn++bCaD2RQJ9I2 b/yb82cHyyvSeJ6CHCNH7JIYmVCxoXypsBHBMmGij+CrG19A8lbexSM+QLvs1Sqc47pm mzhEavRU8o1d5Wa2DTKdErhBCi8bj8r7+t/oYkUYIZbU0ZApbdX2cmoy5guFURB/fOut NK3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CTESbqWcckMo/4i92TzIl4y3TmAuiek3Eq/3qJ27aVE=; b=F3C9hGQhrEsmH/AgnUcDPqHphU+UJ3m+GKgXW/qxHH+PmA5gzjJfQpGg7SKASfvdes LEfa2C3v8lGgmnHLr4HWjIEtuLOtHzWnH/dpCgQ0u6N/KYDl4fiVDs69SwRpW3WIFtiz UfovHCKzuPMvCqfh2+czHfJvJ/yoB6Il9RQRhhN+kdGOsBM7WtWzd6dgcBGnn9EWQDJj ZBTUmI+JBxachJT23KGQq0dqddE8R7iDLaCUIgGUI+xhkqoBZ2w+2oLxZ8GeJo6m3W6G P9muaOJWOLAVegzKnGfPhATDtrgml6uW8Plh8jSP1uwWaRxKGcL3W0gNrO5RBT8n+X5d Nk+g== X-Gm-Message-State: AOAM531n1/NgUsTE5ixyW64RVAdy/tcfuqWq9PSVpeNFse9jh9+3wDda UizL36BRMLL9N48wGkLqTNhFMqqnrRTaPCXfioT5jw== X-Google-Smtp-Source: ABdhPJz1RyJuGe8nKXGB7ItsvvZPLSvoGDx42NmD5N6TVh8ahpXgSpJt+qJCvPDzRQV+I/1aLUWOgK4iRugm3Y5SJFU= X-Received: by 2002:a50:9ea6:: with SMTP id a35mr6269472edf.52.1602109772370; Wed, 07 Oct 2020 15:29:32 -0700 (PDT) MIME-Version: 1.0 References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-11-daniel.vetter@ffwll.ch> In-Reply-To: From: Dan Williams Date: Wed, 7 Oct 2020 15:29:21 -0700 Message-ID: Subject: Re: [PATCH 10/13] PCI: revoke mappings like devmem To: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390 , linux-samsung-soc , Jan Kara , Kees Cook , KVM list , Jason Gunthorpe , John Hubbard , LKML , DRI Development , Linux MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Linux PCI , Bjorn Helgaas , Daniel Vetter , Andrew Morton , Linux ARM , "Linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 7, 2020 at 3:23 PM Dan Williams wrote: > > On Wed, Oct 7, 2020 at 12:49 PM Daniel Vetter wrote: > > > > On Wed, Oct 7, 2020 at 9:33 PM Dan Williams wrote: > > > > > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter wrote: > > > > > > > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > > > the region") /dev/kmem zaps ptes when the kernel requests exclusive > > > > acccess to an iomem region. And with CONFIG_IO_STRICT_DEVMEM, this is > > > > the default for all driver uses. > > > > > > > > Except there's two more ways to access pci bars: sysfs and proc mmap > > > > support. Let's plug that hole. > > > > > > Ooh, yes, lets. > > > > > > > For revoke_devmem() to work we need to link our vma into the same > > > > address_space, with consistent vma->vm_pgoff. ->pgoff is already > > > > adjusted, because that's how (io_)remap_pfn_range works, but for the > > > > mapping we need to adjust vma->vm_file->f_mapping. Usually that's done > > > > at ->open time, but that's a bit tricky here with all the entry points > > > > and arch code. So instead create a fake file and adjust vma->vm_file. > > > > > > I don't think you want to share the devmem inode for this, this should > > > be based off the sysfs inode which I believe there is already only one > > > instance per resource. In contrast /dev/mem can have multiple inodes > > > because anyone can just mknod a new character device file, the same > > > problem does not exist for sysfs. > > > > But then I need to find the right one, plus I also need to find the > > right one for the procfs side. That gets messy, and I already have no > > idea how to really test this. Shared address_space is the same trick > > we're using in drm (where we have multiple things all pointing to the > > same underlying resources, through different files), and it gets the > > job done. So that's why I figured the shared address_space is the > > cleaner solution since then unmap_mapping_range takes care of > > iterating over all vma for us. I guess I could reimplement that logic > > with our own locking and everything in revoke_devmem, but feels a bit > > silly. But it would also solve the problem of having mutliple > > different mknod of /dev/kmem with different address_space behind them. > > Also because of how remap_pfn_range works, all these vma do use the > > same pgoff already anyway. > > True, remap_pfn_range() makes sure that ->pgoff is an absolute > physical address offset for all use cases. So you might be able to > just point proc_bus_pci_open() at the shared devmem address space. For > sysfs it's messier. I think you would need to somehow get the inode > from kernfs_fop_open() to adjust its address space, but only if the > bin_file will ultimately be used for PCI memory. To me this seems like a new sysfs_create_bin_file() flavor that registers the file with the common devmem address_space. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel