From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49880C433ED for ; Wed, 5 May 2021 22:34:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1785613C0 for ; Wed, 5 May 2021 22:34:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1785613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5341E6B006C; Wed, 5 May 2021 18:34:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3C86B006E; Wed, 5 May 2021 18:34:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35D4D6B0070; Wed, 5 May 2021 18:34:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 179936B006C for ; Wed, 5 May 2021 18:34:56 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D80D0181AEF09 for ; Wed, 5 May 2021 22:34:55 +0000 (UTC) X-FDA: 78108633750.19.42771DE Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf11.hostedemail.com (Postfix) with ESMTP id E90542000241 for ; Wed, 5 May 2021 22:34:35 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id y7so5269528ejj.9 for ; Wed, 05 May 2021 15:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B1bm9uJX30iPwZls3eRhxhkP/DbQdOuBZzDJzJyq+2I=; b=EFgg2BvMDvkr9HS5wBP8RzrFMmKRNRLT4ZsUlkUW5MxTzaAG758PvgHZDX6erpf1W8 OuFhBoWMGuYMLS/qTKt3YoXY/B8An3fvpbnzWx6DZGOVwVWg0sPKlSYODmqO4mAAHZ+s GdJNyEEoP3dXCmWOeTIYjmsDtziqLVHcgySJsF6+0jRObqf9QtdtUuh5t3enkjfIz6DM omtiNzJJpCwMjtFTYc54S4TNKjtJaV6C4cCa81L8jfu7JfqrVW7Qn2b8awvslSILBP7b ITHfdPKapQIJYiJgp5lK+/TzDTC0Q/W8D7j0P+tKDdL2pBwM0Gk+1Jo68K9BmRwKOjkt VlmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B1bm9uJX30iPwZls3eRhxhkP/DbQdOuBZzDJzJyq+2I=; b=VffJrcd8FZgyHqQB5/U0ULCTmidxNK6daSAeP8mvcNB7joZX8CjFQV+5IbsbwdHC1G BNoh66zEndkjPUkqkXqdSYqlkf2Pbhp5VYVLz/EcK8YbhsrJqDCBmrb4V1Ra2XBLcJxJ 9E0NNQRGugRkV+gMY4WcbGJRGH7MY29JQ+CkBWDRWUOnAVRVDKqLgVm93ondxM28X6Sh KxHZEq4Tk28YutWXk5a8QlUlzCiPj+zWxMfag/8Xfcu4bxV2prFzgQNO6vB+Ptj/60Zc YT0OeEQquhkbPKufghqc/DbXgdK+neIfOkxmDaYxquhE67DzLXMIY+lky6HaGa6lu/AP 60JA== X-Gm-Message-State: AOAM530AjIPwSfMJn4+0cSsuuynJGicqbqwNzW7Ge/GtBiC8DUAQ3uXe NKPZw9BwPiz5+5WSY/EIO/fqY6EZ3feb2xevWrYYfQ== X-Google-Smtp-Source: ABdhPJx1MBEljZ3xcoj0GQnKnzUMPQV7wGRSF4ZNYBLUGHBQDVcb+JN5tEMQt4PocQ5of1gymzvVs1VRU0eqQqhNTBw= X-Received: by 2002:a17:906:33da:: with SMTP id w26mr1056579eja.472.1620254090125; Wed, 05 May 2021 15:34:50 -0700 (PDT) MIME-Version: 1.0 References: <20210325230938.30752-1-joao.m.martins@oracle.com> <20210325230938.30752-6-joao.m.martins@oracle.com> In-Reply-To: <20210325230938.30752-6-joao.m.martins@oracle.com> From: Dan Williams Date: Wed, 5 May 2021 15:34:54 -0700 Message-ID: Subject: Re: [PATCH v1 05/11] mm/sparse-vmemmap: add a pgmap argument to section activation To: Joao Martins Cc: Linux MM , Ira Weiny , linux-nvdimm , Matthew Wilcox , Jason Gunthorpe , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton , Oscar Salvador Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel-com.20150623.gappssmtp.com header.s=20150623 header.b=EFgg2BvM; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf11.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.218.54) smtp.mailfrom=dan.j.williams@intel.com X-Rspamd-Server: rspam03 X-Stat-Signature: ytoxex9g5jocmqauexz7gr98a6cbosjb X-Rspamd-Queue-Id: E90542000241 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail-ej1-f54.google.com; client-ip=209.85.218.54 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620254075-797934 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 25, 2021 at 4:10 PM Joao Martins wrote: > > @altmap is stored in a dev_pagemap, but it will be repurposed for > hotplug memory for storing the memmap in the hotplugged memory[*] and > reusing the altmap infrastructure to that end. This is to say that > altmap can't be replaced with a @pgmap as it is going to cover more than > dev_pagemap backend altmaps. I was going to say, just pass the pgmap and lookup the altmap from pgmap, but Oscar added a use case for altmap independent of pgmap. So you might refresh this commit message to clarify why passing pgmap by itself is not sufficient. Other than that, looks good. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A4DC433B4 for ; Wed, 5 May 2021 22:34:56 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6710613C0 for ; Wed, 5 May 2021 22:34:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6710613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 96BCD100F2257; Wed, 5 May 2021 15:34:55 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::629; helo=mail-ej1-x629.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BF56B100EB85D for ; Wed, 5 May 2021 15:34:51 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id l4so5263777ejc.10 for ; Wed, 05 May 2021 15:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B1bm9uJX30iPwZls3eRhxhkP/DbQdOuBZzDJzJyq+2I=; b=EFgg2BvMDvkr9HS5wBP8RzrFMmKRNRLT4ZsUlkUW5MxTzaAG758PvgHZDX6erpf1W8 OuFhBoWMGuYMLS/qTKt3YoXY/B8An3fvpbnzWx6DZGOVwVWg0sPKlSYODmqO4mAAHZ+s GdJNyEEoP3dXCmWOeTIYjmsDtziqLVHcgySJsF6+0jRObqf9QtdtUuh5t3enkjfIz6DM omtiNzJJpCwMjtFTYc54S4TNKjtJaV6C4cCa81L8jfu7JfqrVW7Qn2b8awvslSILBP7b ITHfdPKapQIJYiJgp5lK+/TzDTC0Q/W8D7j0P+tKDdL2pBwM0Gk+1Jo68K9BmRwKOjkt VlmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B1bm9uJX30iPwZls3eRhxhkP/DbQdOuBZzDJzJyq+2I=; b=A4E2q7T0qw8wX7qGw1qSysRy3GC3nFrkN8EpJvDz/dhL0SlITbXYIChGiGZDe8L01F MhApjoqdfLYw1AzlQ40G/6kKwEmV2X/VPg+65/hyHPOWbGR0nqAaShJEE1J4GrjINykY lLhhSx+khM872BiZZYC61DtQRv15QmbMtuY36xnv2RWzddWO0CVUuzjiF/Ffz7L1v2Ta PmYjpshV2Tba2nVVrOUZvepXs24sQGc8227rvdOm9QeG5Ktrl0iGQF0Z4KopzMKJpVk2 ZxIB/48CnNrdy7Hu1J6E2Qavxl72W/XzxPy6PUWC8ZGaSe97V234szbH/TYagdWOBEaw xScw== X-Gm-Message-State: AOAM532tIe+E03I5X+ajgmBqgC27MVFbJgnKGyCMgn1SzcfZQfO439Ww p+TRiAQrZgawto6hYqKKFj6jptpEjiHUcxyTYaeEJA== X-Google-Smtp-Source: ABdhPJx1MBEljZ3xcoj0GQnKnzUMPQV7wGRSF4ZNYBLUGHBQDVcb+JN5tEMQt4PocQ5of1gymzvVs1VRU0eqQqhNTBw= X-Received: by 2002:a17:906:33da:: with SMTP id w26mr1056579eja.472.1620254090125; Wed, 05 May 2021 15:34:50 -0700 (PDT) MIME-Version: 1.0 References: <20210325230938.30752-1-joao.m.martins@oracle.com> <20210325230938.30752-6-joao.m.martins@oracle.com> In-Reply-To: <20210325230938.30752-6-joao.m.martins@oracle.com> From: Dan Williams Date: Wed, 5 May 2021 15:34:54 -0700 Message-ID: Subject: Re: [PATCH v1 05/11] mm/sparse-vmemmap: add a pgmap argument to section activation To: Joao Martins Message-ID-Hash: 5OUL3DYI37SER3L5RHTFLM6KSHS5ZGR5 X-Message-ID-Hash: 5OUL3DYI37SER3L5RHTFLM6KSHS5ZGR5 X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Linux MM , linux-nvdimm , Matthew Wilcox , Jason Gunthorpe , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton , Oscar Salvador X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Mar 25, 2021 at 4:10 PM Joao Martins wrote: > > @altmap is stored in a dev_pagemap, but it will be repurposed for > hotplug memory for storing the memmap in the hotplugged memory[*] and > reusing the altmap infrastructure to that end. This is to say that > altmap can't be replaced with a @pgmap as it is going to cover more than > dev_pagemap backend altmaps. I was going to say, just pass the pgmap and lookup the altmap from pgmap, but Oscar added a use case for altmap independent of pgmap. So you might refresh this commit message to clarify why passing pgmap by itself is not sufficient. Other than that, looks good. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org