From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A4CF2C9C for ; Mon, 7 Feb 2022 23:42:51 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id d187so15748840pfa.10 for ; Mon, 07 Feb 2022 15:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xL7zYBxlDA9OyfIUt1+hVo3jnzbaDpzhjP+X9npLjjg=; b=wphYccQt9nxerxeU/p5xPEp3OdfAMZRtra+QtigCBGV2rEpNVW9+U6vtvsejhTgn8e AjHdHHleGcguuyudfB/EYL8nXm+kpV8ZcSykDngC+byWUyRxqjSZ/RPjTH8AXc+RnLns uIgVupROuzl/7/rcKGowF45+b0zBguco1bdtkEO3QuTU6AEph9xDvvOseyxx2hOke+gU uNJF3+A19rkf9glt328qDrxjnlD9a+5MH5956bLQ7wt6C83PtpfdJpKPQIdDraMVj14L rYSrK3ggYTWNdNsRn2y7f5gnAE9dOOC2PJVNruXRQWVHXWccOP1/uFHHzbWsGMDwZaME cPJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xL7zYBxlDA9OyfIUt1+hVo3jnzbaDpzhjP+X9npLjjg=; b=KThX7Iiujfv/RqQT113TQZZIRDskq1ZsfZwybbO5NPr4yXbjzCYUUB5rLPh5htZuIv FFxeiTfo0eVVsKt0dV0d13vV3cJv1cXXfBfj2xzjiJYZ1v5LipL19nA72H2wyi3WpAxp dkGLdjUV9mwRTN0UqPWzc25Dy4vLLRsavJ87lCsFFNC3j7b+asyDMHEPdbFkn0YiApoU Qg0Cev4ZksGEL8AeCsgknynaHZRrMPVBL+iyBfefuJmChevmIMeoSYyhpMzARYg2yxhK JzgtcSIeUMCVXfv9YYS8ye9NYK8J45U/a4jY/NNUd3w/ZEmUGws9FHKVVYTsnJ7T82un j27A== X-Gm-Message-State: AOAM533AlGnqX4OvfbVhhDj+buaQg89oygiZMeptML2X+ISHR94WPNDp rSOqrJTSgfhhTlAX3boiKEXsvBD3fwWDvsXGHXbNrA== X-Google-Smtp-Source: ABdhPJwrqWzltx/fzSQ9DuX2BTfk2qmQ+rOek9DuscJqYjd5cc23devekMbaCYKV7qKyZJb3bcu/cjHgnw2J/KhyG60= X-Received: by 2002:a65:484b:: with SMTP id i11mr1385516pgs.40.1644277370737; Mon, 07 Feb 2022 15:42:50 -0800 (PST) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-6-hch@lst.de> In-Reply-To: <20220207063249.1833066-6-hch@lst.de> From: Dan Williams Date: Mon, 7 Feb 2022 15:42:39 -0800 Message-ID: Subject: Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages To: Christoph Hellwig Cc: Andrew Morton , Felix Kuehling , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Jason Gunthorpe , Alistair Popple , Logan Gunthorpe , Ralph Campbell , Linux Kernel Mailing List , amd-gfx list , Maling list - DRI developers , nouveau@lists.freedesktop.org, Linux NVDIMM , Linux MM Content-Type: text/plain; charset="UTF-8" On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. Looks good to me: Reviewed-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACCD0C433FE for ; Mon, 7 Feb 2022 23:42:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F23910E11A; Mon, 7 Feb 2022 23:42:52 +0000 (UTC) Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AE5510E3D0 for ; Mon, 7 Feb 2022 23:42:51 +0000 (UTC) Received: by mail-pf1-x430.google.com with SMTP id y5so14831403pfe.4 for ; Mon, 07 Feb 2022 15:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xL7zYBxlDA9OyfIUt1+hVo3jnzbaDpzhjP+X9npLjjg=; b=wphYccQt9nxerxeU/p5xPEp3OdfAMZRtra+QtigCBGV2rEpNVW9+U6vtvsejhTgn8e AjHdHHleGcguuyudfB/EYL8nXm+kpV8ZcSykDngC+byWUyRxqjSZ/RPjTH8AXc+RnLns uIgVupROuzl/7/rcKGowF45+b0zBguco1bdtkEO3QuTU6AEph9xDvvOseyxx2hOke+gU uNJF3+A19rkf9glt328qDrxjnlD9a+5MH5956bLQ7wt6C83PtpfdJpKPQIdDraMVj14L rYSrK3ggYTWNdNsRn2y7f5gnAE9dOOC2PJVNruXRQWVHXWccOP1/uFHHzbWsGMDwZaME cPJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xL7zYBxlDA9OyfIUt1+hVo3jnzbaDpzhjP+X9npLjjg=; b=k5agAszI7rWXBaV80TXp2FnKYNV1KFSGyUjZBqiKNl+tJ6QRtjIEt5dKgJHNaegpXp cbgIBAs16MAmIY24dLS1OqwfbJRcT4j9cjaNDECYfSA7+oextnMolxKH/ybB4qy6rLts Rl3Nb7W24oyZCb9l583siMU97vFFzQYs+urwUmIjXhDOVzipdNlJsRLbLic0gaTgDYMV r8YLxoIkI/01uZriN6E4pYHHSMrlxhhwWnbEXuei74p86oJqPXPtyyiLwlRAPyEvDcUl ZyImc/cOJnHV5jaiNEzaBKuzCWW5p36lag3nsh9vpsoHWK/rjC/qqSyXFfY8Ybui9Wo1 aRaw== X-Gm-Message-State: AOAM5301U69EAZuBR4LSSZiLaUcss++d3Z8jfh7cKDQHYauaZt7NgF9v PQ/PeXpIZ33iBHqUN/p3wXE5urOJWNmAPmoEnyvSGg== X-Google-Smtp-Source: ABdhPJwrqWzltx/fzSQ9DuX2BTfk2qmQ+rOek9DuscJqYjd5cc23devekMbaCYKV7qKyZJb3bcu/cjHgnw2J/KhyG60= X-Received: by 2002:a65:484b:: with SMTP id i11mr1385516pgs.40.1644277370737; Mon, 07 Feb 2022 15:42:50 -0800 (PST) MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-6-hch@lst.de> In-Reply-To: <20220207063249.1833066-6-hch@lst.de> From: Dan Williams Date: Mon, 7 Feb 2022 15:42:39 -0800 Message-ID: To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Subject: Re: [Nouveau] [PATCH 5/8] mm: simplify freeing of devmap managed pages X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , Linux MM , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. Looks good to me: Reviewed-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4422EC433EF for ; Mon, 7 Feb 2022 23:42:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F33210E3D0; Mon, 7 Feb 2022 23:42:52 +0000 (UTC) Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2319710E11A for ; Mon, 7 Feb 2022 23:42:51 +0000 (UTC) Received: by mail-pf1-x436.google.com with SMTP id n32so15747978pfv.11 for ; Mon, 07 Feb 2022 15:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xL7zYBxlDA9OyfIUt1+hVo3jnzbaDpzhjP+X9npLjjg=; b=wphYccQt9nxerxeU/p5xPEp3OdfAMZRtra+QtigCBGV2rEpNVW9+U6vtvsejhTgn8e AjHdHHleGcguuyudfB/EYL8nXm+kpV8ZcSykDngC+byWUyRxqjSZ/RPjTH8AXc+RnLns uIgVupROuzl/7/rcKGowF45+b0zBguco1bdtkEO3QuTU6AEph9xDvvOseyxx2hOke+gU uNJF3+A19rkf9glt328qDrxjnlD9a+5MH5956bLQ7wt6C83PtpfdJpKPQIdDraMVj14L rYSrK3ggYTWNdNsRn2y7f5gnAE9dOOC2PJVNruXRQWVHXWccOP1/uFHHzbWsGMDwZaME cPJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xL7zYBxlDA9OyfIUt1+hVo3jnzbaDpzhjP+X9npLjjg=; b=2ho4isvkVz3+4AlHDn2yydJWTM6oERN55gS8MuCSSYdYM/kBARpz8285xbBqDNIaNN vVPAlGMPKa1Eglrrgxw5lTGIHXtvZBFTU5bYwbq2WedtYi1kY8AgZC/pG+4CfWbZBqtJ aaUjVCVf/pek+lLy3dqZypemGmU5AqQgcCeEs5gLHI3pSte387RiERYqv3g/aDj7yhqT zKhe0QqllZoIfqD3kBiLCZWRMIYOAbwajoHIJ6KJT8mcceheOdLVhwHQjhyX25fY8UA6 eWvz24gsCkU+AJHfDvBKUGOHti5p7bOHqYD91Dz0S/nLHiJcJL5z8g8vGLxukClc4/T0 06Fg== X-Gm-Message-State: AOAM533ZXajGc95ArVNVaITlXYQerG//gjQhUmOrP96kceSxaDrGxk6l e+JMLze3CPqZGK1LXMaiMTB5cc/B+4zND89wsbcp4w== X-Google-Smtp-Source: ABdhPJwrqWzltx/fzSQ9DuX2BTfk2qmQ+rOek9DuscJqYjd5cc23devekMbaCYKV7qKyZJb3bcu/cjHgnw2J/KhyG60= X-Received: by 2002:a65:484b:: with SMTP id i11mr1385516pgs.40.1644277370737; Mon, 07 Feb 2022 15:42:50 -0800 (PST) MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-6-hch@lst.de> In-Reply-To: <20220207063249.1833066-6-hch@lst.de> From: Dan Williams Date: Mon, 7 Feb 2022 15:42:39 -0800 Message-ID: Subject: Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , Karol Herbst , Linux MM , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. Looks good to me: Reviewed-by: Dan Williams