From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F4EC433E6 for ; Tue, 9 Mar 2021 20:47:08 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 220B06523B for ; Tue, 9 Mar 2021 20:47:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 220B06523B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id D4A33100EB858; Tue, 9 Mar 2021 12:47:07 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::62b; helo=mail-ej1-x62b.google.com; envelope-from=dan.j.williams@intel.com; receiver= Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C2DA9100EB855 for ; Tue, 9 Mar 2021 12:47:04 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id jt13so31640696ejb.0 for ; Tue, 09 Mar 2021 12:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rxekq9CmjmqiQezEq23fxoA2lWRbGVUv5ZHopeMn1UE=; b=cnHrmQr/VMb/t2E/EgCby5Ir+NbwqGQ0u5beELJg+31cT1IgztSHwumMnd5zdcoDB2 66n4NERbQg+uvwjesYYTCrNMtq9i9BOp/xxNWs/vGHWpji0JOhm5y/MI1V1Ox4Pc4WRW tBCkqmAvU9bVb4X02t4bXL1znuI21REF0jrmhFii+VAU1w787tzlvvkSi8J6MFfQp9Qc pDQjCC5HheYIdn0dNKCnxnEBuaRZu7xTQPpa9IDV/OMAz50a7gzVrpOYTiwkLGnkyiNv Xl9tJ2GvH5S31+9GqAUexpRyDEuTmNjlBu3J2Ogs0+mgYdfyBUBeIAD+tjEcWDtq2eIa u1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rxekq9CmjmqiQezEq23fxoA2lWRbGVUv5ZHopeMn1UE=; b=jkaG9xbQN4aRUbRBTScU7GLGLhQLOrNT05eZV+2yPXYM5pfgGRtTtxnpD7DzkBHBds wn5IZ7kMOTdf3Kai9DXZhP0KbTu7gvD8XVNFwo3adVk0dkl6TEpQ+RYmSKEnSAnKyR8z uy0EXLbTsxVpBFluuQgdX4kGUElaWkA+px30ZK5vcEPe44DUpotghsfzSL3R4JoqocnF zYM87gdU04MPZHNwR1x7tYs/FVmtOFlljhlmecY0Rn2bM+wjR9V0Z0n0eVZDGBzVSQEB Yed9cAKUvJ8xSALjxZfc2dGAn5yhSqc6/5G8f1z8yD1yjodVNUFLn7IjTgCRnCuJAuHQ DHeA== X-Gm-Message-State: AOAM533aOhXPFwioHHtfGz6ZQZVq/K+yPfDUQ18FeVFPGnkQ4DMruG7U /Cw5mKhkJDRtG/acG3/qxJbI8o2RzWoVAoW86xmPlw== X-Google-Smtp-Source: ABdhPJyGCNUbmQJ/wDHu5IcJL/niMgxwiRhAm5hQcCcYAEaJxVRh4Cge+6PJtQJj3bcb2aVMkwUuE9suuO9SNZofuRY= X-Received: by 2002:a17:906:c405:: with SMTP id u5mr22581663ejz.341.1615322822643; Tue, 09 Mar 2021 12:47:02 -0800 (PST) MIME-Version: 1.0 References: <20210309195747.283796-1-willy@infradead.org> In-Reply-To: <20210309195747.283796-1-willy@infradead.org> From: Dan Williams Date: Tue, 9 Mar 2021 12:47:00 -0800 Message-ID: Subject: Re: [PATCH v2] include: Remove pagemap.h from blkdev.h To: "Matthew Wilcox (Oracle)" Message-ID-Hash: ERNKAWA4PSYIQQTIX26K6UFCWRFFF636 X-Message-ID-Hash: ERNKAWA4PSYIQQTIX26K6UFCWRFFF636 X-MailFrom: dan.j.williams@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Andrew Morton , Linux MM , linux-block@vger.kernel.org, Linux Kernel Mailing List , linux-bcache@vger.kernel.org, linux-nvdimm , linux-scsi X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Mar 9, 2021 at 11:59 AM Matthew Wilcox (Oracle) wrote: > > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dependency is harder and this solves my problem. > x86 allmodconfig builds, but there may be implicit include problems > on other architectures. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > v2: Fix CONFIG_SWAP=n implicit use of pagemap.h by swap.h. Increases > the number of files from 240, but that's still a big win -- 68% > reduction instead of 77%. > [..] > drivers/nvdimm/btt.c | 1 + > drivers/nvdimm/pmem.c | 1 + For the nvdimm bits: Acked-by: Dan Williams _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE5FC433DB for ; Tue, 9 Mar 2021 20:47:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A16765243 for ; Tue, 9 Mar 2021 20:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231828AbhCIUrT (ORCPT ); Tue, 9 Mar 2021 15:47:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231808AbhCIUrE (ORCPT ); Tue, 9 Mar 2021 15:47:04 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 010ADC06174A for ; Tue, 9 Mar 2021 12:47:03 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id c10so31504803ejx.9 for ; Tue, 09 Mar 2021 12:47:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rxekq9CmjmqiQezEq23fxoA2lWRbGVUv5ZHopeMn1UE=; b=cnHrmQr/VMb/t2E/EgCby5Ir+NbwqGQ0u5beELJg+31cT1IgztSHwumMnd5zdcoDB2 66n4NERbQg+uvwjesYYTCrNMtq9i9BOp/xxNWs/vGHWpji0JOhm5y/MI1V1Ox4Pc4WRW tBCkqmAvU9bVb4X02t4bXL1znuI21REF0jrmhFii+VAU1w787tzlvvkSi8J6MFfQp9Qc pDQjCC5HheYIdn0dNKCnxnEBuaRZu7xTQPpa9IDV/OMAz50a7gzVrpOYTiwkLGnkyiNv Xl9tJ2GvH5S31+9GqAUexpRyDEuTmNjlBu3J2Ogs0+mgYdfyBUBeIAD+tjEcWDtq2eIa u1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rxekq9CmjmqiQezEq23fxoA2lWRbGVUv5ZHopeMn1UE=; b=pu7VNbt0EnOPBxneYrPOGDd/W3fho/MoKT475ZaIcDVHME48bGqYXMV8OQvAVEkHtR 10+6DiKRYyImipV+BbdJQR8NtJrzWOQaGB3Yuzb+GnG7S8v+rDkuDD8xurrAfTys/9Wx cz39x2XwnX7bt4LjmOY0i0crKLwlKpUuy7I28Py7FLOtyQfvMKt2zjdUhwGziFIHouse nFm3nvvVWO0ZzbT/LybnmlDyjUms693fWHON6/l4FCq3cukF8q7hfnppHKnGAEw5FlLn AeONA0cnim9PZNAT4xycxYWH1CpY92txrYEtrl/cqg/I82DyaSjCoAYwzkh92U4iPXP8 2d1Q== X-Gm-Message-State: AOAM533tGPCyx5l54QpJeJZZeQgsThiOXa5USd9wUWGe/HZj84nDAKS6 5/qzCZ8VQeovK1VpWdTBYGWsloUsf6P8E8a9b172WA== X-Google-Smtp-Source: ABdhPJyGCNUbmQJ/wDHu5IcJL/niMgxwiRhAm5hQcCcYAEaJxVRh4Cge+6PJtQJj3bcb2aVMkwUuE9suuO9SNZofuRY= X-Received: by 2002:a17:906:c405:: with SMTP id u5mr22581663ejz.341.1615322822643; Tue, 09 Mar 2021 12:47:02 -0800 (PST) MIME-Version: 1.0 References: <20210309195747.283796-1-willy@infradead.org> In-Reply-To: <20210309195747.283796-1-willy@infradead.org> From: Dan Williams Date: Tue, 9 Mar 2021 12:47:00 -0800 Message-ID: Subject: Re: [PATCH v2] include: Remove pagemap.h from blkdev.h To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Linux MM , linux-block@vger.kernel.org, Linux Kernel Mailing List , linux-bcache@vger.kernel.org, linux-nvdimm , linux-scsi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Mar 9, 2021 at 11:59 AM Matthew Wilcox (Oracle) wrote: > > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dependency is harder and this solves my problem. > x86 allmodconfig builds, but there may be implicit include problems > on other architectures. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > v2: Fix CONFIG_SWAP=n implicit use of pagemap.h by swap.h. Increases > the number of files from 240, but that's still a big win -- 68% > reduction instead of 77%. > [..] > drivers/nvdimm/btt.c | 1 + > drivers/nvdimm/pmem.c | 1 + For the nvdimm bits: Acked-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F25BC433DB for ; Tue, 9 Mar 2021 20:47:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F1C066523A for ; Tue, 9 Mar 2021 20:47:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1C066523A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7A47A8D0142; Tue, 9 Mar 2021 15:47:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 753F88D012A; Tue, 9 Mar 2021 15:47:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A67A8D0142; Tue, 9 Mar 2021 15:47:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 3AA908D012A for ; Tue, 9 Mar 2021 15:47:05 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EA12D3630 for ; Tue, 9 Mar 2021 20:47:04 +0000 (UTC) X-FDA: 77901520368.12.1F8AAEB Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf24.hostedemail.com (Postfix) with ESMTP id 8B279A0009E2 for ; Tue, 9 Mar 2021 20:47:00 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id r17so31547033ejy.13 for ; Tue, 09 Mar 2021 12:47:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rxekq9CmjmqiQezEq23fxoA2lWRbGVUv5ZHopeMn1UE=; b=cnHrmQr/VMb/t2E/EgCby5Ir+NbwqGQ0u5beELJg+31cT1IgztSHwumMnd5zdcoDB2 66n4NERbQg+uvwjesYYTCrNMtq9i9BOp/xxNWs/vGHWpji0JOhm5y/MI1V1Ox4Pc4WRW tBCkqmAvU9bVb4X02t4bXL1znuI21REF0jrmhFii+VAU1w787tzlvvkSi8J6MFfQp9Qc pDQjCC5HheYIdn0dNKCnxnEBuaRZu7xTQPpa9IDV/OMAz50a7gzVrpOYTiwkLGnkyiNv Xl9tJ2GvH5S31+9GqAUexpRyDEuTmNjlBu3J2Ogs0+mgYdfyBUBeIAD+tjEcWDtq2eIa u1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rxekq9CmjmqiQezEq23fxoA2lWRbGVUv5ZHopeMn1UE=; b=r9aE2IJNpbzKr/8sYgDeUp0alPnn+pj+osqNhaNZscuEjaYzGiHibDtMK/vA/S4j1M Dp/plbHKnESmaKETStKEaZimlsdWSCUSy/Qgh5E+DNZCsdYdiv/Z0qvSruBFSpIhQgZB v4xYVhfOvYYl6EuumdHOazfKsL/niGpKzDFgn+ODrB0wAcDvytq1VhXY4qQ6h8Tn3qHC CJJBG7fRgj3aznMwk+MeSj2lWKSC740KKV0+dzI7qy770qzjlK/hC16/n4tOhNSJJL44 fm4sz2yuQI1d/nRchhPSXT4wcmuQORbEnaIgZzEeLnbNRc+DpcSESER2Jt/0sZCS05tU U52Q== X-Gm-Message-State: AOAM5333o6xjU+UGxDDU35TZFpSw5JdKjM1C9XQ1RZXlLmlgfJtGR4B/ kUjCMfmN9uG4YowRKLsXjCP0m6nU9sMUgzsx0hq2FA== X-Google-Smtp-Source: ABdhPJyGCNUbmQJ/wDHu5IcJL/niMgxwiRhAm5hQcCcYAEaJxVRh4Cge+6PJtQJj3bcb2aVMkwUuE9suuO9SNZofuRY= X-Received: by 2002:a17:906:c405:: with SMTP id u5mr22581663ejz.341.1615322822643; Tue, 09 Mar 2021 12:47:02 -0800 (PST) MIME-Version: 1.0 References: <20210309195747.283796-1-willy@infradead.org> In-Reply-To: <20210309195747.283796-1-willy@infradead.org> From: Dan Williams Date: Tue, 9 Mar 2021 12:47:00 -0800 Message-ID: Subject: Re: [PATCH v2] include: Remove pagemap.h from blkdev.h To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Linux MM , linux-block@vger.kernel.org, Linux Kernel Mailing List , linux-bcache@vger.kernel.org, linux-nvdimm , linux-scsi Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: rosxhssrapayfu1anwaaxzjzreizrcq8 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8B279A0009E2 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-ej1-f53.google.com; client-ip=209.85.218.53 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615322820-333353 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 9, 2021 at 11:59 AM Matthew Wilcox (Oracle) wrote: > > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dependency is harder and this solves my problem. > x86 allmodconfig builds, but there may be implicit include problems > on other architectures. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > v2: Fix CONFIG_SWAP=n implicit use of pagemap.h by swap.h. Increases > the number of files from 240, but that's still a big win -- 68% > reduction instead of 77%. > [..] > drivers/nvdimm/btt.c | 1 + > drivers/nvdimm/pmem.c | 1 + For the nvdimm bits: Acked-by: Dan Williams