From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E5F7C4320E for ; Fri, 20 Aug 2021 15:27:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CFE260F44 for ; Fri, 20 Aug 2021 15:27:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241001AbhHTP2E (ORCPT ); Fri, 20 Aug 2021 11:28:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240865AbhHTP2D (ORCPT ); Fri, 20 Aug 2021 11:28:03 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF068C061757 for ; Fri, 20 Aug 2021 08:27:25 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id j1so7529784pjv.3 for ; Fri, 20 Aug 2021 08:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s+pZady9bZxuI5ZV217HLh19NePVUH4NtT4PhDASe8A=; b=mxA9ryU8JJCE6xg91cuNIqjrL1JDkONo6P8+DLklfSN2yE7omlUTGVGqGsV1LSrJxc u4r8m32maq75ln8QSnsVjt9XX5dmqle4XU1My+eIZsS0jOx+vYDBuXsJbjmri79tSozC LWc4QxAU/S3MEO/w8soRt9iUyt6bsc+zdf16d1u6kn3PvO2WLVhSEOlzuAnzSFLZhcfH B7xmSABvYCijcB2WMf1CsVQQjTsozoby0hS/2FmN81TbxQ2/AsTb9+zM7cG/0oG/6pPx LBPeMmPGI0E0s2HAI/mpmtk5cMbx6dWGUpQvnNfM89CcP9e/Z3/7W8Y34lCUC92JOBNm UWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s+pZady9bZxuI5ZV217HLh19NePVUH4NtT4PhDASe8A=; b=TPd3sY2uKJvEmdG8IXs75aO0BLONzgo/Ld6Gge9nh00Ov8gElFJVy2qLUy58KrPKJz to+dAGqAoeGx4NSpalAPLBpdXqcDKxyEuxdB9C1fUZB2FMjyVrmoTmHOj1E+6sPtSImX 3bxi6hf1iZbn6mBKfmV9th+rZkHpOM5DE+A/cNy2QXYEimj+xRxDL0WAH236CGELbXkz dj6Af4UvfNhPkw4ayAMuRULbX8QEwuVshwdZ84rH0h39LQunL5o8Lg13J4T5WHnQG27c roRDSxa0hc+QoVL0mModZAg4Iffflz3rDXea2sEpOsjBUkKsfePply9WUa4p+Ws/jBcl 1jEw== X-Gm-Message-State: AOAM533pkpjIXPda7xRIAbNbQVOj5/hxutxan060i0CYdXdgEEyjOB9B 6ZGeqKfazUHPZonj8jooNduPVgrycmDUEkyh+qabaA== X-Google-Smtp-Source: ABdhPJxF0RCYcUVUBwMvZeOpqalPa/B9+Q+bapkBeipJxdjltc3i6RXJVl+F7zMaJbsIi20VC25awiuka6Iizvicc98= X-Received: by 2002:a17:90b:23d6:: with SMTP id md22mr4951556pjb.149.1629473245264; Fri, 20 Aug 2021 08:27:25 -0700 (PDT) MIME-Version: 1.0 References: <20210809061244.1196573-1-hch@lst.de> <20210809061244.1196573-12-hch@lst.de> <20210820041158.GA26417@lst.de> In-Reply-To: <20210820041158.GA26417@lst.de> From: Dan Williams Date: Fri, 20 Aug 2021 08:27:14 -0700 Message-ID: Subject: Re: [PATCH 11/30] iomap: add the new iomap_iter model To: Christoph Hellwig Cc: "Darrick J. Wong" , Matthew Wilcox , Andreas Gruenbacher , Shiyang Ruan , linux-xfs , linux-fsdevel , linux-btrfs , Linux NVDIMM , cluster-devel@redhat.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Aug 19, 2021 at 9:12 PM Christoph Hellwig wrote: > > On Thu, Aug 19, 2021 at 02:25:52PM -0700, Dan Williams wrote: > > Given most of the iomap_iter users don't care about srcmap, i.e. are > > not COW cases, they are leaving srcmap zero initialized. Should the > > IOMAP types be incremented by one so that there is no IOMAP_HOLE > > confusion? In other words, fold something like this? > > A hole really means nothing to read from the source. The existing code > also relies on that. Ok, I've since found iomap_iter_srcmap(). Sorry for the noise. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EACBE3FC2 for ; Fri, 20 Aug 2021 15:27:25 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id c4so6136392plh.7 for ; Fri, 20 Aug 2021 08:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s+pZady9bZxuI5ZV217HLh19NePVUH4NtT4PhDASe8A=; b=mxA9ryU8JJCE6xg91cuNIqjrL1JDkONo6P8+DLklfSN2yE7omlUTGVGqGsV1LSrJxc u4r8m32maq75ln8QSnsVjt9XX5dmqle4XU1My+eIZsS0jOx+vYDBuXsJbjmri79tSozC LWc4QxAU/S3MEO/w8soRt9iUyt6bsc+zdf16d1u6kn3PvO2WLVhSEOlzuAnzSFLZhcfH B7xmSABvYCijcB2WMf1CsVQQjTsozoby0hS/2FmN81TbxQ2/AsTb9+zM7cG/0oG/6pPx LBPeMmPGI0E0s2HAI/mpmtk5cMbx6dWGUpQvnNfM89CcP9e/Z3/7W8Y34lCUC92JOBNm UWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s+pZady9bZxuI5ZV217HLh19NePVUH4NtT4PhDASe8A=; b=GDQFHPhUGi1sn5KAXFPyHcqqXuFiMphvPPDf3GPYPMwmSp+sIG4T/FBvJu7jhQHx0i x1MkMBuEpyUWaUKWcoq3XCgSAM34T3Qsyycmq5HKJs5JT2rIHkbrx/a4ole3G9tlN8Dc vcgmnVa80chE/aEkmzNMd+7c6JiG/gkvojCZIh5ayuZlwRpMdGae07KH0/EO8/0UMMPi JxChu+0ujaAmg92J+YalPdpKaRUtGawOdY+PkgZvfZY3aeAOGRDk4sbbTP1hRMJltlvN eWgRqmOog5xkPv4ivjjcdB261c44UK9fRO0s3izaUlwa0iBrsJJZ/wWph72ZV6sj3XYn XiuA== X-Gm-Message-State: AOAM530dOb0MfyueOZtMxwvoDUCCK4/aQnqlWaETS+sOc/kVAFc4qrUd ZQeXLwug93asAttpy5a//vchmGXNOtvFXH0XNwnDLA== X-Google-Smtp-Source: ABdhPJxF0RCYcUVUBwMvZeOpqalPa/B9+Q+bapkBeipJxdjltc3i6RXJVl+F7zMaJbsIi20VC25awiuka6Iizvicc98= X-Received: by 2002:a17:90b:23d6:: with SMTP id md22mr4951556pjb.149.1629473245264; Fri, 20 Aug 2021 08:27:25 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210809061244.1196573-1-hch@lst.de> <20210809061244.1196573-12-hch@lst.de> <20210820041158.GA26417@lst.de> In-Reply-To: <20210820041158.GA26417@lst.de> From: Dan Williams Date: Fri, 20 Aug 2021 08:27:14 -0700 Message-ID: Subject: Re: [PATCH 11/30] iomap: add the new iomap_iter model To: Christoph Hellwig Cc: "Darrick J. Wong" , Matthew Wilcox , Andreas Gruenbacher , Shiyang Ruan , linux-xfs , linux-fsdevel , linux-btrfs , Linux NVDIMM , cluster-devel@redhat.com Content-Type: text/plain; charset="UTF-8" On Thu, Aug 19, 2021 at 9:12 PM Christoph Hellwig wrote: > > On Thu, Aug 19, 2021 at 02:25:52PM -0700, Dan Williams wrote: > > Given most of the iomap_iter users don't care about srcmap, i.e. are > > not COW cases, they are leaving srcmap zero initialized. Should the > > IOMAP types be incremented by one so that there is no IOMAP_HOLE > > confusion? In other words, fold something like this? > > A hole really means nothing to read from the source. The existing code > also relies on that. Ok, I've since found iomap_iter_srcmap(). Sorry for the noise. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Date: Fri, 20 Aug 2021 08:27:14 -0700 Subject: [Cluster-devel] [PATCH 11/30] iomap: add the new iomap_iter model In-Reply-To: <20210820041158.GA26417@lst.de> References: <20210809061244.1196573-1-hch@lst.de> <20210809061244.1196573-12-hch@lst.de> <20210820041158.GA26417@lst.de> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Aug 19, 2021 at 9:12 PM Christoph Hellwig wrote: > > On Thu, Aug 19, 2021 at 02:25:52PM -0700, Dan Williams wrote: > > Given most of the iomap_iter users don't care about srcmap, i.e. are > > not COW cases, they are leaving srcmap zero initialized. Should the > > IOMAP types be incremented by one so that there is no IOMAP_HOLE > > confusion? In other words, fold something like this? > > A hole really means nothing to read from the source. The existing code > also relies on that. Ok, I've since found iomap_iter_srcmap(). Sorry for the noise.