From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [PATCH v2 0/8] nvdimm: hotplug support Date: Thu, 18 Aug 2016 10:47:27 -0700 Message-ID: References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: ehabkost@redhat.com, KVM list , "Michael S. Tsirkin" , Gleb Natapov , Vishal L Verma , mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Igor Mammedov , Paolo Bonzini , rth@twiddle.net To: Xiao Guangrong Return-path: In-Reply-To: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong wrote: > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > rx queue siz) on pci branch of Michael's git tree and can be found at: > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 > > Changelog in v2: > Fixed signed integer overflow pointed out by Stefan Hajnoczi > > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, > for example, a new nvdimm device can be plugged as follows: > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 > device_add nvdimm,id=nvdimm3,memdev=mem3 > > and unplug it as follows: > device_del nvdimm3 > object_del mem3 Did you test this against the Linux NFIT hotplug support? We just found that the Linux driver is not properly registering for ACPI0012 event notification. Is a notification sent on a 'device_add' event? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baRPh-0003HN-Ow for qemu-devel@nongnu.org; Thu, 18 Aug 2016 13:47:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baRPg-0008Ga-O0 for qemu-devel@nongnu.org; Thu, 18 Aug 2016 13:47:33 -0400 Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:35065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baRPg-0008GE-IE for qemu-devel@nongnu.org; Thu, 18 Aug 2016 13:47:32 -0400 Received: by mail-oi0-x230.google.com with SMTP id 4so32106083oih.2 for ; Thu, 18 Aug 2016 10:47:28 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> From: Dan Williams Date: Thu, 18 Aug 2016 10:47:27 -0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: Paolo Bonzini , Igor Mammedov , Gleb Natapov , mtosatti@redhat.com, stefanha@redhat.com, "Michael S. Tsirkin" , rth@twiddle.net, ehabkost@redhat.com, KVM list , qemu-devel@nongnu.org, Vishal L Verma [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong wrote: > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > rx queue siz) on pci branch of Michael's git tree and can be found at: > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 > > Changelog in v2: > Fixed signed integer overflow pointed out by Stefan Hajnoczi > > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, > for example, a new nvdimm device can be plugged as follows: > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 > device_add nvdimm,id=nvdimm3,memdev=mem3 > > and unplug it as follows: > device_del nvdimm3 > object_del mem3 Did you test this against the Linux NFIT hotplug support? We just found that the Linux driver is not properly registering for ACPI0012 event notification. Is a notification sent on a 'device_add' event?