From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8285EC433E0 for ; Mon, 22 Mar 2021 16:12:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BB6861974 for ; Mon, 22 Mar 2021 16:12:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231673AbhCVQLr (ORCPT ); Mon, 22 Mar 2021 12:11:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231228AbhCVQLZ (ORCPT ); Mon, 22 Mar 2021 12:11:25 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42927C061574 for ; Mon, 22 Mar 2021 09:11:24 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id w3so22209058ejc.4 for ; Mon, 22 Mar 2021 09:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c/AUtBaGI9CnR9/DqWeJf3hjAPYoclxfcYyUmUiEtsQ=; b=0qo/4PJUC/Enlck3rYWsBzPBBDRgAZHY169EQXzCSbNjX/ve+Q9Zv6UB160D6TGfIO wBOHs3sguwSEPp2aT498ZXR7yzT9Gm9ZTvR0INjcf5aka51gKBvzxvzcm03dh57uZkrJ uEPPoDHuhSX+QlN6Nh+88W6QbuDrjgsop0WIVChNQVKzuqflECkassa8eIEGsynZu8IU WR5dWFuLpYuPerhSmHLfE8lmTZq2Vih3/6fylJT8pStOvaeCNJYG+BcVMf1WWpm0EdGo Sc6fwzgPKJSCnudhykFtXEXAgLl1NtcpAUAq2JvQV9/nAL4X72npLxxH4x9oTd2fulU3 Piyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c/AUtBaGI9CnR9/DqWeJf3hjAPYoclxfcYyUmUiEtsQ=; b=NfPsZkF7XpK6vtPph/BiYrbhZOWP4NJ9cKYT8mTkmeLLVzmTJ7w37NVkHAzldMG9cr MeEKzpbmzj1iJWfNAfLXk4yJQq5WUfdRynNHAZ8pCJaLSqFe5/oPzYchIdT6c77IDRuc Ay7n02T3+0Ex+PS9xyE3chc9OP1n80+LgJfEFulZHtY5jk67aroD1oZr8weVeaTryhOc hcPWzHNCDzT6vV9y6yPIybjf2LR4Q+rctSzPtDvzskKKhx7gFWBgl6k/tKtgjvRJFKBf RFPusvXxNyxXD3aGnJNJZxUdIzzQm40SNMUT0FYfIo7HHLJMS41St2WY/mVFSbeyJYa+ dWKw== X-Gm-Message-State: AOAM532yBZqbH2Hm2cf1T7YKgCV1ms9MKxl15HaH4/sKgAfAFHMbCNZm EjXDOXmFDzH84xUYlnUAqHMeswPcJRNgV8kEnojpNQ== X-Google-Smtp-Source: ABdhPJwIndKOmeEx4PPwNBwhPt09B0tQMn0i2g4ul2GEkjoVT0CF1bU/9/Ka9Eh1FJRpEhDXxnGmdxECTwx795lLSC4= X-Received: by 2002:a17:906:1386:: with SMTP id f6mr525033ejc.45.1616429483036; Mon, 22 Mar 2021 09:11:23 -0700 (PDT) MIME-Version: 1.0 References: <20210322160200.19633-1-david@redhat.com> <20210322160200.19633-3-david@redhat.com> In-Reply-To: <20210322160200.19633-3-david@redhat.com> From: Dan Williams Date: Mon, 22 Mar 2021 09:11:14 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources To: David Hildenbrand Cc: Linux Kernel Mailing List , Linux MM , Andrew Morton , Greg Kroah-Hartman , Daniel Vetter , Andy Shevchenko , Mauro Carvalho Chehab , Dave Young , Baoquan He , Vivek Goyal , Dave Hansen , Keith Busch , Michal Hocko , Qian Cai , Oscar Salvador , Eric Biederman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Tom Lendacky , Brijesh Singh , X86 ML , Kexec Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 9:02 AM David Hildenbrand wrote: > > It used to be true that we can have system RAM only on the first level > in the resourc tree. However, this is no longer holds for driver-managed > system RAM (i.e., dax/kmem and virtio-mem). > > The function walk_mem_res() only consideres the first level and is > used in arch/x86/mm/ioremap.c:__ioremap_check_mem() only. We currently > fail to identify System RAM added by dax/kmem and virtio-mem as > "IORES_MAP_SYSTEM_RAM", for example, allowing for remapping of such > "normal RAM" in __ioremap_caller(). > > Let's find all busy IORESOURCE_MEM resources, making the function > behave similar to walk_system_ram_res(). Looks good, Reviewed-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E315C433E0 for ; Mon, 22 Mar 2021 16:11:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A51FB6198D for ; Mon, 22 Mar 2021 16:11:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A51FB6198D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 47D966B00EE; Mon, 22 Mar 2021 11:53:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4550A6B00F0; Mon, 22 Mar 2021 11:53:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31EA56B00F1; Mon, 22 Mar 2021 11:53:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 167886B00EE for ; Mon, 22 Mar 2021 11:53:02 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 79D0A180630E1 for ; Mon, 22 Mar 2021 16:11:52 +0000 (UTC) X-FDA: 77948001264.03.C4DADC1 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 4947DC0007D3 for ; Mon, 22 Mar 2021 16:11:44 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id k10so22228595ejg.0 for ; Mon, 22 Mar 2021 09:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c/AUtBaGI9CnR9/DqWeJf3hjAPYoclxfcYyUmUiEtsQ=; b=0qo/4PJUC/Enlck3rYWsBzPBBDRgAZHY169EQXzCSbNjX/ve+Q9Zv6UB160D6TGfIO wBOHs3sguwSEPp2aT498ZXR7yzT9Gm9ZTvR0INjcf5aka51gKBvzxvzcm03dh57uZkrJ uEPPoDHuhSX+QlN6Nh+88W6QbuDrjgsop0WIVChNQVKzuqflECkassa8eIEGsynZu8IU WR5dWFuLpYuPerhSmHLfE8lmTZq2Vih3/6fylJT8pStOvaeCNJYG+BcVMf1WWpm0EdGo Sc6fwzgPKJSCnudhykFtXEXAgLl1NtcpAUAq2JvQV9/nAL4X72npLxxH4x9oTd2fulU3 Piyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c/AUtBaGI9CnR9/DqWeJf3hjAPYoclxfcYyUmUiEtsQ=; b=TeQKCe9SnJvVNqy+0+MU1NAAtVADeDymUrcHR6cyiPwYVbfeySWRluMNaQcn9I7wOF imgmRrieD69JVM+VX92uNyc0So4sHT3DStft/AJ5mFs0oI0awz91eiu5KU+RERdaKS6Q ZQcpaS0DKLDOGtgVYkRcZdmnUnH2bs2q2VTsptYQvLp870hOEE/XNCbIQsgpqxSRZm/J 8bqmhWAI/KZMDUa1xVoCm+L5J2k8JN20tA+zOGSvZd17l877EIZLuBet3IYN9XxkcE9R zuhmqB7UuViGEjDc6S6JUId8KXsf5hP1pizyNfjc3Y8NEPacm2UMGaty4frskWQc9e5E h2qg== X-Gm-Message-State: AOAM530kyeX+S9pwijPVGjcm4J2I1UEBTQKcbCarX1tZ/eSH9NeoD+as fWdtI79k38xBhBQtBnr6DAV4CszRbf1a6wIyoBUUrg== X-Google-Smtp-Source: ABdhPJwIndKOmeEx4PPwNBwhPt09B0tQMn0i2g4ul2GEkjoVT0CF1bU/9/Ka9Eh1FJRpEhDXxnGmdxECTwx795lLSC4= X-Received: by 2002:a17:906:1386:: with SMTP id f6mr525033ejc.45.1616429483036; Mon, 22 Mar 2021 09:11:23 -0700 (PDT) MIME-Version: 1.0 References: <20210322160200.19633-1-david@redhat.com> <20210322160200.19633-3-david@redhat.com> In-Reply-To: <20210322160200.19633-3-david@redhat.com> From: Dan Williams Date: Mon, 22 Mar 2021 09:11:14 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources To: David Hildenbrand Cc: Linux Kernel Mailing List , Linux MM , Andrew Morton , Greg Kroah-Hartman , Daniel Vetter , Andy Shevchenko , Mauro Carvalho Chehab , Dave Young , Baoquan He , Vivek Goyal , Dave Hansen , Keith Busch , Michal Hocko , Qian Cai , Oscar Salvador , Eric Biederman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Tom Lendacky , Brijesh Singh , X86 ML , Kexec Mailing List Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ocr47wq6m8xdtbu4xgwk9b4ouiefkx1s X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4947DC0007D3 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail-ej1-f53.google.com; client-ip=209.85.218.53 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616429504-215812 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 22, 2021 at 9:02 AM David Hildenbrand wrote: > > It used to be true that we can have system RAM only on the first level > in the resourc tree. However, this is no longer holds for driver-managed > system RAM (i.e., dax/kmem and virtio-mem). > > The function walk_mem_res() only consideres the first level and is > used in arch/x86/mm/ioremap.c:__ioremap_check_mem() only. We currently > fail to identify System RAM added by dax/kmem and virtio-mem as > "IORES_MAP_SYSTEM_RAM", for example, allowing for remapping of such > "normal RAM" in __ioremap_caller(). > > Let's find all busy IORESOURCE_MEM resources, making the function > behave similar to walk_system_ram_res(). Looks good, Reviewed-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lON9I-00BzqB-AL for kexec@lists.infradead.org; Mon, 22 Mar 2021 16:11:26 +0000 Received: by mail-ej1-x630.google.com with SMTP id u9so22210743ejj.7 for ; Mon, 22 Mar 2021 09:11:23 -0700 (PDT) MIME-Version: 1.0 References: <20210322160200.19633-1-david@redhat.com> <20210322160200.19633-3-david@redhat.com> In-Reply-To: <20210322160200.19633-3-david@redhat.com> From: Dan Williams Date: Mon, 22 Mar 2021 09:11:14 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: David Hildenbrand Cc: Linux Kernel Mailing List , Linux MM , Andrew Morton , Greg Kroah-Hartman , Daniel Vetter , Andy Shevchenko , Mauro Carvalho Chehab , Dave Young , Baoquan He , Vivek Goyal , Dave Hansen , Keith Busch , Michal Hocko , Qian Cai , Oscar Salvador , Eric Biederman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Tom Lendacky , Brijesh Singh , X86 ML , Kexec Mailing List On Mon, Mar 22, 2021 at 9:02 AM David Hildenbrand wrote: > > It used to be true that we can have system RAM only on the first level > in the resourc tree. However, this is no longer holds for driver-managed > system RAM (i.e., dax/kmem and virtio-mem). > > The function walk_mem_res() only consideres the first level and is > used in arch/x86/mm/ioremap.c:__ioremap_check_mem() only. We currently > fail to identify System RAM added by dax/kmem and virtio-mem as > "IORES_MAP_SYSTEM_RAM", for example, allowing for remapping of such > "normal RAM" in __ioremap_caller(). > > Let's find all busy IORESOURCE_MEM resources, making the function > behave similar to walk_system_ram_res(). Looks good, Reviewed-by: Dan Williams _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec