From: Dan Williams <dan.j.williams@intel.com>
To: Vishal Verma <vishal@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] dax: add a 'modalias' attribute to DAX 'bus' devices
Date: Sun, 24 Feb 2019 10:24:48 -0800 [thread overview]
Message-ID: <CAPcyv4j853QjDpK5ViTgCNSZ2ncmke0T=eZx8i_wt1ULdTbnqg@mail.gmail.com> (raw)
In-Reply-To: <00540b00898a544b38a989b0b3b6c005fd50bef4.camel@kernel.org>
On Sat, Feb 23, 2019 at 5:29 PM Vishal Verma <vishal@kernel.org> wrote:
>
> On Fri, 2019-02-22 at 16:24 -0800, Dan Williams wrote:
> > Looks ok, but I think the changelog could be more accurate.
> >
> > On Fri, Feb 22, 2019 at 3:59 PM Vishal Verma <vishal.l.verma@intel.com> wrote:
> > > Add a 'modalias' attribute to devices under the DAX bus so that userspace
> > > is able to dynamically load modules as needed.
> >
> > The modalias is already published in the uevent which is how udev
> > identifies the module. This patch would allow "modalias to module
> > lookups" *outside* of the typical uevent used for dynamically loading
> > modules.
> >
> > Care to fix up the changelog with that detail and why userspace needs
> > to do these lookups in addition to the typical uevent lookups?
> >
>
> Yes, thanks for the feedback, I think this reads better:
>
> 8<----
>
> From 1e399f52f21c22e4c4bd5d48b26f539e12342beb Mon Sep 17 00:00:00 2001
> From: Vishal Verma <vishal.l.verma@intel.com>
> Date: Fri, 22 Feb 2019 16:58:54 -0700
> Subject: [PATCH v2] dax: add a 'modalias' attribute to DAX 'bus' devices
>
> Add a 'modalias' attribute to devices under the DAX bus so that userspace
> is able to dynamically load modules as needed.
>
> Normally, udev can get the modalias from 'uevent', and that is correctly
> set up by the DAX bus. However other tooling such as 'libndctl' for
> interacting with drivers/nvdimm/, and 'libdaxctl' for drivers/dax/ can
> also use the modalias to dynamically load modules via libkmod lookups.
>
> The 'nd' bus set up by the libnvdimm subsystem exports a modalias
> attribute. Imitate this to export the same for the 'dax' bus.
>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Looks good,
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2019-02-24 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 23:58 [PATCH] dax: add a 'modalias' attribute to DAX 'bus' devices Vishal Verma
2019-02-23 0:24 ` Dan Williams
2019-02-24 1:29 ` Vishal Verma
2019-02-24 18:24 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4j853QjDpK5ViTgCNSZ2ncmke0T=eZx8i_wt1ULdTbnqg@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.