From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BCB2C388F7 for ; Thu, 5 Nov 2020 20:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E95AB20735 for ; Thu, 5 Nov 2020 20:27:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="0Gexu+U6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729783AbgKEU17 (ORCPT ); Thu, 5 Nov 2020 15:27:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726996AbgKEU17 (ORCPT ); Thu, 5 Nov 2020 15:27:59 -0500 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6FAFC0613CF for ; Thu, 5 Nov 2020 12:27:58 -0800 (PST) Received: by mail-ed1-x542.google.com with SMTP id v4so2981318edi.0 for ; Thu, 05 Nov 2020 12:27:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4tO08g/mdJrUnRp5xmIkC4E/sM1L+cB4NfZ88sr/eLY=; b=0Gexu+U6183ptqb2s+FG8/LMY6pXKXn7N3ue80u0iYvQLt+J1c2jziWIJNZODieL9I fjudyFeW2Y8vrOoj/uVLGT946g16HQe9FL8wBkxCdGiWweZU2yE2/V2gb4Bqcm8BYY+/ ns6dNvrguGQ8l6UlwQ19zwKV0nsKkWa27hj/znxgNjAWTwoklQ1nLt+8YIkOsZdmkPvC 3q3H5/w0tJ3ggiRN/S0VmI7w6ofXq+u9NWrITHIzdaNW9JjSbueu3JGkhuCe0FDdmPbB 99034gC0Dhmp0LfcxNOoxcJnDRGv8mIiyor9veTUHkdTOiqrRpVnSG0GX3EAWjathtJi 9AwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4tO08g/mdJrUnRp5xmIkC4E/sM1L+cB4NfZ88sr/eLY=; b=BTxDKyUfRlP7GGHWuiRbFiyyV8C8hGDwu9bJ/vby7ZqoKb8/PqV7Wi9129GmxqPFqZ PQaT2TC6QLuGvceq1xvLHrMvCu8xi7mLL5G5hZOcgNtl4HAqPsbzrARLJyqk4OjjdKjN k69AxItv3YSQ62xxn8FZTEQxcY4MhKgTYCL3Ro/wo4kKgct7/pFmGR7eQNtp2o8YDIag KlKvqeFHa+iiaAqXEV2/vMDqxbpX5wxlAGaGAoCgByqmS+QhSON5g7a7YLtglDXtdnGc TIJTRkLPGh5sKW9VuQvRYia6QhvWi1bs+BQdhOsRssdMp037TKwif0iXO4qOkXfi9LBc iP1w== X-Gm-Message-State: AOAM5321zUus6t0hgAP9Ndt6ifinwHDCgg12xVYnvFRao7ToBircoBde ButNqih9eBbewYuwQDpys7ZKhyZUjGnptVKfEpWANQ== X-Google-Smtp-Source: ABdhPJxZyMj5TW7rvvLgOn3hpEvUsDtY61IBF+U1P3Dju0RxQi9OL2cMh7kULFE2kxodEX2WW11HNleHVODps7fifRk= X-Received: by 2002:a05:6402:b35:: with SMTP id bo21mr4691836edb.52.1604608077519; Thu, 05 Nov 2020 12:27:57 -0800 (PST) MIME-Version: 1.0 References: <20201023003338.1285642-1-david.m.ertman@intel.com> <20201023003338.1285642-2-david.m.ertman@intel.com> <20201105094719.GQ5429@unreal> <20201105193009.GA5475@unreal> In-Reply-To: <20201105193009.GA5475@unreal> From: Dan Williams Date: Thu, 5 Nov 2020 12:27:46 -0800 Message-ID: Subject: Re: [PATCH v3 01/10] Add auxiliary bus support To: Leon Romanovsky Cc: Dave Ertman , alsa-devel@alsa-project.org, Takashi Iwai , Mark Brown , linux-rdma , Jason Gunthorpe , Doug Ledford , Netdev , David Miller , Jakub Kicinski , Greg KH , Ranjani Sridharan , Pierre-Louis Bossart , Fred Oh , Parav Pandit , "Saleem, Shiraz" , "Patil, Kiran" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Nov 5, 2020 at 11:30 AM Leon Romanovsky wrote: > > On Thu, Nov 05, 2020 at 09:12:51AM -0800, Dan Williams wrote: > > On Thu, Nov 5, 2020 at 1:47 AM Leon Romanovsky wrote: > > > > > > On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > > > > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > > > > > > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman wrote: > > > > > > > > > > > <...> > > > > > > > > > > > > > +config AUXILIARY_BUS > > > > > + bool > > > > > > > > tristate? Unless you need non-exported symbols, might as well let this > > > > be a module. > > > > > > I asked it to be "bool", because bus as a module is an invitation for > > > a disaster. For example if I compile-in mlx5 which is based on this bus, > > > and won't add auxiliary_bus as a module to initramfs, the system won't boot. > > > > Something is broken if module dependencies don't arrange for > > auxiliary_bus.ko to be added to the initramfs automatically, but yes, > > it is another degree of freedom for something to go wrong if you build > > the initramfs by hand. > > And this is something that I would like to avoid for now. Fair enough. > > > > > > > > > <...> > > > > > > > > > > > Per above SPDX is v2 only, so... > > > > > > Isn't it default for the Linux kernel? > > > > SPDX eliminated the need to guess a default, and MODULE_LICENSE("GPL") > > implies the "or later" language. The only default assumption is that > > the license is GPL v2 compatible, those possibilities are myriad, but > > v2-only is the first preference. > > I mean that plain GPL == GPL v2 in the kernel. You are right, I was wrong. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E20B9C388F7 for ; Thu, 5 Nov 2020 20:29:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2FA620735 for ; Thu, 5 Nov 2020 20:29:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="W/gyoxE0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="0Gexu+U6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2FA620735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9A3C5166E; Thu, 5 Nov 2020 21:28:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9A3C5166E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604608139; bh=mSRQsgzQkT3M49fMqGqJYmARChjAFFLF23jaetQZSno=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=W/gyoxE0j/ZMEqEiI/GcfJl3qDoGUqaE6lqo89BogItcx/yfS/LWgYAoZ734tMMtf 6R0e+c3HFzWuPoc3zLiA/W7aavlXVlEVNFy89SXB/YQrgY4xAfw1jPQ7zoYMoaEnYx nuYRoUvAPKAOX5EhzaMbHVW+lV0hcSoc1qRIAvZQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F216BF80162; Thu, 5 Nov 2020 21:28:08 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 18C74F80171; Thu, 5 Nov 2020 21:28:06 +0100 (CET) Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E5A07F800EC for ; Thu, 5 Nov 2020 21:27:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E5A07F800EC Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="0Gexu+U6" Received: by mail-ed1-x544.google.com with SMTP id q3so2697972edr.12 for ; Thu, 05 Nov 2020 12:27:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4tO08g/mdJrUnRp5xmIkC4E/sM1L+cB4NfZ88sr/eLY=; b=0Gexu+U6183ptqb2s+FG8/LMY6pXKXn7N3ue80u0iYvQLt+J1c2jziWIJNZODieL9I fjudyFeW2Y8vrOoj/uVLGT946g16HQe9FL8wBkxCdGiWweZU2yE2/V2gb4Bqcm8BYY+/ ns6dNvrguGQ8l6UlwQ19zwKV0nsKkWa27hj/znxgNjAWTwoklQ1nLt+8YIkOsZdmkPvC 3q3H5/w0tJ3ggiRN/S0VmI7w6ofXq+u9NWrITHIzdaNW9JjSbueu3JGkhuCe0FDdmPbB 99034gC0Dhmp0LfcxNOoxcJnDRGv8mIiyor9veTUHkdTOiqrRpVnSG0GX3EAWjathtJi 9AwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4tO08g/mdJrUnRp5xmIkC4E/sM1L+cB4NfZ88sr/eLY=; b=uoJdu7DckSulHItsrkHnyboILwGk7VvkichF3xdJsVQfHn8RjqU0oCfUeCEitlsFKW awQpeJ5AhHvHv1jSw6aIGKFQ+KKqSg91PYhuAR2R7xifOuFVTMW70bidTRDEMJe1JJ96 DwXsqnBl9Nf3ZkR67P6akJ5Rotr1EDrMs5Qr3s8rO8G5omsFpySFgSOChrRtVkTrVKy1 r3NK2r9Hk0neG425Yc7AR+Jf/jAoqXNfSPcvDn/JVjmzKRwcSfe0zZpv0YErdp2uJE8t ZT1YkKzoq+fmmzv3qX1uLxKdxtH5qntOqz4OAIc2/sUTIeIQKsq3gBKBo/JC+58/vw6t PiTw== X-Gm-Message-State: AOAM533i5GUtPtc22XC+dUsFgW0CP5w2f4u66E9f7jCFu1UqrbcEYvUl 0CLD7tiCK0qCghVqv12F09gHVg19NngHYB6R0D1E2g== X-Google-Smtp-Source: ABdhPJxZyMj5TW7rvvLgOn3hpEvUsDtY61IBF+U1P3Dju0RxQi9OL2cMh7kULFE2kxodEX2WW11HNleHVODps7fifRk= X-Received: by 2002:a05:6402:b35:: with SMTP id bo21mr4691836edb.52.1604608077519; Thu, 05 Nov 2020 12:27:57 -0800 (PST) MIME-Version: 1.0 References: <20201023003338.1285642-1-david.m.ertman@intel.com> <20201023003338.1285642-2-david.m.ertman@intel.com> <20201105094719.GQ5429@unreal> <20201105193009.GA5475@unreal> In-Reply-To: <20201105193009.GA5475@unreal> From: Dan Williams Date: Thu, 5 Nov 2020 12:27:46 -0800 Message-ID: Subject: Re: [PATCH v3 01/10] Add auxiliary bus support To: Leon Romanovsky Content-Type: text/plain; charset="UTF-8" Cc: alsa-devel@alsa-project.org, Parav Pandit , Greg KH , Takashi Iwai , Netdev , Ranjani Sridharan , Pierre-Louis Bossart , Fred Oh , linux-rdma , Doug Ledford , Mark Brown , Jason Gunthorpe , Jakub Kicinski , Dave Ertman , "Saleem, Shiraz" , David Miller , Linux Kernel Mailing List , "Patil, Kiran" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Nov 5, 2020 at 11:30 AM Leon Romanovsky wrote: > > On Thu, Nov 05, 2020 at 09:12:51AM -0800, Dan Williams wrote: > > On Thu, Nov 5, 2020 at 1:47 AM Leon Romanovsky wrote: > > > > > > On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > > > > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > > > > > > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman wrote: > > > > > > > > > > > <...> > > > > > > > > > > > > > +config AUXILIARY_BUS > > > > > + bool > > > > > > > > tristate? Unless you need non-exported symbols, might as well let this > > > > be a module. > > > > > > I asked it to be "bool", because bus as a module is an invitation for > > > a disaster. For example if I compile-in mlx5 which is based on this bus, > > > and won't add auxiliary_bus as a module to initramfs, the system won't boot. > > > > Something is broken if module dependencies don't arrange for > > auxiliary_bus.ko to be added to the initramfs automatically, but yes, > > it is another degree of freedom for something to go wrong if you build > > the initramfs by hand. > > And this is something that I would like to avoid for now. Fair enough. > > > > > > > > > <...> > > > > > > > > > > > Per above SPDX is v2 only, so... > > > > > > Isn't it default for the Linux kernel? > > > > SPDX eliminated the need to guess a default, and MODULE_LICENSE("GPL") > > implies the "or later" language. The only default assumption is that > > the license is GPL v2 compatible, those possibilities are myriad, but > > v2-only is the first preference. > > I mean that plain GPL == GPL v2 in the kernel. You are right, I was wrong.