From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754826AbbL3UjI (ORCPT ); Wed, 30 Dec 2015 15:39:08 -0500 Received: from mail-yk0-f181.google.com ([209.85.160.181]:33711 "EHLO mail-yk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753983AbbL3UjG (ORCPT ); Wed, 30 Dec 2015 15:39:06 -0500 MIME-Version: 1.0 In-Reply-To: <56838FA3.5030909@oracle.com> References: <1450899560-26708-1-git-send-email-ross.zwisler@linux.intel.com> <1450899560-26708-3-git-send-email-ross.zwisler@linux.intel.com> <56838FA3.5030909@oracle.com> Date: Wed, 30 Dec 2015 12:39:04 -0800 Message-ID: Subject: Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree From: Dan Williams To: Bob Liu Cc: Ross Zwisler , "linux-kernel@vger.kernel.org" , "H. Peter Anvin" , "J. Bruce Fields" , "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4 , linux-fsdevel , Linux MM , linux-nvdimm , X86 ML , XFS Developers , Andrew Morton , Matthew Wilcox , Dave Hansen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 30, 2015 at 12:02 AM, Bob Liu wrote: > Hi Ross, > > On 12/24/2015 03:39 AM, Ross Zwisler wrote: >> Add support for tracking dirty DAX entries in the struct address_space >> radix tree. This tree is already used for dirty page writeback, and it >> already supports the use of exceptional (non struct page*) entries. >> >> In order to properly track dirty DAX pages we will insert new exceptional >> entries into the radix tree that represent dirty DAX PTE or PMD pages. > > I may get it wrong, but there is "struct page" for persistent memory after > "[PATCH v4 00/18]get_user_pages() for dax pte and pmd mappings". > So why not just add "struct page" to radix tree directly just like normal page cache? > > Then we don't need to deal with any exceptional entries and special writeback. That "struct page" is optional and fsync/msync needs to operate in its absence. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <56838FA3.5030909@oracle.com> References: <1450899560-26708-1-git-send-email-ross.zwisler@linux.intel.com> <1450899560-26708-3-git-send-email-ross.zwisler@linux.intel.com> <56838FA3.5030909@oracle.com> Date: Wed, 30 Dec 2015 12:39:04 -0800 Message-ID: Subject: Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree From: Dan Williams To: Bob Liu Cc: Ross Zwisler , "linux-kernel@vger.kernel.org" , "H. Peter Anvin" , "J. Bruce Fields" , "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4 , linux-fsdevel , Linux MM , linux-nvdimm , X86 ML , XFS Developers , Andrew Morton , Matthew Wilcox , Dave Hansen Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: On Wed, Dec 30, 2015 at 12:02 AM, Bob Liu wrote: > Hi Ross, > > On 12/24/2015 03:39 AM, Ross Zwisler wrote: >> Add support for tracking dirty DAX entries in the struct address_space >> radix tree. This tree is already used for dirty page writeback, and it >> already supports the use of exceptional (non struct page*) entries. >> >> In order to properly track dirty DAX pages we will insert new exceptional >> entries into the radix tree that represent dirty DAX PTE or PMD pages. > > I may get it wrong, but there is "struct page" for persistent memory after > "[PATCH v4 00/18]get_user_pages() for dax pte and pmd mappings". > So why not just add "struct page" to radix tree directly just like normal page cache? > > Then we don't need to deal with any exceptional entries and special writeback. That "struct page" is optional and fsync/msync needs to operate in its absence. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 61A4829DF5 for ; Wed, 30 Dec 2015 14:39:10 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 515F8304053 for ; Wed, 30 Dec 2015 12:39:07 -0800 (PST) Received: from mail-yk0-f170.google.com (mail-yk0-f170.google.com [209.85.160.170]) by cuda.sgi.com with ESMTP id OzhV1t2NCbBbq3k5 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Wed, 30 Dec 2015 12:39:05 -0800 (PST) Received: by mail-yk0-f170.google.com with SMTP id x67so163715363ykd.2 for ; Wed, 30 Dec 2015 12:39:05 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <56838FA3.5030909@oracle.com> References: <1450899560-26708-1-git-send-email-ross.zwisler@linux.intel.com> <1450899560-26708-3-git-send-email-ross.zwisler@linux.intel.com> <56838FA3.5030909@oracle.com> Date: Wed, 30 Dec 2015 12:39:04 -0800 Message-ID: Subject: Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree From: Dan Williams List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Bob Liu Cc: linux-nvdimm , Dave Hansen , "J. Bruce Fields" , Linux MM , Andreas Dilger , "H. Peter Anvin" , Jeff Layton , X86 ML , Ingo Molnar , Matthew Wilcox , Ross Zwisler , linux-ext4 , XFS Developers , Alexander Viro , Thomas Gleixner , Theodore Ts'o , "linux-kernel@vger.kernel.org" , Jan Kara , linux-fsdevel , Andrew Morton , Matthew Wilcox On Wed, Dec 30, 2015 at 12:02 AM, Bob Liu wrote: > Hi Ross, > > On 12/24/2015 03:39 AM, Ross Zwisler wrote: >> Add support for tracking dirty DAX entries in the struct address_space >> radix tree. This tree is already used for dirty page writeback, and it >> already supports the use of exceptional (non struct page*) entries. >> >> In order to properly track dirty DAX pages we will insert new exceptional >> entries into the radix tree that represent dirty DAX PTE or PMD pages. > > I may get it wrong, but there is "struct page" for persistent memory after > "[PATCH v4 00/18]get_user_pages() for dax pte and pmd mappings". > So why not just add "struct page" to radix tree directly just like normal page cache? > > Then we don't need to deal with any exceptional entries and special writeback. That "struct page" is optional and fsync/msync needs to operate in its absence. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs