From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x236.google.com (mail-oi0-x236.google.com [IPv6:2607:f8b0:4003:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0AFFC21EA15D3 for ; Tue, 10 Oct 2017 19:08:56 -0700 (PDT) Received: by mail-oi0-x236.google.com with SMTP id h200so646440oib.4 for ; Tue, 10 Oct 2017 19:12:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20171011004631.GX3666@dastard> References: <150764693502.16882.15848797003793552156.stgit@dwillia2-desk3.amr.corp.intel.com> <150764695771.16882.9179160793491582514.stgit@dwillia2-desk3.amr.corp.intel.com> <20171011004631.GX3666@dastard> From: Dan Williams Date: Tue, 10 Oct 2017 19:12:23 -0700 Message-ID: Subject: Re: [PATCH v8 04/14] xfs: prepare xfs_break_layouts() for reuse with MAP_DIRECT List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dave Chinner Cc: Jan Kara , "Darrick J. Wong" , linux-rdma@vger.kernel.org, Linux API , "linux-nvdimm@lists.01.org" , linux-xfs@vger.kernel.org, Linux MM , iommu@lists.linux-foundation.org, linux-fsdevel , Christoph Hellwig List-ID: On Tue, Oct 10, 2017 at 5:46 PM, Dave Chinner wrote: > On Tue, Oct 10, 2017 at 07:49:17AM -0700, Dan Williams wrote: >> Move xfs_break_layouts() to its own compilation unit so that it can be >> used for both pnfs layouts and MAP_DIRECT mappings. > ..... >> diff --git a/fs/xfs/xfs_pnfs.h b/fs/xfs/xfs_pnfs.h >> index b587cb99b2b7..4135b2482697 100644 >> --- a/fs/xfs/xfs_pnfs.h >> +++ b/fs/xfs/xfs_pnfs.h >> @@ -1,19 +1,13 @@ >> #ifndef _XFS_PNFS_H >> #define _XFS_PNFS_H 1 >> >> +#include "xfs_layout.h" >> + > > I missed this the first time through - we try not to put includes > in header files, and instead make sure each C file has all the > includes they require. Can you move this to all the C files that > need layouts and remove the include of the xfs_pnfs.h include from > them? Sure, will do. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [PATCH v8 04/14] xfs: prepare xfs_break_layouts() for reuse with MAP_DIRECT Date: Tue, 10 Oct 2017 19:12:23 -0700 Message-ID: References: <150764693502.16882.15848797003793552156.stgit@dwillia2-desk3.amr.corp.intel.com> <150764695771.16882.9179160793491582514.stgit@dwillia2-desk3.amr.corp.intel.com> <20171011004631.GX3666@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20171011004631.GX3666@dastard> Sender: owner-linux-mm@kvack.org To: Dave Chinner Cc: "linux-nvdimm@lists.01.org" , Jan Kara , "Darrick J. Wong" , linux-rdma@vger.kernel.org, Linux API , iommu@lists.linux-foundation.org, linux-xfs@vger.kernel.org, Linux MM , Jeff Moyer , linux-fsdevel , Ross Zwisler , Christoph Hellwig List-Id: linux-rdma@vger.kernel.org On Tue, Oct 10, 2017 at 5:46 PM, Dave Chinner wrote: > On Tue, Oct 10, 2017 at 07:49:17AM -0700, Dan Williams wrote: >> Move xfs_break_layouts() to its own compilation unit so that it can be >> used for both pnfs layouts and MAP_DIRECT mappings. > ..... >> diff --git a/fs/xfs/xfs_pnfs.h b/fs/xfs/xfs_pnfs.h >> index b587cb99b2b7..4135b2482697 100644 >> --- a/fs/xfs/xfs_pnfs.h >> +++ b/fs/xfs/xfs_pnfs.h >> @@ -1,19 +1,13 @@ >> #ifndef _XFS_PNFS_H >> #define _XFS_PNFS_H 1 >> >> +#include "xfs_layout.h" >> + > > I missed this the first time through - we try not to put includes > in header files, and instead make sure each C file has all the > includes they require. Can you move this to all the C files that > need layouts and remove the include of the xfs_pnfs.h include from > them? Sure, will do. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f51.google.com ([209.85.218.51]:44006 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099AbdJKCMZ (ORCPT ); Tue, 10 Oct 2017 22:12:25 -0400 Received: by mail-oi0-f51.google.com with SMTP id c77so663598oig.0 for ; Tue, 10 Oct 2017 19:12:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20171011004631.GX3666@dastard> References: <150764693502.16882.15848797003793552156.stgit@dwillia2-desk3.amr.corp.intel.com> <150764695771.16882.9179160793491582514.stgit@dwillia2-desk3.amr.corp.intel.com> <20171011004631.GX3666@dastard> From: Dan Williams Date: Tue, 10 Oct 2017 19:12:23 -0700 Message-ID: Subject: Re: [PATCH v8 04/14] xfs: prepare xfs_break_layouts() for reuse with MAP_DIRECT Content-Type: text/plain; charset="UTF-8" Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: "linux-nvdimm@lists.01.org" , Jan Kara , "Darrick J. Wong" , linux-rdma@vger.kernel.org, Linux API , iommu@lists.linux-foundation.org, linux-xfs@vger.kernel.org, Linux MM , Jeff Moyer , linux-fsdevel , Ross Zwisler , Christoph Hellwig On Tue, Oct 10, 2017 at 5:46 PM, Dave Chinner wrote: > On Tue, Oct 10, 2017 at 07:49:17AM -0700, Dan Williams wrote: >> Move xfs_break_layouts() to its own compilation unit so that it can be >> used for both pnfs layouts and MAP_DIRECT mappings. > ..... >> diff --git a/fs/xfs/xfs_pnfs.h b/fs/xfs/xfs_pnfs.h >> index b587cb99b2b7..4135b2482697 100644 >> --- a/fs/xfs/xfs_pnfs.h >> +++ b/fs/xfs/xfs_pnfs.h >> @@ -1,19 +1,13 @@ >> #ifndef _XFS_PNFS_H >> #define _XFS_PNFS_H 1 >> >> +#include "xfs_layout.h" >> + > > I missed this the first time through - we try not to put includes > in header files, and instead make sure each C file has all the > includes they require. Can you move this to all the C files that > need layouts and remove the include of the xfs_pnfs.h include from > them? Sure, will do.