From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF8CD72 for ; Wed, 18 Aug 2021 21:01:26 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id o2so3621317pgr.9 for ; Wed, 18 Aug 2021 14:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tsxhBVRZlO9and7DhCBUruAlzXa20bXVaKImjY48c7o=; b=zGGJKW23TpE7PPFJ4/n391OFSE+ePfB6XhKYr42xqQdacaGLoy/MLGcJOB9KJclibB 29yQ1DLoZOq7YUGzImZJ1hjNXdcN4bUgBPPOpNCAUpQuExc321UUpjfAEZalmz/yrEmp QMBCgYswdRECqSZZszyKnB1/zOj6k9++ko8k9sPqN4YI0mQ+MpWE8w90ykG4GHsvonXj +NKnoDJPWaGnOUjnABohDzuGK/EN0y6cm+wAyrcNscAwRna0z/xgPtNqS+mR4HhFrKCd yR/73F6u/b1hWv+BHa6yM7WRf5HOfuotX6pcWtI2uqTJ6KkhqyfixiY4MEVxCLYod6oS Jj2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tsxhBVRZlO9and7DhCBUruAlzXa20bXVaKImjY48c7o=; b=PRt6q3OMgb5R7FCBX3+xq2IRn6Eshear8UqYj/5aawXIgadsbDd7rvztSRfrLd5enR wejmoO/kENauRl99HcwZXWMmhHOtEkhS0OqzwWg13Wl5viH15r0/ssw+IQwvg6pmHovs CsuIYZYRyEZuj0IsEHxx9E3wGi4b3Idv+JE19aPiSYoaoZb5ROPS5y4EnpjUetLiwokk XiIQy0R9i/rfCg+MW2GDQZC3brhXvy+VHq2dN8Iqzb/+GbZUaV4c1dVHTNEiwKV1Jgyi LH3KYfd7A9CUWvmx+z+HQQuuN7L9i4uGvRi2XwOIygXUDpWUcOITQA04EYO4BFQWpRAR mp5w== X-Gm-Message-State: AOAM531wYST2EcrGKli+97lpPHJ41In64nDVlN3TRAdzyN5ug3fWxu0h JYczdTVPL6OSChcWkqZYNiBeZj3KG1g+J4HbJSQmOA== X-Google-Smtp-Source: ABdhPJyC7TVzou7MS10S9DHd4c6rf2rdDWgmDabraG+KHQy+8QVQinJv59B8c4LqBnwh3oILNYKei6BontbTyhivPwk= X-Received: by 2002:a63:dd0e:: with SMTP id t14mr9090412pgg.279.1629320486279; Wed, 18 Aug 2021 14:01:26 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210816060359.1442450-1-ruansy.fnst@fujitsu.com> <20210816060359.1442450-2-ruansy.fnst@fujitsu.com> In-Reply-To: <20210816060359.1442450-2-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Wed, 18 Aug 2021 14:01:15 -0700 Message-ID: Subject: Re: [PATCH v7 1/8] fsdax: Output address in dax_iomap_pfn() and rename it To: Shiyang Ruan Cc: "Darrick J. Wong" , Christoph Hellwig , linux-xfs , david , linux-fsdevel , Linux Kernel Mailing List , Linux NVDIMM , Goldwyn Rodrigues , Al Viro , Matthew Wilcox , Ritesh Harjani Content-Type: text/plain; charset="UTF-8" On Sun, Aug 15, 2021 at 11:04 PM Shiyang Ruan wrote: > > Add address output in dax_iomap_pfn() in order to perform a memcpy() in > CoW case. Since this function both output address and pfn, rename it to > dax_iomap_direct_access(). > > Signed-off-by: Shiyang Ruan > Reviewed-by: Christoph Hellwig > Reviewed-by: Ritesh Harjani Looks good to me: Reviewed-by: Dan Williams From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16493C4338F for ; Wed, 18 Aug 2021 21:01:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EADE3610CD for ; Wed, 18 Aug 2021 21:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233847AbhHRVCD (ORCPT ); Wed, 18 Aug 2021 17:02:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229965AbhHRVCB (ORCPT ); Wed, 18 Aug 2021 17:02:01 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD10EC061764 for ; Wed, 18 Aug 2021 14:01:26 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id x16so3449581pfh.2 for ; Wed, 18 Aug 2021 14:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tsxhBVRZlO9and7DhCBUruAlzXa20bXVaKImjY48c7o=; b=zGGJKW23TpE7PPFJ4/n391OFSE+ePfB6XhKYr42xqQdacaGLoy/MLGcJOB9KJclibB 29yQ1DLoZOq7YUGzImZJ1hjNXdcN4bUgBPPOpNCAUpQuExc321UUpjfAEZalmz/yrEmp QMBCgYswdRECqSZZszyKnB1/zOj6k9++ko8k9sPqN4YI0mQ+MpWE8w90ykG4GHsvonXj +NKnoDJPWaGnOUjnABohDzuGK/EN0y6cm+wAyrcNscAwRna0z/xgPtNqS+mR4HhFrKCd yR/73F6u/b1hWv+BHa6yM7WRf5HOfuotX6pcWtI2uqTJ6KkhqyfixiY4MEVxCLYod6oS Jj2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tsxhBVRZlO9and7DhCBUruAlzXa20bXVaKImjY48c7o=; b=lvyZWXjAltV14DluArSYMSzP3Hv+6tKlyqp/BV7tn2fF5fsZDQCa0fX5zvp8VfjQld 0VnZdUDgVKzuFoyH+IXS95cYTfu/RQYxi/tJahk+SBK1dFYk+3rn1vceEAQNz6Ntfj+p nn9S40KF9scJ0hiOZwImaCEr+sziKQm80pY+QLnWNSxemke+DY8q2vsecZkJKA0yC+ng fNFP5O4s6xSV+mq+ejgHqG6YMan5sywxjLA4cNPvfZ2R9Wj1BjxtgQnLdST5Zm9t7NCJ K6ZcV0HUHiyQ0C25DvPfeEO0tA/Xc5yNNq971uw6BIBfip48TXvyM6lb0nYKhcRArAF5 ctjA== X-Gm-Message-State: AOAM531FT92KSDVYXBIZtjEaqj/v23H3vsN77yWSSQXcbFkSoUamXifh Lh9E2d5y6+H9+dZAABpldvi6MPwh8gGX2YmhpzdPNQ== X-Google-Smtp-Source: ABdhPJyC7TVzou7MS10S9DHd4c6rf2rdDWgmDabraG+KHQy+8QVQinJv59B8c4LqBnwh3oILNYKei6BontbTyhivPwk= X-Received: by 2002:a63:dd0e:: with SMTP id t14mr9090412pgg.279.1629320486279; Wed, 18 Aug 2021 14:01:26 -0700 (PDT) MIME-Version: 1.0 References: <20210816060359.1442450-1-ruansy.fnst@fujitsu.com> <20210816060359.1442450-2-ruansy.fnst@fujitsu.com> In-Reply-To: <20210816060359.1442450-2-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Wed, 18 Aug 2021 14:01:15 -0700 Message-ID: Subject: Re: [PATCH v7 1/8] fsdax: Output address in dax_iomap_pfn() and rename it To: Shiyang Ruan Cc: "Darrick J. Wong" , Christoph Hellwig , linux-xfs , david , linux-fsdevel , Linux Kernel Mailing List , Linux NVDIMM , Goldwyn Rodrigues , Al Viro , Matthew Wilcox , Ritesh Harjani Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 15, 2021 at 11:04 PM Shiyang Ruan wrote: > > Add address output in dax_iomap_pfn() in order to perform a memcpy() in > CoW case. Since this function both output address and pfn, rename it to > dax_iomap_direct_access(). > > Signed-off-by: Shiyang Ruan > Reviewed-by: Christoph Hellwig > Reviewed-by: Ritesh Harjani Looks good to me: Reviewed-by: Dan Williams