From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [RFC 1/2] pmem: Move reusable code to base header files Date: Thu, 12 Oct 2017 13:42:42 -0700 Message-ID: References: <20171012155027.3277-1-pagupta@redhat.com> <20171012155027.3277-2-pagupta@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20171012155027.3277-2-pagupta@redhat.com> Sender: owner-linux-mm@kvack.org To: Pankaj Gupta Cc: "linux-kernel@vger.kernel.org" , KVM list , Qemu Developers , linux-nvdimm , Linux MM , Jan Kara , Stefan Hajnoczi , Rik van Riel , Haozhong Zhang , Nitesh Narayan Lal , Kevin Wolf , Paolo Bonzini , "Zwisler, Ross" , David Hildenbrand , Xiao Guangrong List-Id: linux-nvdimm@lists.01.org On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch moves common code to base header files > so that it can be used for both ACPI pmem and VIRTIO pmem > drivers. More common code needs to be moved out in future > based on functionality required for virtio_pmem driver and > coupling of code with existing ACPI pmem driver. > > Signed-off-by: Pankaj Gupta [..] > diff --git a/include/linux/pmem_common.h b/include/linux/pmem_common.h > new file mode 100644 > index 000000000000..e2e718c74b3f > --- /dev/null > +++ b/include/linux/pmem_common.h This should be a common C file, not a header. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbdJLUmp (ORCPT ); Thu, 12 Oct 2017 16:42:45 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:50990 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752452AbdJLUmn (ORCPT ); Thu, 12 Oct 2017 16:42:43 -0400 X-Google-Smtp-Source: ABhQp+SwDCxxNt/CKXWf8yUfpKrKc9ehg8zKgzeacr1F3s7LxhrLMLJb6DDO7wYh45U/0KwOg/P1EJU4QLHS7aNVJtw= MIME-Version: 1.0 In-Reply-To: <20171012155027.3277-2-pagupta@redhat.com> References: <20171012155027.3277-1-pagupta@redhat.com> <20171012155027.3277-2-pagupta@redhat.com> From: Dan Williams Date: Thu, 12 Oct 2017 13:42:42 -0700 Message-ID: Subject: Re: [RFC 1/2] pmem: Move reusable code to base header files To: Pankaj Gupta Cc: "linux-kernel@vger.kernel.org" , KVM list , Qemu Developers , linux-nvdimm , Linux MM , Jan Kara , Stefan Hajnoczi , Rik van Riel , Haozhong Zhang , Nitesh Narayan Lal , Kevin Wolf , Paolo Bonzini , "Zwisler, Ross" , David Hildenbrand , Xiao Guangrong Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch moves common code to base header files > so that it can be used for both ACPI pmem and VIRTIO pmem > drivers. More common code needs to be moved out in future > based on functionality required for virtio_pmem driver and > coupling of code with existing ACPI pmem driver. > > Signed-off-by: Pankaj Gupta [..] > diff --git a/include/linux/pmem_common.h b/include/linux/pmem_common.h > new file mode 100644 > index 000000000000..e2e718c74b3f > --- /dev/null > +++ b/include/linux/pmem_common.h This should be a common C file, not a header. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2kJa-0004x9-8N for qemu-devel@nongnu.org; Thu, 12 Oct 2017 16:42:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2kJZ-0002vr-FU for qemu-devel@nongnu.org; Thu, 12 Oct 2017 16:42:46 -0400 Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:44795) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2kJZ-0002uJ-9f for qemu-devel@nongnu.org; Thu, 12 Oct 2017 16:42:45 -0400 Received: by mail-oi0-x233.google.com with SMTP id v132so10439903oie.1 for ; Thu, 12 Oct 2017 13:42:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20171012155027.3277-2-pagupta@redhat.com> References: <20171012155027.3277-1-pagupta@redhat.com> <20171012155027.3277-2-pagupta@redhat.com> From: Dan Williams Date: Thu, 12 Oct 2017 13:42:42 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pankaj Gupta Cc: "linux-kernel@vger.kernel.org" , KVM list , Qemu Developers , linux-nvdimm , Linux MM , Jan Kara , Stefan Hajnoczi , Rik van Riel , Haozhong Zhang , Nitesh Narayan Lal , Kevin Wolf , Paolo Bonzini , "Zwisler, Ross" , David Hildenbrand , Xiao Guangrong On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch moves common code to base header files > so that it can be used for both ACPI pmem and VIRTIO pmem > drivers. More common code needs to be moved out in future > based on functionality required for virtio_pmem driver and > coupling of code with existing ACPI pmem driver. > > Signed-off-by: Pankaj Gupta [..] > diff --git a/include/linux/pmem_common.h b/include/linux/pmem_common.h > new file mode 100644 > index 000000000000..e2e718c74b3f > --- /dev/null > +++ b/include/linux/pmem_common.h This should be a common C file, not a header.